Commit Graph

1894 Commits

Author SHA1 Message Date
Vitaly Baranov
5ac5a4b2fe Add check that user name is not empty to authenticateUserByHTTP(). 2024-07-08 13:05:34 +02:00
Antonio Andelic
b04f210dec Merge branch 'master' into keeper-correct-log-long-total 2024-07-08 10:05:09 +02:00
Vitaly Baranov
c42b5eddd4 Fix error messages in authenticateUserByHTTP() when multiple authentication methods are used simultaneously. 2024-07-05 21:36:13 +02:00
Vitaly Baranov
e572dfd2dc Use Common/Base64.h 2024-07-05 20:15:19 +02:00
Sema Checherinda
5e4a244faf
Revert "Revert "insertion deduplication on retries for materialised views"" 2024-07-05 16:52:51 +02:00
Antonio Andelic
bf0b782960 Correctly print long processing requests in Keeper 2024-07-05 15:16:08 +02:00
Sema Checherinda
77e60543fd
Revert "insertion deduplication on retries for materialised views" 2024-07-05 14:58:17 +02:00
Kruglov Pavel
6239f7d62f
Merge branch 'master' into data-types-binary-encoding 2024-07-05 13:20:31 +02:00
Nikita Mikhaylov
3a7c98399f
Merge pull request #65777 from ClickHouse/make_analyzer_important
Make `allow_experimental_analyzer` be controlled by the initiator for distributed queries
2024-07-04 20:38:40 +00:00
Vitaly Baranov
6bf1320870
Merge pull request #66061 from vitlibar/fix-shutdown-in-grpc-server
Fix shutdown in GRPCServer
2024-07-04 14:33:59 +00:00
Sema Checherinda
19816401c4
Merge pull request #61601 from ClickHouse/chesema-dedup-matview
insertion deduplication on retries for materialised views
2024-07-04 13:52:52 +00:00
Nikita Mikhaylov
fe6a875c74 Make the setting back IMPORTANT + fix build 2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
fcabefa8f3 Automatically disabling 2024-07-04 11:12:27 +00:00
Nikita Mikhaylov
dd3eb538f6 Better 2024-07-04 11:12:27 +00:00
morning-color
a99c803ddf Rename rows_before_group_by_at_least to rows_before_aggregation_at_least 2024-07-04 17:26:06 +08:00
Vitaly Baranov
ecfe6fddcf Move function HTTPHandler::formatExceptionForClient() to a separate header in order to reuse it. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
49b982747a Move function authenticateUserByHTTP() to a separate header in order to reuse it. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
25dc96aaca Simplify initialization of settings in HTTPHandler. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
bf56ad69dd Make Context::setCurrentRoles() check that new current roles are granted in order to make HTTPHandler's implementation easier. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
29ed1c9bf8 Move function exceptionCodeToHTTPStatus() from HTTPHandler.cpp to a separate header in order to reuse it. 2024-07-03 21:23:09 +02:00
Vitaly Baranov
e8701dc4e4 Fix shutdown in GRPCServer. 2024-07-03 18:18:23 +02:00
Antonio Andelic
cddd2312fb Merge branch 'master' into keeper-remove-standalone-build 2024-07-03 16:23:31 +02:00
Antonio Andelic
ce4d361cd7 Merge branch 'master' into keeper-remove-standalone-build 2024-07-03 16:23:06 +02:00
Antonio Andelic
e3beff45c1
Merge pull request #65918 from ClickHouse/add-some-tools-for-keeper-profiling
Add extra profiling helpers for Keeper
2024-07-03 07:01:13 +00:00
Sema Checherinda
06e235024f work with review 2024-07-02 15:16:57 +02:00
Arthur Passos
cc13783acd Merge branch 'master' into multi_auth_methods 2024-07-02 09:11:20 -03:00
Kruglov Pavel
15b32b6d0c
Merge branch 'master' into data-types-binary-encoding 2024-07-02 13:26:43 +02:00
Konstantin Bogdanov
138eb924fa
Merge pull request #65626 from tonickkozlov/tonickkozlov/x509-san-validation
Add support for x509 SubjectAltName identification
2024-07-02 11:20:01 +00:00
Antonio Andelic
a0f6751c4d Merge branch 'master' into add-some-tools-for-keeper-profiling 2024-07-02 10:50:24 +02:00
Azat Khuzhin
4f2a0e8eeb Fix possible issues with MySQL server protocol TLS connections
The problem here is that retries (in SecureSocketImpl.cpp::mustRetry())
relies on non-zero socket timeout, but MySQL handler does not set
timeouts for the socket (like other does), and this leads to a problem
when OpenSSL returns SSL_ERROR_WANT_READ/SSL_ERROR_WANT_WRITE, the
connection will be simply terminated.

I've played with this patch, by hacking the openssl sources:

    diff --git a/crypto/bio/bss_sock.c b/crypto/bio/bss_sock.c
    index 82f7be85ae..a399291ff4 100644
    --- a/crypto/bio/bss_sock.c
    +++ b/crypto/bio/bss_sock.c
    @@ -124,7 +125,18 @@ static int sock_read(BIO *b, char *out, int outl)
                 ret = ktls_read_record(b->num, out, outl);
             else
     # endif
    -            ret = readsocket(b->num, out, outl);
    +        {
    +            /* pthread_kill(pthread_self(), SIGUSR1); */
    +            static int i = 0;
    +            if (!(++i % 2))
    +            {
    +                fprintf(stderr, "sock_read: inject EAGAIN\n");
    +                ret = -1;
    +                errno = EAGAIN;
    +            }
    +            else
    +                ret = readsocket(b->num, out, outl);
    +        }
             BIO_clear_retry_flags(b);
             if (ret <= 0) {
                 if (BIO_sock_should_retry(ret))

And after this patch this succeed without errors:

    ch benchmark -c10 -q "SELECT * FROM mysql('127.0.0.1:9004', system, one, 'default', '', SETTINGS connection_pool_size=1, connect_timeout = 100, connection_wait_timeout = 100)"

Note, that this also fixes the timeouts for plain (non-TLS) connections

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-01 15:22:33 +02:00
Antonio Andelic
1a95259182 Add extra profiling helpers for Keeper 2024-07-01 15:17:41 +02:00
avogar
22eb2fe006 Merge branch 'master' of github.com:ClickHouse/ClickHouse into data-types-binary-encoding 2024-07-01 10:19:31 +00:00
Anton Kozlov
b1b9aaf2ec Add support for x509 SubjectAltName identification 2024-07-01 09:47:28 +00:00
Antonio Andelic
4a9daa202d Remove Keeper standalone build 2024-07-01 11:24:45 +02:00
Sema Checherinda
abe58184df Merge branch 'master' into chesema-dedup-matview 2024-06-29 01:35:32 +02:00
Alexander Tokmakov
4748e2929f
Merge pull request #65570 from ClickHouse/keeper_az
Improve ZooKeeper load balancing
2024-06-28 22:57:20 +00:00
Kruglov Pavel
6436bd9cf3
Merge branch 'master' into data-types-binary-encoding 2024-06-27 17:19:36 +02:00
morning-color
71d71bd5fe Add rows_before_group_by_counter 2024-06-27 20:06:14 +08:00
Kseniia Sumarokova
7892e77d9d
Merge pull request #65744 from ClickHouse/try-fix-race-in-tcp-handler
Try fix data race in TCPHandler between `processOrdinaryQuery -> sendProgress` and `fatal_error_callback -> sendLogs`
2024-06-27 10:27:24 +00:00
Sema Checherinda
92375ec052 Merge branch 'master' into chesema-dedup-matview 2024-06-27 02:12:32 +02:00
Sema Checherinda
d485606e94 fix header in async insert and projections 2024-06-27 02:09:45 +02:00
Sema Checherinda
4d409831a0
Merge pull request #64478 from ClickHouse/chesema-fix-buffer-cancelation
make writebuffers cancelable
2024-06-26 22:12:30 +00:00
Sema Checherinda
8efa045a97 fix resolving conflicts with squashing 2024-06-27 00:09:55 +02:00
kssenii
2e7c23b82c Try fix data race in TCPHandler 2024-06-26 19:49:14 +02:00
Sema Checherinda
5d2e2a9f44 Merge branch 'master' into chesema-dedup-matview 2024-06-26 17:03:05 +02:00
Yakov Olkhovskiy
57ea611876
Merge branch 'master' into ft-chunked-protocol 2024-06-26 10:12:38 -04:00
Arthur Passos
c2dd3bb5d2 Merge branch 'master' into multi_auth_methods 2024-06-26 09:03:58 -03:00
Konstantin Bogdanov
665b4a9d1d
Merge pull request #62829 from ClickHouse/jwt-auth-in-client
Support JWT in `clickhouse-client`
2024-06-26 07:56:28 +00:00
Yakov Olkhovskiy
3f3305a63a fix server settings 2024-06-26 04:33:52 +00:00
Yakov Olkhovskiy
6112ef710c fix style 2024-06-26 03:43:28 +00:00
Yakov Olkhovskiy
9eec834427 better chunked protocol negotiation, comments, review suggestions 2024-06-26 03:19:16 +00:00
Alexander Tokmakov
43cb2f6af7 remove trash 2024-06-26 02:03:22 +02:00
Sema Checherinda
072eb14493 fixing HTTPHandler 2024-06-25 23:04:47 +02:00
Yakov Olkhovskiy
4240cb98fd
Merge branch 'master' into ft-chunked-protocol 2024-06-23 14:27:45 -04:00
avogar
785f3ac5c9 Revert unrelated changes 2024-06-21 18:40:49 +00:00
Arthur Passos
f55d15d9b9 Merge branch 'master' into multi_auth_methods 2024-06-21 15:39:02 -03:00
avogar
b9fbbbb284 Update settings changes history 2024-06-21 18:23:52 +00:00
avogar
3dfab50408 Merge branch 'master' of github.com:ClickHouse/ClickHouse into data-types-binary-encoding 2024-06-21 18:21:19 +00:00
avogar
b1f45da3eb Implement binary encoding for ClickHouse data types 2024-06-21 18:20:35 +00:00
Arthur Passos
179d54505a make progress, seems functional 2024-06-20 15:07:16 -03:00
Sema Checherinda
e36a641a80 Merge branch 'master' into protocols-tls-extend-params 2024-06-20 19:02:12 +02:00
Sema Checherinda
19bafb5063 Merge branch 'master' into chesema-fix-buffer-cancelation 2024-06-20 18:10:53 +02:00
Anton Ivashkin
d06867e886 Catch exception in tryLoadImpl 2024-06-19 17:21:25 +02:00
Daniil Ivanik
3df8695ec4
Merge pull request #65118 from jmaicher/fix/65117/receive-timeout-exception-handling
Improve exception handling in case of receive timeout while reading (parts of) the request body
2024-06-19 13:04:17 +00:00
Yarik Briukhovetskyi
a08f77850c
Merge pull request #61047 from yariks5s/balancing_transform
Implementing `BalancingTransform` for inserts
2024-06-19 11:37:17 +00:00
Kseniia Sumarokova
784f66cf2f
Merge pull request #65239 from ClickHouse/tracing-try-2
Initialize global profiler for Poco::ThreadPool (needed for keeper, etc)
2024-06-19 09:00:46 +00:00
Konstantin Bogdanov
f2583db8a1
Support JWT in clickhouse-client 2024-06-19 04:29:46 +02:00
Anton Ivashkin
9a7655be2f Catch exception in sslContext init 2024-06-18 11:20:50 +02:00
Julian Maicher
966a32a4d4 Fix HTTP exception handling in case of receive timeouts
Closes #65117
2024-06-18 07:57:43 +02:00
avogar
9dd43bbbea Merge branch 'master' of github.com:ClickHouse/ClickHouse into balancing_transform 2024-06-17 18:08:19 +00:00
Sema Checherinda
4d73a4f13b Merge branch 'master' into chesema-dedup-matview 2024-06-17 18:27:20 +02:00
Sema Checherinda
2d16ab0c07 Merge branch 'master' into chesema-fix-buffer-cancelation 2024-06-17 17:15:29 +02:00
Anton Ivashkin
fc6f2aa59a Small refactoring of CertificateReloader 2024-06-14 14:31:58 +02:00
kssenii
fb32a99578 Initialize global trace collector for Poco::ThreadPool 2024-06-13 19:20:58 +02:00
Sema Checherinda
979e84513b Merge branch 'master' into chesema-dedup-matview 2024-06-13 18:56:46 +02:00
Grigorii Sokolik
80575fe122 Fix CI failure 2024-06-13 14:16:31 +03:00
Grigorii Sokolik
2aa2f2f7da Rollback unnecessary style fixes 2024-06-13 11:21:48 +03:00
Grigorii Sokolik
7bff47701b Fix styles 2024-06-13 11:21:48 +03:00
Grigorii Sokolik
06383d7a7a Fix Static handler 2024-06-13 11:21:47 +03:00
Grigorii Sokolik
979b447451 Fix styles 2024-06-13 11:21:47 +03:00
Grigorii Sokolik
ffa66225d0 Fix tests 2024-06-13 11:21:47 +03:00
Grigorii Sokolik
a417a1c676 feat-59620 Style fix 2024-06-13 11:21:47 +03:00
Grigorii Sokolik
47686e0c4a [feature] A setting http_response_headers
Implementing https://github.com/ClickHouse/ClickHouse/issues/59620
Deprecating `content_type` setting (still supported).
2024-06-13 11:21:47 +03:00
Yarik Briukhovetskyi
07e746d5a4
Merge branch 'ClickHouse:master' into balancing_transform 2024-06-12 12:16:24 +02:00
yariks5s
4a72b36f28 Revert "Revert "roll back some changes""
This reverts commit 66a714e3ee.
2024-06-11 23:26:23 +00:00
yariks5s
66a714e3ee Revert "roll back some changes"
This reverts commit a54d679357.
2024-06-11 22:45:02 +00:00
yariks5s
a54d679357 roll back some changes 2024-06-11 18:46:09 +00:00
yariks5s
7b239f1102 fixes due to review 2024-06-11 17:36:49 +00:00
Sema Checherinda
b35ee73b15 Merge branch 'master' into chesema-fix-buffer-cancelation 2024-06-11 13:27:39 +02:00
yariks5s
f5137c351c Merge branch 'balancing_transform' of https://github.com/yariks5s/ClickHouse into balancing_transform 2024-06-10 18:09:33 +00:00
yariks5s
68e1d8701c fixes due to review 2024-06-10 18:09:07 +00:00
Yakov Olkhovskiy
30a6b36395 Merge branch 'master' into ft-chunked-protocol 2024-06-09 21:39:48 +00:00
Yakov Olkhovskiy
a562118d2a major refactoring of chunked write buffer - more buffering, some bugs fixed 2024-06-07 01:45:56 +00:00
Alexey Milovidov
2c5ebf9ca6
Merge branch 'master' into master 2024-06-05 04:23:37 +02:00
Yarik Briukhovetskyi
34d5c64900
Merge branch 'ClickHouse:master' into balancing_transform 2024-06-04 21:12:06 +02:00
Yakov Olkhovskiy
eaeabd8d37 fix typos 2024-06-02 13:03:48 +00:00
Yakov Olkhovskiy
f11f414910 fix special case of testing feature for chunked protocol 2024-06-02 07:25:48 +00:00
Yakov Olkhovskiy
fdccba97a3 set chunked for testing 2024-05-31 06:35:04 +00:00
yariks5s
84c8c4ca48 try to assign header unconditionally 2024-05-30 18:28:24 +00:00
yariks5s
5a09dce95d adding header in TCPHandler 2024-05-30 18:06:11 +00:00
yariks5s
826bec2575 added move constructor and removed unused parts 2024-05-30 16:33:48 +00:00
Sema Checherinda
8f4a7a7c09 work with tests 2024-05-30 17:07:36 +02:00
Sema Checherinda
ef3a2fef01 work with tests 2024-05-29 16:45:32 +02:00
Sema Checherinda
3dbd290f21 Merge branch 'master' into chesema-dedup-matview 2024-05-28 18:33:00 +02:00
Robert Schulze
2680683863
Merge pull request #64110 from rschu1ze/redundant-inline
Throw out some `inline`s
2024-05-28 09:55:56 +00:00
yariks5s
00b07bba14 remove squashing 2024-05-27 16:23:01 +00:00
Alexander Tokmakov
3ee2307024
Revert "Refactoring of Server.h: Isolate server management from other logic" 2024-05-27 10:04:19 +02:00
Robert Schulze
4d642a0e6c
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-26 20:43:41 +00:00
Robert Schulze
f182920c98
Merge remote-tracking branch 'ClickHouse/master' into redundant-inline 2024-05-26 14:21:47 +00:00
Robert Schulze
7a313e7358
Merge remote-tracking branch 'ClickHouse/master' into refactor-protocol-server 2024-05-26 13:40:12 +00:00
yariks5s
e6f8338666 memory optimizations and removed unused parts 2024-05-24 20:38:45 +00:00
TTPO100AJIEX
aada1de796 Rename function parameters, remove unnecessary virtual 2024-05-24 15:36:41 +03:00
TTPO100AJIEX
251010f109 Move protocol-server and inter-server management into separate classes
Co-authored-by: Alex Koledaev <ax3l3rator@gmail.com>
2024-05-24 02:14:26 +03:00
Yakov Olkhovskiy
94bc0a1e96 add config parameters and client arguments, make default notchunked_optional 2024-05-23 22:01:32 +00:00
Anton Ivashkin
983fa64e4f Fix CertificateReloader usage for custom protocols 2024-05-23 17:53:23 +02:00
yariks5s
d4ec6138c5 Merge branch 'yariks5s-balancing_transform' into balancing_transform 2024-05-23 13:47:28 +00:00
yariks5s
f3c4a25f3f Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into yariks5s-balancing_transform 2024-05-23 13:43:24 +00:00
Robert Schulze
f584807359
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-22 21:05:27 +00:00
kssenii
1059b51177 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-22 14:13:27 +02:00
Anton Ivashkin
298b19c19d Fix style 2024-05-22 14:10:50 +02:00
Anton Ivashkin
ca45acd57f Use CertificateReloader in TLSHandler 2024-05-22 12:28:40 +02:00
Sergei Trifonov
dd22140b57
Merge branch 'master' into fix-use-concurrency-control 2024-05-22 11:36:20 +02:00
Yakov Olkhovskiy
7ea6eb98b2 Merge branch 'master' into ft-chunked-protocol 2024-05-21 20:54:58 +00:00
Sema Checherinda
7fe1fe11b9 fixing tests 2024-05-21 17:07:52 +02:00
kssenii
7b225ab59c Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-21 16:58:25 +02:00
Anton Ivashkin
40eef7f027 Fix tidy build 2024-05-21 15:58:00 +02:00
vdimir
4b72748b2a
Better handling illegal user input not to throw unexpected of CORRUPTED_DATA errors 2024-05-21 08:53:30 +00:00
Robert Schulze
a14e58ab88
Merge remote-tracking branch 'rschu1ze/master' into redundant-inline 2024-05-21 05:15:35 +00:00
Yakov Olkhovskiy
5308256c67 enable chunked before processing defaul database 2024-05-20 16:25:19 +00:00
Anton Ivashkin
b8389925a4 Merge master 2024-05-19 16:12:51 +02:00
Robert Schulze
113bb00005
Fix clang-tidy "-readability-redundant-inline-specifier" 2024-05-19 10:23:58 +00:00
Robert Schulze
2909e6451b
Move StringUtils.h/cpp back to Common/ 2024-05-19 09:39:36 +00:00
Alexey Milovidov
bd9709adee
Merge pull request #64022 from ClickHouse/fix-analyzer
Fix a typo in Analyzer
2024-05-17 20:02:13 +02:00
yariks5s
8d235a4a39 remove trash from the code 2024-05-17 15:11:21 +00:00
Anton Ivashkin
f01386fc79 Fix non-SSL build 4 2024-05-17 16:36:55 +02:00
Anton Ivashkin
f4afaf7f18 Fix non-SSL build 3 2024-05-17 16:16:54 +02:00
Anton Ivashkin
72285615cb Fix non-SSL build 2 2024-05-17 15:33:14 +02:00
Anton Ivashkin
222dbe30d8 Fix non-SSL build 2024-05-17 15:06:50 +02:00
Anton Ivashkin
183223b7ba Fix tabs instead of spaces 2024-05-17 14:53:54 +02:00
Anton Ivashkin
20b23b0ff9 Fix variable name style 2024-05-17 14:28:40 +02:00
Alexey Milovidov
26501178e6 Fix analyzer 2024-05-17 10:23:32 +02:00
yariks5s
fed6c65858 add setting to enable planning 2024-05-16 17:57:01 +00:00
Anton Ivashkin
92df0f9737 More parameters for tls layer in protocols 2024-05-16 18:34:17 +02:00
Azat Khuzhin
49a52cdb3f Remove http_max_chunk_size setting (too internal)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-05-16 18:33:43 +02:00
Yakov Olkhovskiy
ee74d0de8c
Merge branch 'master' into ft-chunked-protocol 2024-05-15 16:56:10 -04:00
Yakov Olkhovskiy
05e823a1e9 add chunked wrapper to native protocol 2024-05-14 15:37:20 +00:00
serxa
0acdfd6a37 Explicit passing of use_concurrency_control setting to find all place where it is not set at all 2024-05-14 10:41:40 +00:00
kssenii
9ce465bb88 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-13 16:14:58 +02:00
yariks5s
a66a81efa3 merge 2024-05-10 11:21:40 +00:00
Alexey Milovidov
a05fccf8cc Useless changes 2024-05-10 07:30:40 +02:00
Alexey Milovidov
a6543a1c48 Useless changes 2024-05-10 05:07:37 +02:00
Alexey Milovidov
426a51b624 Useless changes 2024-05-10 04:53:29 +02:00
Alexey Milovidov
1d69518c4d Useless changes 2024-05-09 02:07:04 +02:00
yariks5s
e1ed0af3d2 Added pointer check, Chunk as argument to PlanSquashingTransform, fully refactored names of functions 2024-05-08 14:28:09 +00:00
kssenii
e9d9f2bc25 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-05-03 13:55:12 +02:00
Konstantin Bogdanov
273464c963
Merge pull request #63046 from ClickHouse/support-user-expiration
Check user expiration date before query execution
2024-04-30 17:42:58 +00:00
Konstantin Bogdanov
fccb463222
Rename 2024-04-30 16:07:51 +02:00
Konstantin Bogdanov
36014f739a
Rename 2024-04-30 14:52:43 +02:00
Nikita Taranov
8fd38f2abc
Merge pull request #62752 from ClickHouse/log_profile_events_send_timings
Log profile events send timings
2024-04-29 15:41:28 +00:00
kssenii
7a416f2e76 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-28 12:19:32 +02:00
Azat Khuzhin
cf1451ecde Fix possible CHECKSUM_DOESNT_MATCH during replicated fetches
Previously HTTP server does not tries to send exception if something had
been written to the client already, but after rewriting to "zero-copy"
HTTP implementation (back in #19516) this got broken, and you can get
pretty "dangerous" at least at first glance errors, like:
- Malformed chunked encoding
- or most likely to CHECKSUM_DOESNT_MATCH error

This is not crucial because it will never pass checksum checks, but
still icky. So let's fix it.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-28 07:34:08 +02:00
Alexey Milovidov
58792a1935
Merge pull request #60302 from azat/INSERT-receive-timeout
Change back how receive_timeout is handled for INSERTs
2024-04-27 14:55:28 +00:00
Konstantin Bogdanov
64de52397e
Merge pull request #62978 from ClickHouse/fix-grpc-ipv6-crash
gRPC: fix crash on IPv6 peer connection
2024-04-27 06:22:41 +00:00
Konstantin Bogdanov
822a57cb83
Fix integration tests 2024-04-26 19:56:24 +02:00
Konstantin Bogdanov
6d805d094c
Fix harder 2024-04-26 19:37:14 +02:00
kssenii
91014456b5 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-26 19:24:07 +02:00
Konstantin Bogdanov
4c607147ba
Fix 2024-04-26 17:38:02 +02:00
Konstantin Bogdanov
466633729f
Support user expiration 2024-04-26 17:03:40 +02:00
Konstantin Bogdanov
07e4e7fa73
Check for protocol prefix 2024-04-26 16:45:30 +02:00
Konstantin Bogdanov
7326e2a0fa
Fix aborting on IPv6 peer address 2024-04-25 16:44:16 +02:00
kssenii
730995f2a4 Review suggestion 2024-04-22 13:44:36 +01:00
kssenii
4a68b2a877 Allow quota key with different auth scheme 2024-04-22 13:19:59 +01:00
Alexander Gololobov
25cfd48f87
Only log if it took longer than 100 ms 2024-04-18 14:39:23 +01:00
Alexander Gololobov
01b80e754a Log profile events send timings 2024-04-18 11:37:09 +01:00
Vitaly Baranov
d12608f366
Merge pull request #62669 from slvrtrn/http-interface-role-query-param
Add `role` query parameter to the HTTP interface
2024-04-17 16:39:49 +00:00
slvrtrn
0718a31921 Add NameValueCollection::getAll method 2024-04-16 18:50:39 +02:00
slvrtrn
fd81810b9c Use SET_NON_GRANTED_ROLE error code instead of ACCESS_DENIED 2024-04-16 17:14:16 +02:00
slvrtrn
bb6d5d8d55 Support multiple roles via HTTP, update tests 2024-04-16 16:42:56 +02:00
slvrtrn
9889109780 Fix tests, fix error message 2024-04-15 22:07:42 +02:00
slvrtrn
3611415766 Add tests for the role query parameter 2024-04-15 20:41:35 +02:00
slvrtrn
d8fca3bdc5 Merge remote-tracking branch 'origin' into http-interface-role-query-param 2024-04-15 18:25:39 +02:00
slvrtrn
098cc92cdf Add role query param to the HTTP interface 2024-04-15 18:25:11 +02:00
Robert Schulze
3c35f14804
Merge remote-tracking branch 'ClickHouse/master' into mkmkme/protobuf-25.1 2024-04-15 12:38:59 +00:00
kssenii
27672e1dfc Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-15 11:28:14 +01:00
Robert Schulze
8167b774b5
Merge pull request #62307 from rschu1ze/cleanup-ssh
Cleanup SSH-based authentication code
2024-04-09 21:10:09 +00:00
Nikita Taranov
a2147b8ded
Merge branch 'master' into keep_alive_max_reqs 2024-04-09 21:32:36 +02:00
Sergei Trifonov
8349bdd006
Merge pull request #61534 from ClickHouse/fix-db-iterator-waits
Fix db iterator wait during async metrics collection
2024-04-08 12:10:50 +02:00
kssenii
357e5e3ae6 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-05 16:15:56 +02:00
Robert Schulze
9d8f643f5b
Cleanup SSH-based authentication code 2024-04-05 08:43:23 +00:00
kssenii
1e982a2368 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-04 13:26:06 +02:00
kssenii
be30806dbe Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-04-04 13:20:12 +02:00
Robert Schulze
de2a0be025
Don't access static members through instance
- clang-tidy rightfully complains (-readability-static-accessed-through-instance)
- not going to enable the warning for now to avoid breaking the build
2024-04-03 18:50:33 +00:00
Kruglov Pavel
21abaa14e7
Merge pull request #61951 from Avogar/fix-exception-in-format
Fix writing exception message in output format in HTTP when http_wait_end_of_query is used
2024-04-03 13:44:30 +02:00
Mikhail Koviazin
e7a664e9df
Merge remote-tracking branch 'upstream/master' into mkmkme/protobuf-25.1 2024-04-03 13:51:37 +03:00
serxa
5afec7b64d Merge branch 'master' into fix-db-iterator-waits 2024-04-03 09:29:32 +00:00
avogar
22fb91a6ef Fix tests 2024-04-02 18:18:32 +00:00
Raúl Marín
c35a436435 Remove nested dependency on DateLutImpl 2024-04-02 14:45:48 +02:00
Raúl Marín
40a22ffa63 Remove a few nested include dependencies 2024-04-02 13:43:14 +02:00
kssenii
ca1c119115 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-27 22:32:44 +01:00
Nikita Taranov
7b17b14aa0
Merge pull request #61671 from GrigoryPervakov/master
Reload certificate chain during certificate reload
2024-03-27 21:19:32 +01:00
kssenii
e0c02bf3af Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-27 19:27:07 +01:00
avogar
98f99db6b2 Remove unneded change 2024-03-26 16:01:56 +00:00
Azat Khuzhin
b9469e2729 Do not try to INSERT into readonly replicas for Distributed engine
Sometimes replica may be readonly for a long time, and this will make
some INSERT queries fail, but it does not make sense to INSERT into
readonly replica, so let's ignore them.

But note, that this will require to extend TableStatus (not extend, but
introduce new version), that will have is_readonly field.

Also before background INSERT into Distributed does not uses
getManyChecked() which means that they do not request TableStatus
packet, while now they would, though this is minor (just a note).

v2: Add a note about max_replica_delay_for_distributed_queries for INSERT
v3: Skip read-only replicas for async INSERT into Distributed
v4: Remove extra @insert parameter for ConnectionPool*::get*
    It make sense only when the table name had passed --
    ConnectionPoolWithFailover::getManyChecked()
v5: rebase on top LoggerPtr
v6: rebase
v7: rebase
v8: move TryResult::is_readonly into the end

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:38 +01:00
Pervakov Grigorii
a2ad832dfe fix error handling 2024-03-25 17:13:30 +00:00
Nikita Taranov
1115fa4bc7 fix tidy 2024-03-25 15:13:13 +00:00
kssenii
46941e7243 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-25 15:10:11 +01:00
Pervakov Grigorii
570dc32b07 fix style 2024-03-25 14:09:53 +00:00
Pervakov Grigorii
6b50f5bf10 Reload certificate chain during certificate reload 2024-03-25 14:09:53 +00:00
Alexey Milovidov
baef1cd4d2 Merge branch 'master' into get-client-http-header 2024-03-24 21:37:14 +01:00
Alexey Milovidov
d249d53de6 Remove DataStreams 2024-03-24 02:07:41 +01:00
Alexey Milovidov
e195806c5b Add function getClientHTTPHeader, part 1 2024-03-23 20:52:26 +01:00
Alexey Milovidov
a56c113c83 Fix for clang-19 2024-03-22 22:12:59 +01:00
Nikita Taranov
146d760338 rm more 2024-03-22 17:38:06 +00:00
Sean Haynes
dc677f0f18 Use scheduleOrThrow in MergeTree data selector thread pool
At the moment, the use of scheduleOrThrowOnError doesn't currently
have a timeout. So if you reach a point of saturation and use all
threads available in the global pool, threads block infinitely
and lead to a deadlock.

This changes that behaviour so that MergeTree data selector threads
will have a timeout and return a "No threads available" exception
to clients.

Credit to Nikita Mikhaylov for the proposition here:

https://github.com/ClickHouse/ClickHouse/pull/56431
2024-03-22 16:46:20 +00:00
Nikita Taranov
d7b34a80bb stash 2024-03-22 16:09:14 +00:00
avogar
47095f63b1 Fix writing exception message in output format in HTTP when http_wait_end_of_query is used 2024-03-22 16:03:28 +00:00
Alexander Tokmakov
9082a018a5
Merge pull request #59082 from ClickHouse/fix_race_async_inserts_queue
Fix race on `Context::async_insert_queue`
2024-03-22 16:06:13 +01:00
serxa
67819b1484 Merge branch 'master' into fix-db-iterator-waits 2024-03-21 10:53:54 +00:00
Alexander Tokmakov
5d7e5e5a72 Merge branch 'master' into fix_race_async_inserts_queue 2024-03-19 19:39:25 +01:00
kssenii
0122c3e883 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-19 19:31:02 +01:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
serxa
051103b0e0 Fix db iterator wait during async metrics collection 2024-03-18 15:39:21 +00:00
Robert Schulze
c17536c3b3
Enable clang-tidy in headers 2024-03-18 08:00:09 +00:00
Alexey Milovidov
01136bbc3b Limit backtracking in parser 2024-03-17 19:54:45 +01:00
kssenii
bfc4f5e1d3 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-11 14:57:15 +01:00
Anton Popov
61859ee865
Merge pull request #61055 from CurtizJ/fix-async-insert-deadlock
Fix deadlock in async inserts to `Log` tables via native protocol
2024-03-08 11:36:49 +01:00
Nikita Mikhaylov
8e3fc1044f
Reject INSERT if async_insert=1 + deduplicate_blocks_in_dependent_materialized_views=1 (#60888) 2024-03-07 20:39:56 +01:00
Anton Popov
b9d6f4b3ed fix deadlock in async inserts via native protocol 2024-03-07 17:42:50 +00:00
kssenii
0aade3765f Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-06 17:02:50 +08:00
kssenii
0c293bce11 Merge remote-tracking branch 'origin/master' into use-iobject-storage-for-table-engines-1 2024-03-06 12:06:19 +08:00
Antonio Andelic
fb8241c651 Better 2024-03-04 16:36:46 +01:00
Antonio Andelic
9f5fe176ad Catch exceptions on finalize 2024-03-04 14:42:11 +01:00
Alexey Milovidov
c362bbc9ca
Merge pull request #60390 from ClickHouse/redirect-handlers
Allow configuring HTTP redirect handlers for clickhouse-server
2024-03-02 05:15:31 +03:00
Mikhail Koviazin
11371e886c
Update protobuf to v25.1
The new version deprecates `syntax()` and makes it inaccessible. Instead, the
attributes corresponding to a feature should be used. This commit addresses
this.
2024-03-01 17:03:10 +02:00
Yakov Olkhovskiy
7d5b5a094d
don't move from capture - it is used repeatedly 2024-02-29 18:50:25 -05:00
Robert Schulze
4ee1aa8c7c
Fixing more headers 2024-02-29 15:40:30 +00:00
Alexey Milovidov
b0ab0b37db
Merge pull request #60434 from ClickHouse/revert-60216-revert-59697-check-stack-size-in-parser
Revert "Revert "Check stack size in Parser""
2024-02-28 19:20:49 +03:00
Alexey Milovidov
9ea7ff231b
Merge pull request #60448 from ClickHouse/clang-19
Update to clang-19
2024-02-27 23:38:08 +03:00
Alexey Milovidov
0f3c9963d1 Merge branch 'master' of github.com:ClickHouse/ClickHouse into revert-60216-revert-59697-check-stack-size-in-parser 2024-02-27 17:30:32 +01:00
Alexey Milovidov
c192a448d0 Update to clang-19 2024-02-27 14:37:21 +01:00
Alexey Milovidov
0b90076a36
Revert "Revert "Check stack size in Parser"" 2024-02-27 01:34:50 +03:00
Alexey Milovidov
fbfc4afb46
Merge branch 'master' into redirect-handlers 2024-02-27 01:27:38 +03:00
Robert Schulze
ac7a3cd18d
Merge remote-tracking branch 'rschu1ze/master' into mysql-friday-evening-fix 2024-02-26 22:00:45 +00:00
Alexey Milovidov
bbf9561a65
Merge pull request #60389 from ClickHouse/allow-remap-web-ui-handlers
Allow to map UI handlers to different paths
2024-02-26 21:03:59 +03:00
Alexey Milovidov
bad7ee271c Merge branch 'redirect-handlers' of github.com:ClickHouse/ClickHouse into redirect-handlers 2024-02-26 17:27:48 +01:00
Alexey Milovidov
0469bdb639 Fix tidy 2024-02-26 17:27:29 +01:00
Antonio Andelic
5b01c4feb3
Revert "Fix: IAST::clone() for RENAME" 2024-02-26 08:47:05 +01:00
Alexey Milovidov
34e85959c1
Update HTTPServerResponse.cpp 2024-02-26 03:34:35 +03:00
Alexey Milovidov
9f4041e3f7 Add support for HTTP redirects 2024-02-25 23:45:09 +01:00
Alexey Milovidov
2756160aea Allow to map UI handlers to different paths 2024-02-25 23:04:39 +01:00