Commit Graph

5089 Commits

Author SHA1 Message Date
serxa
c0f529600d fix darwin build 2023-01-11 12:23:33 +00:00
MeenaRenganathan22
25c94dfa83 Changes to support the CRC32 in PowerPC to address the WeakHash collision issue. Update the reference to support the hash values based on the specific platform 2023-01-10 21:20:13 -08:00
serxa
da4e9c9430 fix SharedMutex build 2023-01-10 16:35:46 +00:00
HarryLeeIBM
bc48b17817 Addressed more review comments. 2023-01-10 08:26:27 -08:00
Robert Schulze
0c3b034887
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-10 09:02:41 +00:00
serxa
6f31c5094d Merge branch 'cancellable-mutex' of github.com:ClickHouse/ClickHouse into cancellable-mutex 2023-01-10 01:27:11 +00:00
serxa
0f80ad6e06 make style-check happy 2023-01-10 01:26:59 +00:00
Sergei Trifonov
b4961a6253
Merge branch 'master' into cancellable-mutex 2023-01-10 02:20:42 +01:00
Robert Schulze
ad4884b394
Fix review comments, pt. I 2023-01-09 21:42:51 +00:00
serxa
ae56ac1b56 add TSA support 2023-01-09 16:46:07 +00:00
serxa
534db794c1 more review fixes 2023-01-09 15:05:41 +00:00
serxa
88c3c2946b review fixes + split into files 2023-01-09 14:58:44 +00:00
taiyang-li
a8da7b4c20 change as request 2023-01-09 20:39:46 +08:00
taiyang-li
4bc2c61406 change as request 2023-01-09 20:37:16 +08:00
Kseniia Sumarokova
b22b51213f
Merge pull request #44868 from kssenii/improve-async-buffer-from-remote
Small perf improvement for async buffer from remote
2023-01-09 13:31:15 +01:00
taiyang-li
20c7c0b1ef change as request 2023-01-09 18:21:31 +08:00
Sergei Trifonov
a4470dd1b2
Update src/Common/Threading.cpp
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2023-01-09 09:01:44 +01:00
Sergei Trifonov
81d2ea30ba
Merge branch 'master' into cancellable-mutex-integration 2023-01-07 19:37:46 +01:00
Sergei Trifonov
a3b81778cd
Merge branch 'master' into cancellable-mutex 2023-01-07 19:34:19 +01:00
Anton Popov
1f32ffedf8
Merge pull request #43221 from ClickHouse/refactoring-ip-types
Replace domain IP types (IPv4, IPv6) with native
2023-01-07 12:01:21 +01:00
serxa
9c51ed6865 fix tests 2023-01-07 00:32:49 +00:00
serxa
705c8f01af fix tests 2023-01-07 00:31:53 +00:00
serxa
15bb127b01 replace every std::shared_mutex with DB::FastSharedMutex 2023-01-06 23:35:38 +00:00
serxa
a6958fff45 git-apply PR #44924 up to commit c65573d 2023-01-06 23:04:10 +00:00
Sergei Trifonov
c65573dd7e
Merge branch 'master' into cancellable-mutex 2023-01-06 23:52:35 +01:00
serxa
00b2c96ce8 fix special builds 2023-01-06 22:48:19 +00:00
Robert Schulze
45dbcf88e5
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-06 20:42:48 +00:00
kssenii
81070907a2 Better time watch 2023-01-06 18:44:48 +01:00
Kseniia Sumarokova
573d3283b0
Merge pull request #44327 from kssenii/use-new-named-collections-code-2
Replace old named collections code with new (from #43147) part 2
2023-01-06 13:06:26 +01:00
serxa
d217136ede review fixes 2023-01-05 20:41:36 +00:00
Yakov Olkhovskiy
1be48f706b
Merge pull request #43706 from ClibMouse/s390x_crc32
s390x weakhash32 support
2023-01-05 14:45:20 -05:00
Sergei Trifonov
3f87e6cd77
Update src/Common/Threading.h
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
2023-01-05 15:27:51 +01:00
Sergei Trifonov
985dff1dbf
Update src/Common/tests/gtest_threading.cpp
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2023-01-05 15:27:32 +01:00
Sergei Trifonov
c507d7ecef
Update src/Common/tests/gtest_threading.cpp
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2023-01-05 15:27:21 +01:00
Ilya Yatsishin
0a60fe6e60
Merge pull request #44895 from Algunenano/ignore_label_issues_on_hwmon
Ignore hwmon sensors on label read issues
2023-01-05 12:43:37 +01:00
serxa
abf63d0c33 cleanup 2023-01-05 00:26:28 +00:00
serxa
c4e896f73a cleanup 2023-01-05 00:23:10 +00:00
Sergei Trifonov
5d5cf7d5b0
Merge branch 'master' into cancellable-mutex 2023-01-05 00:50:38 +01:00
serxa
f706cf8903 fix style 2023-01-04 23:49:29 +00:00
serxa
e9e3414ae1 remove debug print 2023-01-04 23:04:04 +00:00
serxa
3ea04f0429 fix typos 2023-01-04 22:59:29 +00:00
serxa
baf6297f1d add fast and cancellable shared_mutex alternatives 2023-01-04 21:50:57 +00:00
Yakov Olkhovskiy
7a5a36cbed
Merge branch 'master' into refactoring-ip-types 2023-01-04 11:11:06 -05:00
Maksim Kita
2482acc600
Merge pull request #44881 from azat/concurrent-bounded-queue-fix
Fix ConcurrentBoundedQueue::emplace() return value in case of finished queue
2023-01-04 15:44:54 +03:00
Raúl Marín
05ce5eec06 Ignore hwmon sensors on label read issues 2023-01-04 12:05:13 +01:00
Alexey Milovidov
a804d9a643
Merge pull request #44856 from ClickHouse/fix-distinct-zero-size-key-44831
Fix: sorted DISTINCT with empty string
2023-01-04 05:16:00 +03:00
Alexey Milovidov
3a027d285f
Merge pull request #44828 from ClickHouse/remove-two-lines-of-code
What if I will remove two lines of code?
2023-01-04 04:50:52 +03:00
Azat Khuzhin
a2f17d2d91 Fix ConcurrentBoundedQueue::emplace() return value in case of finished queue
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-01-03 20:36:12 +01:00
Robert Schulze
cfb6feffde
What happens if I remove these 139 lines of code? 2023-01-03 18:35:31 +00:00
Raúl Marín
0785bf6b29 Do not throw DB::Exception when folders do not exist 2023-01-03 17:05:54 +01:00
kssenii
67509aa2d5 Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2 2023-01-03 16:41:30 +01:00
kssenii
bda8f0d410 Better async buffer from remote 2023-01-03 15:27:37 +01:00
Robert Schulze
421473e974
Merge pull request #44421 from ClickHouse/revert-of-revert-of-age-function
Revert revert of age function
2023-01-03 10:02:18 +01:00
Igor Nikonov
b7062c182a Fix: sorted DISTINCT with empty string 2023-01-03 00:23:05 +00:00
Alexey Milovidov
e855d3519a
Merge branch 'master' into refactoring-ip-types 2023-01-02 21:58:53 +03:00
Robert Schulze
e9e04166d9
Merge remote-tracking branch 'origin/master' into query-result-cache 2023-01-02 08:20:27 +00:00
Larry Luo
71da1b1379 Updated inverted index to use ActionsDAG 2022-12-31 18:05:06 -08:00
HarryLeeIBM
6a5fef632d Added more tests and experimental flag, etc. 2022-12-31 18:05:01 -08:00
Harry-Lee
b43ddde50a Refactor full text search according to reviews 2022-12-31 18:03:14 -08:00
Larry Luo
7d1c34316a Fixed a type in comments 2022-12-31 18:03:14 -08:00
Larry Luo
ca4893307b Reference FST paper title directly 2022-12-31 18:03:14 -08:00
Larry Luo
00e4411740 Created FST namespace to hide FST details 2022-12-31 18:03:14 -08:00
Larry Luo
514e17d037 Code clean up 2022-12-31 18:03:14 -08:00
Larry Luo
1d9bf9962c Code clean up 2022-12-31 18:03:14 -08:00
Larry Luo
7b850b6d93 Refactoring 2022-12-31 18:03:13 -08:00
Larry Luo
3652740535 Code clean up 2022-12-31 18:03:13 -08:00
Larry Luo
0b63d6b5be Resolve conflicts and style errors. 2022-12-31 18:03:13 -08:00
HarryLeeIBM
0839ff60ee Initial Checkin of full text search 2022-12-31 18:00:17 -08:00
Nikolay Degterinsky
dfe93b5d82
Merge pull request #42284 from Algunenano/perf_experiment
Performance experiment
2022-12-30 03:14:22 +01:00
Alexey Milovidov
9378194320
Merge pull request #44688 from ClickHouse/improve-odbc-test
Improve odbc test
2022-12-29 15:40:47 +03:00
Raúl Marín
5de11979ce
Unify query elapsed time measurements (#43455)
* Unify query elapsed time reporting

* add-test: Make shell tests executable

* Add some tests around query elapsed time

* Style and ubsan
2022-12-28 21:01:41 +01:00
Alexey Milovidov
4fce10940e
Merge pull request #44629 from Algunenano/revert_flamegraph
Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log
2022-12-28 22:56:50 +03:00
Raúl Marín
e915ce1e95 Merge remote-tracking branch 'blessed/master' into perf_experiment 2022-12-28 20:15:43 +01:00
Alexey Milovidov
c3eff78f20 Don't be kind with third-party code 2022-12-28 20:07:26 +01:00
Alexey Milovidov
135a32c606
Merge branch 'master' into faster-startup-bc-check 2022-12-27 23:17:24 +03:00
Sergei Trifonov
56b3c6c68f
Merge pull request #44308 from ZhiguoZh/20221216-threadpool-notify
Call std::condition_variable::notify_* without lock in ThreadPool
2022-12-27 15:02:49 +01:00
Raúl Marín
948ce8db93 Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log"
This reverts commit e99849d031, reversing
changes made to 7ad3ff8a9e.
2022-12-27 14:28:13 +01:00
Alexey Milovidov
42415d49ac
Merge pull request #44607 from ClickHouse/fix-log-messages-coordination
Fix log messages in Coordination
2022-12-27 15:46:14 +03:00
Alexey Milovidov
d68c5c24ca
Merge pull request #44610 from ClickHouse/better-log-meesage
Better log message
2022-12-27 15:45:38 +03:00
Raúl Marín
fc1fa82a39
Merge branch 'master' into perf_experiment 2022-12-27 10:51:58 +01:00
Alexey Milovidov
54c8b162c0 Better log message 2022-12-26 20:09:52 +01:00
Alexey Milovidov
f0fa0977ed Fix wrong log messages 2022-12-26 18:36:07 +01:00
Alexey Milovidov
4f3db6a63a Fix wrong log message 2022-12-26 18:35:43 +01:00
Alexey Milovidov
91c1f9de8f Faster server startup after stress test 2022-12-26 18:13:50 +01:00
Alexey Milovidov
f22fc35900 Minimal changes 2022-12-25 14:18:05 +01:00
Alexander Tokmakov
ca989e9212 less runtime format strings 2022-12-23 19:50:34 +01:00
Alexander Tokmakov
93509395fb add a column with a message pattern to text_log 2022-12-23 15:06:30 +01:00
alesapin
2fecf420cb
Merge pull request #44513 from ClickHouse/small_polishing
Minor code polishing
2022-12-23 13:47:26 +01:00
Alexander Gololobov
0788269c25
Merge pull request #44410 from ClickHouse/fix_unicode_bar
Fix buffer overrun in UnicodeBar::render
2022-12-23 13:17:24 +01:00
kssenii
8308177361 Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2 2022-12-23 12:14:46 +01:00
kssenii
853f2ea123 Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2 2022-12-23 11:49:02 +01:00
Alexander Gololobov
0ae7f03516
Merge branch 'master' into fix_unicode_bar 2022-12-22 14:53:33 +01:00
alesapin
fa467b3398 Minor code polishing 2022-12-22 14:31:42 +01:00
vdimir
88008726d8
Merge branch 'master' into vdimir/tmp-data-in-fs-cache-2 2022-12-22 10:58:39 +00:00
alesapin
380c6cebe4
Merge pull request #44393 from ClickHouse/small_improvement
Lock table for share during startup for database ordinary
2022-12-22 11:42:42 +01:00
vdimir
d30d25dbbe
Temporary files evict fs cache 2022-12-22 10:22:49 +00:00
Vladimir C
6a0210fb0f
Merge pull request #43785 from mo-avatar/binhexstringliterals 2022-12-22 10:56:18 +01:00
Yakov Olkhovskiy
a8cb29da4b
Merge branch 'master' into refactoring-ip-types 2022-12-21 23:56:24 -05:00
Alexander Gololobov
4b0cbdb4a4 Fixed unused value warning 2022-12-21 10:55:20 +01:00
Robert Schulze
f8378473c4
Fix call to wrong overload on Darwin 2022-12-21 09:00:44 +00:00
Zhiguo Zhou
823cb8a8f0 Call std::condition_variable::notify_one w/o lock in ThreadPool
Calling notify_one function with lock held would let the notified
thread immediately block again, and increase the lock contention.
This commit moves the calls of notify_one function out of critical
sections of ThreadPool, whose lock (ThreadPoolImpl::mutex) is most
extensively contended in some workloads.
2022-12-21 13:50:03 +08:00
kssenii
1d75f740d7 Fix tests 2022-12-20 22:33:54 +01:00
kssenii
6bd4f8c029 Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2 2022-12-20 21:17:28 +01:00
alesapin
c902bca426 Remove races 2022-12-20 18:14:06 +01:00
Alexander Gololobov
424ae4686e Cleaups based on code review comments 2022-12-20 17:02:30 +01:00
Robert Schulze
3f03b0b53d
Revert "Revert "Add function 'age'""
This reverts commit 4549b14027.
2022-12-20 10:18:43 +00:00
Raúl Marín
45d27f461b
Merge branch 'master' into perf_experiment 2022-12-20 09:07:48 +00:00
Alexander Gololobov
2ab6b7d033 Check remaining space to avoid buffer overruns; some cleanups 2022-12-20 02:39:44 +01:00
alesapin
c8d9ccf3cd Lock table for share during startup for database ordinary 2022-12-19 18:51:46 +01:00
Sergei Trifonov
6f7bba159f
Merge pull request #41840 from ClickHouse/io-scheduler
IO scheduling subsystem
2022-12-19 15:15:19 +01:00
Robert Schulze
b93c56323c
Merge remote-tracking branch 'origin/master' into query-result-cache 2022-12-19 09:18:36 +00:00
Alexey Milovidov
0511532305
Merge pull request #44256 from azat/hashtable-fix
Fix double-free in HashTable::clearAndShrink() with zero elements in it
2022-12-17 03:20:22 +03:00
Sergei Trifonov
bded03e035
Merge branch 'master' into io-scheduler 2022-12-17 00:39:54 +01:00
kssenii
30547d2dcd Replace old named collections code for url 2022-12-17 00:24:05 +01:00
Alexey Milovidov
d3fd9a6c1e
Merge pull request #44239 from azat/builtin-skim-v2
Builtin skim for fuzzy search in clickhouse client/local history
2022-12-16 21:23:24 +03:00
Sergei Trifonov
f61a98b5dc
Merge branch 'master' into io-scheduler 2022-12-16 15:55:08 +01:00
Azat Khuzhin
81be20edfe Fix double-free in HashTable::clearAndShrink() with zero elements in it
Before this patch HashTable::clearAndShrink() did this:

    destroyElements();
    clearHasZero();

While destroyElements() already destroys the zero element, so it leads
to double free, like here [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/40003/f09e956ddf150c1aceb210348544bc28876a2d11/stateless_tests__asan__[2/4].html

The issue is only for complex types.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-16 15:22:00 +01:00
Robert Schulze
d1615ec283
Display metrics for query result cache 2022-12-16 10:49:15 +00:00
Nikolai Kochetov
e99849d031
Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log
Track allocation ptr in system.trace_log. Add aggregate function flamegraph
2022-12-15 18:16:05 +01:00
Alexander Tokmakov
ec36ce7bb3
Merge branch 'master' into threads-in-overcommit-tracker-metric 2022-12-15 19:18:03 +03:00
Robert Schulze
537c64aad2
Merge remote-tracking branch 'origin/master' into query-result-cache
Conflicts:
- tests/queries/0_stateless/02117_show_create_table_system.reference
2022-12-15 12:17:58 +00:00
Alexey Milovidov
d8bb74d68a
Revert "Add information about written rows in progress indicator" 2022-12-15 10:19:15 +03:00
Azat Khuzhin
82aaad61aa Integrate skim into the client/local
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.

P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC. But anyway
this will be resolved in a different way, but separatelly.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 20:57:41 +01:00
Dmitry Novik
3ab294be82 Also count waiting on global mutext 2022-12-14 18:05:07 +00:00
Dmitry Novik
1e5fdbdef0 Add ThreadsInOvercommitTracker metric 2022-12-14 16:56:19 +00:00
Azat Khuzhin
67fa185611
Revert "Builtin skim" 2022-12-14 17:17:19 +03:00
Alexey Milovidov
c93b7741b3
Merge branch 'master' into builtin-skim 2022-12-14 02:30:21 +03:00
Alexey Milovidov
4549b14027
Revert "Add function 'age'" 2022-12-13 23:28:09 +03:00
Nikolay Degterinsky
9b6d31b95d
Merge branch 'master' into perf_experiment 2022-12-13 17:15:07 +01:00
Igor Nikonov
ca06fd02c1
Merge pull request #43860 from bigo-sg/podopt
A little improve performance of PODArray
2022-12-13 12:57:22 +01:00
Vladimir C
ef45590413
Merge pull request #43925 from jh0x/improve-number-separator
Fixes https://github.com/ClickHouse/ClickHouse/issues/28967
2022-12-13 12:37:32 +01:00
Robert Schulze
1f9b34f133
Merge pull request #44049 from HarryLeeIBM/hlee-s390x-string-htable
Fix endian issue in StringHashTable for s390x
2022-12-13 09:27:52 +01:00
Alexey Milovidov
df17d1b71b
Merge branch 'master' into builtin-skim 2022-12-13 03:33:42 +03:00
Nikolai Kochetov
e451137040 Add comments. 2022-12-12 18:26:07 +00:00
Suzy Wang
093dc95d0f
Merge branch 'master' into s390x_crc32 2022-12-12 09:39:29 -05:00
Robert Schulze
b78652e138
Query result cache 2022-12-12 10:37:10 +00:00
Azat Khuzhin
9ed6aa0be1 Fix -Wshorten-64-to-32 on FreeBSD
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-12 08:05:28 +01:00
Azat Khuzhin
de58e9c02d Integrate skim into the client/local
Note, that it can the fail the client if the skim itself will fail,
however I haven't seen it panicd, so let's try.

P.S. about adding USE_SKIM into configure header instead of just compile
option for target, it is better, because it allows not to recompile lots
of C++ headers, since we have to add skim library as PUBLIC.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-11 15:52:00 +01:00
Alexey Milovidov
9a48cf0da8
Merge pull request #40422 from pkubaj/patch-1
Add FreeBSD/powerpc64le support
2022-12-11 09:38:04 +03:00
mo-avatar
e88b85178f Support SQL standard binary and hex string literals 2022-12-11 13:05:40 +08:00
Yakov Olkhovskiy
38707238b5 fix parser 2022-12-10 06:22:49 +00:00
Yakov Olkhovskiy
79a26203fe add variant parser and use it for toIPv6 2022-12-10 04:39:43 +00:00
Boris Kuschel
592c73e2c3
Merge branch 'master' into openssl_support 2022-12-09 20:21:22 -05:00
Yakov Olkhovskiy
8a923e72fa parser fixed, some optimizations 2022-12-10 00:48:44 +00:00
Yakov Olkhovskiy
02b253cffc fix style 2022-12-09 21:35:05 +00:00
Yakov Olkhovskiy
f7799c173b adapt IPv4 and IPv6 parsers for ReadBuffer, update to fit last master's merge 2022-12-09 21:20:52 +00:00
Suzy Wang
802f633f39
Merge branch 'master' into s390x_crc32 2022-12-09 15:00:46 -05:00
Anton Popov
17c557648e
Merge pull request #44045 from CurtizJ/fix-tracing-of-profile-events
Fix tracing of profile events
2022-12-09 14:12:58 +01:00
HarryLeeIBM
c381eb1b8e Fix endian issue in StringHashTable for s390x 2022-12-08 08:56:56 -08:00
Yakov Olkhovskiy
0641066183
Merge branch 'master' into refactoring-ip-types 2022-12-08 11:12:05 -05:00