Commit Graph

57766 Commits

Author SHA1 Message Date
Alexey Milovidov
0f77b6fd95 Even more better 2021-02-19 22:01:45 +03:00
Azat Khuzhin
fba1c7fcc1 Fix uncaught exception when HTTP client goes away
Even after #20464 it was still possible, for example [1].

    2021.02.19 11:40:21.886191 [ 68373 ] {} <Trace> DynamicQueryHandler: Request URI: /?database=test_ds2d6y&log_comment=/usr/share/clickhouse-test/queries/0_stateless/01302_aggregate_state_exception_memory_leak.sh&enable_http_compression=1&http_zlib_compression_level=1

    <snip>

    2021.02.19 11:41:35.289940 [ 365 ] {} <Fatal> BaseDaemon: (version 21.3.1.6058, build id: 8D46D65205E2C8B7FE408A0B4EC76CA0483F9E92) (from thread 68373) Terminate called for uncaught exception:
    Code: 24, e.displayText() = DB::Exception: Cannot write to ostream at offset 262568, Stack trace (when copying this message, always include the lines below):

    0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x15b3c7db in /usr/bin/clickhouse
    1. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:56: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x8aba66e in /usr/bin/clickhouse
    2. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::nextImpl() @ 0x8b8c105 in /usr/bin/clickhouse
    3. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x8b8c537 in /usr/bin/clickhouse
    4. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:44: DB::Write

  [1]: https://clickhouse-test-reports.s3.yandex.net/16481/5d150cce4778dd14f58dcff67435bdec1efa155b/stress_test_(thread).html#fail1

And according to this partial stacktrace it seems that the dtor of
WriteBufferFromOStream was called from
WriteBufferFromHTTPServerResponse, since the class name starts from
DB::Write*

The problem is that if first time WriteBufferFromOStream::next() fails,
it will reset position to make next write no-op, however
WriteBufferFromHTTPServerResponse::next() will set position to available
buffer back, and next() will throw again, but this time it can be from
dtor.
2021-02-19 22:00:57 +03:00
Denis Zhuravlev
66e775ef88 test for decimal ( p , s) in dictionaries 2021-02-19 14:53:34 -04:00
Alexey Milovidov
252bcccdda Just little better 2021-02-19 21:32:39 +03:00
alexey-milovidov
a78523cf01
Merge pull request #20208 from vzakaznikov/ldap_docs
Adding documentation on how to use LDAP server as external user authenticator or directory
2021-02-19 20:56:01 +03:00
Maksim Kita
fc03c1013c
Fixed style check 2021-02-19 20:42:51 +03:00
alexey-milovidov
2299930c31
Merge pull request #20545 from kssenii/rabbit-format-settings
rabbitmq: add missing format factory settings
2021-02-19 20:24:17 +03:00
alexey-milovidov
91de5628f0
Merge pull request #20866 from CurtizJ/fix-distinct-state
Fix usage of 'distinct' combinator with 'state' combinator
2021-02-19 20:22:53 +03:00
Maksim Kita
0b5213c80d
Added comment 2021-02-19 19:49:19 +03:00
tavplubix
3509fe88d8
Merge pull request #20878 from ClickHouse/fix_18926
Fix COM_FIELD_LIST response in MySQL protocol
2021-02-19 19:25:54 +03:00
Maksim Kita
b84112a603 Function sumMap decimal fix 2021-02-19 19:25:50 +03:00
alexey-milovidov
ceacae4ee4
Merge pull request #20462 from azat/stress-backtrace-on-failure
Improve backtrace catching on server failures in CI for stress tests
2021-02-19 17:33:29 +03:00
alesapin
ea27c3ca32 Add gdb to fasttest image 2021-02-19 16:41:46 +03:00
alesapin
bebc66b0ca
Merge pull request #20960 from kssenii/fixed-aerospike-version
Fix push to dockerhub
2021-02-19 16:22:24 +03:00
Ivan
414f470c79
Make Poco HTTP Server zero-copy again (#19516)
* Refactoring: part 1

* Refactoring: part 2

* Handle request using ReadBuffer interface

* Struggles with ReadBuffer's

* Fix URI parsing

* Implement parsing of multipart/form-data

* Check HTTP_LENGTH_REQUIRED before eof() or will hang

* Fix HTTPChunkedReadBuffer

* Fix build and style

* Fix test

* Resist double-eof

* Fix arcadian build
2021-02-19 15:51:26 +03:00
Nikolai Kochetov
866dfaec79
Update 01731_async_task_queue_wait.sh 2021-02-19 15:25:22 +03:00
Maksim Kita
71c65b5d82
Merge pull request #20611 from kitaisreal/rename-untyped-function-reinterpret-as
Rename untyped function reinterpretAs into reinterpret
2021-02-19 14:35:00 +03:00
Nikolai Kochetov
df1cf481cf
Update 01731_async_task_queue_wait.sh 2021-02-19 14:14:31 +03:00
Nikolai Kochetov
8f8a4f6423
Update 01731_async_task_queue_wait.sh 2021-02-19 13:59:38 +03:00
kssenii
1c5b10de41 Use fixed version for aerospike 2021-02-19 10:42:25 +00:00
Maksim Kita
5bbd6f7480 Fixed documentation 2021-02-19 12:37:00 +03:00
Amos Bird
fc1885ea9b
Try fixing flaky tests 2021-02-19 17:28:01 +08:00
Nikolai Kochetov
ed4697cffc Fix timeout in epoll_wait for RemoteQueryExecutorReadContext 2021-02-19 12:20:24 +03:00
Nikolai Kochetov
d438d7e390 Fix timeout in epoll_wait for PollingQueue 2021-02-19 12:07:34 +03:00
Alexey Milovidov
39f07d62a4 Disable in-memory compression by default 2021-02-19 12:02:18 +03:00
Alexey Milovidov
a9d9a6d56f Merge branch 'master' into in-memory-compression 2021-02-19 12:01:33 +03:00
Alexey Milovidov
8e8a81883e Merge branch 'master' into in-memory-compression 2021-02-19 11:59:11 +03:00
Nikolai Kochetov
7d1119680e Remove not needed file. 2021-02-19 11:52:33 +03:00
Nikolai Kochetov
b9d6df9618 Check for eintr in epoll_wait 2021-02-19 11:49:41 +03:00
alexey-milovidov
4650dcdbb0
Merge pull request #20883 from azat/ccache-4.2
ccache 4.2+ does not requires any quirks for SOURCE_DATE_EPOCH
2021-02-19 09:59:17 +03:00
Amos Bird
fc185e5fb7
Another try 2021-02-19 11:56:24 +08:00
Azat Khuzhin
7bcfe92cd7 Mark 01730_distributed_group_by_no_merge_order_by as long
https://clickhouse-test-reports.s3.yandex.net/20882/af660140c320ca45bca0edfd89000b3c6da8ee6a/functional_stateless_tests_flaky_check_(address).html#fail1
2021-02-18 23:29:38 +03:00
Azat Khuzhin
865dca0b0d ccache 4.2+ does not requires any quirks for SOURCE_DATE_EPOCH
And besides "ccache <some ccache options> compiler" does not work, since
it interpret everything as ccache options.

Refs: cad2416291
2021-02-18 22:39:44 +03:00
Azat Khuzhin
9c01869090 Fix 'Empty task was returned from async task queue' on query cancellation 2021-02-18 22:15:21 +03:00
Azat Khuzhin
af660140c3 Do only merging of sorted blocks on initiator with distributed_group_by_no_merge=2
When distributed_group_by_no_merge=2 is used (or when
optimize_distributed_group_by_sharding_key takes place), remote servers
will do full ORDER BY, so initiator can skip this step and do only merge
of ordered blocks.
2021-02-18 21:43:27 +03:00
Azat Khuzhin
b854a7b7f8 Add some details into comment for first_stage/second_stage
Regardless
distributed_group_by_no_merge=2/optimize_distributed_group_by_sharding_key
2021-02-18 21:41:50 +03:00
Alexander Tokmakov
8097532cb7 Merge branch 'master' into database_replicated 2021-02-18 17:42:06 +03:00
Alexander Tokmakov
1bad1e3a7c fix dockerfile 2021-02-18 17:37:51 +03:00
Alexander Tokmakov
97f4c457ec fix MySQL COMM_FIELD_LIST response 2021-02-18 16:27:51 +03:00
alesapin
45119fce4f
Merge pull request #20306 from bharatnc/ncb/docs-rename-column
Document ALTER RENAME Column
2021-02-18 15:46:28 +03:00
Amos Bird
2c4bc43014
Backward compatible 2021-02-18 20:20:29 +08:00
Amos Bird
f402aa4057
Normalize constant expression 2021-02-18 20:20:28 +08:00
Amos Bird
cac9c7fc07
Fix tests 2021-02-18 20:20:28 +08:00
Amos Bird
2dc7ba160a
Better 2021-02-18 20:20:28 +08:00
Amos Bird
77fd060665
Normalize function names 2021-02-18 20:20:28 +08:00
zlx19950903
c92e613b82
Add a function htmlOrXmlCoarseParse to extract content from html or xml format string. (#19600)
* add html and xml coarse parse

* add test file

* add conditional check: hyperscan

* fix style error

* add conditional check

* bug fix

* delete unit

* typos check fix

* add unit test

* style check fix

* fix build error: case style

* acradis_skip test fix

* LINT error fix

* Remove comments

Co-authored-by: guojiantao <guojiantao15@mails.ucas.ac.cn>
Co-authored-by: Ivan <5627721+abyss7@users.noreply.github.com>
Co-authored-by: Ivan Lezhankin <ilezhankin@yandex-team.ru>
2021-02-18 15:05:55 +03:00
Kruglov Pavel
419962dbfb
Merge pull request #20712 from kssenii/add-test
Add test for already fixed odbc Postgres date type conversion
2021-02-18 13:43:17 +03:00
Maksim Kita
4278098f9a Reinterpret function added Decimal, DateTim64 support 2021-02-18 13:09:01 +03:00
Maksim Kita
dcabbc95ed
Merge pull request #20623 from kitaisreal/dictionary-create-source-with-functions-fix
Dictionary create source with functions crash fix
2021-02-18 11:50:20 +03:00
alesapin
abe5d9df1e
Merge pull request #20627 from ClickHouse/fix_fast_test_retry
Fix fasttest retry for failed tests
2021-02-18 11:41:21 +03:00