Commit Graph

142466 Commits

Author SHA1 Message Date
Jiebin Sun
d40c5a07be Avoid UBSan warning while buf is nullptr 2024-05-24 19:35:07 +08:00
Jiebin Sun
d1d57caf0a Generate the seperate function firstPopulatedCell() and lastPopulatedCell() 2024-05-24 19:35:07 +08:00
Jiebin Sun
ca88da11e0 Update src/Common/HashTable/FixedHashTable.h
Revise the method name by Nikita.

Co-authored-by: Nikita Taranov <nickita.taranov@gmail.com>
2024-05-24 19:35:07 +08:00
Jiebin Sun
4e6f5fba83 Update src/Common/HashTable/FixedHashTable.h
Add comment by Nikita.

Co-authored-by: Nikita Taranov <nickita.taranov@gmail.com>
2024-05-24 19:35:07 +08:00
Jiebin Sun
7f960e4e8a Add the use_emplace_to_insert_data flag. emplace() is the only interface
to update min/max. If the FixedHashTable.emplace() is not used to revise
the hashtable value, then we should not continue the min/max optimization.
2024-05-24 19:35:07 +08:00
Jiebin Sun
60420f2a8e Fix a bug if data will be inserted not by emplace(). 2024-05-24 19:35:07 +08:00
Jiebin Sun
69960a5735 Fix a bug if the container is empty 2024-05-24 19:35:07 +08:00
Jiebin Sun
d48fba5b2b Limit the array index of FixedHashTable by min/max
If the type of key is 8 bits or 16 bits in aggregation, ClickHouse will use array
of 256 or 65536 length to store the key and boost the mergeSingleLevel, rather than
key comparison. However, if the key has occupied only small range of the total 65536
cells, most of the cycles are wasted on the `isZero()` to find the next cell which
is not zero in iterator++.
The solution is to use min/max and update min/max when emplace. Then we can set the
upper searching limit to max in iterator++. And just set min as the value of `begin()`,
rather than searching the first cell that not equals to 0.
We have tested the patch on 2x80 vCPUs server, Query 7 of ClickBench has gained 2.1x
performance improvement.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
2024-05-24 19:35:07 +08:00
Alexey Milovidov
dddcfaab65
Merge pull request #64245 from den-crane/test/issue_45804
test for #45804
2024-05-24 04:32:53 +02:00
Alexey Milovidov
6c06772e5c
Merge pull request #64285 from ClickHouse/vdimir/squashing_transform_followup
Followup for #63691
2024-05-24 04:32:08 +02:00
Alexey Milovidov
2040a4d209
Merge pull request #64243 from Michicosun/fix_hdfs_unset_skip_unavailable_shards
Fix test_hdfsCluster_unset_skip_unavailable_shards
2024-05-24 01:14:15 +00:00
Alexey Milovidov
476bdb7174
Merge pull request #64325 from natalyjazzviolin/nataly/file-engine-cloud
Adds note: File engine unavailable in ClickHouse Cloud.
2024-05-24 01:13:23 +00:00
Nataly Merezhuk
5710b5852f Adds note - file engine unavailable in ClickHouse Cloud. 2024-05-23 17:45:58 -04:00
Robert Schulze
0bfa56b468
Merge pull request #64199 from rschu1ze/fix-64136
Query Cache: Consider identical queries against different databases as different
2024-05-23 20:52:32 +00:00
Robert Schulze
578dc58521
Merge pull request #62696 from rschu1ze/revert-revert-62392
Revert "Revert "Speed up `splitByRegexp`""
2024-05-23 20:21:21 +00:00
pufit
8ce3f38eeb
Merge pull request #64079 from ClickHouse/pufit/63777-fix-sql-security-with-analyzer
Fix SQL security access checks with analyzer
2024-05-23 20:00:16 +00:00
Robert Schulze
e513fc1985
Merge pull request #64019 from Blargian/document_revision
[Docs] add function `revision` + format changes to `other-functions`
2024-05-23 15:09:39 +00:00
Kseniia Sumarokova
ab43f18ce9
Merge pull request #64128 from MikhailBurdukov/enable_keeep_free_bytes_metadata
Enable keep_free_space_bytes for the metadata storage.
2024-05-23 14:22:53 +00:00
Kruglov Pavel
30dce7821c
Merge pull request #63058 from Avogar/dynamic-data-type
Implement Dynamic data type
2024-05-23 14:19:46 +00:00
Shaun Struwig
508b035654 Move is NaN from other-functions to arithmetic functions 2024-05-23 14:08:48 +00:00
Shaun Struwig
f8fc1fa338
Merge branch 'master' into document_revision 2024-05-23 16:00:38 +02:00
Shaun Struwig
e24253c097
Fix formatting in zh/index.md 2024-05-23 15:45:26 +02:00
Shaun Struwig
6e3a609907
Fix formatting in ru/index.md 2024-05-23 15:43:17 +02:00
Max K
9fb8c8263f
Merge pull request #64293 from ClickHouse/ci_changelog_py_fix
CI: dependency fix for changelog.py
2024-05-23 13:42:29 +00:00
Max K
b1fe9ab5f0 CI: dependency fix for changelog.py
#do_not_test
2024-05-23 15:33:21 +02:00
Robert Schulze
147516f162
Fix AST fuzzer failure 2024-05-23 13:04:18 +00:00
Robert Schulze
f872ad8b0d
Merge remote-tracking branch 'rschu1ze/master' into fix-64136 2024-05-23 12:34:32 +00:00
Blargian
713764f62f Add missing space before link 2024-05-23 14:01:00 +02:00
Blargian
ce26c4f657 Review changes and replace … with ... 2024-05-23 13:54:45 +02:00
Robert Schulze
906d17e6d5
Merge pull request #63957 from Blargian/document_proportionsZTest
[Docs] add `proportionsZTest` to docs
2024-05-23 11:49:24 +00:00
vdimir
299f0886bf
Followup for #63691 2024-05-23 13:48:17 +02:00
Raúl Marín
1bb41f820e
Merge pull request #64283 from ClickHouse/24.6-prepare
Update version after release
2024-05-23 11:11:04 +00:00
Raúl Marín
00bbffa6f0 Update autogenerated version to 24.6.1.1 and contributors 2024-05-23 11:04:29 +00:00
Robert Schulze
9d63095db9
Revert "Revert "Speed up splitByRegexp""
This reverts commit 08e5c2ba4d.
2024-05-23 10:01:10 +00:00
vdimir
70a1d3a63d
Merge pull request #63691 from ClickHouse/vdimir/fix_squashing_transform
Fix SimpleSquashingChunksTransform (02115_rewrite_local_join_right_di…
2024-05-23 09:43:45 +00:00
Raúl Marín
e6880e9e68
Merge pull request #62432 from canhld94/final_undefined_last_mark
Fix queries with FINAL give wrong result when table does not use adaptive granularity
2024-05-23 09:14:16 +00:00
Raúl Marín
d2231732bb
Merge pull request #64174 from Algunenano/create_as_mv_logical
Prevent LOGICAL_ERROR on CREATE TABLE as MaterializedView
2024-05-23 09:12:47 +00:00
Kseniia Sumarokova
cbacab0bf4
Merge pull request #64203 from ClickHouse/vdimir/rocksdb_flaky_test
Add debug logging to EmbeddedRocksDBBulkSink
2024-05-23 08:48:37 +00:00
MikhailBurdukov
45492baf44 Restart Ci 2024-05-23 08:20:16 +00:00
Blargian
9234beaff8 Fix typo and move from other-functions to math-functions 2024-05-23 09:32:43 +02:00
Antonio Andelic
3ff1b20e05
Merge pull request #64218 from ClickHouse/ignore-text-log-keeper
Ignore `text_log` for Keeper
2024-05-23 06:45:20 +00:00
Nikita Mikhaylov
02e463ab39
Merge pull request #64227 from ClickHouse/nikitamikhaylov-patch-1
Add gh to style-check dockerfile
2024-05-23 01:39:49 +00:00
Denny Crane
c07c9d4c87 test for #45804 2024-05-22 21:57:43 -03:00
Alexander Tokmakov
cd1d6d9b94
Merge pull request #64202 from azat/allow_suspicious_primary_key-fixes
Ignore allow_suspicious_primary_key on ATTACH and verify on ALTER
2024-05-22 23:23:57 +00:00
Mikhail Artemenko
7ecfdbb3aa fix test_hdfsCluster_unset_skip_unavailable_shards 2024-05-22 23:05:27 +00:00
Robert Schulze
2cf1b8b2ca
Merge remote-tracking branch 'rschu1ze/master' into fix-64136 2024-05-22 21:17:35 +00:00
Alexey Milovidov
5a4633aa0e
Merge pull request #63962 from ClickHouse/analyzer-columns-list-fix
Analyzer: Fix COLUMNS resolve
2024-05-22 22:44:28 +02:00
Max K
4279174fad
Merge pull request #63961 from ClickHouse/ci_disable_arm_int_tests_with_kerberazied_kafka
CI: aarch64: disable arm integration tests with kerberaized kafka
2024-05-22 20:02:54 +00:00
Alexander Tokmakov
6611d430e2
Merge pull request #64063 from ClickHouse/fix_waiting_for_mutations
Fix waiting for mutations with retriable errors
2024-05-22 18:58:45 +00:00
Max K
9a40ff033d
Merge branch 'master' into ci_disable_arm_int_tests_with_kerberazied_kafka 2024-05-22 20:35:23 +02:00