Commit Graph

48689 Commits

Author SHA1 Message Date
Azat Khuzhin
d553e56db7 Add a test for UAF in ThreadPool (triggered under ASAN) 2020-09-29 11:01:24 +03:00
Azat Khuzhin
1fcc36ef80 Use ThreadPool to ensure that everything has been finished in PipelineExecutor
This will fix possible UAF, since ThreadFromGlobalPool cannot wait until
the job will be reseted, for this you need to call ThreadPool::wait()
(that waits until scheduled_jobs will be zero), and this guarantee that
the job was reseted, otherwise some variables that job is referencing
may be already destroyed, while job hasn't been destoyed yet (example
that I found PipelineExecutor -> ThreadGroupStatusPtr -> MemoryTracker
-> ~MemoryTracker -> log, while log had been destroyed already, here is
TSAN report --
https://gist.github.com/azat/d480dc3af5a0a44de4b038e20807c4b9, copied
from
https://clickhouse-test-reports.s3.yandex.net/15035/79133a426fdf042e383ea0cdccc4dc8273baa3a7/functional_stateless_tests_(thread)/test_run.txt.out.log)
2020-09-29 11:00:03 +03:00
Azat Khuzhin
789434994a Reset job on failure too in ThreadPool::worker()
job should be reseted before decrementing scheduled_jobs to
ensure that the Job destroyed before wait() returns.
2020-09-29 10:56:36 +03:00
alesapin
bd531bb045
Merge pull request #15396 from ClickHouse/yet_another_retry
Fix some flaky tests: test_mysql_federated and 00652_replicated_mutations_zookeeper
2020-09-29 09:51:41 +03:00
Alexey Milovidov
e65465ac16 Fix install script 2020-09-29 00:11:08 +03:00
Alexander Kuzmenkov
51b9aaf4d8
Merge pull request #15363 from ClickHouse/format-regexp-raw
Add support for "Raw" column format for Regexp format
2020-09-28 20:03:32 +03:00
tavplubix
4578d89819
Merge pull request #15348 from ClickHouse/replicate_default_args
Continuation of #14791
2020-09-28 18:53:02 +03:00
tavplubix
421d3b0b86
Merge pull request #14760 from bharatnc/ncb/event_time_microsec_p2
add event_time_microseconds field for system.{trace,text,query,query_thread}_log tables
2020-09-28 18:34:21 +03:00
alesapin
071ff6c9af
Merge pull request #15063 from azat/symbolizers-settings-for-non-server
Set sanitizers options in the current shell too
2020-09-28 17:44:39 +03:00
Alexander Kuzmenkov
c48d212320 performance comparison 2020-09-28 15:09:08 +03:00
alesapin
a526a767df Fix some flaky tests 2020-09-28 14:17:07 +03:00
Nikita Mikhaylov
72e4b10c00
Merge pull request #14842 from hexiaoting/hxt_dev
Fix bug for LineAsString Format
2020-09-28 14:02:23 +03:00
Nikita Mikhaylov
0321c2529c
Merge pull request #15353 from hexiaoting/build_bugfix2
fix bug for building query_db_generator.cpp
2020-09-28 13:32:54 +03:00
alesapin
1adc0a8205 Fix race condition in client suggestions 2020-09-28 12:58:42 +03:00
Nikita Mikhaylov
73573472e9
Merge pull request #15299 from CurtizJ/fix-mysql-hung
Fix hang of queries with a lot of subqueries to same mysql table
2020-09-28 12:51:35 +03:00
alesapin
fff9e5d592 Merge branch 'master' into azat-symbolizers-settings-for-non-server 2020-09-28 12:31:05 +03:00
Artem Zuikov
b4f1eb07ff
slightly better bigint plus/minus (#15320) 2020-09-28 12:07:45 +03:00
tavplubix
ffc0499952
Merge pull request #15243 from ClickHouse/tavplubix-patch-1
Try fix race on Context::settings
2020-09-28 11:44:27 +03:00
alesapin
70cb4f6d0f
Merge pull request #15366 from ClickHouse/llvm-11
Prepare for LLVM-11
2020-09-28 11:38:42 +03:00
alesapin
bc662ac4e0
Merge pull request #15293 from amosbird/bc3
Replace useless multiset with unordered_set
2020-09-28 10:30:04 +03:00
Alexey Milovidov
07b931a414 Prepare for LLVM-11 2020-09-28 04:21:40 +03:00
Alexey Milovidov
79f510d63a Fix error in LowCardinality; add test 2020-09-28 03:22:50 +03:00
Alexey Milovidov
b800a7fdf1 Add support for "Raw" column format for Regexp format 2020-09-28 01:09:32 +03:00
alexey-milovidov
ca6e56f997
Merge pull request #15322 from den-crane/tests/partition_pruning
Tests/partition pruning
2020-09-27 22:50:22 +03:00
Alexander Tokmakov
7486539862 try fix test 2020-09-27 16:25:28 +03:00
Denny Crane
0dd244126d
Update 01508_partition_pruning.sh 2020-09-27 10:03:13 -03:00
Alexander Tokmakov
3bc8d9daa9 fix sync 2020-09-27 14:10:45 +03:00
hexiaoting
6ad48ade83 fix bug for building query_db_generator.cpp 2020-09-27 16:42:04 +08:00
Denis Zhuravlev
a8618c96f7 fix test (UTC timezone specified) more UTC 2020-09-26 21:02:18 -03:00
Denis Zhuravlev
cb901ac304 fix test (UTC timezone specified) 2020-09-26 19:07:13 -03:00
Alexander Tokmakov
34addcf61f add review suggestions 2020-09-26 22:18:28 +03:00
alexey-milovidov
bbbe51033d
Merge pull request #15321 from ClickHouse/query-obfuscator
Query obfuscator
2020-09-26 19:43:36 +03:00
tavplubix
df6221f7bf
Merge pull request #15302 from ClickHouse/tavplubix-patch-2
Fix ASTColumnsReplaceTransformer::Replacement::clone()
2020-09-26 19:10:00 +03:00
Denis Zhuravlev
06f3991b74 added test for queries results 2020-09-26 12:25:47 -03:00
Denis Zhuravlev
44846da2b1 added test for queries results 2020-09-26 12:21:48 -03:00
alesapin
3086fd88cd
Merge pull request #15307 from ClickHouse/test_integration_tests_flaky_check
Fix flaky integration test
2020-09-26 17:08:23 +03:00
alesapin
d1bb6b6555
Update test.py 2020-09-26 11:47:26 +03:00
alesapin
59f2bbe2a3
Merge pull request #15304 from ClickHouse/fix_race_condition_on_rename
Fix race condition between write ahead log cleanup and rename
2020-09-26 10:43:26 +03:00
alesapin
adf8c94d70
Merge pull request #15300 from ClickHouse/fix_race_on_default_database
Fix for default database race on server startup
2020-09-26 10:43:17 +03:00
Alexey Milovidov
da8a938069 Replace unit test to functional test 2020-09-26 09:50:34 +03:00
alexey-milovidov
fc1cf426dd
Merge pull request #15048 from markpapadakis/patch-5
Update ForkProcessor.cpp
2020-09-26 07:35:31 +03:00
alexey-milovidov
9e4c48ad81
Merge pull request #15184 from ycd/master
Added Comprehension to Improve Performance
2020-09-26 07:34:26 +03:00
alexey-milovidov
d1fce06292
Merge pull request #15297 from hexiaoting/build_bugfix
fix build bug for merge_selector2.cpp
2020-09-26 07:32:33 +03:00
alexey-milovidov
adb83d920a
Merge pull request #15267 from ClickHouse/clickhouse-test-fail-early
Fail more quickly in clickhouse-test if server does not respond
2020-09-26 07:28:34 +03:00
Alexey Milovidov
57b480e65d Fix PVS warning 2020-09-26 07:03:55 +03:00
Denis Zhuravlev
6fade0f363 stabilize merges 2020-09-26 00:47:54 -03:00
Alexey Milovidov
5e146eda04 Fix error 2020-09-26 06:02:05 +03:00
Alexey Milovidov
11ab250a71 More test cases 2020-09-26 05:18:18 +03:00
Alexey Milovidov
f3349c8d13 Keywords are case-insensitive 2020-09-26 05:13:20 +03:00
Alexey Milovidov
c51502bce4 Remove words with dashes 2020-09-26 05:06:14 +03:00