Commit Graph

10659 Commits

Author SHA1 Message Date
pufit
2f46ae850e
Merge branch 'master' into pufit/role-from-storage 2023-08-07 17:57:41 -04:00
robot-ch-test-poll
066dd8a2e8
Merge pull request #52949 from CurtizJ/fix-nested-array-lowcardinality
Fix reading of empty `Nested(Array(LowCardinality(...)))`
2023-08-07 23:32:25 +02:00
Sema Checherinda
796f874116
metrics_perf_events_enabled turn off in perf tests (#52072)
* metrics_perf_events_enabled turn off in perf tests

* turn on metrics_perf_events_enabled for heating and profile requests

* close_perf_descriptors fix the condition

* do not read opend but disabled perf event

* Revert "do not read opend but disabled perf event"

This reverts commit eeab1c9c63.
2023-08-07 23:25:16 +02:00
Nikolai Kochetov
30075d3bc2
Merge branch 'master' into revert-44629-revert_flamegraph 2023-08-07 19:31:20 +02:00
Alexey Milovidov
06f557a62b Merge branch 'master' of github.com:ClickHouse/ClickHouse into allow-creating-system-tables-at-startup 2023-08-07 18:58:18 +02:00
Duc Canh Le
cd02980130
Merge branch 'master' into ch_fix_direct_hash_join 2023-08-07 22:20:29 +08:00
Kseniia Sumarokova
55864b51a4
Merge pull request #53055 from kssenii/fix-rare-race-on-key-prefix-directory-cleanup
Fix rare race condition with empty key prefix directory deletion in fs cache
2023-08-07 15:38:46 +02:00
Raúl Marín
d37283e9fb Fix query_id in part_log with async flush queries 2023-08-07 10:46:55 +02:00
Duc Canh Le
ed2a1d7c9b select required columns when getting join 2023-08-07 03:15:20 +00:00
Alexey Milovidov
74a4c9755c Don not produce warning if a system table was created on startup 2023-08-07 02:26:23 +02:00
Alexey Gerasimchuck
da0c013b16
Merge branch 'master' into ADQM-1011 2023-08-07 07:44:57 +10:00
Alexey Milovidov
7886e06217
Merge pull request #46051 from ucasfl/count-distinct-if
Continue of #42008, rewrite countDistinctIf with count_distinct_implementation
2023-08-06 19:31:44 +03:00
Alexey Milovidov
93a10980e9 Fix review comments 2023-08-06 16:27:45 +02:00
Alexey Milovidov
ce2fcc8f33 Fix wording 2023-08-06 14:48:20 +02:00
Alexey Milovidov
3e599acdb1 Fix lock order inversion 2023-08-06 04:44:07 +02:00
Alexey Milovidov
06d45cfa81 Allow creating system logs at startup 2023-08-06 01:29:31 +02:00
Alexey Milovidov
7e90df67a7 Remove whitespaces 2023-08-06 00:58:26 +02:00
Alexey Milovidov
afb1a55bf3 Remove whitespaces 2023-08-06 00:56:33 +02:00
Alexey Gerasimchuck
c2f94101e9
Merge branch 'master' into ADQM-1011 2023-08-05 20:35:45 +10:00
Ilya Yatsishin
390c97cdae
Merge pull request #52320 from ClickHouse/create-index-unique-noop 2023-08-05 10:45:06 +02:00
robot-ch-test-poll4
ce36a3cba0
Merge pull request #51537 from ClickHouse/vdimir/tmp_storage_cache_msg
Add info about acquired space in cache to not enough space error
2023-08-05 07:26:28 +02:00
Alexey Milovidov
447987deea
Merge branch 'master' into revert-revert-of-db-filesystem-fix 2023-08-05 03:07:44 +03:00
Kseniia Sumarokova
166ac7a8be
Merge pull request #53047 from kssenii/fix-logical-error-in-cache
Fix cache related logical error in stress tests
2023-08-04 22:27:55 +02:00
Alexey Milovidov
7f4ce7697b
Merge branch 'master' into vdimir/tmp_storage_cache_msg 2023-08-04 23:11:28 +03:00
Alexey Milovidov
6f88fc282b
Merge branch 'master' into count-distinct-if 2023-08-04 19:04:36 +03:00
Ilya Yatsishin
0f63a90206
Merge branch 'master' into create-index-unique-noop 2023-08-04 17:53:57 +02:00
kssenii
53d9de0997 Fix rare race condition with key prefix directory cleanup 2023-08-04 16:34:05 +02:00
Alexey Milovidov
b31358933b
Merge pull request #52954 from ClickHouse/fix-error-code
Fix wrong error code "BAD_GET"
2023-08-04 16:26:33 +03:00
kssenii
12ed37e99a Fix 2023-08-04 13:08:01 +02:00
Duc Canh Le
8aaa46ca90 StorageJoin: do not create clone hash join with all columns 2023-08-04 11:07:33 +00:00
kssenii
4b8b78f220 Revert "Merge pull request #53044 from ClickHouse/revert-52155-database-filesystem-remove-catch"
This reverts commit e71f20891f, reversing
changes made to aa9ab58994.
2023-08-04 12:41:55 +02:00
Alexander Tokmakov
0b312f541a
Revert "Remove try/catch from DatabaseFilesystem" 2023-08-04 13:29:28 +03:00
vdimir
8050edaff6
style convertFieldToTypeStrict 2023-08-04 09:45:13 +00:00
vdimir
079c6783a2
Update decimal_in tests for analyzer 2023-08-04 09:45:12 +00:00
vdimir
0032eb9ab7
Fix IN with decimal in analyzer 2023-08-04 09:45:08 +00:00
Vitaly Baranov
587877dba3
Merge branch 'master' into disable-fs-cache-for-backups 2023-08-04 01:15:23 +02:00
Vitaly Baranov
0af043459a
Merge pull request #52660 from vitlibar/remove-unnecessary-temp-context-access
Remove creation of a unnecessary temporary ContextAccess on login
2023-08-04 01:08:12 +02:00
Alexey Gerasimchuck
1e7daca85b Added new tests for session_log plus bugfix 2023-08-03 22:06:33 +00:00
Alexey Milovidov
95f5d2f37f
Merge pull request #52155 from ClickHouse/database-filesystem-remove-catch
Remove try/catch from DatabaseFilesystem
2023-08-03 23:02:01 +03:00
Alexander Tokmakov
968c79cf3f
Merge pull request #52956 from ClickHouse/fixes_for_databases
Fix some issues with databases
2023-08-03 19:13:41 +03:00
Maksim Kita
a0fa3cc73b EXPLAIN actions for JOIN step 2023-08-03 18:55:15 +03:00
Anton Popov
92cb5e9ae3
Merge pull request #52687 from alkorgun/fix-named-collections-on-cluster-23.7
Fix named collections on cluster 23.7
2023-08-03 14:50:28 +02:00
Alexey Milovidov
29d386fec2
Merge branch 'master' into count-distinct-if 2023-08-03 15:36:11 +03:00
Alexey Milovidov
56660f44b1
Merge branch 'master' into database-filesystem-remove-catch 2023-08-03 15:08:07 +03:00
Vitaly Baranov
f427c779eb Disable using fs cache for backup/restore. 2023-08-03 13:52:32 +02:00
Igor Nikonov
4155b0adfd
Merge pull request #52768 from ClickHouse/fix-window-func-range-check
Fix: check correctly window frame bounds for RANGE
2023-08-03 13:48:55 +02:00
Alexey Milovidov
d417061886 Merge branch 'master' into fix-error-code 2023-08-03 13:48:23 +02:00
Vitaly Baranov
7a112459d3 Implement passing current roles to Context::setUser(). 2023-08-03 13:45:01 +02:00
Vitaly Baranov
16dfb028b6 Remove creation of a unnecessary temporary ContextAccess on login. 2023-08-03 13:44:59 +02:00
Alexander Tokmakov
7684e68008
Add system stop pulling replication log (#52881)
* add system stop pulling replication log

* add const

* fix another stupid test

* Update test.py
2023-08-03 13:34:43 +03:00
vdimir
9cdd4fe41a
Add info about aquired space in cache to not enough space error 2023-08-03 10:32:44 +00:00
Kseniia Sumarokova
621d852289
Merge pull request #52778 from kssenii/revert-revert-drop-cache
Revert revert of system drop filesystem cache by key
2023-08-03 10:55:25 +02:00
Alexander Tokmakov
c4fb0a0cd5 fix two minor issue 2023-08-02 23:36:54 +02:00
Alexey Milovidov
dbf14b5e2d Fix wrong error code "BAD_GET" 2023-08-02 23:16:06 +02:00
Alexey Milovidov
e101f2011b
Merge branch 'master' into count-distinct-if 2023-08-03 00:09:52 +03:00
Igor Nikonov
44b9ed438f
Merge branch 'master' into fix-window-func-range-check 2023-08-02 19:24:55 +02:00
Anton Popov
d43e76b147 fix reading of empty Nested(Array(LowCardinality(...))) 2023-08-02 16:48:08 +00:00
Alexey Milovidov
b17e93e78c Merge branch 'master' into database-filesystem-remove-catch 2023-08-02 17:13:12 +02:00
Nikita Taranov
2cbe79b529
Fix memory consumption when max_block_size is huge in Aggregator + more memory checks (#51566)
* impl

* remove checks from without_key methods

* maybe will improve smth

* add test

* Update 02797_aggregator_huge_mem_usage_bug.sql

* Update 02797_aggregator_huge_mem_usage_bug.sql

---------

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
2023-08-02 15:11:52 +02:00
Alexander Tokmakov
61977479be
Update SystemLog.cpp (#52858) 2023-08-02 15:18:57 +03:00
Mike Kot
1335d06b8f
Do not replicate ALTER TABLE t FREEZE on Replicated engine (#52064)
* fix

* do not replicate alter freeze

* fix

---------

Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-08-02 14:39:54 +03:00
Kseniia Sumarokova
eabca22909
Merge branch 'master' into revert-revert-drop-cache 2023-08-01 23:19:38 +02:00
Alexey Milovidov
7954b732fd
Merge branch 'master' into database-filesystem-remove-catch 2023-08-01 20:52:26 +03:00
Nikolai Kochetov
fa06056fa2 Merge branch 'master' into revert-44629-revert_flamegraph 2023-08-01 17:14:16 +00:00
Kseniia Sumarokova
dbc11b83fd
Merge branch 'master' into kssenii-patch-6 2023-08-01 18:40:20 +02:00
Vitaly Baranov
65bd8f5e81
Merge branch 'master' into backups-fix-tmp-files 2023-08-01 16:37:06 +02:00
alesapin
0ee9797fb8
Merge pull request #51141 from ClickHouse/azure_blob_storage_sas_token
Azure blob storage sas token
2023-08-01 12:27:17 +02:00
Kseniia Sumarokova
16851040df
Fix annoying test 2023-08-01 11:21:46 +02:00
Alexey Milovidov
8ce1b87cda Merge branch 'master' of github.com:ClickHouse/ClickHouse into database-filesystem-remove-catch 2023-08-01 07:30:57 +02:00
Igor Nikonov
81c08199a8
Merge branch 'master' into fix-window-func-range-check 2023-07-31 19:45:25 +02:00
Alexander Tokmakov
7359a8108b
Merge pull request #51724 from arenadata/ADQM-939
Added max_sessions_for_user setting
2023-07-31 15:38:58 +03:00
Alexander Tokmakov
01f05e14eb
Merge pull request #50424 from tonickkozlov/tonickkozlov/zk-session-lifetime
Introduce fallback ZooKeeper sessions
2023-07-31 15:14:44 +03:00
flynn
c23893d7c1
Merge branch 'master' into count-distinct-if 2023-07-31 18:53:06 +08:00
kssenii
d136f18c30 Fix 2023-07-31 12:17:30 +02:00
Igor Nikonov
1868497534 Merge remote-tracking branch 'origin/master' into fix-window-func-range-check 2023-07-31 08:50:48 +00:00
Alexey Gerasimchuck
2c07607f25
Merge branch 'master' into ADQM-939 2023-07-31 13:43:45 +10:00
Igor Nikonov
3d7257cc7e Allow Floats as boundaries for RANGE is nonsense 2023-07-30 23:19:54 +00:00
Igor Nikonov
bdf47428f2 Merge remote-tracking branch 'origin/master' into fix-window-func-range-check 2023-07-30 22:40:58 +00:00
Igor Nikonov
6d971bc3a8 Specific check for NaN in window functions with RANGE 2023-07-30 22:35:19 +00:00
Alexey Gerasimchuck
e58b3cfd32 Implemented max sessions for user 2023-07-30 22:09:03 +00:00
alesapin
aba291ca68
Revert "Revert "Add an ability to specify allocations size for sampling memory profiler"" 2023-07-30 14:01:34 +02:00
kssenii
0cf93e7114 Reduce redundant logging 2023-07-30 13:51:10 +02:00
kssenii
20b76010ef Merge remote-tracking branch 'upstream/master' into kssenii-patch-6 2023-07-30 13:46:58 +02:00
kssenii
38f12f0664 Revert some commenting 2023-07-30 13:46:40 +02:00
kssenii
6ae6268ad0 Revert "Merge pull request #51917 from ClickHouse/revert-system-drop-filesystem-cache-by-key"
This reverts commit 520195f7ef, reversing
changes made to e36a638014.
2023-07-30 13:39:54 +02:00
Alexey Milovidov
91e67c105f
Merge pull request #52569 from ClickHouse/Realize_parameterized_view_as_new_storage_view
Realize parameterized view as new view with parameters substitued
2023-07-30 05:46:51 +03:00
Alexey Milovidov
a336f06f57
Update Context.cpp 2023-07-30 05:46:05 +03:00
Igor Nikonov
918571a5ee Fix: check correctly frame bounds for RANGE 2023-07-29 22:04:21 +00:00
pufit
6211845ef0
Merge pull request #51303 from ClickHouse/deprecate-metadata-cache
Deprecate the `metadata_cache` feature
2023-07-28 10:31:02 -04:00
Alexander Tokmakov
39200606ec
Merge pull request #52174 from arenadata/ADQM-988
Added possibility to save logs on crash and options to configure logs buffer
2023-07-28 16:55:00 +03:00
Anton Kozlov
5dfc30528d Introduce fallback ZooKeeper sessions 2023-07-28 11:43:27 +00:00
robot-clickhouse
bba9a2cd28
Merge pull request #51961 from nickitat/exec_udf_allow_parameters
Don't throw exception when exec udf has parameters
2023-07-28 11:52:17 +02:00
Alexey Gerasimchuck
63b05da1f2 System logs improvements 2023-07-28 07:23:34 +00:00
flynn
6de5127c0d fix conflict 2023-07-28 07:11:52 +00:00
pufit
9dbb106dc1 Fix tests, docs 2023-07-27 23:37:09 -04:00
Al Korgun
ebbd662071
Merge branch 'ClickHouse:master' into fix-named-collections-on-cluster-23.7 2023-07-27 23:31:35 +03:00
Azat Khuzhin
d40dbdee62 Fix usage of temporary directories during RESTORE
Previously during RESTORE you may get the following warning in logs:

    <Warning> TemporaryFileOnDisk: Temporary path 'tmp/21672kaaaaa' does not exist in './disks/s3_common_disk/'

The reason is that it uses not disks/s3_common_disk/tmp but instead
disks/s3_common_disk/disks/s3_common_disk/tmp path.

Fix this by adding TemporaryFileOnDisk::getRelativePath() and use it
when appropriate.

And now - `find disks`, does not shows any more temporary leftovers.

v2: rename getPath to getAbsolutePath
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-27 19:24:54 +02:00
Robert Schulze
c2ee774350
Add query cache metrics to system.asynchronous_metrics
Cf. https://github.com/ClickHouse/ClickHouse/pull/52384#issuecomment-1653241216
2023-07-27 15:19:01 +00:00
Robert Schulze
d48b1cadb0
Merge pull request #52384 from rschu1ze/query_cache_usage_in_query_log
Include query cache usage in SYSTEM.QUERY_LOG
2023-07-27 17:16:54 +02:00
Jiebin Sun
78f3a575f9
Convert hashSets in parallel before merge (#50748)
* Convert hashSets in parallel before merge

Before merge, if one of the lhs and rhs is singleLevelSet and the other is twoLevelSet,
then the SingleLevelSet will call convertToTwoLevel(). The convert process is not in parallel
and it will cost lots of cycle if it cosume all the singleLevelSet.

The idea of the patch is to convert all the singleLevelSets to twoLevelSets in parallel if
the hashsets are not all singleLevel or not all twoLevel.

I have tested the patch on Intel 2 x 112 vCPUs SPR server with clickbench and latest upstream
ClickHouse.
Q5 has got a big 264% performance improvement and 24 queries have got at least 5% performance
gain. The overall geomean of 43 queries has gained 7.4% more than the base code.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* add resize() for the data_vec in parallelizeMergePrepare()

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* Add the performance test prepare_hash_before_merge.xml

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* Fit the CI to rename the data set from hits_v1 to test.hits.

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

* remove the redundant branch in UniqExactSet

Co-authored-by: Nikita Taranov <nickita.taranov@gmail.com>

* Remove the empty methods and add throw exception in parallelizeMergePrepare()

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>

---------

Signed-off-by: Jiebin Sun <jiebin.sun@intel.com>
Co-authored-by: Nikita Taranov <nickita.taranov@gmail.com>
2023-07-27 15:06:34 +02:00