Commit Graph

107141 Commits

Author SHA1 Message Date
Alexey Milovidov
d66beb9ac4 Allow accurate comparison of Big Int with other integers 2023-02-08 07:56:00 +01:00
Alexey Milovidov
8e407899ef
Merge pull request #46149 from ClickHouse/fix-flaky-test-11
Remove flaky test
2023-02-08 09:30:43 +03:00
Alexey Milovidov
8d4a98113c
Merge pull request #46120 from azat/copier-fixes
Fix fault injection in copier and test_cluster_copier flakiness
2023-02-08 08:59:17 +03:00
Alexey Milovidov
a69f9c05a9 Remove flaky test 2023-02-08 05:35:19 +01:00
Alexey Milovidov
a2df6e950e Whitespace 2023-02-08 03:38:23 +01:00
Alexey Milovidov
a67eac20fb
Merge pull request #46090 from azat/clickhouse-test-logs
Add also last messages from stdout/stderr/debuglog in clickhouse-test
2023-02-08 05:28:43 +03:00
Alexey Milovidov
66e9dd3c94
Update README.md 2023-02-08 04:53:47 +03:00
Alexey Milovidov
da22a770a0
Merge pull request #46107 from kssenii/rabbit-test-overloaded-insert-fix
Fix flaky rabbitmq test
2023-02-08 04:14:03 +03:00
Alexey Milovidov
b10bc50c6a
Merge pull request #46137 from ClickHouse/tylerhannan-patch-1
Adding FOSDEM
2023-02-08 01:31:21 +03:00
Alexey Milovidov
d6af40a4b4
Merge pull request #46135 from DanRoscigno/add-mermaid
Use mermaid chart in dev architecture doc
2023-02-08 01:30:50 +03:00
Kseniia Sumarokova
a5d3b00699
Merge pull request #46010 from kssenii/named-collections-fix-access
Fix named collections access
2023-02-07 23:20:22 +01:00
Tyler Hannan
a60a3726e8
Adding FOSDEM 2023-02-07 23:06:32 +01:00
DanRoscigno
fe5bc01951 merged Mermaid support today 2023-02-07 14:43:36 -05:00
Nikolai Kochetov
3912f5a333
Merge pull request #45681 from CurtizJ/compact-parts-vertical-merge
Allow vertical merges from compact to wide parts
2023-02-07 17:09:17 +01:00
Azat Khuzhin
ff324fe81a Fix fault injection in copier (wrong query syntax)
There are very frequent flakiness of `test_cluster_copier` test, here is
an example of copier failures on CI [1]:

    AssertionError: Instance: s0_1_0 (172.16.29.9). Info: {'ID': '5d68dcb46fdb4b0c54b7c7ba1ddde83b8f34d483bbb32abcb0c52b966444ce82', 'Running': False, 'ExitCode': 85, 'ProcessConfig': {'tty': False, 'entrypoint': '/usr/bin/clickhouse', 'arguments': ['copier', '--config', '/etc/clickhouse-server/config-copier.xml', '--task-path', '/clickhouse-copier/task_simple_4DFWYTDD49', '--task-file', '/task0_description.xml', '--task-upload-force', 'true', '--base-dir', '/var/log/clickhouse-server/copier', '--copy-fault-probability', '0.2', '--experimental-use-sample-offset', '1'], 'privileged': False, 'user': '0'}, 'OpenStdin': False, 'OpenStderr': True, 'OpenStdout': True, 'CanRemove': False, 'ContainerID': 'f356df6694b3cc09ee9830c623681626f8e8d999677c188b9fe911aa702784ca', 'DetachKeys': '', 'Pid': 84332}
    assert 85 == 0

But let's look what the error it is, apparently it is UNFINISHED:

    SELECT
        name,
        code
    FROM system.errors
    WHERE ((code % 256) = 85) AND (NOT remote)
    SETTINGS system_events_show_zero_values = 1

    ┌─name─────────────────────────────┬─code─┐
    │ FORMAT_IS_NOT_SUITABLE_FOR_INPUT │   85 │
    │ UNFINISHED                       │  341 │
    │ NO_SUCH_ERROR_CODE               │  597 │
    └──────────────────────────────────┴──────┘

Let's verify:

    $ grep -r UNFINISHED ./test_cluster_copier/_instances_0/s0_1_0/logs/copier/clickhouse-copier_*
    ./test_cluster_copier/_instances_0/s0_1_0/logs/copier/clickhouse-copier_20230206220846_368/log.log:2023.02.06 22:09:19.015251 [ 368 ] {} <Error> : virtual int DB::ClusterCopierApp::main(const std::vector<std::string> &): Code: 341. DB::Exception: Too many tries to process table cluster1.default.hits. Abort remaining execution. (UNFINISHED), Stack trace (when copying this message, always include the lines below):

And apparently that it is due to query error with fault injection:

    2023.02.06 22:09:15.654724 [ 368 ] {} <Error> Application: An error occurred while processing partition 0: Code: 62. DB::Exception: Syntax error (Query): failed at position 168 ('Native'): Native. Expected one of: token, Dot, OR, AND, BETWEEN, NOT BETWEEN, LIKE, ILIKE, NOT LIKE, NOT ILIKE, IN, NOT IN, GLOBAL IN, GLOBAL NOT IN, MOD, DIV, IS NULL, IS NOT NULL, alias, AS, Comma, OFFSET, WITH TIES, BY, LIMIT, SETTINGS, UNION, EXCEPT, INTERSECT, INTO OUTFILE, FORMAT, end of query. (SYNTAX_ERROR), Stack trace (when copying this message, always include the lines below):

Example:

    select x from x limit  1FORMAT Native

    Syntax error: failed at position 32 ('Native'):

So fixing this should fix test_cluster_copier flakiness.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/46045/bd4170e03c6af583a51d12d2c39fa775dcb9997b/integration_tests__release__[4/4].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 17:01:06 +01:00
Azat Khuzhin
18d2a99761 Use comments for variables that clang can parse
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 16:53:45 +01:00
Zhiguo Zhou
b43ffb98e8
Vectorize filter generation of ColumnNullable in FilterDescription (#45962)
This commit achieved the data parallelism for filter generations of
the nullable columns by replacing the logical AND operator with the
bitwise one, which could be auto-vectorized by the compiler.
2023-02-07 16:33:01 +01:00
Sema Checherinda
52d4e78b7f
Merge pull request #45907 from CheSema/forbid-wal-on-s3
do not run wal on remote disks
2023-02-07 14:48:00 +01:00
Yakov Olkhovskiy
4e7dffafe4
Merge pull request #46087 from ClickHouse/fix-ip-bloom
Allow bloom filter for IPv4 and IPv6
2023-02-07 08:29:28 -05:00
Yakov Olkhovskiy
909a772701
Merge pull request #45375 from ClibMouse/window_view_fix
Window view functional test failed on platform s390x
2023-02-07 08:23:50 -05:00
Han Fei
021e6e90cc
Merge pull request #45631 from hanfei1991/hanfei/regexp-refine
RegExpTreeDict use re2 engines when processing heavy regexps
2023-02-07 13:21:22 +01:00
kssenii
022d4308ce Address review comments 2023-02-07 13:01:55 +01:00
kssenii
427f2d0257 Try fix rabbit test 2023-02-07 12:36:25 +01:00
Robert Schulze
690d873126
Merge pull request #46088 from ClickHouse/rs/fix-liburing-build
Fix build with `-DENABLE_LIBURING=0` (or `-DENABLE_LIBRARIES=0`)
2023-02-07 12:16:14 +01:00
Sergei Trifonov
950c04cb0e
Merge pull request #44907 from azat/dist/async-INSERT-error-message-fix
Fix error message for a broken distributed batches ("While sending batch")
2023-02-07 12:14:52 +01:00
Vitaly Baranov
f021c0eab6
Merge pull request #46058 from vitlibar/remove-unnecessary-execute-for-const-expr
Remove unnecessary execute() while evaluating a constant expression.
2023-02-07 12:09:37 +01:00
Robert Schulze
f9b6c10700
Merge pull request #46072 from ClickHouse/rs/follow-up-to-46057
Smallish follow-up to #46057
2023-02-07 11:52:51 +01:00
Kseniia Sumarokova
e6e482201c
Merge pull request #46078 from ClickHouse/kssenii-patch-6
Disable temporarily rabbitmq tests which use channel.startConsuming()
2023-02-07 11:17:27 +01:00
Vitaly Baranov
1fc82fbeec Fix test 01114_database_atomic (more rows to fit to execution time expected in test). 2023-02-07 02:31:58 +01:00
Vitaly Baranov
bc63042723 Fix test "00626_in_syntax" (elements of set after IN must be const). 2023-02-07 02:31:58 +01:00
Vitaly Baranov
d27a83ee21 Fix error code in test "01934_constexpr_aggregate_function_parameters" (parameter of groupArray must be const). 2023-02-07 02:31:58 +01:00
Vitaly Baranov
db500b856f Fix test "01834_alias_columns_laziness_filimonov" (no more sleeping in ExpressionAnalyzer). 2023-02-07 02:31:58 +01:00
Anton Popov
7dfea59267 remove an assertion 2023-02-07 00:50:41 +00:00
Alexander Tokmakov
bd68612f10
Merge pull request #46077 from ClickHouse/fix_test_00002
Fix 00002_log_and_exception_messages_formatting
2023-02-07 03:27:07 +03:00
Alexander Tokmakov
13da43ead8
Merge branch 'master' into fix_test_00002 2023-02-07 03:25:42 +03:00
Anton Popov
3ad5a085da
Merge pull request #45987 from CurtizJ/fix-sparse-columns-crash
Fix `INTERSECT` and `EXCEPT` with sparse columns
2023-02-06 23:01:02 +01:00
Alexey Milovidov
6a389eef32
Add a comment 2023-02-06 22:27:46 +03:00
Azat Khuzhin
ad3b4da488 Add also last messages from stdout/stderr/debuglog in clickhouse-test
First lines not very helpful usually, since the problem usually happens
at the end [1], though some tricky stuff may happens at the beginning,
so let's output both.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/1716af465d376f5335720b5045bcccdd9e1823aa/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 19:47:44 +01:00
Rich Raposa
07545d7386
Merge pull request #46048 from ClickHouse/add-executable-engine
Add docs for Executable and ExecutablePool table engines
2023-02-06 12:36:57 -06:00
rfraposa
f3136e3f25 Resolve feedback 2023-02-06 10:48:54 -07:00
Han Fei
d1d893275a fix 2023-02-06 18:46:23 +01:00
Robert Schulze
8840aa9242
Fix build with -DENABLE_LIBURING=0 (or -DENABLE_LIBRARIES=0)
Follow-up to #38456

The problem was that code which uses liburing was conditionally build
depending on define OS_LINUX and not based on whether liburing was
enabled/disabled at build time.
2023-02-06 16:57:42 +00:00
Yakov Olkhovskiy
e433c26cf9 allow bloom filter for IPv4 and IPv6 2023-02-06 16:30:18 +00:00
Han Fei
eb76041312 address comments and add one more test 2023-02-06 17:26:20 +01:00
Alexander Tokmakov
af655eb7dc
Merge pull request #45889 from CheSema/release-merge-blocker-drop-part
do not block merges when old parts are droping in drop queries
2023-02-06 19:09:09 +03:00
Anton Popov
bb78daaa68
Merge pull request #46025 from CurtizJ/fix-memory-leak-azure
Fix memory leak at creation of curl connection in azure sdk
2023-02-06 16:22:39 +01:00
Anton Popov
3850a1969d
Merge branch 'master' into fix-memory-leak-azure 2023-02-06 16:21:56 +01:00
Suzy Wang
6edbffa3cc
Merge branch 'master' into window_view_fix 2023-02-06 10:06:04 -05:00
Mikhail f. Shiryaev
c1655052e2
Merge pull request #46079 from ClickHouse/update-yarn-docs
Update yarn packages for dev branches
2023-02-06 15:44:07 +01:00
alesapin
e999f66234
Merge pull request #46040 from azat/backup-fix-race
Fix data race in BACKUP
2023-02-06 15:20:44 +01:00