Azat Khuzhin
d99fb4ce5b
tests: rewrite test for MergeTree engines in s3_plain using ATTACH
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
aafc149c1e
Prohibit CREATE on static storages (ATTACH should be used instead)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
1ee723d50d
Prohibit DROP from static storages
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
046a7a5df5
tests: cover DROP TABLE on s3_plain disk
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
d79c1f7e1c
Fix MetadataStorageFromPlainObjectStorage::iterateDirectory() (add prefix)
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
9ce18bbf43
Implement MetadataStorageFromPlainObjectStorageTransaction::removeDirectory (for DROP TABLE)
...
This is required to remove format_version.txt for MergeTree after DROP
(lldb) bt
* thread 192, name = 'BgSchPool', stop reason = breakpoint 1.1
frame 0: 0x0000000016c7f452 clickhouse`__cxa_throw(thrown_object=0x00007ffd7a53c480, tinfo=0x00000000011602a0, dest=(clickhouse`DB::Exception::~Exception() at Exception.h:40)) + 18 at cxa_exception.cpp:258
frame 1: 0x00000000109bf709 clickhouse`DB::IMetadataTransaction::throwNotImplemented() + 137 at IMetadataStorage.h:151
frame 2: 0x00000000109bf126 clickhouse`DB::IMetadataTransaction::removeDirectory(this=<unavailable>, (null)=<unavailable>) + 6 at IMetadataStorage.h:96
frame 3: 0x0000000010968978 clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="tmp_insert_all_2_2_0") + 376 at DiskObjectStorageTransaction.cpp:364
frame 4: 0x000000001096893d clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::removeMetadataRecursive(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1, path_to_remove="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/") + 317 at DiskObjectStorageTransaction.cpp:362
frame 5: 0x0000000010965a7f clickhouse`DB::(anonymous namespace)::RemoveRecursiveObjectStorageOperation::execute(this=0x00007ffd7a7327a0, tx=std::__1::shared_ptr<DB::IMetadataTransaction>::element_type @ 0x00007ffd7a6f6018 strong=4 weak=1) + 95 at DiskObjectStorageTransaction.cpp:372
frame 6: 0x0000000010963a2f clickhouse`DB::DiskObjectStorageTransaction::commit(this=0x00007ffea22b6168) + 79 at DiskObjectStorageTransaction.cpp:903
frame 7: 0x00000000109577e5 clickhouse`DB::DiskObjectStorage::removeSharedRecursive(this=<unavailable>, path="store/27f/27f6f9d2-ab2e-4817-b771-0e706e485b15/", keep_all_batch_data=false, file_names_remove_metadata_only=size=0) + 133 at DiskObjectStorage.cpp:426
frame 8: 0x000000001095af79 clickhouse`DB::DiskObjectStorage::removeRecursive(this=<unavailable>, path=<unavailable>) + 57 at DiskObjectStorage.h:79
* frame 9: 0x0000000010b5c3d5 clickhouse`DB::DatabaseCatalog::dropTableFinally(this=0x00007ffff7096800, table=0x00007ffe853e1bd0) + 1365 at DatabaseCatalog.cpp:1317
frame 10: 0x0000000010b5b7e7 clickhouse`DB::DatabaseCatalog::dropTableDataTask(this=0x00007ffff7096800) + 2375 at DatabaseCatalog.cpp:1270
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
f3b4f28f0d
Disable mutable operations into {Replicated,}MergeTree with static storage
...
Mutable operations includes:
- INSERT
- OPTIMIZE
- parts manipulation
- ...
But does not include DROP, since you need an ability to DROP it.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
41ebaefeda
Add a note for MetadataStorageFromPlainObjectStorage to support transactions
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
6751e01cc3
Do not drop parts for static (ro/write-once) storages for Replicated engine
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Azat Khuzhin
e56728ae6c
tests: add s3_plain disk
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 16:47:35 +01:00
Mikhail f. Shiryaev
4286634876
Merge pull request #59256 from azat/tests/fasttest
...
Fix fasttest by pinning pip dependencies
2024-01-26 16:00:32 +01:00
Azat Khuzhin
92d96c4d02
Fix fasttest by pinning pip dependencies
...
After image update it prints the following warning:
/ClickHouse/tests/queries/0_stateless/01558_ttest_scipy.python:5: DeprecationWarning:
Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0),
(to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries)
but was not found to be installed on your system.
If this would cause problems for you,
please provide us feedback at https://github.com/pandas-dev/pandas/issues/54466
Pyarrow can be added as well, but according to the comment in the issue
it bloats the image size 170%, so let's simply downgrade it for now and
see how that issue will be resolved (or the warning could be suppressed
of course).
And pin other dependencies as well to avoid further failures.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-26 15:08:22 +01:00
Nikolai Kochetov
75edbdd39c
Merge pull request #59147 from ClickHouse/vdimir/fix_agg_nothing_2
...
Fix AggregateFunctionNothing result type issues introducing it with different names
2024-01-26 14:33:38 +01:00
Yarik Briukhovetskyi
0cbadc9b52
Merge pull request #59190 from yariks5s/fix_to_string_nullable_timezone
...
Fix crash with nullable timezone for `toString`
2024-01-26 13:33:12 +01:00
Nikolai Kochetov
10d4f1fd87
Merge pull request #59228 from kitaisreal/actions-dag-build-filter-actions-refactoring
...
Actions dag build filter actions refactoring
2024-01-26 11:34:19 +01:00
Sergei Trifonov
4fb511bfb3
Merge pull request #59137 from ClickHouse/fix-async-loader-shutdown-deadlock
...
Fix not started database shutdown deadlock
2024-01-26 11:21:13 +01:00
Max K
94b599d126
Merge pull request #59252 from ClickHouse/ci_fix_nightly_job
...
CI: fix ci configuration for nightly job
2024-01-26 10:59:00 +01:00
Max Kainov
2b75836ad2
CI: fix ci configuration for nightly job
2024-01-26 09:33:04 +00:00
Vitaly Baranov
3fbdf48b53
Merge pull request #59244 from vitlibar/disable-copy-constructor-for-multi-version
...
Disable copy constructor for MultiVersion
2024-01-26 09:29:43 +01:00
pufit
92e63bf45c
Load server configs in clickhouse local ( #59231 )
...
Load server configs in clickhouse local
2024-01-25 23:13:31 -05:00
Vitaly Baranov
a7b1fe9fa2
Disable copy constructor for MultiVersion.
2024-01-25 23:53:54 +01:00
Alexey Milovidov
aedffeaab0
Merge pull request #58959 from Algunenano/fix_sum_map
...
Fix sumMapFiltered with NaN values
2024-01-25 23:50:28 +01:00
Sema Checherinda
a69a0aea0e
Merge pull request #59066 from ClickHouse/chesema-remove-flaky-test
...
remove flaky test
2024-01-25 21:39:46 +01:00
Nikita Taranov
368ef60c77
Merge pull request #59093 from ClickHouse/nickitat-patch-18
...
Add `[[nodiscard]]` to a couple of methods
2024-01-25 17:03:05 +01:00
Maksim Kita
5bb734a4bb
ActionsDAG buildFilterActionsDAG refactoring
2024-01-25 18:24:14 +03:00
Kseniia Sumarokova
70514e3d14
Merge pull request #57615 from ClickHouse/filecache-small-optimization
...
fs cache: small optimization
2024-01-25 15:50:09 +01:00
Yarik Briukhovetskyi
da1cf46b14
Fix fuzzer
2024-01-25 15:47:32 +01:00
Nikolai Kochetov
3fd6b4d1ac
Merge pull request #58831 from kitaisreal/table-create-drop-logger-memory-leak-fix
...
Table CREATE DROP Poco::Logger memory leak fix
2024-01-25 15:13:20 +01:00
yariks5s
1620c069b7
Merge branch 'fix_to_string_nullable_timezone' of github.com:yariks5s/ClickHouse into fix_to_string_nullable_timezone
2024-01-25 12:02:49 +00:00
yariks5s
c277148ee1
enhanced tests, fix
2024-01-25 12:01:51 +00:00
Maksim Kita
485a46f610
Fixed tests
2024-01-25 14:31:49 +03:00
Maksim Kita
109337e91e
Updated implementation
2024-01-25 14:31:49 +03:00
Maksim Kita
2a327107b6
Updated implementation
2024-01-25 14:31:49 +03:00
Maksim Kita
6f698b40ae
Poco update Logger to allow create shared LoggerPtr
2024-01-25 14:31:18 +03:00
Maksim Kita
bd8bbdaeb3
Poco update RefCountedObject with std::atomic
2024-01-25 14:31:18 +03:00
Maksim Kita
42029f42e7
Table CREATE DROP Poco::Logger memory leak fix
2024-01-25 14:31:18 +03:00
serxa
a40da92761
Merge branch 'master' into fix-async-loader-shutdown-deadlock
2024-01-25 11:31:05 +00:00
Robert Schulze
5ba7a78d23
Merge pull request #59108 from rschu1ze/slimmer-norm-distance-test
...
Further reduce runtime of `norm_distance.xml`
2024-01-25 12:16:54 +01:00
Kseniia Sumarokova
951c874aa9
Merge pull request #59080 from ClickHouse/data-lakes-survive-restart
...
Allow server to start with broken data lake table and fix itself lazily
2024-01-25 11:50:16 +01:00
Kseniia Sumarokova
b13be4fd55
Merge pull request #59175 from ClickHouse/filecache-minor
...
Move some headers
2024-01-25 11:33:57 +01:00
Antonio Andelic
0386830b98
Merge pull request #59145 from ClickHouse/capability-check-s3-plain
...
Capability check for `s3_plain`
2024-01-25 09:28:36 +01:00
Dmitry Novik
a2d7bcbd5f
Merge pull request #58958 from ClickHouse/analyzer-insert-block
...
Analyzer: fix storage replacement with insertion block
2024-01-25 09:25:50 +01:00
Igor Nikonov
7ae7086a2d
Merge pull request #59153 from ClickHouse/fix-pr-limit-by
...
Fix: LIMIT BY and LIMIT in distributed query
2024-01-25 01:51:52 +01:00
Yarik Briukhovetskyi
f71c38f71c
Merge branch 'ClickHouse:master' into fix_to_string_nullable_timezone
2024-01-25 00:12:16 +01:00
yariks5s
2a508bdd34
enhance tests
2024-01-24 22:42:20 +00:00
Mikhail f. Shiryaev
a66d409534
Merge pull request #59184 from ClickHouse/fix-lambda-for-hash-#-in-branch
...
Fix another place with special symbols in the URL
2024-01-24 22:24:26 +01:00
Nikita Taranov
1e3f6894a3
Merge pull request #59089 from nickitat/sort_res_ranges_before_sending_to_replica
...
Coordinator returns ranges for reading in sorted order
2024-01-24 21:04:53 +01:00
Mikhail f. Shiryaev
3d03c16fc8
Fix another place with special symbols in the URL
2024-01-24 21:02:22 +01:00
Nikita Taranov
fddfc7e9c4
Merge pull request #57700 from nickitat/debug_in_ci
...
Bring test back
2024-01-24 20:25:57 +01:00
Raúl Marín
a07eefe7c2
Merge pull request #59090 from Algunenano/02294_decimal_second_errors
...
Raise timeout in 02294_decimal_second_errors
2024-01-24 19:37:50 +01:00