Commit Graph

111612 Commits

Author SHA1 Message Date
Robert Schulze
e1d299640b
Small follow-up to #48017 2023-03-31 14:11:37 +00:00
Robert Schulze
5d64841276
Merge pull request #48017 from ClickHouse/rs/show_columns
MySQL compatibility: Implement `SHOW COLUMNS`
2023-03-31 15:50:23 +02:00
Rich Raposa
6eb692eacc
Merge pull request #48258 from den-crane/patch-61
Doc. Notes about file names in UDF examples, make them more clear.
2023-03-31 07:43:31 -06:00
Alexey Milovidov
3de29f5cc1
Merge pull request #48278 from azat/backups/fix-UB
Fix UB (signed integer overflow) in StorageMergeTree::backupData()
2023-03-31 16:35:10 +03:00
Anton Popov
12c7992d36
Merge pull request #48118 from CurtizJ/optimize-mapUpdate
Optimize function `mapUpdate`
2023-03-31 15:03:15 +02:00
Alexey Milovidov
070210a02f
Merge pull request #48271 from vchekan/master
In messages, put values into quotes
2023-03-31 15:35:19 +03:00
Alexey Milovidov
99194d0ff8
Merge pull request #48281 from ClickHouse/auto/v23.3.1.2823-lts
Update version_date.tsv and changelogs after v23.3.1.2823-lts
2023-03-31 15:34:17 +03:00
robot-clickhouse
0c9d7f73ce Update version_date.tsv and changelogs after v23.3.1.2823-lts 2023-03-31 10:35:58 +00:00
Alexey Milovidov
d06ab59737
Merge pull request #48279 from ClickHouse/23.4-prepare
Update version after release
2023-03-31 13:28:30 +03:00
Alexey Milovidov
dd79bf0a03 Update autogenerated version to 23.4.1.1 and contributors 2023-03-31 12:20:50 +02:00
Robert Schulze
9806a831c0
Small test refactoring 2023-03-31 09:41:59 +00:00
Alexander Tokmakov
c28ed094a4
Merge pull request #48277 from ClickHouse/revert-48196-jit-randomization
Revert "Randomize JIT settings in tests"
2023-03-31 12:33:04 +03:00
Azat Khuzhin
bac7def719 Fix UB (signed integer overflow) in StorageMergeTree::backupData()
UBsan report:

    /build/src/Storages/StorageMergeTree.cpp:2088:80: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long'
        0 0x30c2ae7b in DB::StorageMergeTree::backupData(DB::BackupEntriesCollector&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::optional<absl::lts_20211102::InlinedVector<std::__1::shared_ptr<DB::IAST>, 7ul, std::__1::allocator<std::__1::shared_ptr<DB::IAST>>>> const&) build_docker/./src/Storages/StorageMergeTree.cpp:2088:80
        1 0x2dd641b5 in DB::BackupEntriesCollector::makeBackupEntriesForTableData(DB::QualifiedTableName const&) build_docker/./src/Backups/BackupEntriesCollector.cpp:703:18
        2 0x2dd5c2a7 in DB::BackupEntriesCollector::makeBackupEntriesForTablesData() build_docker/./src/Backups/BackupEntriesCollector.cpp:676:9
        3 0x2dd5848d in DB::BackupEntriesCollector::run() build_docker/./src/Backups/BackupEntriesCollector.cpp:119:5
        4 0x2dd84da3 in DB::BackupsWorker::doBackup(std::__1::shared_ptr<DB::ASTBackupQuery> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, DB::BackupInfo const&, DB::BackupSettings, std::__1::shared_ptr<DB::IBackupCoordination>, std::__1::shared_ptr<DB::Context const> const&, std::__1::shared_ptr<DB::Context>, bool) build_docker/./src/Backups/BackupsWorker.cpp:359:59
        5 0x2dd82405 in DB::BackupsWorker::startMakingBackup(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const> const&) build_docker/./src/Backups/BackupsWorker.cpp:248:13
        6 0x2dd81d0a in DB::BackupsWorker::start(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context>) build_docker/./src/Backups/BackupsWorker.cpp:179:16
        7 0x2f4d0d5f in DB::InterpreterBackupQuery::execute() build_docker/./src/Interpreters/InterpreterBackupQuery.cpp:39:30

    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /build/src/Storages/StorageMergeTree.cpp:2088:80 in

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-31 12:29:31 +03:00
Alexander Tokmakov
792979a527
Revert "Randomize JIT settings in tests" 2023-03-31 12:24:47 +03:00
Robert Schulze
eb93ec35f5
Merge pull request #48154 from azat/varuint-v2
Add sanity checks for writing number in variable length format (resubmit)
2023-03-31 10:59:21 +02:00
Vadym Chekan
0f4c8144a6 In messages, put values into quotes
Configuration values, such as disk names, backup engine names, etc, may give error message unintended sense, for example, if trying to backup to `disk` instead of `Disk`, the error message will be "Not found backup engine disk", which can be interpreted as "disk of backup engine not found". It might be not clear that the word "disk" comes from the query and is not part of the error message.
2023-03-30 22:46:18 -07:00
Rich Raposa
8d9baceeb1
Merge branch 'master' into patch-61 2023-03-30 22:10:50 -06:00
Rich Raposa
1ef49eb5e4
Merge pull request #48265 from ClickHouse/youtube-fixes
Cleaned up the youtube dislikes dataset
2023-03-30 22:07:56 -06:00
Rich Raposa
d49e4afb60
Merge branch 'master' into youtube-fixes 2023-03-30 21:22:01 -06:00
Alexander Tokmakov
46e85357ce
Merge pull request #48244 from azat/fix-threadpools
Fix incorrect ThreadPool usage after ThreadPool introspection
2023-03-31 01:48:01 +03:00
Alexander Tokmakov
b7cbf83395
Merge branch 'master' into fix-threadpools 2023-03-31 01:47:23 +03:00
Alexander Tokmakov
8994305fb3
Merge pull request #48264 from ClickHouse/fix_test_numbers_again
fix test numbers again
2023-03-31 01:47:00 +03:00
Rich Raposa
348da6d19f
Merge branch 'master' into youtube-fixes 2023-03-30 16:43:13 -06:00
rfraposa
98833bcc82 Update youtube-dislikes.md 2023-03-30 16:41:29 -06:00
Alexander Tokmakov
b7f411443d fix test numbers again 2023-03-31 00:36:34 +02:00
Alexander Tokmakov
29e85bd9a4
Merge branch 'master' into fix-threadpools 2023-03-31 01:03:06 +03:00
Denny Crane
6507a86104
Merge branch 'master' into patch-61 2023-03-30 17:56:07 -03:00
Sergei Trifonov
01ed4ffca4
Merge pull request #47870 from ClickHouse/segmentator-fix
Fix CPU usage counters update logic
2023-03-30 22:55:58 +02:00
Kruglov Pavel
a3908b54c1
Merge pull request #48124 from Avogar/msgpack-more-types
Support more ClickHouse types in MsgPack format
2023-03-30 22:03:47 +02:00
Denny Crane
429975b345
Update index.md 2023-03-30 17:01:16 -03:00
Alexey Milovidov
5146dc0c53
Merge pull request #48199 from ClickHouse/qoega-patch-4
Update style in ParserKQLSort.cpp
2023-03-30 22:58:20 +03:00
Alexey Milovidov
614be6f718
Merge pull request #47387 from sippy/pg_select_from_only
Use "SELECT * FROM ONLY xyz", not "SELECT * FROM xyz" while replicating
2023-03-30 22:57:57 +03:00
Alexey Milovidov
e4fa53ae9b
Merge pull request #48170 from ClickHouse/more-stable-keeper-map-test
Try making KeeperMap test more stable
2023-03-30 22:57:08 +03:00
Alexey Milovidov
eb38616cc9
Merge pull request #48214 from ClickHouse/remove-wrong-assert
Remove wrong assert from LogicalExpressionOptimizerPass
2023-03-30 22:55:24 +03:00
Nikolai Kochetov
fae8d7a1ee
Merge pull request #48221 from ClickHouse/fix-aggregate-projection-analysis
Disable AST optimizations for projection analysis.
2023-03-30 21:31:58 +02:00
Alexander Gololobov
9a67a2f29a
Merge pull request #48196 from ClickHouse/jit-randomization
Randomize JIT settings in tests
2023-03-30 21:09:09 +02:00
Alexey Milovidov
6e3ced86e9
Merge pull request #48220 from ClickHouse/rs/caseinsensitive-str_to_date
MySQL compatibility: Make str_to_date alias case-insensitive
2023-03-30 22:08:01 +03:00
Alexey Milovidov
38738606e7
Merge pull request #48245 from DanRoscigno/march-changelog
edits for March 30th changelog
2023-03-30 22:06:47 +03:00
DanRoscigno
37213aa6b4 edits 2023-03-30 14:45:01 -04:00
Mikhail f. Shiryaev
e8eb052467
Merge pull request #48236 from ClickHouse/clickhouse-keeper-images-suffixless
Push clickhouse-keeper as both w/ and w/o suffix `-alpine`
2023-03-30 20:10:14 +02:00
Azat Khuzhin
edeeac84cf Fix incorrect ThreadPool usage after ThreadPool introspection
```
$ gg 'ThreadPool[^()]([A-Za-z_]\+,' src/
src/Interpreters/Context.cpp:        shared->load_marks_threadpool = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
src/Interpreters/Context.cpp:        shared->prefetch_threadpool = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
src/Interpreters/Context.cpp:        shared->threadpool_writer = std::make_unique<ThreadPool>(pool_size, pool_size, queue_size);
```

Fixes: #47880
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-03-30 20:08:38 +02:00
Robert Schulze
4938681f87
Fix macos build 2023-03-30 17:46:11 +00:00
robot-ch-test-poll2
af59727c53
Merge pull request #48239 from ClickHouse/rfraposa-patch-3
Lightweight deletes are no longer experimental
2023-03-30 19:33:52 +02:00
Rich Raposa
42cd0d0ddb
Merge pull request #48238 from ClickHouse/rfraposa-patch-2
Change default Parquet compression from snappy to lz4
2023-03-30 10:59:27 -06:00
Mikhail f. Shiryaev
c5ec7a3ec9
Merge pull request #48235 from ClickHouse/fix-01293_show_clusters
Determine the hosts order in `SHOW CLUSTER` query
2023-03-30 18:41:56 +02:00
Rich Raposa
4675fa82a3
Update delete.md
Lightweight deletes are no longer experimental in 23.3
2023-03-30 10:29:08 -06:00
Rich Raposa
3a3438ebf9
Update settings-formats.md
Default compression method for Parquet changed from snappy to lz4 in 23.3
2023-03-30 10:26:33 -06:00
Antonio Andelic
80cb121d2a
Merge pull request #48092 from ClickHouse/nosign-keyword-for-s3
Add support for `NOSIGN` keyword and `no_sign_request` config for S3
2023-03-30 18:10:56 +02:00
Mikhail f. Shiryaev
1c58a911eb
Push clickhouse-keeper as both w/ and w/o suffix -alpine 2023-03-30 18:07:40 +02:00
Nikolai Kochetov
f06bdc85eb
Merge pull request #48226 from ClickHouse/rename-setting-stop_reading_on_first_cancel
Rename setting stop_reading_on_first_cancel
2023-03-30 18:03:23 +02:00