Alexey Milovidov
9ad4157dbb
Fix strange code
2021-05-08 22:40:23 +03:00
Maksim Kita
0b67f593e0
Merge pull request #23963 from azat/dict-hit_rate-nan
...
Use 0 over nan for hit_rate in case of 0 queries to the cache dictionary
2021-05-08 22:38:21 +03:00
Maksim Kita
99c25feafe
Merge pull request #23965 from azat/aggregator-logs
...
Round floats in Aggregator log messages
2021-05-08 22:38:02 +03:00
Maksim Kita
ced1b33fa4
Merge pull request #23974 from kitaisreal/functional-stateless-fix-numbers
...
Functional stateless tests fix numbers
2021-05-08 22:35:45 +03:00
Alexey Milovidov
0af587a346
Fix warnings by PVS-Studio in some third-party code
2021-05-08 22:31:11 +03:00
Alexey Milovidov
8a804f1e35
Fix warnings by PVS-Studio
2021-05-08 22:30:58 +03:00
Alexey Milovidov
d057bcf42c
Fix error (amend)
2021-05-08 22:28:55 +03:00
Vitaliy Zakaznikov
b85205aa30
Enabling testflows window function tests.
2021-05-08 15:22:03 -04:00
Alexey Milovidov
883c826d3f
Minor code modification
2021-05-08 22:17:46 +03:00
Vitaliy Zakaznikov
b303ebc7e3
Fixing window functions distributed tests by moving to using deterministic sharding key.
2021-05-08 15:06:31 -04:00
Alexey Milovidov
fa5205b4c7
Get rid of ugly notation
2021-05-08 22:05:08 +03:00
Alexey Milovidov
49160ae1ba
Big integers and UUID in dictionaries
2021-05-08 22:01:59 +03:00
Alexey Milovidov
49c0e18e45
Fix build
2021-05-08 21:46:41 +03:00
Alexey Milovidov
2d3647c5b0
Merge branch 'master' into normalize-bigint
2021-05-08 21:22:32 +03:00
Alexey Milovidov
c9fb8ca026
Fix deprecated header
2021-05-08 21:19:45 +03:00
Alexey Milovidov
ac9b43f103
Fix error
2021-05-08 21:16:46 +03:00
Alexey Milovidov
2b4f4e08c3
Fix error
2021-05-08 21:16:25 +03:00
Alexey Milovidov
aa25ffa9e3
Fix error
2021-05-08 21:15:23 +03:00
Alexey Milovidov
52bea2630b
Fix error
2021-05-08 21:15:00 +03:00
Maksim Kita
290e1ec307
Functional stateless tests fix numbers
2021-05-08 21:13:27 +03:00
Alexey Milovidov
8e8160be28
Fix error
2021-05-08 21:11:47 +03:00
Alexey Milovidov
b96087025e
Fix error
2021-05-08 21:11:31 +03:00
Maksim Kita
2a630b68a4
Fixed FunctionComparison with special edge case
2021-05-08 21:04:21 +03:00
Azat Khuzhin
f1aebbe927
Check that totals correctly calculated in 01865_aggregator_overflow_row
...
Change aggregation function to uniqCombined() to check this.
2021-05-08 20:43:01 +03:00
Maksim Kita
7c948139fc
Merge pull request #23959 from divanorama/patch-1
...
Don't try GLIBC_COMPATIBILITY for i686 Linux
2021-05-08 19:24:41 +03:00
Maksim Kita
0a2ea38cc9
Merge pull request #23916 from azat/dict-found_rate
...
Measure found rate for dictionaries
2021-05-08 19:23:52 +03:00
Alexey Milovidov
ad88819ee4
Fix a bunch of warnings from PVS-Studio
2021-05-08 19:13:10 +03:00
Alexey Milovidov
f805f4aa4f
Fix error found by PVS-Studio
2021-05-08 19:13:00 +03:00
Alexey Milovidov
3025f9e141
More fixes for PVS-Studio
2021-05-08 19:12:49 +03:00
Alexey Milovidov
e905883c75
More fixes for PVS-Studio
2021-05-08 19:12:31 +03:00
Alexey Milovidov
022667a190
Fix some PVS-Studio warnings
2021-05-08 19:12:19 +03:00
Alexey Milovidov
8d62c42eb9
A bunch of changes for PVS-Studio
2021-05-08 19:11:50 +03:00
Alexey Milovidov
bdc372cb9a
Fix bad code (found by PVS-Studio)
2021-05-08 19:11:40 +03:00
Alexey Milovidov
8b9c058141
Fix bad code in Keeper (found by PVS-Studio)
2021-05-08 19:11:31 +03:00
Alexey Milovidov
241c7a94da
Fix bad code in Keeper (found by PVS-Studio)
2021-05-08 19:11:08 +03:00
Alexey Milovidov
7ca0f46708
Add suppressions for PVS-Studio
2021-05-08 19:10:56 +03:00
Alexey Milovidov
78a2df5900
Fix low quality code in Qualtile (found by PVS-Studio)
2021-05-08 19:10:38 +03:00
Alexey Milovidov
125b2ab214
Suppressions for PVS-Studio
2021-05-08 19:10:23 +03:00
Alexey Milovidov
604daa9581
Fix a bunch of warnings from PVS-Studio
2021-05-08 19:09:17 +03:00
Maksim Kita
9b405b4c07
Fixed FunctionComparison for constants
2021-05-08 18:47:08 +03:00
Alexey Milovidov
f59c55abb5
Fix error found by PVS-Studio
2021-05-08 18:35:38 +03:00
Alexey Milovidov
45dea86395
More fixes for PVS-Studio
2021-05-08 18:35:09 +03:00
Alexander Kuzmenkov
308c4657ce
support longer query ids in trace log for perf tests
2021-05-08 18:20:42 +03:00
Alexey Milovidov
2fbecf36ca
More fixes for PVS-Studio
2021-05-08 18:20:40 +03:00
Azat Khuzhin
69e395bede
Round floats in AggregatingTransform log messages
2021-05-08 18:01:57 +03:00
Azat Khuzhin
6b11319cdf
Round floats in Aggregator log messages
2021-05-08 18:01:24 +03:00
Alexey Milovidov
3e8deef6fe
Fix some PVS-Studio warnings
2021-05-08 17:54:08 +03:00
Azat Khuzhin
21f08a1aa9
Use 0 over nan for hit_rate in case of 0 queries to the cache dictionary
2021-05-08 17:51:22 +03:00
kssenii
266567e04c
Merge branch 'master' of github.com:ClickHouse/ClickHouse into poco-file-to-std-fs
2021-05-08 17:49:05 +03:00
Azat Khuzhin
4cecc238d6
Fix SIGSEGV for external GROUP BY and overflow row
...
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive
And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.
Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.
And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.
Found with fuzzer [1].
[1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
