Commit Graph

88881 Commits

Author SHA1 Message Date
kssenii
e501a5a106 Update tests config 2022-05-19 15:55:07 +02:00
kssenii
e4e6e44e86 Merge master 2022-05-17 15:47:33 +02:00
Vitaly Baranov
23a61b1596
Merge pull request #36700 from azat/fix-server-reload
Fix server reload on port change (do not wait for current connections from query context)
2022-05-17 12:25:21 +02:00
Kseniia Sumarokova
8cb71d0172
Merge pull request #33332 from Michicosun/MeiliSearch
MeiliSearch
2022-05-17 11:47:56 +02:00
alesapin
4d4634b12d
Merge pull request #37164 from kssenii/ficx-async-reads-assertions
fix async reads from remote fs internal setting not being always turned on
2022-05-17 11:29:14 +02:00
Robert Schulze
8500cdd082
Merge pull request #37262 from ni1l/master
Sync the English version of conditional-functions.md and date-time-fu…
2022-05-17 09:24:27 +02:00
Kseniia Sumarokova
94683786dc
Merge branch 'master' into MeiliSearch 2022-05-16 22:42:09 +02:00
Kseniia Sumarokova
f073efc025
Merge pull request #37225 from Vxider/wv-fix-cleanup
Fix WindowView cleanup
2022-05-16 22:39:58 +02:00
Mikhail f. Shiryaev
b49e6359fb
Merge pull request #37271 from ClickHouse/fix-docker-cleaner
Fix docker cleaner in workflows
2022-05-16 22:23:54 +02:00
Maksim Kita
20380fa87b
Merge pull request #37257 from kitaisreal/dynamic-dispatch-infrastructure-for-class-members
Dynamic dispatch infrastructure for class member functions
2022-05-16 22:15:10 +02:00
kssenii
6a51dea791 Merge master 2022-05-16 22:13:22 +02:00
kssenii
5e3410f60a Better 2022-05-16 22:09:11 +02:00
Mikhail f. Shiryaev
302b7e00cf
Fix docker cleaner in workflows 2022-05-16 21:57:05 +02:00
Vitaly Baranov
72bff5242a
Merge pull request #37168 from vitlibar/backup-improvements-5
Backups Improvements 5
2022-05-16 21:25:54 +02:00
ni1l
1bec6edd24 Sync the English version of conditional-functions.md and date-time-functions.md to the Chinese document 2022-05-17 00:30:26 +08:00
Alexey Milovidov
4d78f11154
Merge pull request #37261 from ClickHouse/revert-37051-flexible_query_div_height
Revert "Remove height restrictions from the query div in play web tool."
2022-05-16 19:20:48 +03:00
Alexey Milovidov
434b8fbf14
Revert "Remove height restrictions from the query div in play web tool." 2022-05-16 19:20:30 +03:00
Rich Raposa
75d9ef0e3b
Merge pull request #37126 from mrk-andreev/patch-3
Add Kafka headers virtual columns
2022-05-16 09:35:50 -06:00
Rich Raposa
cd22ce032e
Merge pull request #37127 from cwurm/add_json_docs
Add documentation for JSON data type
2022-05-16 09:34:51 -06:00
Dmitry Novik
dd1e7b55b8
Merge pull request #37050 from azat/fix-optimize_aggregation_in_order-prefix-Array
Fix optimize_aggregation_in_order with prefix GROUP BY and *Array aggregate functions
2022-05-16 17:17:56 +02:00
Maksim Kita
032b5d3fc3 Dynamic dispatch infrastructure for class member functions 2022-05-16 17:05:16 +02:00
Maksim Kita
46f69e8df2
Merge pull request #37255 from den-crane/patch-7
Doc. Fix typo
2022-05-16 16:52:20 +02:00
Anton Popov
9c3daf7e5b
Merge pull request #37245 from ClickHouse/CurtizJ-patch-4-1
Temporarily fix flaky test `01825_type_json_insert_select.sql`
2022-05-16 16:44:27 +02:00
Denny Crane
52b7f899b2
Update syntax.md 2022-05-16 11:27:49 -03:00
Denny Crane
df6b874df9
Update syntax.md
fix typo
2022-05-16 11:25:33 -03:00
kssenii
f3c1f3796b Some fixes 2022-05-16 16:16:38 +02:00
Sergei Trifonov
b71511eaf8
Merge pull request #37246 from ClickHouse/remove-bash-prompt
Remove prompt($) from bash scripts
2022-05-16 15:50:08 +02:00
Kseniia Sumarokova
ff37d7d5c3
Update ErrorCodes.cpp 2022-05-16 15:30:07 +02:00
Azat Khuzhin
c8420c0dbe Remove duplication for server connections check
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
e503f1f22c Keep reloaded servers and currently active in one list
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
367daca584 Add a test for SYSTEM RELOAD CONFIG directly from the query context
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
f15a5461be Fix server reload on port change (do not wait for current connections)
If you will execute 'SYSTEM RELOAD CONFIG' via, i.e., TCP protocol, then
reload on port change will endlessly wait for connection from which this
query had been issued, and you will see the following message in the
logs:

    2022.04.28 03:34:57.552513 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Debug> executeQuery: (from 127.0.0.1:11774) system reload config
    ...
    2022.04.28 03:34:57.710640 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Information> Application: Stopped listening for http://127.0.0.1:18123
    2022.04.28 03:34:57.798774 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Information> Application: Stopped listening for native protocol (tcp): 127.0.0.1:19000
    ...
    2022.04.28 03:34:57.901375 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Debug> Application: Server finished: http://127.0.0.1:18123
    2022.04.28 03:34:57.901455 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
    2022.04.28 03:34:58.001717 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
    2022.04.28 03:34:58.101881 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
    ...
    2022.04.28 03:35:01.707951 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000

But waiting for the current connection will never ends.

So instead of waiting directly from the query context (SYSTEM RELOAD
CONFIG) do this in background (actually not even in background, but
check on server reload and on exit).

v0: just don't wait for the servers
v2: fix use-after-free by removing dependency from server in handlers
v3: wait servers in background to avoid use-after-free of the context
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
568e29ceb6 tests/integration/test_server_reload: add pylint hints
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
b528a72e89 tests/integration/test_server_reload: add missing assertions
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Kruglov Pavel
5e34f48a18
Merge pull request #37021 from excitoon-favorites/fixtdigest
Fixed problem with infs in `quantileTDigest`
2022-05-16 15:21:59 +02:00
Mikhail Artemenko
535b3ea686 refactor code & change exception numbers 2022-05-16 16:13:05 +03:00
Vxider
b3a731c226 fix build 2022-05-16 12:51:19 +00:00
Robert Schulze
ed7df7cabd
Merge pull request #36960 from ClickHouse/clangtidies
Enable clangtidies
2022-05-16 14:22:50 +02:00
Igor Nikonov
34de7d9973
Remove prompt($) from bash scripts
Copy bash script. Paste it into terminal. Some bash scripts fail to execute due to bash prompt in documentation. So, I just removed the prompt(s)
2022-05-16 13:55:42 +02:00
Robert Schulze
82c30442bd
Merge pull request #37223 from ni1l/master
Sync the English version of bit-functions.md to the Chinese document
2022-05-16 13:42:06 +02:00
Vxider
6b3b744e3f fix data race 2022-05-16 11:31:49 +00:00
alesapin
1829256ae2
Merge pull request #37178 from ClickHouse/ignore_auto_increment_in_create_table_2
Ignore AUTO_INCREMENT in CREATE TABLE to simplify migration from MySQL
2022-05-16 13:29:22 +02:00
Anton Popov
848b762eb0 Update 01825_type_json_insert_select.sql 2022-05-16 11:18:31 +00:00
alesapin
b10f26e3ed Fix style 2022-05-16 12:25:25 +02:00
Vladimir C
75008d5903
Merge pull request #37166 from vdimir/issue_37141 2022-05-16 12:21:41 +02:00
ni1l
e85c616704 fix the broken link in the bit-functions.md 2022-05-16 18:03:09 +08:00
Robert Schulze
d66dcdad79
Fix new occurrences of new clang-tidy warnings 2022-05-16 11:31:36 +02:00
kssenii
f7493965b7 Remove additional check for merge tree 2022-05-16 11:19:57 +02:00
Robert Schulze
7006ef6ebb
Merge pull request #37230 from ramazanpolat/patch-3
update materialize index notation
2022-05-16 11:18:10 +02:00
kssenii
49201f217f Revert 2022-05-16 11:17:56 +02:00