Commit Graph

97843 Commits

Author SHA1 Message Date
Roman Vasin
e66e70870a Fix timezone issues 2022-09-28 16:05:59 +00:00
Roman Vasin
a551e8d950 Fix example in documentation 2022-09-28 13:00:52 +00:00
Roman Vasin
109c5ee1a1 Update docs for DateTime64 return types. 2022-09-28 12:49:58 +00:00
Roman Vasin
d50dcf3314 Add tests for DateTime64 2022-09-28 12:26:20 +00:00
Roman Vasin
36274baba9 Code cleanup 2022-09-26 15:36:32 +03:00
Roman Vasin
2a92c2aae9 Fix timeSlot() for DateTime64 argument 2022-09-26 15:26:07 +03:00
Roman Vasin
348f28a3e7 Fix toStartOfFiveMinutes, toStartOfTenMinutes, toStartOfFifteenMinutes 2022-09-22 13:30:40 +00:00
Roman Vasin
cdd20241bf Finish toStartOfDay; fix toStartOfMinute 2022-09-22 13:16:46 +00:00
Roman Vasin
4ddd6f3c60 Fix timeSlot(); partial fix StartOfDay 2022-09-22 09:19:22 +00:00
Roman Vasin
49b0da0273 Add date32IsNotSupported() 2022-09-22 07:15:03 +00:00
Roman Vasin
f6ebd94ce1 Add execute_extended_result for Date32 argument 2022-09-22 07:07:04 +00:00
Roman Vasin
30c4719f7b Add FunctionDateOrDateTimeToDateTimeOrDateTime64; function toStartOfHour works 2022-09-21 12:58:57 +00:00
Kseniia Sumarokova
55ebe90e3b
Merge pull request #41496 from lesandie/master
Fixed cache parameter name
2022-09-19 13:36:21 +02:00
Sema Checherinda
2f6c5c8f75
Merge pull request #41417 from nickitat/stabilize_uniq_sorted
Stabilize uniq stored
2022-09-19 12:30:16 +02:00
Sema Checherinda
f50378d551
Merge pull request #41425 from den-crane/test/issue_41394
test for #41394
2022-09-19 12:27:33 +02:00
Kseniia Sumarokova
8922f81399
Merge pull request #41468 from azat/tests/test_hive_query
tests: fix test_hive_query flakiness
2022-09-19 12:25:16 +02:00
Antonio Andelic
1763af37b9
Merge pull request #41403 from ClickHouse/keeper-fix-shutdown-without-server
Fix Keeper segfault during shutdown when RAFT server failed to start
2022-09-19 12:03:58 +02:00
Diego Nieto (lesandie)
1a14515e35 Fixed cache parameter name 2022-09-19 10:29:41 +02:00
Vladimir C
b6b5932efc
Merge pull request #41223 from ClickHouse/vdimir/exponential_rewrite_21557 2022-09-19 10:07:24 +02:00
Alexey Milovidov
b9bd2c8373
Merge pull request #41458 from ClickHouse/fix-bug-orc
Fix very strange behavior of Apache ORC
2022-09-19 10:43:17 +03:00
Alexey Milovidov
e20bc9953c
Merge pull request #41481 from ClickHouse/alexey-milovidov-patch-5
Update geo.md
2022-09-19 09:34:24 +03:00
Alexey Milovidov
b01f5bdca8
Merge pull request #39354 from ClickHouse/window-order-by
Respect ORDER BY clause in window functions
2022-09-19 09:22:37 +03:00
Alexey Milovidov
6a09340f11
Merge pull request #41459 from azat/io/threadpoolreader-elapsed
Account any IO that is done from ThreadPoolReader
2022-09-19 09:04:20 +03:00
Azat Khuzhin
00d4ac542d tests: fix test_hive_query flakiness
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-19 07:54:49 +02:00
Alexey Milovidov
2e5fa7880e
Update geo.md 2022-09-19 07:52:24 +03:00
Alexey Milovidov
81e8cb4be6
Merge branch 'master' into fix-bug-orc 2022-09-19 06:38:17 +03:00
Alexey Milovidov
d4b9fe41be
Merge pull request #41457 from ClickHouse/remove-trash-5
Remove trash from Field
2022-09-19 06:36:48 +03:00
Alexey Milovidov
57a1f47972
Merge pull request #41441 from ClickHouse/pod-array-overflow
Fix overflow in `PODArray`
2022-09-19 06:34:21 +03:00
Alexey Milovidov
ce130d0dc0
Merge pull request #41462 from ClickHouse/kerberos-remove-noise
Remove noise from the build process
2022-09-19 06:32:46 +03:00
Alexey Milovidov
4719ed6f2c
Merge pull request #41466 from ClickHouse/add_missed_throw
Add missed throw expression
2022-09-19 06:31:29 +03:00
Alexey Milovidov
ac193facde
Merge branch 'master' into add_missed_throw 2022-09-19 06:31:12 +03:00
Alexey Milovidov
51a847af11
Merge pull request #41469 from azat/build/tidy-fix
Fix clang-tidy build
2022-09-19 06:29:42 +03:00
Alexey Milovidov
036e882097
Merge pull request #41460 from ClickHouse/add-test-31631
Add a test for #31631
2022-09-19 06:28:56 +03:00
Alexey Milovidov
df52df83f9
Merge pull request #41463 from ClickHouse/add-test-38383
Add a test for #38383
2022-09-19 06:27:38 +03:00
Alexey Milovidov
790cb730d6 Fix clang-tidy 2022-09-19 00:34:41 +02:00
Alexey Milovidov
cc28120761 Merge branch 'master' into pod-array-overflow 2022-09-19 00:34:38 +02:00
Alexey Milovidov
f3fd5ef845 Fix clang-tidy 2022-09-19 00:32:52 +02:00
Alexey Milovidov
36aaeecc2f Fix clang-tidy 2022-09-19 00:32:11 +02:00
Alexey Milovidov
041d2f7dee Fix clang-tidy 2022-09-19 00:31:37 +02:00
Alexey Milovidov
f78d028177 Fix clang-tidy 2022-09-19 00:31:02 +02:00
Alexey Milovidov
5d9e125c71 Fix clang-tidy 2022-09-19 00:28:32 +02:00
Azat Khuzhin
2141665c68 Fix clang-tidy build
Tidy report [1]:

    src/AggregateFunctions/CMakeFiles/clickhouse_aggregate_functions.dir/AggregateFunctionCategoricalInformationValue.cpp.o -c ../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:38:15: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        Counter & counter(AggregateDataPtr __restrict place, size_t i, bool what) const
                  ^                                                               ~~~~~
        static
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:43:21: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        const Counter & counter(ConstAggregateDataPtr __restrict place, size_t i, bool what) const
                        ^                                                                    ~~~~~
        static
    178520 warnings generated.

  [1]: https://s3.amazonaws.com/clickhouse-builds/41459/64b44be513607d59e4b89dd9fb518b8cf4acba21/clickhouse_special_build_check/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-18 22:04:12 +02:00
alesapin
e4c120742e Add missed throw expression 2022-09-18 16:56:19 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch
Fix redundant fetch in zero copy replication
2022-09-18 15:57:27 +02:00
alesapin
1d0dbfb112
Merge pull request #41444 from ClickHouse/one_wrong_config_assert
One more validation for broken config in keeper
2022-09-18 15:56:48 +02:00
Kruglov Pavel
519bcbb3be
Merge pull request #41236 from Avogar/fix-totals-extremes
Don't output totals/extremes in all row formats, update docs
2022-09-18 14:55:07 +02:00
Alexey Milovidov
56fd38de44 Add a test for #38383 2022-09-18 10:38:10 +02:00
Alexey Milovidov
3eb7ee8308 Remove noise from build process 2022-09-18 10:35:25 +02:00
Azat Khuzhin
64b44be513 Account any IO that is done from ThreadPoolReader
In case of some issues with the disk it is possible that
preadv2(RWF_NOWAIT)==EAGAIN can take a lot of time, so let's measure
even this case.

I've verified with a simple (almost) loop of preadv2(RWF_NOWAIT), and
got this:

    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    too long at offset=8691694, ret=18446744073709551615 (14.5016)
    too long at offset=8694766, ret=18446744073709551615 (14.4338)
    too long at offset=8694766, ret=18446744073709551615 (16.2144)

So here you can see that preadv2(RWF_NOWAIT) took 14-16 seconds in case
of failure.

Complete code can be found here [1].

  [1]: https://gist.github.com/azat/f4a6b0750316c42bec021064e0a7627c

I came up with this patch because I saw some stranginess in
ProfileEvents, that does not show all the time that was spend in IO when
pread_threadpool method was used.
Also there was some stranginess with trace_log too.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-18 10:05:21 +02:00
Alexey Milovidov
4f75d818e8 Add a test for #31631 2022-09-18 09:56:29 +02:00