Commit Graph

84337 Commits

Author SHA1 Message Date
Maksim Kita
e7772ed434 Fix clang-tidy warnings in Common folder 2022-03-14 18:17:35 +00:00
Maksim Kita
07b0845110 Fix clang-tidy warnings in Backups, Client, Columns folders 2022-03-14 18:17:35 +00:00
Maksim Kita
5147da3355 Fix clang-tidy warnings in AggregateFunction folder 2022-03-14 18:17:35 +00:00
Maksim Kita
e14cfd5dcd Fix clang-tidy warnings in Access folder 2022-03-14 18:17:35 +00:00
alesapin
b143aefd3f
Merge pull request #35261 from ClickHouse/tavplubix-patch-1
Fix flaky test
2022-03-14 18:21:03 +01:00
Vitaly Baranov
4af61fb9d3
Merge pull request #34738 from DevTeamBK/Issue-33953
New setting in Server Configuration to on/off AuthType Plaintext_password and No_password
2022-03-14 17:09:46 +01:00
Mikhail f. Shiryaev
23afbbaeeb
Merge pull request #35260 from azat/fix-build-check
Mark build action as failed if it was retried and there was no succeeded builds
2022-03-14 16:45:34 +01:00
alesapin
b13b415d3f
Merge pull request #35257 from azat/fix-s3-pool-shutdown
Wait for IDiskRemote thread pool properly
2022-03-14 13:56:37 +01:00
Antonio Andelic
ed3d71d83f
Merge pull request #35072 from azat/buffer-memory-tracker-leak
Avoid MEMORY_LIMIT_EXCEEDED during INSERT into Buffer with AggregateFunction
2022-03-14 12:31:04 +01:00
alesapin
98144bc1f5
Merge pull request #35031 from ClickHouse/standalone_keeper_build
Building small keeper binary
2022-03-14 11:27:25 +01:00
Antonio Andelic
ebf72bf61d
Merge pull request #35145 from bigo-sg/lower-column-name
add setting to lower column case when reading parquet/orc file
2022-03-14 11:25:03 +01:00
Azat Khuzhin
4b770343e1 Mark build action as failed if it was retried and there was no succeeded builds
Builder actions does not shows errors after retries, for example [1]
failed, but the check is green:

    Dump json report {
      'log_url': 'https://s3.amazonaws.com/clickhouse-builds/35204/c5a71a7f10e9d20b116b3e1db02bb444b203c32a/binary_gcc/build_log.log',
      'build_urls': [], <-- empty
      'build_config': {...},
      'elapsed_seconds': 0, 'status': False
    } to build_urls_binary_gcc.json with env build_urls_{build_name}

  [1]: https://github.com/ClickHouse/ClickHouse/runs/5510262456?check_suite_focus=true#logs

And previous build indeed failed [2]:

    Mar 11 08:19:45 ninja: build stopped: subcommand failed.

  [2]: https://s3.amazonaws.com/clickhouse-builds/35204/c5a71a7f10e9d20b116b3e1db02bb444b203c32a/binary_gcc/build_log.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-14 13:23:51 +03:00
alesapin
f1b812bdc1
Merge pull request #35229 from ClickHouse/change-timezone-in-stateful-tests
Change timezone in stateful tests.
2022-03-14 11:13:12 +01:00
alesapin
b149f28cd3
Merge pull request #35209 from kssenii/cache-fix
Cache fix
2022-03-14 11:07:40 +01:00
tavplubix
17e803ea37
Update 01162_strange_mutations.sh 2022-03-14 13:02:56 +03:00
Maksim Kita
ad6b3693e1
Merge pull request #35123 from zhanghuajieHIT/fix_build_fail_with_gcc
fix build fail with gcc
2022-03-14 10:36:15 +01:00
Maksim Kita
25c994c10c
Merge pull request #35255 from ClickHouse/rfraposa-patch-4
Update internal-dicts.md
2022-03-14 10:34:49 +01:00
Kseniia Sumarokova
58a2d2b458
Merge pull request #35118 from zzsmdfj/issue/#31469_MaterializedMysql_mysqlDate2CkDate32
to #31469_MaterializedMysql_mysqlDate2CkDate32
2022-03-14 10:32:33 +01:00
Kseniia Sumarokova
5359e0430d
Merge pull request #35251 from den-crane/Docs/named-collections
Doc. named connections
2022-03-14 10:25:13 +01:00
Azat Khuzhin
d13fc9ec44 Wait for IDiskRemote thread pool properly
ASan report [1]:

    WARNING: ThreadSanitizer: heap-use-after-free (pid=611)
      Read of size 4 at 0x7b48006f0250 by thread T273:
        0 MemoryTracker::allocImpl() obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:105:49 (clickhouse+0xa05d0ef)
        1 MemoryTracker::allocImpl() obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:239:22 (clickhouse+0xa05d580)
        2 MemoryTracker::alloc(long) obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:246:5 (clickhouse+0xa05dea7)
        3 DB::ThreadStatus::~ThreadStatus() obj-x86_64-linux-gnu/../src/Common/ThreadStatus.cpp:154:28 (clickhouse+0xa059b01)
        4 ThreadFromGlobalPool::ThreadFromGlobalPool<>()::'lambda'()::operator()() obj-x86_64-linux-gnu/../s>

      Previous write of size 8 at 0x7b48006f0250 by main thread:
        8 std::__1::unordered_map<std::__1::basic_string<>, DB::ProcessListForUser, std::__1::hash<>, std::__1>
        9 DB::ProcessList::~ProcessList() obj-x86_64-linux-gnu/../src/Interpreters/ProcessList.h:275:7 (clickhouse+0x17b71c9c)
        10 DB::ContextSharedPart::~ContextSharedPart() obj-x86_64-linux-gnu/../src/Interpreters/Context.cpp:304:5 (clickhouse+0x17b70712)
        13 DB::SharedContextHolder::reset() obj-x86_64-linux-gnu/../src/Interpreters/Context.cpp:453:44 (clickhouse+0x17b3daf9)
        14 DB::Server::main()::$_8::o>

      Thread T273 (tid=946, running) created by thread T223 at:
        0 pthread_create <null> (clickhouse+0x9f7d49d)
        15 DB::WriteBufferFromS3::makeSinglepartUpload() obj-x86_64-linux-gnu/../src/IO/WriteBufferFromS3.cpp:332:9 (clickhouse+0x17a81b6a)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/35072/19be9c8c6433ffd1bbf8eb08975d8afbaebf3d43/stress_test__thread__actions_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-14 12:07:47 +03:00
Azat Khuzhin
9f7fae56b0 WriteBufferFromS3: remove unused headers
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-14 12:07:47 +03:00
Maksim Kita
2211e016cb
Merge pull request #35254 from ClickHouse/rfraposa-patch-3
Update rounding-functions.md
2022-03-14 09:31:58 +01:00
Maksim Kita
6e230d4335
Merge pull request #35253 from ClickHouse/rfraposa-patch-2
Update json-functions.md
2022-03-14 09:31:23 +01:00
Maksim Kita
2f5c35516a
Merge pull request #35256 from ClickHouse/rfraposa-patch-5
Update quotas.md
2022-03-14 09:30:34 +01:00
Denny Crane
39c6428636 Doc. named connections 2022-03-14 00:35:02 -03:00
Rich Raposa
928538f04b
Update quotas.md
Missed this comment from Alexey earlier
2022-03-13 21:34:43 -06:00
Rich Raposa
6fbb63b30c
Update internal-dicts.md
The mentioned functions have already been removed
2022-03-13 21:31:48 -06:00
Denny Crane
0b4c3e5be9 Doc. named connections 2022-03-14 00:31:20 -03:00
Rich Raposa
fa3c3f9179
Update rounding-functions.md
Adding a clarification about the use case of `roundDuration`
2022-03-13 21:27:02 -06:00
Rich Raposa
67587a8ed0
Update json-functions.md
Clarified the wording about the assumptions - which only apply to the `visitParam` functions
2022-03-13 21:19:29 -06:00
mergify[bot]
cba9c03d18
Merge branch 'master' into change-timezone-in-stateful-tests 2022-03-14 01:28:19 +00:00
Alexey Milovidov
4712499b83
Merge pull request #35247 from ClickHouse/add-test-34682
Add a test for #34682
2022-03-14 04:26:33 +03:00
Alexey Milovidov
eb1192934c
Merge pull request #35249 from azat/fix-01506_buffer_table_alter_block_structure_2
Fix possible 01506_buffer_table_alter_block_structure_2 flakiness
2022-03-14 04:25:32 +03:00
Denny Crane
7e5589fd78 Doc. named connections 2022-03-13 21:38:00 -03:00
Maksim Kita
ded4c8430c
Merge pull request #35242 from ClickHouse/remove-bugs-2
Remove "bugs" that do not exist anymore
2022-03-14 00:59:08 +01:00
Maksim Kita
ce0c8e5597
Update JSONRowOutputFormat.cpp 2022-03-14 00:58:36 +01:00
Azat Khuzhin
19be9c8c64 Add a comment for ColumnAggregateFunction::force_data_ownership
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-13 23:28:38 +03:00
Azat Khuzhin
619bed4371 Fix possible 01506_buffer_table_alter_block_structure_2 flakiness
SELECT from Buffer table is racy, so you can get data from the
underlying table but not from the Buffer itself, since in parallel with
SELECT, Buffer, can flush it's data to the underlying table.

It is hard to avoid with the current architecture, since this will
require to holding lock until the data will be read from the Buffer, and
this is not a good alternative.

So let's fix the test instead, but not relying on background flush (TTL
increased).

Here is an example of a test failure [1]:

    2022.03.12 20:56:58.141182 [ 678 ] {011e7d25-82a9-4ab6-8cb0-dcbbc84f9581} <Debug> executeQuery: (from [::1]:33324) (comment: 01506_buffer_table_alter_block_structure_2.sql) SELECT * FROM buf ORDER BY timestamp;
    2022.03.12 20:56:58.162709 [ 678 ] {011e7d25-82a9-4ab6-8cb0-dcbbc84f9581} <Trace> MergeTreeInOrderSelectProcessor: Reading 1 ranges in order from part 20200101_1_1_0, approx. 1 rows starting from 0
    2022.03.12 20:56:59.144663 [ 615 ] {} <Trace> test_bdtzgu.buf_dest (79ba36b2-0e90-4bbb-b55f-a42b605b362b): Renaming temporary part tmp_insert_20200101_2_2_0 to 20200101_2_2_0.
    2022.03.12 20:56:59.147550 [ 615 ] {} <Debug> StorageBuffer (test_bdtzgu.buf): Flushing buffer with 1 rows, 18 bytes, age 1 seconds, took 19 ms (bg).
    2022.03.12 20:56:59.391774 [ 678 ] {011e7d25-82a9-4ab6-8cb0-dcbbc84f9581} <Information> executeQuery: Read 1 rows, 13.00 B in 1.250102785 sec., 0 rows/sec., 10.40 B/sec.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/0/044cd6b861c1f4f00c6c24c4020799b676de6d34/stateless_tests__memory__actions__[1/3].html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-13 23:13:31 +03:00
mergify[bot]
638c7f8637
Merge branch 'master' into remove-bugs-2 2022-03-13 19:14:20 +00:00
Alexey Milovidov
b958edc104 Add a test for #34682 2022-03-13 20:12:10 +01:00
Maksim Kita
0dd807d19d
Merge pull request #34750 from kitaisreal/merge-tree-improve-insert-performance
MergeTree improve insert performance
2022-03-13 13:39:18 +01:00
Kseniia Sumarokova
c04b103e6c
Merge pull request #35245 from ClickHouse/kssenii-patch-3
Update CachedReadBufferFromRemoteFS.cpp
2022-03-13 13:33:00 +01:00
Kseniia Sumarokova
35e5b4e8a5
Update CachedReadBufferFromRemoteFS.cpp 2022-03-13 12:37:00 +01:00
Alexey Milovidov
d009263e37
Merge pull request #35243 from ClickHouse/revert-35225-docker-timezone-change
Revert "Change timezone in Docker"
2022-03-13 04:03:51 +03:00
Alexey Milovidov
d0716b035f
Revert "Change timezone in Docker" 2022-03-13 04:03:06 +03:00
Alexey Milovidov
8dedea4f8f
Merge pull request #35236 from rfraposa/master
Update references in docs
2022-03-12 23:03:22 +03:00
Alexey Milovidov
044cd6b861 Remove "ru" blog 2022-03-12 21:03:03 +01:00
Alexey Milovidov
978877a9c0
Merge pull request #35212 from rschu1ze/cpp14-trait-aliases
Use C++14 aliases for some type traits
2022-03-12 22:20:14 +03:00
Alexey Milovidov
2fe54b57b9 Addition to prev. revision 2022-03-12 20:16:25 +01:00
Alexey Milovidov
f0867ed7ea Moved another test 2022-03-12 20:16:25 +01:00