Amos Bird
ea84430864
Get rid of useless std::move to get NRVO
...
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision
Some quote:
> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."
There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
if (block && remove_filter)
block.erase(static_cast<size_t>(filter_column));
return std::move(block);
}
```
because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
Alexey Milovidov
a55b9623c5
Fixed arrayDistinct function [#CLICKHOUSE-3928]
2018-08-24 05:54:02 +03:00
Alexey Milovidov
1437e5cbe3
Fix style [#CLICKHOUSE-2]
2018-08-24 03:07:25 +03:00
proller
df618dd829
Merge remote-tracking branch 'upstream/master' into fix3
2018-08-21 19:52:35 +03:00
alexey-milovidov
edd37cf617
Merge pull request #2910 from yandex/fix-point-in-poligon
...
Fix point in poligon
2018-08-21 19:17:30 +03:00
proller
fc2925b567
Squashed commit of the following:
...
commit 2722e540abfee4a527d716474c4ca582eceeee08
Merge: b4f3af824 aebddd550
Author: proller <proller@github.com>
Date: Tue Aug 21 18:34:18 2018 +0300
Merge remote-tracking branch 'upstream/master' into fix3
commit b4f3af824b88a8b6826583bb483730827574e8ad
Author: proller <proller@github.com>
Date: Tue Aug 21 17:00:20 2018 +0300
fix
commit 3a18fa7ded2a7d6b7a0883a1b9c2d6b99360837d
Author: proller <proller@github.com>
Date: Tue Aug 21 16:57:17 2018 +0300
fix
commit 5d42220c2cf47e1a86bdc73dbfc24b68f8626891
Author: proller <proller@github.com>
Date: Tue Aug 21 16:50:21 2018 +0300
freebsd fixes
commit 7baf4fb5ba4575f79b0d12a9ffaaabd34e1006da
Author: proller <proller@github.com>
Date: Tue Aug 21 16:17:19 2018 +0300
fix
commit e1fe707fd765b841a8d0952d91a980128cbf91d0
Author: proller <proller@github.com>
Date: Tue Aug 21 15:35:21 2018 +0300
fix
commit 027887c71b3ffa98d9473d50d8c3b79cbf3304ac
Author: proller <proller@github.com>
Date: Tue Aug 21 15:25:57 2018 +0300
fix
commit 81af41bfcfff7c02fe4060196cf03c2d2aab416e
Author: proller <proller@github.com>
Date: Tue Aug 21 15:20:41 2018 +0300
fix
commit 93d572c85d9c7e331254999a614c3b22b5573b02
Author: proller <proller@github.com>
Date: Tue Aug 21 14:58:07 2018 +0300
SPLIT_SHARED
commit dd5b8990d8527d59b1e890943d80c2bf27c613ce
Author: proller <proller@github.com>
Date: Tue Aug 21 14:52:39 2018 +0300
fix
commit 4840ca12ab752a38c1ef482e8ec59c5859bb48d7
Author: proller <proller@github.com>
Date: Tue Aug 21 14:46:31 2018 +0300
fix
commit abde633beb86f2a0d025d6fcf079965dbd827b92
Author: proller <proller@github.com>
Date: Tue Aug 21 14:25:32 2018 +0300
fix
commit 0d94a5476a5ba8ba5e88638d58f2cfbf2b4b662d
Author: proller <proller@github.com>
Date: Tue Aug 21 14:45:18 2018 +0300
Travis: try fail on ninja fail
commit c2686f90b68255c2beb0a708804aef404e80a6d2
Merge: 2c3427bbd 2aa7eb463
Author: proller <proller@github.com>
Date: Tue Aug 21 14:25:15 2018 +0300
Merge remote-tracking branch 'upstream/master' into fix3
commit 2c3427bbdb861edbb188ed4621e8a05cafaedafb
Author: proller <proller@github.com>
Date: Mon Aug 20 23:57:24 2018 +0300
fix
commit 530170c6a81d31dcfa81230e48520383234df4bc
Merge: 9abec162c f6e4ec970
Author: proller <proller@github.com>
Date: Mon Aug 20 23:57:03 2018 +0300
Merge remote-tracking branch 'upstream/master' into fix3
commit 9abec162cb2e09bbc2f33cbe80fe76791f6e5a77
Author: proller <proller@github.com>
Date: Mon Aug 20 23:49:58 2018 +0300
Apple fixes
commit 36d05e8217440fbc8ae21571b06d4eb6d679d538
Author: proller <proller@github.com>
Date: Mon Aug 20 23:25:05 2018 +0300
apple fix
commit aeec3e845e4456e89fbb1b1af6f9f36820a46e33
Author: proller <proller@github.com>
Date: Mon Aug 20 23:20:06 2018 +0300
fixes
commit 427961d916a5954981e47d94733996deb2a616ce
Author: proller <proller@github.com>
Date: Mon Aug 20 23:11:11 2018 +0300
fix
commit a7dd55ff8f653624c0f3dbcbc54defd3b3ae97af
Author: proller <proller@github.com>
Date: Mon Aug 20 22:41:53 2018 +0300
fix
commit 6200e0d315c7a62bae63a8de0fc32f7937770ad2
Merge: 8a541d7e6 21cedbe46
Author: proller <proller@github.com>
Date: Mon Aug 20 22:35:49 2018 +0300
Merge remote-tracking branch 'upstream/master' into fix3
commit 8a541d7e64c89e2c16af6c909e0353361153aaa3
Author: proller <proller@github.com>
Date: Mon Aug 20 22:34:32 2018 +0300
Do not use poco types
commit fd560f43d048b7e3307c6c6b9c9d9918230014d8
Author: proller <proller@github.com>
Date: Mon Aug 20 22:20:42 2018 +0300
Try fix apple build
commit cfb2eba07ac06f19e822d3474341d800b1f98cf1
Merge: 8d2e31c90 5b81fdfc0
Author: proller <proller@github.com>
Date: Mon Aug 20 22:03:24 2018 +0300
Merge remote-tracking branch 'upstream/master' into fix3
commit 8d2e31c908be2e99d09e2a9dde2414ab82a5e93c
Author: proller <proller@github.com>
Date: Mon Aug 20 21:56:06 2018 +0300
travis: TEST_SERVER_STARTUP_WAIT=10
2018-08-21 18:56:50 +03:00
Nikolai Kochetov
3404d72da1
Fix pointInPolygon case with nonconvex polygon with two nontrivial halfplanes in cell. #2866
2018-08-21 14:33:15 +03:00
Alexey Milovidov
7d76c3fd4f
Miscellaneous [#CLICKHOUSE-3765]
2018-08-21 07:31:35 +03:00
Alexey Milovidov
76af46ed5d
Merge remote-tracking branch 'origin/master' into CLICKHOUSE-2910
...
Conflicts:
dbms/src/Interpreters/Settings.h
dbms/tests/queries/0_stateless/00687_top_and_offset.sql
2018-08-16 00:44:24 +03:00
chertus
3805794e66
some more build fixes
2018-08-15 16:27:22 +03:00
Alexey Milovidov
9916a75f2e
Merging #2482
2018-08-15 00:35:26 +03:00
chertus
7ca6a0737d
some more build fixes
2018-08-15 00:12:23 +03:00
Alexey Milovidov
acb99b49df
Merge branch 'master' into CLICKHOUSE-2910
2018-08-14 23:29:42 +03:00
alexey-milovidov
c376b2d476
Merge pull request #2869 from yandex/low-cardinality-fixes
...
LowCardinality fixes
2018-08-14 22:36:19 +03:00
alexey-milovidov
beabb91903
Update IFunction.cpp
2018-08-14 22:35:52 +03:00
chertus
21fe103831
fix clang build
2018-08-14 22:16:56 +03:00
Nikolai Kochetov
26f464a4f9
Fix Const(LowCardinality) conversion. [#CLICKHOUSE-3621]
2018-08-14 20:19:48 +03:00
Nikolai Kochetov
f61fdf2076
Better const resolution for LowCardinality type. [#CLICKHOUSE-3621]
2018-08-14 20:19:40 +03:00
chertus
241b05c80a
merge master
2018-08-14 15:50:28 +03:00
alexey-milovidov
3e9f25b1b4
Merge pull request #2830 from yandex/data-type-with-dictionary
...
LowCardinality data type.
2018-08-13 23:49:21 +03:00
Vadim
8510bc3bbd
del white space
2018-08-13 18:31:45 +03:00
alexey-milovidov
f538bd2113
Merge branch 'master' into decimal
2018-08-13 11:57:42 +03:00
Vadim
552d789aa6
Update FunctionsArray.cpp
2018-08-10 18:29:28 +03:00
Vadim
2c6a9b2a92
Update FunctionsArray.h
2018-08-10 18:27:06 +03:00
chertus
01c8b1d7bb
decimal field extraction (from column or type)
2018-08-10 17:57:55 +03:00
Nikolai Kochetov
4a62ab9d5c
Merged with master.
2018-08-10 16:53:08 +03:00
Alexey Milovidov
36db216abf
Preparation for extra warnings [#CLICKHOUSE-2]
2018-08-10 07:02:56 +03:00
Alexey Milovidov
d8ca4345b6
Fixed style violations [#CLICKHOUSE-2]
2018-08-10 04:41:54 +03:00
chertus
479166283e
DecField (in progress)
2018-08-09 19:32:01 +03:00
chertus
2b4171af1f
remove comment
2018-08-09 15:34:10 +03:00
chertus
cc033803d1
decimale Dec128 arithm overflow
2018-08-09 15:24:03 +03:00
Nikolai Kochetov
36da1f2871
Added IFunction::isDeterministicInScopeOfQuery().
2018-08-09 13:52:46 +03:00
Nikolai Kochetov
c339313d8b
Fix LowCardinality conversions for defaults.
2018-08-09 13:52:33 +03:00
chertus
c45b5d9f9a
decimal arithm overflow (except dec128)
2018-08-08 23:15:49 +03:00
chertus
5f93ab73fa
decimal compare overflow
2018-08-08 16:57:16 +03:00
Nikolai Kochetov
0a46943590
Renamed functions makeDictionary, dictionaryIndexes, dictionaryValues to toLowCardinality, lowCardinalityIndexes, lowCardinalityValues.
2018-08-08 16:55:32 +03:00
Nikolai Kochetov
f4d9d50168
Merged with master.
2018-08-08 15:01:18 +03:00
Nikolai Kochetov
c8457abb1b
Made IFunction::isDeterministic and IFunction::isDeterministicInScopeOfQuery are const. Disabled default implementation with dictionary for not isDeterministicInScopeOfQuery functions.
2018-08-08 14:26:18 +03:00
chertus
16ad0caf37
move int exp from decimal scale to libcommon
2018-08-08 13:56:24 +03:00
chertus
297053bfac
decimal compare optimisation
2018-08-08 13:36:03 +03:00
chertus
cae97b1e59
abs for decimal
2018-08-07 17:35:21 +03:00
chertus
7984b4f91d
negate for dec128
2018-08-07 17:12:24 +03:00
chertus
de68022fc5
rewrite Decimal with own data type
2018-08-07 16:57:28 +03:00
alexey-milovidov
38c2b2c8ab
Update FunctionsHashing.h
2018-08-06 20:04:32 +03:00
chertus
c590a74981
Merge branch 'master' into decimal
2018-08-06 13:38:18 +03:00
Anton Popov
efddb89d18
Merge branch 'master' into CLICKHOUSE-3785
2018-08-06 12:42:01 +03:00
ap11
2d41b958a3
add test
2018-08-06 12:35:13 +03:00
Alexey Milovidov
0c233d668f
Removed useless file; preparations #2791
2018-08-03 21:47:44 +03:00
chertus
a338f657d5
unari arithm operations for decimal (partial support)
2018-08-03 19:32:55 +03:00
chertus
e31e4e164f
add least and greatest funcs for decimal
2018-08-03 17:46:02 +03:00