thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 07:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity
71,710 Commits 9,145 Branches 1,779 Tags 2.1 GiB
ed70ed6f71
Commit Graph

71710 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
ed70ed6f71 Introduce connection_no_wait setting for MySQL engine. 
This will allow to avoid superfluous sleep during query execution, since
this not only not desired behavoiur, but also may hang the server, since
if you will execute enough queries that will use MySQL database but will
not allow enough connections (or your MySQL server is too slow) then you
may run out of threads in the global thread pool.

Also note that right now it is possible to get deadlock when the mysql
pool is full, consider the following scenario:

- you have m1 and m2 mysql tables
- you have q1 and q2 queries, bot queries join m1 and m2
- q1 allocated connection for m1 but cannot allocate connection for m2
- q2 allocated connection for m2 but cannot allocate connection for m1
- but to resolve the lock one should give up on the locking while it is not possible right now...

And then you got no free threads and this:

    # grep -h ^202 /proc/$(pgrep clickhouse-serv)/task/*/syscall  | cut -d' ' -f2 | sort | uniq -c | sort -nr | head
       1554 0x7ffb60b92fe8 # mutex in mysqlxx::PoolWithFailover::get
       1375 0x7ffb9f1c4748 # mutex in ::PoolEntryHelper::~PoolEntryHelper from DB::MultiplexedConnections::invalidateReplica
       1160 0x7ffb612918b8 # mutex in mysqlxx::PoolWithFailover::get
         42 0x7ffb9f057984 # mutex in ThreadPoolImpl<std::__1::thread>::worker

    *NOTE: 202 is a `futex` with WAIT*

(Went with `syscall` because debugging 10k+ threads is not easy, and
eventually it may TRAP)
 2021-09-02 22:23:37 +03:00
Maksim Kita
027c531243
Merge pull request #28503 from kitaisreal/executable-multiple-pipes-added-test 
Executable multiple pipes added test
 2021-09-02 18:30:03 +03:00
robot-clickhouse
2ecfc06fbc Update version_date.tsv after release 21.8.5.7 2021-09-02 18:18:36 +03:00
robot-clickhouse
c832a41dff Update version_date.tsv after release 21.7.9.7 2021-09-02 17:37:47 +03:00
Nikolai Kochetov
af0da33147
Merge pull request #27827 from ClickHouse/more-checks-for-lv-and-native 
Add more checks for LC in native protocol.
 2021-09-02 17:27:42 +03:00
alexey-milovidov
ab3e005e6a
Merge pull request #28411 from kssenii/fix-web-disk 
Fix disk with static files a little
 2021-09-02 16:23:35 +03:00
Alexey Milovidov
03ae73a91a Drop arcadia_skip_list.txt 2021-09-02 16:19:36 +03:00
Maksim Kita
958174192b
Merge pull request #28523 from kitaisreal/borrowed-object-pool-fix-style 
BorrowedObjectPool fix style
 2021-09-02 16:18:48 +03:00
Maksim Kita
e5ee3752ef BorrowedObjectPool fix style 2021-09-02 16:18:10 +03:00
Maksim Kita
83c70a8a65
Merge pull request #28516 from kitaisreal/user-defined-function-factory-added-comments 
UserDefinedFunctionFactory added comments
 2021-09-02 14:37:25 +03:00
Maksim Kita
0a12592b50 UserDefinedFunctionFactory added comments 2021-09-02 14:37:06 +03:00
alesapin
b592400e54
Merge pull request #28404 from ClickHouse/remove_outdated_settings 
Remove obsolete settings for replicated fetches.
 2021-09-02 14:03:12 +03:00
Nikolai Kochetov
5f0b1bc4e3
Merge pull request #26286 from amosbird/projection-improve2 
Virtual projection for min max indices.
 2021-09-02 13:03:30 +03:00
alesapin
78a0cefafd
Merge pull request #28437 from ClickHouse/remove_some_tests 
Remove some rename tests
 2021-09-02 12:26:28 +03:00
Maksim Kita
3286b32499 Executable multiple pipes added test 2021-09-02 10:47:21 +03:00
Maksim Kita
befb82e441
Merge pull request #28433 from kssenii/fix-materialized-postgresql 
Fix cannot use non-ordinary table names in materialized postgresql
 2021-09-02 09:49:33 +03:00
Maksim Kita
be4c9102d8
Merge pull request #28438 from azat/udf-race-fix-v2 
Fix race in UDF (follow up)
 2021-09-01 23:57:05 +03:00
tavplubix
b5b9fd8663
Merge pull request #28446 from ClickHouse/ddlworker_fix_watch_leak 
Fix watch leak in DDLWorker
 2021-09-01 22:44:39 +03:00
Nikolay Degterinsky
53b6d918eb
Merge pull request #25310 from bharatnc/ncb/import-export-lz4 
LZ4 compression for import/export
 2021-09-01 21:12:50 +03:00
alexey-milovidov
ff0b332c24
Update custom-partitioning-key.md 2021-09-01 20:53:06 +03:00
alexey-milovidov
4699386470
Update mergetree.md 2021-09-01 20:52:05 +03:00
Kseniia Sumarokova
e7dfb0e703
Update test.py 2021-09-01 17:32:09 +03:00
Kseniia Sumarokova
a67741b626
Merge pull request #28430 from kssenii/fix-startup 
Do not allow create postgres storage with bad arguments
 2021-09-01 17:29:14 +03:00
mergify[bot]
5d299fbdee
Merge branch 'master' into remove_outdated_settings 2021-09-01 14:07:48 +00:00
mergify[bot]
91ea6a8891
Merge branch 'master' into remove_some_tests 2021-09-01 14:07:07 +00:00
Nikolai Kochetov
cdafa6fb5d
Update Fiber.h 2021-09-01 16:46:23 +03:00
mergify[bot]
143d5a169c
Merge branch 'master' into udf-race-fix-v2 2021-09-01 10:42:08 +00:00
Nikolai Kochetov
6bd9b82141
Update Fiber.h 2021-09-01 12:43:38 +03:00
Kseniia Sumarokova
d6f89fd9cf
Merge pull request #28397 from zhongyuankai/DOCSUP-13927-document-system_views 
Docsup-13927 document system views
 2021-09-01 12:35:21 +03:00
alesapin
68f6ecec62
Merge pull request #28184 from ClickHouse/trying_to_fix_fetches_test 
Better detection of the default interface in replicated fetches tests
 2021-09-01 12:21:50 +03:00
Alexander Tokmakov
f8ea865283 fix watch leak in DDLWorker 2021-09-01 12:18:28 +03:00
tavplubix
e55c0bc40a
Merging #27980 (#28413) 
* fix: empty string convert to DecimalOrNumbeOrDateOrDateTime

* fix: ifnull convert to defaut value

* fix variable name

* fix cast args

* modify ifnull args

* use short circuit

Co-authored-by: liyang830 <liyang830@jd.com>
 2021-09-01 12:12:23 +03:00
alesapin
d5c93200f3
Merge pull request #28412 from ClickHouse/more-accurate-exists-check-for-zk-init 
More accurate check that zk root exists.
 2021-09-01 11:16:42 +03:00
alesapin
fd1581aee1 Fix style 2021-09-01 10:52:33 +03:00
Azat Khuzhin
99fe4308b5 Fix race in UDF (follow up) 2021-09-01 10:38:46 +03:00
alesapin
4d94a72398 Remove some tests and make some of them lightweight 2021-09-01 10:31:45 +03:00
alesapin
383a84553e
Merge pull request #28396 from ClickHouse/add_test_for_our_friends 
Add a test for a friend
 2021-09-01 10:30:44 +03:00
alesapin
7e2cb7c8ac
Merge pull request #27538 from ClickHouse/stress-thread-fuzzer 
Enable Thread Fuzzer in Stress test
 2021-09-01 10:26:19 +03:00
Alexey Milovidov
19445ac096 Drop unused headers 2021-09-01 02:47:52 +03:00
alexey-milovidov
77d085f264
Merge pull request #27527 from evillique/log_queries_probability 
Add log_queries_probability setting
 2021-09-01 00:51:23 +03:00
alexey-milovidov
4cc0b0298c
Merge pull request #28269 from amosbird/fixweirdcode 
Better nullable primary key implementation
 2021-09-01 00:48:45 +03:00
kssenii
445b6b34fc Fix 2021-08-31 20:58:00 +00:00
alexey-milovidov
307ae344db
Merge pull request #27934 from azat/integration-tests-improve-check 
Improve server logs checking in integration tests
 2021-08-31 23:08:51 +03:00
kssenii
f9592cae11 Fix 2021-08-31 22:24:58 +03:00
Kseniia Sumarokova
63a0eb3922
Update DiskWebServer.cpp 2021-08-31 21:51:00 +03:00
Nikita Mikhaylov
f471ed4506
Merge pull request #28037 from nikitamikhaylov/settings-s3-engine 
Support `SETTINGS` clause for `S3` engine
 2021-08-31 21:08:53 +03:00
Nikita Mikhaylov
cc29130eba chmod -x 2021-08-31 18:08:02 +00:00
alesapin
2c7a51d816
Merge pull request #28366 from azat/remove-Temporary-part-fix-v2 
Fix removing of parts in a Temporary state (v2 followup)
 2021-08-31 19:13:15 +03:00
Nikolai Kochetov
487e36720c
Update src/Common/ZooKeeper/ZooKeeper.cpp 
Co-authored-by: alesapin <alesapin@gmail.com>
 2021-08-31 17:50:24 +03:00
Nikolai Kochetov
43d5ada6bd More accurate check that zk root exists. 2021-08-31 17:37:36 +03:00