Commit Graph

3413 Commits

Author SHA1 Message Date
Larry Luo
59d380c4a2 Avoid CVE-2022-40303 CVE-2022-40304 2023-02-09 12:29:42 -08:00
Suzy Wang
64313d7020
Merge branch 'master' into z-build-0120 2023-02-09 14:49:22 -05:00
bkuschel
0d61ab29f7
Update Curl to 7.87.0 2023-02-09 12:55:05 -05:00
Alexey Milovidov
d9fbf643bc
Merge pull request #45226 from hanfei1991/hanfei/gwp-asan
Introduce llvm/gwp-asan
2023-02-09 09:24:52 +03:00
Kruglov Pavel
979ccda629
Merge pull request #46139 from ClibMouse/capnproto_update_2065
update CapnProto to v0.10.3 to avoid CVE-2022-46149
2023-02-08 22:43:24 +01:00
Robert Schulze
f97880840a
Complain about missing Yasm at configure time at of build time 2023-02-08 13:17:42 +00:00
Kseniia Sumarokova
6160db6569
Merge pull request #44949 from ClibMouse/HDFS_PowerPC
Changes to support the HDFS in Power PC.
2023-02-08 12:17:15 +01:00
Robert Schulze
b79ead9c84
Move poco to base/poco/ (#46075)
* Replicate poco into base/poco/

* De-register poco submodule

* Build poco from ClickHouse

* Exclude poco from stylecheck

* Exclude poco from whitespace check

* Exclude poco from typo check

* Remove x bit from sources/headers (the style check complained)

* Exclude poco from duplicate include check

* Fix fasttest

* Remove contrib/poco-cmake/*

* Simplify poco build descriptions

* Remove poco stuff not used by ClickHouse

* Glob poco sources

* Exclude poco from clang-tidy
2023-02-08 12:04:11 +01:00
Antonio Andelic
3418a8e955 use master for aws 2023-02-08 10:07:30 +00:00
SadiHassan
b3d8dd766f update CapnProto to v0.10.3 to avoid CVE-2022-46149 2023-02-07 14:47:28 -08:00
Nikolay Degterinsky
e5b5fce970
Update liburing CmakeLists.txt 2023-02-07 18:11:43 +01:00
MeenaRenganathan22
2445a391fb Updating the libhdfs3 to reflect the revert of PR#21 2023-02-07 09:05:12 -05:00
Han Fei
0f7defb87f
Merge branch 'master' into hanfei/gwp-asan 2023-02-07 14:55:55 +01:00
HarryLeeIBM
3f78c86b31 Fix endian issue in CityHash for s390x 2023-02-06 15:51:08 -08:00
MeenaRenganathan22
e8f45ddf59 Updating the submodule to reflect the latest changes i.e revert of PR#24 2023-02-06 10:22:29 -05:00
Anton Popov
3850a1969d
Merge branch 'master' into fix-memory-leak-azure 2023-02-06 16:21:56 +01:00
MeenaRenganathan22
722e389847 Updating the submodule to the local branch HDFS_PowerPC 2023-02-03 17:45:48 -08:00
Anton Popov
e9f80c650a fix memory leak at creation of curl connection in azure sdk 2023-02-03 20:10:39 +00:00
Antonio Andelic
d5117f2aa6
Define S3 client with bucket and endpoint resolution (#45783)
* Update aws

* Define S3 client with bucket and endpoint resolution

* Add defines for ErrorCodes

* Use S3Client everywhere

* Remove unused errorcode

* Add DROP S3 CLIENT CACHE query

* Add a comment

* Fix style

* Update aws

* Update reference files

* Add missing include

* Fix unit test

* Remove unneeded declarations

* Correctly use RetryStrategy

* Rename S3Client to Client

* Fix retry count

* fix clang-tidy warnings
2023-02-03 14:30:52 +01:00
Anton Popov
cdbe145bc1
Merge pull request #45796 from CurtizJ/fix-leak-in-azure-sdk
Fix test `test_azure_blob_storage_zero_copy_replication ` (memory leak in azure sdk)
2023-02-03 14:16:19 +01:00
MeenaRenganathan22
7435ba1e3d Updating the submodule and CMakeLists.txt 2023-02-02 17:36:03 -08:00
jasperzhu
38a73c9bfe
Merge branch 'master' into iaadeflate_upgrade_qpl_v1.0.0 2023-02-02 10:20:49 +08:00
jinjunzh
d60fe99c4e Merge branch 'iaadeflate_upgrade_qpl_v1.0.0' of https://github.com/jinjunzh/ClickHouse into iaadeflate_upgrade_qpl_v1.0.0 2023-02-02 09:28:33 -05:00
jinjunzh
4089c34337 move the content of idxd-config-cmake into QPL-cmake 2023-02-02 09:26:27 -05:00
jinjunzh
40e9834313 Merge branch 'iaadeflate_upgrade_qpl_v1.0.0' of https://github.com/jinjunzh/ClickHouse into iaadeflate_upgrade_qpl_v1.0.0 2023-02-01 09:49:46 -05:00
jinjunzh
2a42c1314b Improved code detals according to suggestions 2023-02-01 09:45:06 -05:00
Robert Schulze
a92595890c
Merge pull request #45670 from HarryLeeIBM/hlee-s390x-snappy-endian
Fix endian issue in snappy lib for s390x
2023-02-01 11:55:07 +01:00
Antonio Andelic
a3e3b65b32
Merge branch 'master' into keeper-use-fallocate 2023-02-01 09:05:49 +01:00
Alexey Milovidov
bf9f62dcbd
Merge pull request #38456 from sauliusvl/iouring
Re-introduce io_uring read method
2023-02-01 06:41:32 +03:00
jasperzhu
7ee8af9123
Merge branch 'master' into iaadeflate_upgrade_qpl_v1.0.0 2023-02-01 10:42:19 +08:00
jinjunzh
3bc0c13ea0 Update QPL version from v0.3.0 to v1.0.0 2023-01-31 09:31:26 -05:00
jinjunzh
d1d5f06260 add libaccel-config as submodule and static link to QPL 2023-01-31 09:24:43 -05:00
Han Fei
716518f143
Merge branch 'master' into hanfei/gwp-asan 2023-01-31 15:01:25 +01:00
Antonio Andelic
1786237be6 Merge branch 'master' into keeper-use-fallocate 2023-01-31 13:53:47 +00:00
Robert Schulze
ffa00fc134
Merge pull request #45632 from ClibMouse/icudata_s390x_support
support icudata on s390x platform
2023-01-31 12:27:09 +01:00
jasperzhu
53ed394447
Merge branch 'master' into iaadeflate_upgrade_qpl_v1.0.0 2023-01-31 11:12:31 +08:00
Alexey Milovidov
7aa10a430a
Merge branch 'master' into hanfei/gwp-asan 2023-01-31 04:13:59 +03:00
Anton Popov
839cd614fb fix memory leak in azure sdk 2023-01-31 01:01:10 +00:00
Robert Schulze
19b3c1cc3f
Merge pull request #45519 from ClibMouse/fix_krb5_openssl
Fix krb5 for OpenSSL
2023-01-30 11:48:32 +01:00
Robert Schulze
49b7c45686
Add note about OpenSSL 2023-01-29 20:03:50 +00:00
Saulius Valatka
a7d1e62054 bump liburing 2023-01-28 21:54:44 +02:00
Saulius Valatka
fb45ed038f add liburing to build 2023-01-28 21:54:44 +02:00
MeenaRenganathan22
9f43446959 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into HDFS_PowerPC 2023-01-27 10:08:26 -05:00
Robert Schulze
dae708c588
Merge pull request #45593 from genzgd/update_poco_http
Update poco version
2023-01-27 00:08:24 +01:00
HarryLeeIBM
27857901eb Fix endian issue in snappy lib for s390x 2023-01-26 07:20:08 -08:00
Antonio Andelic
80e7dca288 Update NuRaft 2023-01-26 10:08:24 +00:00
Antonio Andelic
f02a763830
Merge pull request #45511 from ClickHouse/keeper-fix-race-asio-listener
Fix race in NuRaft's asio listener
2023-01-26 09:21:03 +01:00
bkuschel
5aa3c10c3f
Fix Cmake 2 2023-01-25 17:58:09 -05:00
SuzyWangIBMer
e3c286de29 support icudata on s390x platform 2023-01-25 22:53:03 +00:00
bkuschel
748c3ad015
Fix build error 2023-01-25 13:35:31 -05:00
bkuschel
d6d2414ef8 Remove aes.c and use the one krb5 2023-01-25 13:29:54 -05:00
bkuschel
ec1e0bde6b Update krb5 2023-01-25 13:29:54 -05:00
Antonio Andelic
e7a86998ef Fix race more 2023-01-25 11:46:59 +00:00
Antonio Andelic
7421d8f872 Merge branch 'master' into keeper-use-fallocate 2023-01-25 11:36:47 +00:00
MeenaRenganathan22
6f76ecfdb5 Committing the libhdfs3-cmake/CMakeLists.txt to include the IntelAsmCrc32c.cpp and perf_checksum.cpp 2023-01-24 20:33:25 -05:00
MeenaRenganathan22
359775a1cf Updated yhe libhdfs3 submoule 2023-01-24 20:31:33 -05:00
Geoff Genz
909cb9b6b1 Update poco version 2023-01-24 16:40:01 -07:00
MeenaRenganathan22
78a4c8a270 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into HDFS_PowerPC 2023-01-24 11:30:52 -05:00
Kruglov Pavel
689fbea759
Merge pull request #45478 from Avogar/fix-arrow-abort
Fix possible aborts in arrow lib
2023-01-24 16:37:44 +01:00
Antonio Andelic
71f754b6f6 Fix race in NuRaft 2023-01-24 11:16:55 +00:00
Suzy Wang
1176260b3c
Merge branch 'master' into z-build-0120 2023-01-24 01:14:42 -05:00
Suzy Wang
b7ba24945f fix build 2023-01-23 22:09:08 -08:00
Suzy Wang
fb46b5ed4d s390x support 2023-01-23 14:20:49 +00:00
Suzy Wang
19d26828a0 s390x build support 2023-01-20 21:16:55 +00:00
avogar
4432ee9927 Fix aborts in arrow lib 2023-01-20 16:40:33 +00:00
Han Fei
8b29f8406b
Merge branch 'master' into hanfei/gwp-asan 2023-01-20 11:03:12 +01:00
MeenaRenganathan22
f66dbf6372 Committing the CMakeLists.txt with IntelAsmCrc32c.cpp and perf_checksum.cpp 2023-01-18 13:47:16 -05:00
MeenaRenganathan22
c6c4246314 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into HDFS_PowerPC 2023-01-18 10:09:07 -05:00
Han Fei
29b20775f7 not compile gwp in non-linux environment 2023-01-17 23:06:44 +01:00
Alexander Tokmakov
e7899825e6 save format strings for DB::Exceptions 2023-01-16 23:20:33 +01:00
Nikolay Degterinsky
d414d4aa7a Merge remote-tracking branch 'upstream/master' into bcrypt 2023-01-16 22:14:03 +00:00
MeenaRenganathan22
9f571d3e93 Updating the submodules libhdfs3 and libgsasl 2023-01-16 08:28:03 -05:00
Alexander Tokmakov
2d7773fccc Merge branch 'master' into text_log_add_pattern 2023-01-13 20:33:46 +01:00
Han Fei
7feb9b7f6f Merge branch 'master' into hanfei/gwp-asan 2023-01-13 20:26:34 +01:00
MeenaRenganathan22
245bcaa75a Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into HDFS_PowerPC 2023-01-13 12:49:41 -05:00
Han Fei
214830c569 enable gwp_asan by option 2023-01-13 15:22:14 +01:00
Robert Schulze
9779d034eb
Merge pull request #45144 from ClibMouse/crc-power-fix
Changes to support the CRC32 in PowerPC.
2023-01-13 11:24:18 +01:00
Han Fei
f5e736e240 introduce llvm/gwp-asan 2023-01-12 15:00:26 +01:00
Antonio Andelic
6a0e481ed7 Merge branch 'master' into keeper-use-fallocate 2023-01-12 13:57:05 +00:00
alesapin
3245e822ef Update merge 2023-01-12 12:55:50 +01:00
MeenaRenganathan22
28d5c3cf7f Addressed the review comments 2023-01-11 17:00:10 -08:00
alesapin
e581a56ed0 Better 2023-01-11 15:30:48 +01:00
alesapin
fe8f373aa6 Less stupid tests 2023-01-11 15:20:18 +01:00
MeenaRenganathan22
25c94dfa83 Changes to support the CRC32 in PowerPC to address the WeakHash collision issue. Update the reference to support the hash values based on the specific platform 2023-01-10 21:20:13 -08:00
Meena Renganathan
ba5111905e Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into HDFS_PowerPC 2023-01-10 19:13:13 -05:00
alesapin
9b16b3f48f Fix potential memory leak 2023-01-11 01:03:01 +01:00
Alexey Milovidov
4995ce945e Fix TSan report in SQLite (false positive) 2023-01-08 05:40:48 +01:00
Alexey Milovidov
77708b4a03 Update SQLite 2023-01-08 05:22:56 +01:00
Ilya Yatsishin
2703b47d31
Merge pull request #44942 from vitlibar/fix-memory-leak-in-aws-init
Fix memory leak in Aws::InitAPI
2023-01-06 12:12:46 +01:00
Vitaly Baranov
239734ceb6 Fix memory leak in Aws::InitAPI. 2023-01-06 00:40:18 +01:00
Meena Renganathan
06e44827a3 Added the file DataReader.cpp in source list when the HDFS submodule has been updated to the latest commit 2023-01-05 15:21:31 -05:00
Meena Renganathan
ba0edb310f Changes to support the HDFS in PowerPC 2023-01-05 15:21:14 -05:00
Yakov Olkhovskiy
1be48f706b
Merge pull request #43706 from ClibMouse/s390x_crc32
s390x weakhash32 support
2023-01-05 14:45:20 -05:00
Robert Schulze
a4322b3057
Merge pull request #44894 from ClickHouse/upgrade-googletest
Upgrade googletest to latest HEAD
2023-01-04 21:49:56 +01:00
Nikolay Degterinsky
aa52956412 Add bcrypt authentification type 2023-01-04 15:33:16 +00:00
alesapin
92255e5d4b
Merge pull request #43020 from vitlibar/update-aws-c-submodules
Update aws-c* submodules
2023-01-04 16:25:22 +01:00
Robert Schulze
23196ceffd
Upgrade googletest to their lastest main state 2023-01-04 10:44:39 +00:00
Nikolay Degterinsky
57b3fbf206 Fix build 2023-01-04 02:24:14 +00:00
Nikolay Degterinsky
c6daf0a6eb Merge remote-tracking branch 'upstream/master' into ulid 2023-01-03 19:58:50 +00:00
Robert Schulze
27f5aad49e
What happens if I remove 156 lines of code? 2023-01-03 18:51:16 +00:00
Robert Schulze
cfb6feffde
What happens if I remove these 139 lines of code? 2023-01-03 18:35:31 +00:00
Antonio Andelic
14355d8009 Merge branch 'master' into keeper-use-fallocate 2023-01-02 08:22:27 +00:00
Vitaly Baranov
9014be8968 Fix disable loading EC2 metadata by aws-sdk-core. 2022-12-29 12:26:43 +01:00
Nikolay Degterinsky
7bb8db4bb3 Add generateULID function 2022-12-28 00:54:50 +00:00
avogar
5c42b78766 Forbid paths in timezones in cctz lib 2022-12-27 17:52:38 +00:00
Alexey Milovidov
3342b84321
Merge pull request #44569 from ClickHouse/stack-traces-debug-build
Fix extremely slow stack traces in debug build
2022-12-27 14:31:35 +03:00
Vitaly Baranov
c7e1aa2ea0 Fix finding pthread_atfork() while linking ppc64le build. 2022-12-25 18:24:35 +01:00
Vitaly Baranov
dffeb2a54a Disable memory sanitizer for events from epoll 2022-12-25 18:24:35 +01:00
Vitaly Baranov
fea3a6280c Fix race condition in cJSON_Parse.* calls. 2022-12-25 18:24:35 +01:00
Vitaly Baranov
e23c42d042 Fix checking for embedded error in PocoHTTPClient. 2022-12-25 18:24:35 +01:00
Vitaly Baranov
1eb0d5db16 Disable loading EC2-metadata. 2022-12-25 18:24:35 +01:00
Vitaly Baranov
f8f598e298 Correctly handle that dlopen(NULL) returns NULL in ClickHouse. 2022-12-25 18:24:35 +01:00
Vitaly Baranov
8efb1ae7bb Fix support for boringssl. 2022-12-25 18:24:35 +01:00
Vitaly Baranov
665813e127 Remove subsubmodules contrib/aws/crt and contrib/aws-crt-cpp/crt
because they were moved to the contrib folder.
2022-12-25 18:24:35 +01:00
Vitaly Baranov
8e53b54082 Update AWS SDK to version 1.10.36 2022-12-25 18:24:35 +01:00
Vitaly Baranov
fa722c6cd8 Switch "contrib/sysroot" back to master. 2022-12-25 10:50:45 +01:00
Alexey Milovidov
4651a538a8 Fix extremely slow stack traces in debug build 2022-12-24 20:31:04 +01:00
Alexander Tokmakov
93509395fb add a column with a message pattern to text_log 2022-12-23 15:06:30 +01:00
Antonio Andelic
fcb78cd1d7 Update NuRaft 2022-12-19 12:05:15 +00:00
Alexey Milovidov
a3dc5e8b0a
Merge pull request #44132 from azat/bump-libdivide
Bump libdivide (to gain some new optimizations)
2022-12-17 04:07:08 +03:00
Azat Khuzhin
92d70c66e8 corrosion: export path to FindRust.cmake in CMAKE_MODULE_PATH
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 20:58:09 +01:00
Azat Khuzhin
440aa50588 corrosion: clean rules (remove useless message)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-14 20:57:01 +01:00
Azat Khuzhin
67fa185611
Revert "Builtin skim" 2022-12-14 17:17:19 +03:00
Azat Khuzhin
cdfe62f303 Update libdivide
This will includes at least [1].

  [1]: https://github.com/ridiculousfish/libdivide/pull/94

v2: Define LIBDIVIDE_* macros mutually exclusive
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-13 10:45:01 +01:00
Suzy Wang
093dc95d0f
Merge branch 'master' into s390x_crc32 2022-12-12 09:39:29 -05:00
Azat Khuzhin
67eab36086 corrosion-cmake: clean rules
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-11 15:51:37 +01:00
Alexey Milovidov
9a48cf0da8
Merge pull request #40422 from pkubaj/patch-1
Add FreeBSD/powerpc64le support
2022-12-11 09:38:04 +03:00
Alexey Milovidov
03648ab5a9
Merge pull request #43991 from ClibMouse/openssl_support
Add OpenSSL option to Clickhouse
2022-12-11 07:59:23 +03:00
Suzy Wang
1903a1b645
Merge branch 'master' into s390x_enable_base64 2022-12-09 16:15:39 -05:00
Suzy Wang
802f633f39
Merge branch 'master' into s390x_crc32 2022-12-09 15:00:46 -05:00
Boris Kuschel
cc3314acbe
Merge branch 'master' into openssl_support 2022-12-08 07:40:43 -05:00
Nikita Taranov
b81ad6aaf7
Add google benchmark to contrib (#43779)
* add google benchmark to contrib

* rework integer_hash_tables_and_hashes

* update readme

* keep benchmarks near the benchmarked code

* fix fasttests build

* rm old target

* fix
2022-12-08 13:38:08 +01:00
jinjunzh
47c3508337 fixed build issues for QPL 0.3.0 2022-12-07 16:41:12 -05:00
Boris Kuschel
f03f95044e OpenSSL code changes 2022-12-07 13:22:46 -05:00
Boris Kuschel
623f23f55d OpenSSL cmake changes 2022-12-07 13:22:46 -05:00
Boris Kuschel
6591e804c5 Add cmake support for openssl 2022-12-07 13:22:46 -05:00
Boris Kuschel
daab1fde8f Add OpenSSL submodule 2022-12-07 13:22:46 -05:00
Suzy Wang
75a298a275 fix cmake 2022-12-06 14:02:22 -08:00
jinjunzh
5206816b6c Update contrib/qpl to latest v0.3.0 2022-12-06 16:10:13 -05:00
Antonio Andelic
2623804dc5 Update NuRaft 2022-12-02 08:17:48 +00:00
Suzy Wang
e34af8602c
Merge branch 'master' into s390x_crc32 2022-12-01 11:02:43 -05:00
Suzy Wang
be16e0bce7 Include crc32_s390x as a submodule library 2022-12-01 07:43:32 -08:00
Antonio Andelic
c12c0cc8af Merge branch 'master' into parallel-log-appending 2022-12-01 08:53:52 +00:00
Antonio Andelic
0921356e91
Merge branch 'master' into parallel-log-appending 2022-11-30 09:42:38 +01:00
Alexey Milovidov
54e27d4230
Merge branch 'master' into build-libcxx-and-libcxxabi-from-llvm-project 2022-11-30 00:25:25 +01:00
Alexander Gololobov
e94ac23a4e Update Poco 2022-11-29 15:03:52 +01:00
Robert Schulze
829958e13a
Merge branch 'master' into build-libcxx-and-libcxxabi-from-llvm-project 2022-11-28 16:09:14 +01:00
Antonio Andelic
599f381217
Merge branch 'master' into parallel-log-appending 2022-11-26 09:04:27 +01:00
Nikita Taranov
d1c258cf20
Add xxh3 hash function (#43411)
* impl

* try fix

* add docs

* add test

* rm unused file

* excellent
2022-11-26 00:14:08 +01:00
Antonio Andelic
f79af2aea7 Merge branch 'master' into parallel-log-appending 2022-11-24 11:13:04 +00:00
Antonio Andelic
2d2c6eee30 Update NuRaft 2022-11-21 15:06:33 +00:00
Suzy Wang
d1a2af8670 Enable base64 on s390x platform 2022-11-16 13:01:10 -08:00
Azat Khuzhin
ddfea23804 Do not include libcxx library for C
If you will have the same header in both libraries you may have some
tricky failures.

And there is at least one header that exists in both: stdatomic.h

Right now there is a workaround for this header, that allows to use C++
version of this header for C - the workaround is called "set
_LIBCPP_COMPILER_CLANG_BASED not only for CXX" [1] and use include_next
[2].

  [1]: 9a457ab3c6/include/__config (L39)
  [2]: 9a457ab3c6/include/stdatomic.h (L223-L231)

However #42730 changes this, and now it fails to compile because of this.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-11-11 14:43:14 +01:00
Antonio Andelic
25b19e6ba0
Merge branch 'master' into manual_snapshot_for_keeper 2022-11-03 08:55:01 +01:00
Robert Schulze
c8068bdfa2
Merge pull request #42816 from azat/build/llvm-fix
Fix compilation of LLVM with cmake cache
2022-11-01 08:22:06 +01:00
Azat Khuzhin
b62170426a Fix compilation of LLVM with cmake cache
Simple reproducer:

    $ cmake
    $ ninja contrib/llvm-project/llvm/lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/MasmParser.cpp.o # will have -std=c++14
    $ touch CMakeLists.txt
    $ cmake
    $ ninja contrib/llvm-project/llvm/lib/MC/MCParser/CMakeFiles/LLVMMCParser.dir/MasmParser.cpp.o # will have -std=c++20 and fail
    (fails because std::vector cannot work with opaque types anymore)

Fixes: #42249 (cc @rschu1ze)
2022-10-31 10:56:05 +01:00
Alexey Milovidov
25d35a97f9 Update CCTZ to 2022f 2022-10-29 18:10:33 +02:00
Sema Checherinda
df3e4d26ad
Merge pull request #42463 from ClibMouse/update_zlib
Update zlib-ng to latest commit
2022-10-27 12:45:23 +02:00
Robert Schulze
a9427888be
Build libcxx and libcxxabi from llvm-project
Resolves #42245
2022-10-27 09:55:27 +00:00
Robert Schulze
31ef6c66cb
Merge pull request #42513 from ClickHouse/update-libcxx-to-15
Build with libcxx(abi) 15
2022-10-27 10:30:36 +02:00
Alexey Milovidov
8a56beb74a
Merge branch 'master' into update_zlib 2022-10-25 08:55:44 +02:00
Alexey Milovidov
c48127534b
Merge pull request #41753 from pkit/morton_coding
add Morton Coding (ZCurve)
2022-10-25 06:10:37 +02:00
Alexey Milovidov
dcf45e83a9
Merge branch 'master' into update_zlib 2022-10-25 05:08:09 +02:00
Robert Schulze
240637f8f1
Merge branch 'master' into update-libcxx-to-15 2022-10-24 11:11:01 +02:00
Robert Schulze
7243e12ef8
Fix build 2022-10-24 07:42:20 +00:00
Alexey Milovidov
729692f862
Merge pull request #42462 from ClibMouse/power_build_fix
Fix power8+ support add power9+ support
2022-10-24 09:30:38 +02:00
Robert Schulze
c119cd2f00
Merge branch 'master' into update-libcxx-to-15 2022-10-24 08:29:37 +02:00
JackyWoo
39c88c74e8 check whether last manually created snapshot is done 2022-10-22 22:31:17 +08:00
Yakov Olkhovskiy
d285c9e7ff move libfuzzer to dedicated contrib/libfuzzer-cmake 2022-10-21 14:04:01 +00:00
Yakov Olkhovskiy
bd33c4f180 add lib_fuzzer and lib_fuzzer_no_main to llvm-project build 2022-10-21 01:25:51 +00:00
Robert Schulze
eda3955f01
Update libcxx submodule 2022-10-20 14:50:51 +00:00
Robert Schulze
820e6b4276
Build with libcxx(abi) 15 2022-10-20 10:52:43 +00:00
Constantine Peresypkin
5b3b11b517 add Morton Coding (ZCurve) 2022-10-19 15:59:25 +02:00
Boris Kuschel
4645d465b1
update zlib-ng to latest 2022-10-18 17:38:06 -05:00
Boris Kuschel
e45c800cdf Fix power8+ support add power9+ support 2022-10-18 17:14:43 -05:00
Alexey Milovidov
87296eb90b Update CCTZ to 2022e. 2022-10-14 22:01:26 +02:00
Dom Del Nano
6bbbbda868 Update cctz to pull in upstream 2022e changes 2022-10-12 21:46:51 -07:00
Robert Schulze
50ae7d8484
Merge branch 'master' into cleanup-llvm 2022-10-12 10:02:55 +02:00
Robert Schulze
c08387eb0d
Minor cleanups of LLVM integration 2022-10-11 14:18:52 +00:00
Raúl Marín
dbed82e74c Fix LLVM build 2022-10-10 12:18:05 +02:00
Maksim Kita
4eb29f7428 Updated submodule 2022-10-07 10:55:08 +02:00
Alexey Milovidov
25d13b89e9
Merge pull request #41142 from MeenaRenganathan22/OpenSSL_InHouse
Changes to support the OpenSSL In-house build.
2022-10-05 23:02:04 +03:00
Kseniia Sumarokova
46c20a7197
Merge pull request #42031 from kssenii/update-amqp
Update amqp-cpp
2022-10-05 12:06:58 +02:00
Kseniia Sumarokova
7935337513
Update CMakeLists.txt 2022-10-04 19:59:08 +02:00
Robert Schulze
af8d32bb1f
Merge pull request #42023 from ClickHouse/llvm-without-clothes
Build against an LLVM version which has clang[-extra-tools], lldb and lld removed
2022-10-04 17:13:50 +02:00
Kseniia Sumarokova
aacb314a41
Update cmake 2022-10-04 16:15:33 +02:00
kssenii
620b0673d0 Update AMQP 2022-10-03 17:24:57 +02:00
Vitaly Baranov
65c61877c7
Merge pull request #33435 from BoloniniD/BLAKE3
Integrating Rust code into ClickHouse
2022-10-03 15:25:06 +02:00
Robert Schulze
aadb999913
Build against an LLVM version which has clang[-extra-tools], lldb and lld removed
Saves ca. 600 MB of disk space
2022-10-03 12:44:11 +00:00
Robert Schulze
aa9373c9c2
Merge pull request #41951 from ClickHouse/llvm-14
Bump LLVM from 13 to 14
2022-10-03 12:34:31 +02:00
BoloniniD
92e6bf57dc Remove old if-statement in corrosion-cmake 2022-10-02 22:29:47 +03:00
BoloniniD
a3c0b8e815
Fix CMake style in corrosion-cmake
Co-authored-by: Vitaly Baranov <vitlibar@yandex.ru>
2022-10-02 21:25:10 +03:00
Alexey Milovidov
2194c549ba
Merge pull request #41974 from ClibMouse/enable_base64_ppc64le
Enable lib base64 for powerpc platform
2022-10-01 18:10:08 +03:00
root
7e4edfeb5a Merge branch 'master' of https://github.com/MeenaRenganathan22/ClickHouse into OpenSSL_InHouse 2022-09-30 15:50:46 -07:00
root
4318ec125e Merge branch 'master' of https://github.com/MeenaRenganathan22/ClickHouse into OpenSSL_InHouse 2022-09-30 15:50:22 -07:00
root
bb1771e159 Update the macro ENABLE_CH_BUNDLE_BORINGSSLL to ENABLE_EXTERNAL_OPENSSL 2022-09-30 10:35:49 -07:00
BoloniniD
758d4b79fb Fix submodules 2022-09-30 20:31:01 +03:00
Suzy Wang
29c8023b7f Enable lib base64 for powerpc platform 2022-09-30 07:04:47 -07:00
Robert Schulze
4ac308a7a6
Update submodule + fix compile error 2022-09-30 09:23:41 +00:00
BoloniniD
55c79230b3 Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3 2022-09-29 23:53:25 +03:00
Robert Schulze
32f0aa75e6
Bump to LLVM 14 2022-09-29 19:16:11 +00:00
Robert Schulze
a300ea6024
Try to fix binary compatibility check + extend check to library-bridge 2022-09-28 09:56:58 +00:00
Robert Schulze
9c62797d28
Bump LLVM from 12 to 13 2022-09-26 07:13:46 +00:00
Nikolay Degterinsky
6edf8ec3f2 Better S3 logs 2022-09-22 22:34:13 +00:00
BoloniniD
7642212ff8 Fix find_package(Rust) for corrosion-cmake 2022-09-22 21:53:55 +03:00
Alexey Milovidov
33c751a561
Merge pull request #41603 from ClickHouse/cut-openldap
Update OpenLDAP library
2022-09-22 07:26:01 +03:00
Alexey Milovidov
2d6350b114 Update OpenLDAP library 2022-09-21 06:27:10 +02:00
Filatenkov Artur
2139d5be17
Merge branch 'master' into annoy 2022-09-20 15:28:08 +03:00
FArthur-cmd
14c963e4ee update submodule 2022-09-20 11:29:13 +03:00
BoloniniD
55fcb98f29 Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3 2022-09-19 21:53:14 +03:00
BoloniniD
4f2915c8f7 Fix aarch64-darwin build 2022-09-19 21:52:57 +03:00
BoloniniD
5b4fb4bf66
Merge branch 'master' into BLAKE3 2022-09-18 23:14:37 +03:00
BoloniniD
7b5d3e3d82 Fix Rust installation for Corrosion 2022-09-18 23:14:16 +03:00
Alexey Milovidov
3eb7ee8308 Remove noise from build process 2022-09-18 10:35:25 +02:00
Alexey Milovidov
7e93dbfcd6
Merge pull request #41094 from HarryLeeIBM/hlee-s390x-zlib-ng
Fix zlib-ng build issue for s390x
2022-09-18 07:55:20 +03:00
Alexey Milovidov
59d05b949b
Merge branch 'master' into bump-replxx 2022-09-17 22:49:34 +03:00
BoloniniD
627dea333e Merge branch 'master' into BLAKE3 2022-09-17 22:14:30 +03:00
Alexander Tokmakov
42dab6dc02 Revert "Merge pull request #38200 from ClickHouse/keeper-linearizable-reads"
This reverts commit 222b964070, reversing
changes made to da01982652.
2022-09-17 19:22:58 +02:00
BoloniniD
1c0047dbff Review fixes 2022-09-17 16:34:19 +03:00
Alexey Milovidov
cb45f51e51
Merge branch 'master' into bump-replxx 2022-09-17 03:22:10 +03:00
BoloniniD
452ef4435b Merge branch 'master' of github.com:ClickHouse/ClickHouse into BLAKE3 2022-09-16 20:05:56 +03:00
Robert Schulze
545893f56a
Merge pull request #41239 from ClickHouse/bundled-c-ares
Bundle c-ares 3rd-party library
2022-09-16 12:06:54 +02:00
Antonio Andelic
222b964070
Merge pull request #38200 from ClickHouse/keeper-linearizable-reads
Keeper faster linearizable reads
2022-09-16 07:58:52 +02:00
Alexey Milovidov
da01982652
Merge pull request #41046 from azat/build/llvm-15
Switch to llvm/clang 15
2022-09-16 07:31:06 +03:00
Robert Schulze
2b9938fb3a
Merge branch 'master' into bundled-c-ares 2022-09-16 02:15:19 +02:00
BoloniniD
0df426d329 Corrosion fixes + review fixes 2022-09-16 00:05:21 +03:00
Antonio Andelic
761d53b438 Use merged NuRaft 2022-09-15 16:14:45 +00:00
Antonio Andelic
0dbd0c1f72 Merge branch 'master' into keeper-linearizable-reads 2022-09-15 16:03:18 +00:00
Robert Schulze
065e668182
Merge branch 'master' into bundled-c-ares 2022-09-14 09:31:06 +02:00
Robert Schulze
5aedf60689
fix: repair aarch64 build 2022-09-13 20:51:51 +00:00
Robert Schulze
fb5812f554
Bump vectorscan to 5.4.8
Brings good stuff like
- https://github.com/VectorCamp/vectorscan/pull/119
- https://github.com/VectorCamp/vectorscan/pull/118
2022-09-13 17:06:09 +00:00
Robert Schulze
d2d6e6787b
style: remove obsolete comments 2022-09-13 17:42:57 +02:00
Robert Schulze
5fcad783d2
fix: make musl build work 2022-09-13 07:21:27 +00:00
Robert Schulze
134def1cff
build: bundle c-ares 2022-09-12 20:36:35 +00:00
BoloniniD
147dfac11e Try using Corrosion 2022-09-12 23:05:41 +03:00
Meena Renganathan
51d6611b96 Committing the ClickHouse core changes and other libraries to support OpenSSL. BoringSSL is still set as default 2022-09-12 09:05:38 -07:00
Alexey Milovidov
485262991e
Merge pull request #41033 from ClickHouse/regen-vectorscan-assets
Regenerate vectorscan assets with latest and greatest ragel/colm
2022-09-11 22:57:39 +03:00
Azat Khuzhin
3c47d5bbff Add a workaround for strerror_r() libpq for FreeBSD (for clang-15)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:35 +02:00
Azat Khuzhin
38c0b0ee50 Add a workaround for krb5 and musl for strerror_r()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:35 +02:00
Azat Khuzhin
0bb835c66e Add a workaround for clang-15 in libpq for strerror_r()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:35 +02:00
Azat Khuzhin
95b3a02779 Fix strerror_r() configuration for jemalloc with musl under clang-15
Build error [1]:

    Sep 06 18:40:53 FAILED: contrib/jemalloc-cmake/CMakeFiles/_jemalloc.dir/__/jemalloc/src/malloc_io.c.o
    Sep 06 18:40:53 /usr/bin/ccache /usr/bin/clang-15 --target=x86_64-linux-musl --sysroot=/build/cmake/linux/../../contrib/sysroot/linux-x86_64-musl -DHAS_RESERVED_IDENTIFIER -DJEMALLOC_NO_PRIVATE_NAMESPACE -DJEMALLOC_PROF=1 -DJEMALLOC_PROF_LIBGCC=1 -DSTD_EXCEPTION_HAS_STACK_TRACE=1 -DUSE_MUSL=1 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -D_LIBCPP_HAS_MUSL_LIBC=1 -I../contrib/jemalloc/include -isystem ../contrib/jemalloc-cmake/include -isystem contrib/jemalloc-cmake/include_linux_x86_64_musl/jemalloc/internal -isystem ../contrib/libcxx/include -isystem ../contrib/libcxxabi/include -isystem ../contrib/libunwind/include --gcc-toolchain=/build/cmake/linux/../../contrib/sysroot/linux-x86_64-musl --gcc-toolchain=/build/cmake/linux/../../contrib/sysroot/linux-x86_64-musl -fdiagnostics-color=always -Xclang -fuse-ctor-homing  -gdwarf-aranges -pipe -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt -fasynchronous-unwind-tables -ffile-prefix-map=/build=. -falign-functions=32 -mbranches-within-32B-boundaries  -fdiagnostics-absolute-paths -fexperimental-new-pass-manager -w -O2 -g -DNDEBUG -O3 -g -gdwarf-4  -flto=thin -fwhole-program-vtables -fno-pie   -D OS_LINUX -D_GNU_SOURCE -Werror -std=gnu11 -MD -MT contrib/jemalloc-cmake/CMakeFiles/_jemalloc.dir/__/jemalloc/src/malloc_io.c.o -MF contrib/jemalloc-cmake/CMakeFiles/_jemalloc.dir/__/jemalloc/src/malloc_io.c.o.d -o contrib/jemalloc-cmake/CMakeFiles/_jemalloc.dir/__/jemalloc/src/malloc_io.c.o   -c ../contrib/jemalloc/src/malloc_io.c
    Sep 06 18:40:53 /build/contrib/jemalloc/src/malloc_io.c💯8: error: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion]
    Sep 06 18:40:53         char *b = strerror_r(err, buf, buflen);
    Sep 06 18:40:53               ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Sep 06 18:40:53 1 error generated.

  [1]: https://s3.amazonaws.com/clickhouse-builds/41046/0e9265ad951d40cdce3716fb8a679360b2e0c156/package_release/build_log.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:35 +02:00
Azat Khuzhin
32d9bb5a7e Update sentry for clang-15 (to fix __msan_unpoison())
CI: https://s3.amazonaws.com/clickhouse-builds/41046/0e9265ad951d40cdce3716fb8a679360b2e0c156/package_msan/build_log.log
Refs: https://github.com/ClickHouse/sentry-native/pull/5
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:34 +02:00
Azat Khuzhin
aed0897e77 Update libcpuid for clang-15 (for snprintf())
CI: https://s3.amazonaws.com/clickhouse-builds/41046/0e9265ad951d40cdce3716fb8a679360b2e0c156/binary_freebsd/build_log.log
Refs: https://github.com/ClickHouse/libcpuid/pull/2
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:34 +02:00
Azat Khuzhin
e1cfde8a86 Update librdkafka for clang-15 (do not set _POSIX_C_SOURCE on FreeBSD)
Refs: https://github.com/ClickHouse/librdkafka/pull/7
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:34 +02:00
Azat Khuzhin
50cc4a6a1f Update llvm to add ability to preserve debug symbols
There are some issues with JIT, you will find details in a patch that
disables one function for it, and it will be great to have an ability to
get full backtrace for this problem during investigations.

Refs: https://github.com/ClickHouse/llvm/pull/9
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-10 21:38:34 +02:00
Azat Khuzhin
c214875a36 Bump replxx to fix possible uncaught exception
Refs: https://github.com/ClickHouse/replxx/pull/24
2022-09-09 22:02:45 +02:00
Azat Khuzhin
62a105f216 Update capnproto to v0.10.2 (to address issue with ASan in clang-15)
This should address issue with ASan:

- CI report - https://s3.amazonaws.com/clickhouse-test-reports/41046/490a2c75610c4bc3191d55226f8454b3c3d3919a/stateless_tests__asan__[1/2].html

    2022-09-08 19:39:40 kj/exception.c++:977: failed: expected offset < 65536 && offset > -65536; ExceptionCallback must be allocated on the stack.

- Discussion in ML - https://www.mail-archive.com/capnproto@googlegroups.com/msg01451.html

- Fix capnproto/capnproto@c4eef80a13

    "Fix ASAN problems under Clang 15.

    It appears ASAN now by default tries to detect stack-use-after-return. This breaks our assumptions in requireOnStack() and totally breaks fibers.

    For requireOnStack() we can just skip the check in this case.

    For fibers, we need to implement the ASAN hints to tell it when we're switching fibers."

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-09 19:56:25 +02:00
BoloniniD
e8bcbcd016
Merge branch 'master' into BLAKE3 2022-09-09 11:48:31 +03:00
BoloniniD
ff82784b91 Fix MSAN test 2022-09-08 23:41:18 +03:00
Robert Schulze
0df6173e4a
Merge remote-tracking branch 'origin/master' into regen-vectorscan-assets 2022-09-08 08:37:30 +00:00
BoloniniD
c08b41b611 Clean files and compatibility code 2022-09-08 09:34:59 +03:00
Robert Schulze
9b868f8b7d
doc: add note about upstream colm/ragel 2022-09-07 20:10:17 +00:00
Robert Schulze
151bf1e074
fix: suppress warnings for ARM ragel assets 2022-09-07 20:08:31 +00:00
HarryLeeIBM
af603f9ac6 Fix zlib-ng build for s390x 2022-09-07 12:20:39 -07:00
Robert Schulze
d1d6e5cb23
fix: build ragel assets for amd64 and aarch64 separately 2022-09-07 11:56:09 +00:00
Antonio Andelic
61398cee80 Merge branch 'master' into keeper-linearizable-reads 2022-09-07 10:25:35 +00:00
Robert Schulze
c4297c6c99
fix: disable narrowing warnings 2022-09-06 22:02:02 +00:00
Robert Schulze
0e363ca6e3
chore: regenerate vectorscan assets with ragel/colm head 2022-09-06 21:15:30 +00:00
BoloniniD
d635c3f9be Disable BLAKE3 for aarch64-darwin 2022-09-06 21:22:40 +03:00
Robert Schulze
cc1bd3ac36
fix: disable vectorscan when building w/o SSE >=3 2022-09-06 16:15:50 +00:00
Filatenkov Artur
7949b3fb74
Merge branch 'master' into annoy 2022-09-06 11:23:15 +03:00
FArthur-cmd
7f311ad03c add words about setting to docs 2022-09-05 13:20:49 +00:00
FArthur-cmd
9096b73084 add setting 2022-09-05 12:41:46 +00:00
Kruglov Pavel
582216a3ca
Merge pull request #39919 from pzhdfy/UniqSketch
UniqThetaSketch support set operation such as union/intersect/not
2022-09-05 13:42:14 +02:00
Antonio Andelic
110ad53300 Merge branch 'master' into keeper-linearizable-reads 2022-09-05 07:12:45 +00:00
alesapin
3da9e8646d
Merge pull request #40941 from ClickHouse/keeper-fix-shutdown-increase-request-size
Fix in Keeper shutdown during long commit and increase allowed request size
2022-09-04 13:39:33 +02:00
Antonio Andelic
396500aaa7 Update NuRaft 2022-09-02 13:14:33 +00:00
Azat Khuzhin
dd8478422a Fix usage of generator expressions for libcxx cmake
Before, if you store clickhouse sources in /src, there was a typo and it
produce the following error:

    CMake Error in contrib/libcxx-cmake/CMakeLists.txt:
      Target "cxx" INTERFACE_INCLUDE_DIRECTORIES property contains path:

        "/src"

      which is prefixed in the source directory.

Also move "src" into PRIVATE, since it is required only for libcxx
itself.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-09-02 14:21:43 +02:00
Fangyuan Deng
bc7d661668
Merge branch 'master' into UniqSketch 2022-09-01 19:31:53 +08:00
Antonio Andelic
9acb253334 Update NuRaft 2022-09-01 08:44:20 +00:00
Antonio Andelic
91aff95298 Merge branch 'master' into keeper-linearizable-reads 2022-09-01 08:43:50 +00:00
Filatenkov Artur
899a2e29df
Enable UBsan 2022-08-31 16:44:52 +03:00
Antonio Andelic
97fd3d9123
Merge branch 'master' into fix-install-snapshot 2022-08-31 08:42:00 +02:00
Fangyuan Deng
5c2f35c302
Merge branch 'master' into UniqSketch 2022-08-31 10:23:46 +08:00
FArthur-cmd
941cceda7f fix build 2022-08-30 23:09:22 +00:00
FArthur-cmd
c7d31c3a90 fix indexes for ColumnArray 2022-08-30 15:32:05 +00:00
FArthur-cmd
e7abc06c89 Revert "Revert "Add Annoy index""
This reverts commit 6fdfb964d0.
2022-08-30 15:26:56 +00:00
Alexander Tokmakov
6fdfb964d0
Revert "Add Annoy index" 2022-08-30 15:10:10 +03:00
pzhdfy
92f88c1429 update datasketches-cpp 2022-08-30 20:02:47 +08:00
Alexander Tokmakov
44c6c85f75
Merge pull request #40756 from ClickHouse/libuv_update
Merging #39398
2022-08-30 14:38:50 +03:00
Alexander Tokmakov
ff2db8e2a7 update submodule 2022-08-29 16:46:21 +02:00
FArthur-cmd
c6e45fe690 remove build with UBSan 2022-08-29 09:18:15 +00:00
Antonio Andelic
b4af21b6fb Small fixes 2022-08-29 07:06:51 +00:00
FArthur-cmd
f3d0083e57 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into annoy-2 2022-08-26 13:53:53 +00:00
Antonio Andelic
dae65178b7 Improve preprocessing performance 2022-08-26 10:46:14 +00:00
Antonio Andelic
4bbcbda7cc NuRaft fix for install snapshot 2022-08-25 14:12:17 +00:00
BoloniniD
78d00c3371 Add glibc symbols to glibc_compatibility 2022-08-24 21:30:48 +03:00
Antonio Andelic
073b168b31 add msg type string for leader status 2022-08-24 07:50:08 +00:00
Antonio Andelic
99d23cb67e Merge branch 'master' into keeper-linearizable-reads 2022-08-23 07:03:20 +00:00
BoloniniD
c7a6c4d56f Test with Ubuntu 14.04 static libs 2022-08-22 20:09:37 +03:00
Antonio Andelic
af02c76a3c
Merge branch 'master' into keeper-listen-host 2022-08-21 18:43:55 +02:00
FArthur-cmd
1e8910f048 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into annoy-2 2022-08-21 08:45:03 +00:00
pkubaj
17f757a94c Add FreeBSD/powerpc64le support 2022-08-19 21:41:03 +02:00
BoloniniD
a30d43ba19 Add RUSTFLAGS to link crates to glibc 2022-08-19 21:45:19 +03:00
Suzy Wang
c273ef125d
Merge branch 'master' into libuv_update 2022-08-18 16:30:52 -04:00
BoloniniD
256d4a5e61 Move -l rustc flag out of target part 2022-08-18 23:26:44 +03:00
Alexey Milovidov
aaf6a3c862
Merge pull request #40184 from ClickHouse/update-cctz
Update cctz
2022-08-18 10:13:04 +03:00
Antonio Andelic
26b7117b6c Merge branch 'master' into keeper-listen-host 2022-08-18 07:05:20 +00:00
BoloniniD
eba479101a Fix glibc compat 2022-08-17 21:03:35 +03:00
Suzy Wang
9d14397a2a rm duplicated declaration 2022-08-17 08:15:08 -07:00