Commit Graph

5202 Commits

Author SHA1 Message Date
Alexander Tokmakov
fdf3cf378f fix testkeeper multi response 2021-04-13 15:49:40 +03:00
Nikolai Kochetov
9b67067f05 Fix flappy test. 2021-04-13 11:53:23 +03:00
Maksim Kita
305d3d6b16
Merge pull request #22978 from ClickHouse/filter-by-virtual-columns-fix
Fix trivial mistake in filtering by virtual columns
2021-04-13 11:42:16 +03:00
Maksim Kita
e687fc320f
Merge pull request #22997 from ClickHouse/increase-max-uri-size
Increase `max_uri_size` to 1 MiB by default
2021-04-13 11:26:23 +03:00
Nikolai Kochetov
e731dfe650
Merge pull request #22991 from ClickHouse/untuple-and-subquery
Fix subquery with untuple.
2021-04-13 09:53:13 +03:00
songenjie
fbd26789af [test] show privileges 2021-04-13 14:08:26 +08:00
hexiaoting
77c460e8d1 Merge remote-tracking branch 'origin/master' into dev-sumcount 2021-04-13 11:14:14 +08:00
alexey-milovidov
ee9aaab4bc
Merge pull request #22937 from Enmk/formatDateTime_toDateTime64_fixes
Fixes: formatDateTime and toDateTime64
2021-04-13 01:40:25 +03:00
alexey-milovidov
d239c66fd3
Merge pull request #21511 from azat/optimize_skip_unused_shards-improvement
Rewrite IN in query for remote shards to exclude values that do not belong to the shard
2021-04-13 01:18:11 +03:00
Alexey Milovidov
61816ad076 Add a test for #2719 2021-04-13 00:57:08 +03:00
Alexey Milovidov
5172de3e74 Add test case 2021-04-13 00:12:07 +03:00
Azat Khuzhin
a497d4d462 Do not perform optimize_skip_unused_shards for cluster with one node 2021-04-12 22:18:31 +03:00
Alexey Milovidov
d04541446c Fix test 2021-04-12 22:04:30 +03:00
Alexander Tokmakov
ad414bab05 fix assertion when filtering tables in StorageMerge 2021-04-12 22:04:26 +03:00
kssenii
1251b3260c Merge branch 'postgresql-protocol-with-row-policy' of github.com:kssenii/ClickHouse into postgresql-protocol-with-row-policy 2021-04-12 18:42:15 +00:00
kssenii
9089f44a50 Fix tests 2021-04-12 18:40:34 +00:00
Nikolai Kochetov
f6d86d6032 Merge branch 'master' into add-read-from-mt-step 2021-04-12 15:23:32 +03:00
Nikolai Kochetov
0448e1415f Fix subquery with untuple. 2021-04-12 15:15:55 +03:00
Maksim Kita
b9fe85d537
Merge pull request #22964 from ClickHouse/uniq-up-to-ubsan
Check out of range values in FieldVisitorConverToNumber
2021-04-12 11:50:19 +03:00
Azat Khuzhin
de64b6e987 Cleanup 01756_optimize_skip_unused_shards_rewrite_in 2021-04-12 10:37:28 +03:00
Azat Khuzhin
79bd8d4d3f Respect optimize_skip_unused_shards_rewrite_in with optimize_skip_unused_shards_limit 2021-04-12 10:37:28 +03:00
Azat Khuzhin
fbb386dca5 Rewrite IN in query for remote shards to exclude values that does not belongs to shard
v2: fix optimize_skip_unused_shards_rewrite_in for sharding_key wrapped into function
v3: fix column name for optimize_skip_unused_shards_rewrite_in
v4: fix optimize_skip_unused_shards_rewrite_in with Null
v5:
- squash with Remove query argument for IStreamFactory::createForShard()
- use proper column after function execution (using sharding_key_column_name)
- update the test reference since (X) now is tuple(X)
2021-04-12 10:37:28 +03:00
Dmitry Krylov
a5a4fbdb00 Fix test filenames 2021-04-12 13:09:36 +10:00
Dmitry Krylov
18f58b0c49 Fix test filenames 2021-04-12 12:16:20 +10:00
Dmitry Krylov
b5f6de3cf9 Renaming tests 2021-04-12 10:23:31 +10:00
Dmitry Krylov
160d4a756e Tests for errors and tests for multi arrays 2021-04-12 10:23:31 +10:00
Dmitry Krylov
517ef8ebf4 Bug with string functions in arrayFold fixed 2021-04-12 10:23:31 +10:00
Dmitry Krylov
21941bffc8 Tests for arrayFold 2021-04-12 10:23:31 +10:00
Kseniia Sumarokova
71484fcfbd
Merge branch 'master' into postgresql-protocol-with-row-policy 2021-04-12 00:12:49 +03:00
kssenii
792d57d630 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into postgresql-protocol-with-row-policy 2021-04-11 21:10:33 +00:00
Alexey Milovidov
582ce69ee0 Add a test #20019 2021-04-11 22:40:58 +03:00
Maksim Kita
b571656fd7
Merge pull request #22931 from Enmk/dateDiff_DateTime64_fix
Fixed dateDiff for DateTime64
2021-04-11 21:36:24 +03:00
Maksim Kita
aa6183af86
Merge pull request #22971 from azat/max_part_removal_threads
Respect max_part_removal_threads for ReplicatedMergeTree
2021-04-11 21:14:47 +03:00
Azat Khuzhin
24d2325aa7 Mark 01810_max_part_removal_threads as long 2021-04-11 14:40:12 +03:00
Alexey Milovidov
e3db28ac1e Fix test 2021-04-11 13:27:49 +03:00
Maksim Kita
20d5d550c4
Merge pull request #22960 from kitaisreal/dictionary-added-decimal256-attribute-type-support
Dictionary added Decimal256 attribute type support
2021-04-11 13:07:00 +03:00
Maksim Kita
95d3571ab9 Added test to skiplist 2021-04-11 12:03:55 +03:00
Azat Khuzhin
2061e581e6 Cover max_part_removal_threads 2021-04-11 11:57:58 +03:00
Alexey Milovidov
d369da6643 Update tests 2021-04-11 00:52:42 +03:00
Alexey Milovidov
1f2226b9db Check out of range values in FieldVisitorConverToNumber 2021-04-10 23:38:14 +03:00
alexey-milovidov
e9b39c40f8
Merge pull request #22947 from azat/inactive_parts_to_throw_insert-fix
Fix inactive_parts_to_throw_insert=0 with inactive_parts_to_delay_insert>0
2021-04-10 23:21:16 +03:00
alexey-milovidov
61e3cde428
Merge pull request #22944 from ClickHouse/aku/less-flaky
less flaky test
2021-04-10 23:15:10 +03:00
Maksim Kita
50f76c5837 Remove tests 2021-04-10 22:31:10 +03:00
Maksim Kita
34b026ae32 Fixed test 2021-04-10 21:30:23 +03:00
Maksim Kita
7df43891c1 Dictionary added Decimal256 attribute type support 2021-04-10 19:53:21 +03:00
pingyu
df78a1b3fd address review comments 2021-04-10 23:00:34 +08:00
alexey-milovidov
969d9f495b
Merge pull request #22939 from CurtizJ/fix-const-map-conversion
Fix conversion from const map with nulls
2021-04-10 14:13:58 +03:00
Azat Khuzhin
90f3c9ccd1 Cover inactive_parts_to_throw_insert=0 and inactive_parts_to_delay_insert>0 2021-04-10 09:57:08 +03:00
Azat Khuzhin
0bc672f3a2 Refactor 01709_inactive_parts_to_delay_throw 2021-04-10 09:57:08 +03:00
Alexander Kuzmenkov
ab27d8920f less flaky test 2021-04-09 22:57:40 +03:00
Anton Popov
329c9033a8 fix conversion from const map with nulls 2021-04-09 20:50:10 +03:00
Vasily Nemkov
c882d290bd Fixed parsing string to DateTime64 for large values.
Before fix:
SELECT toDateTime64('2201-01-12 12:12:12', 3, 'UTC')
1970-03-26 09:10:48.237

After fix:
SELECT toDateTime64('2201-01-12 12:12:12', 3, 'UTC')
2201-01-12 12:12:12.000
2021-04-09 19:39:54 +03:00
Vasily Nemkov
4dcc1b2d2e Fixed formatDateTime for DateTime64 arguments 2021-04-09 19:39:54 +03:00
Alexander Kuzmenkov
0264124146
Merge pull request #21942 from ucasFL/distributed_depth
Add settings max_distributed_depth
2021-04-09 15:52:58 +03:00
Vasily Nemkov
4a784bd2e3 Fixed dateDiff for DateTime64
Added tests that verify fix
- against DateTime64 vals of equal scale
- DateTime64 vs DateTime
- DateTime vs DateTime64
- DateTime64 vs Date
- Date vs DateTime64
2021-04-09 15:29:16 +03:00
Nikolai Kochetov
865ae553b8 Fix test output. 2021-04-09 12:48:08 +03:00
kssenii
94e557483e Add test to antlr skip list 2021-04-09 07:44:45 +00:00
Nikolai Kochetov
28ca191102
Merge pull request #22087 from ClickHouse/better-filter-push-down
Better filter push down
2021-04-09 10:22:17 +03:00
alesapin
4b0f973f93
Merge pull request #18215 from filimonov/quorum-dedup-issue
Fix issue with quorum retries behaviour
2021-04-09 10:19:50 +03:00
alexey-milovidov
ee9b53a342
Merge pull request #22863 from kitaisreal/data-type-low-cardinality-format-tsv-parsing-issue
DataTypeLowCardinality format tsv parsing issue
2021-04-09 09:50:50 +03:00
alexey-milovidov
f7edcdf7c8
Merge pull request #22867 from azat/sparse_hashed-bytes_allocated-fix
Fix bytes_allocated for sparse_hashed dictionaries
2021-04-09 09:50:04 +03:00
alexey-milovidov
23e01b8db4
Merge pull request #22855 from ClickHouse/add-test-2
Add a test for already fixed issue
2021-04-09 09:40:19 +03:00
alexey-milovidov
8af2352e27
Merge pull request #22876 from nikitamikhaylov/mann-whitney-over-window
`mannWhitneyUTest` and `rankCorr` with window functions
2021-04-09 09:17:27 +03:00
kssenii
76d1e8243a Try fix test 2021-04-09 00:17:49 +00:00
Nikita Mikhaylov
86933749bd done 2021-04-09 00:22:18 +03:00
Anton Popov
1c28878f5d
Merge pull request #22726 from azat/mt-reverse-total-rows-approx-fix
Fix approx total rows accounting for reverse reading from MergeTree
2021-04-09 00:16:49 +03:00
Maksim Kita
6f17471030 Updated tests 2021-04-09 00:09:53 +03:00
Azat Khuzhin
93c9a02480 Fix bytes_allocated for sparse_hashed dictionaries 2021-04-08 23:29:29 +03:00
Maksim Kita
4c68f3a2a1 Added test 2021-04-08 22:56:31 +03:00
Nikolai Kochetov
3426bc3906
Merge pull request #22763 from CurtizJ/fix-having-push-down
Fix pushdown of having
2021-04-08 21:53:50 +03:00
Nikolai Kochetov
a2906e902e Fix test. 2021-04-08 21:19:57 +03:00
kssenii
0270d1b84d Add test to parallel tests skip list 2021-04-08 16:38:31 +00:00
Nikolai Kochetov
0a43b729b1 Add test. 2021-04-08 18:19:49 +03:00
Nikolai Kochetov
2765810817 Update test. 2021-04-08 18:01:08 +03:00
kssenii
80fc675258 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into postgresql-protocol-with-row-policy 2021-04-08 14:46:56 +00:00
Alexey Milovidov
b5ff97dbd6 Add a test for already fixed issue 2021-04-08 15:29:34 +03:00
alesapin
9294f3ca9a Fix skip list 2021-04-08 15:03:35 +03:00
filimonov
1d56e055e2
Update 01509_parallel_quorum_insert_no_replicas.sql 2021-04-08 13:00:01 +02:00
alesapin
95f27cb356 No bug no more 2021-04-08 13:39:21 +03:00
alesapin
e17444757b Fix rare case when quorum insert is not really quorum because of deduplication 2021-04-08 13:35:38 +03:00
alesapin
dd47f521ef Merge branch 'master' into filimonov-quorum-dedup-issue 2021-04-08 12:00:21 +03:00
Maksim Kita
ef7571c226
Merge pull request #22521 from kitaisreal/dictionaries-update-field-fix
FlatDictionary, HashedDictionary update_field optimizations
2021-04-07 23:29:53 +03:00
Anton Popov
fa9a19cbdd fix pushdown of having 2021-04-07 17:02:59 +03:00
kssenii
3420cf9142 Add setting to config 2021-04-07 14:02:54 +00:00
vdimir
9cff5ebb3e
Add tests in join_with_array_join 2021-04-07 16:09:36 +03:00
Nikita Mikhaylov
48af7a898c
Merge pull request #22299 from nikitamikhaylov/keen-wolf-storagefile-column-oriented
Merging #21302
2021-04-07 16:01:12 +03:00
kssenii
15ae912b56 Fix postgresql protocol with row policy 2021-04-07 12:56:09 +00:00
Alexander Kuzmenkov
06bb58cb69
Merge pull request #22704 from ClickHouse/aku/window-multiple
fix window functions with multiple input streams and no sorting
2021-04-07 15:15:47 +03:00
Vladimir
9fe20c1628
Revert "Move conditions from JOIN ON to WHERE" 2021-04-07 14:57:20 +03:00
Ilya Yatsishin
ed2d82603e
Merge pull request #22588 from foolchi/fix_dist_map_select
fix dist map type select
2021-04-07 11:53:23 +03:00
Vladimir
864ab4a7ab
Merge pull request #21370 from vdimir/fix-merge-engine-join-group-by 2021-04-07 11:52:27 +03:00
alesapin
451ba892fa
Merge pull request #22708 from CurtizJ/fix-flaky-tests-2
Fix test 01702_system_query_log
2021-04-07 11:51:57 +03:00
Vladimir
db0550013c
Merge pull request #22325 from azat/dist-async-insert-header-check
Check only column name and type for async distributed blocks
2021-04-07 11:51:12 +03:00
alesapin
9fd251eaaf
Merge pull request #22514 from ClickHouse/merge_tree_deduplication
Non replicated merge tree deduplication
2021-04-07 10:19:43 +03:00
Nikita Mikhailov
37f48d13b4 add test 2021-04-06 22:23:16 +03:00
Azat Khuzhin
60b000ed51 Fix approx total rows accounting for reverse reading from MergeTree 2021-04-06 21:13:51 +03:00
Alexander Kuzmenkov
d9ad06bd6d fix ubsan 2021-04-06 19:24:56 +03:00
Amos Bird
a89e3df40a
Disable table function view in expression (#21465) 2021-04-06 16:08:29 +03:00
Anton Popov
f9b1661372 fix test 01702_system_query_log 2021-04-06 15:44:06 +03:00
Alexander Kuzmenkov
585da2c8d0 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-06 14:58:21 +03:00
Alexander Kuzmenkov
4497b00ff5 the test 2021-04-06 14:57:32 +03:00
alexey-milovidov
636fe8b631
Merge pull request #22662 from vitlibar/fix-test-01294_create_settings_profile
Fix test 01294_create_settings_profile
2021-04-06 14:40:28 +03:00
Anton Popov
a9a01df74a add test 2021-04-06 14:38:35 +03:00
Anton Popov
c05c1f7a34
Merge pull request #22666 from CurtizJ/fix-flaky-tests-1
Fix random failures of tests that are using query_log
2021-04-06 14:22:26 +03:00
Nikolai Kochetov
6102652c99 Merge branch 'master' into better-filter-push-down 2021-04-06 13:38:03 +03:00
alesapin
3148c224ad
Merge pull request #22663 from CurtizJ/fix-flakey-tests
Fix test 01039_row_policy_dcl
2021-04-06 13:19:08 +03:00
alesapin
6456a1507c Support alter setting 2021-04-06 13:14:44 +03:00
vdimir
735154c81a
Handle not plain where tree in StorageMerge modifySelect 2021-04-06 12:29:29 +03:00
alesapin
fbfa53684a
Merge pull request #22670 from ClickHouse/fix_killer_test
Fix mutation killers tests
2021-04-06 10:24:36 +03:00
Azat Khuzhin
27d4fbd13b Compare Block itself for distributed async INSERT batches
INSERT into Distributed with insert_distributed_sync=1 stores the
distributed batches on the disk for sending in background.

But types may be a little bit different for the Distributed and it's
underlying table, so the initiator need to know whether conversion is
required or not.

Before this patch those on disk distributed batches contains header,
which includes dumpStructure() for the block in that batch, however it
checks not only names and types and plus dumpStructure() is a debug
method.

So instead of storing string representation for the block header we
should store empty block in the file header (note, that we cannot store
the empty block not in header, since this will require reading all
blocks from file, due to some trickery of the readers interface).

Note, that this patch also contains tiny refactoring:
- s/header/distributed_header/

v1: dumpNamesAndTypes()
v2: dump empty block into the batch itself
v3: move empty block into the header
2021-04-06 10:05:21 +03:00
Amos Bird
46c9affa83
Fix CTE in view. 2021-04-06 11:32:16 +08:00
Anton Popov
472662de80
skip test in arcadia 2021-04-06 00:45:28 +03:00
Anton Popov
dfb6890f27 fix flaky test 2021-04-06 00:04:13 +03:00
Anton Popov
1e7f3fd576
Update tests/queries/0_stateless/01670_log_comment.sql
Co-authored-by: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com>
2021-04-05 20:17:26 +03:00
alesapin
be22ffa5a8 Fix mutation killers tests 2021-04-05 19:31:49 +03:00
Anton Popov
700f4dabbd
Update 01670_log_comment.sql 2021-04-05 18:25:31 +03:00
Anton Popov
1f1a01171f try fix one more test 2021-04-05 17:52:41 +03:00
feng lv
f6e4e13f89 fix conflict 2021-04-05 14:08:30 +00:00
Anton Popov
663b300ab2 remove test from parallel run 2021-04-05 17:02:42 +03:00
feng lv
56073db22d max distributed depth
Add settings max_distributed_depth

fix style

fix

fix

fix

fix test

fix

fix
2021-04-05 14:00:54 +00:00
Vitaly Baranov
278ad443e4 Test 01294_create_settings_profile no longer changes settings of the default user. 2021-04-05 13:28:39 +03:00
pingyu
e05ee09621 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into datasketches-uniq 2021-04-05 16:47:53 +08:00
alesapin
8d5a787f6b Merge branch 'master' into merge_tree_deduplication 2021-04-05 10:40:03 +03:00
Azat Khuzhin
42d858b7e5 Fix LOGICAL_ERROR for Log with nested types w/o columns in the SELECT clause
Found with fuzzer [1]:

<details>

    2021.04.04 10:25:46.762596 [ 135 ] {4b6b5de3-d242-4267-910a-76b235467356} <Fatal> : Logical error: 'Logical error: no information about file column%2Ename.size0 in StorageLog'.
    ...
    2021.04.04 10:25:46.763563 [ 44 ] {} <Trace> BaseDaemon: Received signal 6
    2021.04.04 10:25:46.765884 [ 165 ] {} <Fatal> BaseDaemon: 5. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.04.04 10:25:46.901540 [ 165 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:51: DB::handle_error_code() @ 0x11cc4f16 in /workspace/clickhouse
    2021.04.04 10:25:47.030755 [ 165 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:58: DB::Exception::Exception() @ 0x11cc5025 in /workspace/clickhouse
    2021.04.04 10:25:47.617201 [ 165 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Storages/StorageLog.cpp:183: DB::LogSource::readData()

</details>

  [1]: https://clickhouse-test-reports.s3.yandex.net/22583/69296876005c0fa171c755f8b224e4d58192c402/fuzzer_debug/report.html#fail1

The problem here is that there is no column%2Ename.size0 there is
column.size0 instead, and it seems that reading sizeX file is not enough
in other places, so just filter them out in
ExpressionActions::getSmallestColumn() (fallback method for storages w/o
getColumnSizes() implemented)
2021-04-05 08:48:04 +03:00
alexey-milovidov
a16a09eb2f
Merge pull request #22596 from ClickHouse/fix-some-tests-aarch64
Fix some tests on AArch64
2021-04-05 07:40:33 +03:00
alexey-milovidov
6cefb8e620
Merge pull request #22583 from azat/log-rwlock-ub-fix
Avoid UB in *Log engines for rwlock unlock due to unlock from another thread
2021-04-05 05:20:16 +03:00
alexey-milovidov
a9eb7a7c7e
Merge pull request #22595 from ClickHouse/change-accurate-comparison
Change accurate comparison of integer and float to be more consistent across different CPU
2021-04-05 04:22:50 +03:00
Alexey Milovidov
d645c4d4e2 Whitespace 2021-04-05 03:52:44 +03:00
Alexey Milovidov
08f129c0d3 Mark test as long 2021-04-05 03:52:06 +03:00
Alexey Milovidov
e50d82ab45 Merge branch 'master' into change-accurate-comparison 2021-04-05 01:38:55 +03:00
Alexey Milovidov
b07d53640c Fix flaky test 00816_long_concurrent_alter_column 2021-04-05 00:34:51 +03:00
alesapin
0ceb95aa55 Merge branch 'master' into merge_tree_deduplication 2021-04-04 18:32:27 +03:00
Anton Popov
0d03b8c0c4
Merge pull request #21889 from CurtizJ/fix-aggregation-in-order-1
Fix bugs in aggregation by primary key
2021-04-04 18:17:04 +03:00
pingyu
1ea74a1947 bug fix. add unit tests.# 2021-04-04 22:22:47 +08:00
Maksim Kita
ff86c21e65 Dictionary update field fix 2021-04-04 16:30:48 +03:00
Alexey Milovidov
cae21b8560 Fix test 2021-04-04 15:50:19 +03:00
alexey-milovidov
44e160596e
Merge pull request #22587 from ClickHouse/fix-flaky-test-15
Fix flaky test after #22427
2021-04-04 15:44:44 +03:00
alexey-milovidov
f6e6842383
Merge pull request #22590 from ClickHouse/fix-tests-aarch64
Fix CPU-dependent behaviour in tests
2021-04-04 15:43:12 +03:00
alexey-milovidov
0e1035735c
Merge pull request #22565 from ClickHouse/fix-assert-arena
Fix assert in Arena when doing GROUP BY Array of Nothing of non-zero size.
2021-04-04 15:38:17 +03:00
Alexey Milovidov
d18daa5919 Fix test 2021-04-04 15:18:17 +03:00
Alexey Milovidov
3ad3109ec5 Fix tests 2021-04-04 15:14:01 +03:00
Alexey Milovidov
9d47adbae6 Fix tests 2021-04-04 15:10:13 +03:00
Alexey Milovidov
9383fec50b Fix test 2021-04-04 15:07:52 +03:00
Alexey Milovidov
4a58055b2d Update test 2021-04-04 14:52:46 +03:00
Alexey Milovidov
eae9b978f8 Generate test files for accurate comparison int vs. float 2021-04-04 14:49:24 +03:00
Maksim Kita
0bfb429c42
Merge pull request #22479 from kitaisreal/clickhouse-dictionary-source-loop-fix
ClickHouseDictionarySource loop fix
2021-04-04 13:29:17 +03:00
Azat Khuzhin
44abb7588a StorageStripeLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
89a96cf14d StorageLog: avoid UB for rwlock unlock due to unlock from another thread 2021-04-04 13:25:44 +03:00
Azat Khuzhin
5d795661ed StorageTinyLog: add regression test for UB due to unlock from different thread
Refs: #22560
2021-04-04 13:25:44 +03:00
Alexey Milovidov
729214c845 Fix some tests on AArch64 2021-04-04 13:11:36 +03:00