thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-15 02:41:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
97,870 Commits 9,328 Branches 1,783 Tags 2.1 GiB
f8aa738511
Commit Graph

97870 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
serxa
f8aa738511 more conventional profile events names 2022-09-19 17:23:22 +00:00
serxa
6ed53585ab rearrange and fix profile event descriptions 2022-09-19 17:03:48 +00:00
Sergei Trifonov
d4a7e1892c
Merge pull request #41039 from mateng0915/support_s3_api_event_metrics 
Feature: Support Event Tracing when calling Aws S3 API
 2022-09-19 19:00:38 +02:00
Sergei Trifonov
51a7cf1295
Merge branch 'master' into support_s3_api_event_metrics 2022-09-19 17:37:28 +02:00
Alexey Milovidov
1d06ddcb9a
Merge pull request #41522 from DerekChia/patch-1 
Change input_format_skip_unknown_fields default to 1
 2022-09-19 18:29:59 +03:00
Derek Chia
cb613b8675
Change input_format_skip_unknown_fields default to 1 
As per PR https://github.com/ClickHouse/ClickHouse/pull/37192, `input_format_skip_unknown_fields` is enabled by default. Likewise, it is also set as `true` in the factory settings https://github.com/ClickHouse/ClickHouse/blob/master/src/Core/Settings.h#L696

Updating the docs to reflect the change.
 2022-09-19 22:37:03 +08:00
Sergei Trifonov
ff2e1ff8d8
Merge branch 'master' into support_s3_api_event_metrics 2022-09-19 14:35:45 +02:00
Sergei Trifonov
26da32f53f
Update tests/integration/test_profile_events_s3/test.py 2022-09-19 14:35:23 +02:00
Kruglov Pavel
712aebc077
Merge pull request #41083 from Avogar/fix-map-combinator 
Fix possible segfaults, use-heap-after-free and memory leak in aggregate function combinators
 2022-09-19 14:29:17 +02:00
Alexander Tokmakov
4e83174006
Merge pull request #41390 from ClickHouse/fix_drop_partition_on_cluster 
Fix ON CLUSTER with Replicated database cluster
 2022-09-19 15:22:30 +03:00
Alexander Tokmakov
c6efb1773e
Merge branch 'master' into fix_drop_partition_on_cluster 2022-09-19 15:18:05 +03:00
Kruglov Pavel
4c3194eefe
Merge pull request #41286 from azat/utf8-fix 
Do not allow invalid sequences influence other rows in lowerUTF8/upperUTF8
 2022-09-19 14:07:10 +02:00
Kseniia Sumarokova
55ebe90e3b
Merge pull request #41496 from lesandie/master 
Fixed cache parameter name
 2022-09-19 13:36:21 +02:00
Sema Checherinda
2f6c5c8f75
Merge pull request #41417 from nickitat/stabilize_uniq_sorted 
Stabilize uniq stored
 2022-09-19 12:30:16 +02:00
Sema Checherinda
f50378d551
Merge pull request #41425 from den-crane/test/issue_41394 
test for #41394
 2022-09-19 12:27:33 +02:00
Kseniia Sumarokova
8922f81399
Merge pull request #41468 from azat/tests/test_hive_query 
tests: fix test_hive_query flakiness
 2022-09-19 12:25:16 +02:00
Antonio Andelic
1763af37b9
Merge pull request #41403 from ClickHouse/keeper-fix-shutdown-without-server 
Fix Keeper segfault during shutdown when RAFT server failed to start
 2022-09-19 12:03:58 +02:00
Diego Nieto (lesandie)
1a14515e35 Fixed cache parameter name 2022-09-19 10:29:41 +02:00
Vladimir C
b6b5932efc
Merge pull request #41223 from ClickHouse/vdimir/exponential_rewrite_21557 2022-09-19 10:07:24 +02:00
Alexey Milovidov
b9bd2c8373
Merge pull request #41458 from ClickHouse/fix-bug-orc 
Fix very strange behavior of Apache ORC
 2022-09-19 10:43:17 +03:00
Alexey Milovidov
e20bc9953c
Merge pull request #41481 from ClickHouse/alexey-milovidov-patch-5 
Update geo.md
 2022-09-19 09:34:24 +03:00
Alexey Milovidov
3c0961c48b
Merge branch 'master' into fix-map-combinator 2022-09-19 09:32:16 +03:00
Alexey Milovidov
b01f5bdca8
Merge pull request #39354 from ClickHouse/window-order-by 
Respect ORDER BY clause in window functions
 2022-09-19 09:22:37 +03:00
Alexey Milovidov
6a09340f11
Merge pull request #41459 from azat/io/threadpoolreader-elapsed 
Account any IO that is done from ThreadPoolReader
 2022-09-19 09:04:20 +03:00
Azat Khuzhin
00d4ac542d tests: fix test_hive_query flakiness 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-19 07:54:49 +02:00
Alexey Milovidov
2e5fa7880e
Update geo.md 2022-09-19 07:52:24 +03:00
Alexey Milovidov
81e8cb4be6
Merge branch 'master' into fix-bug-orc 2022-09-19 06:38:17 +03:00
Alexey Milovidov
d4b9fe41be
Merge pull request #41457 from ClickHouse/remove-trash-5 
Remove trash from Field
 2022-09-19 06:36:48 +03:00
Alexey Milovidov
57a1f47972
Merge pull request #41441 from ClickHouse/pod-array-overflow 
Fix overflow in `PODArray`
 2022-09-19 06:34:21 +03:00
Alexey Milovidov
ce130d0dc0
Merge pull request #41462 from ClickHouse/kerberos-remove-noise 
Remove noise from the build process
 2022-09-19 06:32:46 +03:00
Alexey Milovidov
4719ed6f2c
Merge pull request #41466 from ClickHouse/add_missed_throw 
Add missed throw expression
 2022-09-19 06:31:29 +03:00
Alexey Milovidov
ac193facde
Merge branch 'master' into add_missed_throw 2022-09-19 06:31:12 +03:00
Alexey Milovidov
51a847af11
Merge pull request #41469 from azat/build/tidy-fix 
Fix clang-tidy build
 2022-09-19 06:29:42 +03:00
Alexey Milovidov
036e882097
Merge pull request #41460 from ClickHouse/add-test-31631 
Add a test for #31631
 2022-09-19 06:28:56 +03:00
Alexey Milovidov
df52df83f9
Merge pull request #41463 from ClickHouse/add-test-38383 
Add a test for #38383
 2022-09-19 06:27:38 +03:00
Alexey Milovidov
790cb730d6 Fix clang-tidy 2022-09-19 00:34:41 +02:00
Alexey Milovidov
cc28120761 Merge branch 'master' into pod-array-overflow 2022-09-19 00:34:38 +02:00
Alexey Milovidov
f3fd5ef845 Fix clang-tidy 2022-09-19 00:32:52 +02:00
Alexey Milovidov
36aaeecc2f Fix clang-tidy 2022-09-19 00:32:11 +02:00
Alexey Milovidov
041d2f7dee Fix clang-tidy 2022-09-19 00:31:37 +02:00
Alexey Milovidov
f78d028177 Fix clang-tidy 2022-09-19 00:31:02 +02:00
Alexey Milovidov
5d9e125c71 Fix clang-tidy 2022-09-19 00:28:32 +02:00
Azat Khuzhin
2141665c68 Fix clang-tidy build 
Tidy report [1]:

    src/AggregateFunctions/CMakeFiles/clickhouse_aggregate_functions.dir/AggregateFunctionCategoricalInformationValue.cpp.o -c ../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:38:15: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        Counter & counter(AggregateDataPtr __restrict place, size_t i, bool what) const
                  ^                                                               ~~~~~
        static
    /build/build_docker/../src/AggregateFunctions/AggregateFunctionCategoricalInformationValue.cpp:43:21: error: method 'counter' can be made static [readability-convert-member-functions-to-static,-warnings-as-errors]
        const Counter & counter(ConstAggregateDataPtr __restrict place, size_t i, bool what) const
                        ^                                                                    ~~~~~
        static
    178520 warnings generated.

  [1]: https://s3.amazonaws.com/clickhouse-builds/41459/64b44be513607d59e4b89dd9fb518b8cf4acba21/clickhouse_special_build_check/report.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-18 22:04:12 +02:00
alesapin
e4c120742e Add missed throw expression 2022-09-18 16:56:19 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch 
Fix redundant fetch in zero copy replication
 2022-09-18 15:57:27 +02:00
alesapin
1d0dbfb112
Merge pull request #41444 from ClickHouse/one_wrong_config_assert 
One more validation for broken config in keeper
 2022-09-18 15:56:48 +02:00
Kruglov Pavel
519bcbb3be
Merge pull request #41236 from Avogar/fix-totals-extremes 
Don't output totals/extremes in all row formats, update docs
 2022-09-18 14:55:07 +02:00
Alexey Milovidov
56fd38de44 Add a test for #38383 2022-09-18 10:38:10 +02:00
Alexey Milovidov
3eb7ee8308 Remove noise from build process 2022-09-18 10:35:25 +02:00
Azat Khuzhin
64b44be513 Account any IO that is done from ThreadPoolReader 
In case of some issues with the disk it is possible that
preadv2(RWF_NOWAIT)==EAGAIN can take a lot of time, so let's measure
even this case.

I've verified with a simple (almost) loop of preadv2(RWF_NOWAIT), and
got this:

    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    too long at offset=8691694, ret=18446744073709551615 (14.5016)
    too long at offset=8694766, ret=18446744073709551615 (14.4338)
    too long at offset=8694766, ret=18446744073709551615 (16.2144)

So here you can see that preadv2(RWF_NOWAIT) took 14-16 seconds in case
of failure.

Complete code can be found here [1].

  [1]: https://gist.github.com/azat/f4a6b0750316c42bec021064e0a7627c

I came up with this patch because I saw some stranginess in
ProfileEvents, that does not show all the time that was spend in IO when
pread_threadpool method was used.
Also there was some stranginess with trace_log too.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-18 10:05:21 +02:00