Commit Graph

5308 Commits

Author SHA1 Message Date
Maksim Kita
2f56f8d040
Merge pull request #23278 from kitaisreal/to-date-time-decimal-overflow-ubsan-fix
Function toDateTime decimal overflow ubsan fix
2021-04-19 10:12:24 +03:00
Maksim Kita
1bfd4f7568 Function toDateTime decimal overflow ubsan fix 2021-04-19 02:00:33 +03:00
alexey-milovidov
1d5a4cfa32
Revert "[RFC] Fix memory tracking with min_bytes_to_use_mmap_io" 2021-04-19 01:30:53 +03:00
Maksim Kita
ca93987ae9
Merge pull request #23182 from kitaisreal/system-query-reload-model
Added system query reload model
2021-04-19 00:39:31 +03:00
Azat Khuzhin
d476a4a9bd Add type conversion for optimize_skip_unused_shards_rewrite_in
MSan reports [1]:

    2021.04.17 15:20:06.665152 [ 56 ] {2336bf92-0269-4acd-8b3f-f09623223d18} <Debug> executeQuery: (from [::1]:44744, using production parser) SELECT * FROM dist_01757 WHERE dummy IN ('255', 0) FORMAT Null
    ...
    0 0x305af885 in (anonymous namespace)::shardContains() obj-x86_64-linux-gnu/../src/Interpreters/OptimizeShardingKeyRewriteInVisitor.cpp:50:28
    ...
    Uninitialized value was created by an allocation of 'sharding_value' in the stack frame of function '_ZN12_GLOBAL__N_113shardContainsERKN2DB5FieldERKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEERKNS4_10shared_ptrINS0_17ExpressionActionsEEESC_RKNS0_7Cluster9ShardInfoERKNS4_6vectorImNS8_ImEEEE'
    0 0x305ae260 in (anonymous namespace)::shardContains() obj-x86_64-linux-gnu/../src/Interpreters/OptimizeShardingKeyRewriteInVisitor.cpp:42

  [1]: https://clickhouse-test-reports.s3.yandex.net/23212/d02eb3f6b7a8dc07bbed5605e1afcf7634436b3a/fuzzer_msan/report.html#fail1

P.S. fuzzers are great!
2021-04-19 00:03:38 +03:00
Maksim Kita
b26dfcd514 Simple key dictionary primary key wrong order fix 2021-04-18 15:19:44 +03:00
Maksim Kita
aa42150ebd Added integration test 2021-04-18 13:38:36 +03:00
alexey-milovidov
83038f84af
Revert "Function arrayFold for folding over array with accumulator" 2021-04-18 03:34:05 +03:00
alexey-milovidov
96fced4c3c
Merge pull request #23211 from azat/mmap-accounting
[RFC] Fix memory tracking with min_bytes_to_use_mmap_io
2021-04-18 03:17:30 +03:00
alexey-milovidov
7f3a40e1b0
Merge pull request #22237 from ClickHouse/protocol-compression-auto
Autodetect compression #22234
2021-04-18 03:13:54 +03:00
Alexey Milovidov
8ac953f459 Make function unhex case insensitive for compatibility 2021-04-17 19:31:35 +03:00
Alexey Milovidov
a790652029 Merge branch 'protocol-compression-auto' of github.com:yandex/ClickHouse into protocol-compression-auto 2021-04-17 16:47:13 +03:00
Alexey Milovidov
77e64b3ebd Merge branch 'master' into protocol-compression-auto 2021-04-17 16:46:51 +03:00
alexey-milovidov
138c6ae228
Merge pull request #23185 from ClickHouse/fix_22573
Fix data_type_default_nullable on ATTACH
2021-04-17 16:13:42 +03:00
Azat Khuzhin
6bd32bd2cb Mark 01605_adaptive_granularity_block_borders as long 2021-04-17 13:50:52 +03:00
Azat Khuzhin
a963fba41a Update 00084_external_aggregation to avoid using mmap 2021-04-17 10:37:58 +03:00
Azat Khuzhin
1b367ee71d Update 01605_adaptive_granularity_block_borders to avoid using mmap 2021-04-17 10:37:58 +03:00
Azat Khuzhin
6064f3ef1d Fix memory tracking with min_bytes_to_use_mmap_io
With min_bytes_to_use_mmap_io=1 memory regions for mmap() will not be
accounted. But this creates issues, since if you will run simple
"SELECT * FROM big_enough_table" it will mmap lot's of files and the
process RSS will grow at some point, and before the kernel will
understand that it needs to unmap physical pages the clickhouse-server
will sync total_memory_tracker with RSS of the process and the
allocations will fail by per-server memory limits.

Also note, that this does not address all the issues with mmap()
regions.

v2: move track/untrack into the MMapReadBufferFromFileWithCache to avoid
data-race [1]

  [1]: https://clickhouse-test-reports.s3.yandex.net/23211/6acf6cb9b22cee7db8d1aa523a6208f63e792f7a/functional_stateful_tests_(thread).html#fail1
2021-04-17 10:37:38 +03:00
Nikita Mikhaylov
7a23d8292f done 2021-04-16 23:53:26 +00:00
Alexey Milovidov
ecf8de7111 Add a test for #14610 2021-04-17 02:22:32 +03:00
alexey-milovidov
786f340256
Merge pull request #22755 from kssenii/postgresql-protocol-with-row-policy
Allow row policy in postgresql protocol
2021-04-17 01:55:30 +03:00
Alexander Kuzmenkov
2782b2a6b0 fix 2021-04-16 21:50:12 +03:00
Nikolai Kochetov
abe84acc8c Update test. 2021-04-16 20:19:03 +03:00
Alexander Kuzmenkov
b991cbf9d6 more stable formatting for negate() 2021-04-16 19:28:33 +03:00
Maksim Kita
9679bdd86e Remove explicit database creation in tests 2021-04-16 16:16:11 +03:00
Maksim Kita
d88e0b1b44 Use local shard if there are no remote connections 2021-04-16 16:01:53 +03:00
vdimir
92e813c806
Merge branch 'master' into create-aggregate-func-settings 2021-04-16 15:48:39 +03:00
Kruglov Pavel
deb86ee520
Merge pull request #22986 from azat/StorageBuffer-flush
[RFC] Add ability to flush buffer only in background for StorageBuffer
2021-04-16 15:14:24 +03:00
Anton Popov
b14798af2a Merge branch 'dev_nested_upadte' of git://github.com/hexiaoting/ClickHouse into nested-update 2021-04-16 14:41:19 +03:00
Nikolai Kochetov
a0c942c7d3 Update test 2021-04-16 14:32:59 +03:00
Alexander Kuzmenkov
74b4c56ba4
Merge pull request #21589 from dmalkr/dmalkr/arrayFold
Function `arrayFold` for folding over array with accumulator
2021-04-16 14:23:53 +03:00
Nikolai Kochetov
21e297b8a3 Update test 2021-04-16 14:18:55 +03:00
Nikolai Kochetov
23089a2fec Add special setting to show indexes. 2021-04-16 14:11:45 +03:00
Alexander Tokmakov
ebf0a3119e fix data_type_default_nullable on attach 2021-04-16 13:29:33 +03:00
Nikolai Kochetov
6fe3470893 Update test. 2021-04-16 12:43:11 +03:00
tavplubix
b5cbbce314
Merge pull request #22706 from songenjie/fetch_part
[clickhouse][server][ddl]support fetch part
2021-04-16 12:26:51 +03:00
tavplubix
ae3dc3dfc0
Merge pull request #23161 from ClickHouse/logs_for_debuging_test_failures
More verbose logs for debuging test failures with Replicated and Keeper
2021-04-16 12:01:58 +03:00
Pavel Kruglov
ec83aed3eb Move long queries from 01798_uniq_theta_sketch to separate test 2021-04-16 11:44:32 +03:00
alexey-milovidov
dcb5d1b395
Merge pull request #23096 from ClickHouse/markdown-bad-alignment
Fix unpleasant behaviour of `Markdown` format
2021-04-16 00:06:58 +03:00
Alexander Tokmakov
0ad6205fa6 logs for debuging test failures with Replicated and Keeper 2021-04-15 21:34:53 +03:00
Azat Khuzhin
19e0439629 Add ability to flush buffer only in background for StorageBuffer
Add 3 new engine arguments:
- flush_time
- flush_rows
- flush_bytes

That will be checked only for background flush, this maybe useful if
INSERT latency is "crucial".
2021-04-15 21:22:13 +03:00
Alexander Kuzmenkov
3b95b637a5 Merge remote-tracking branch 'origin/master' into HEAD 2021-04-15 18:19:53 +03:00
alexey-milovidov
02e77c3ef1
Merge pull request #23111 from ClickHouse/fix_test_name
Rename strange tests
2021-04-15 15:03:31 +03:00
alexey-milovidov
ec97414d5a
Update 01598_memory_limit_zeros.sql 2021-04-15 14:45:05 +03:00
Maksim Kita
e361f5943f
Merge pull request #22999 from azat/no-optimize_skip_unused_shards-single-node
Do not perform optimize_skip_unused_shards for cluster with one node
2021-04-15 14:36:56 +03:00
vdimir
33a9189151
Merge remote-tracking branch 'upstream/master' into create-aggregate-func-settings 2021-04-15 13:41:21 +03:00
Vladimir
8c7ffda676
Merge pull request #22753 from ClickHouse/revert-19685-dev_joinon 2021-04-15 12:42:50 +03:00
Dmitry Krylov
75036debf4 Check type match of lambda and accumulator 2021-04-15 19:25:30 +10:00
Pavel Kruglov
b909899cc9 Remove extra lines 2021-04-15 11:59:56 +03:00
Pavel Kruglov
8bd77e1c0c Change markdown format test 2021-04-15 11:58:14 +03:00
alesapin
c979287526 Rename strange tests 2021-04-15 11:28:22 +03:00
alexey-milovidov
9b546f3b89
Merge pull request #22657 from amosbird/ctefix3
Fix CTE usage in view definition
2021-04-15 02:01:10 +03:00
Alexey Milovidov
346e16ce7f Fix test 2021-04-15 00:45:39 +03:00
Alexey Milovidov
17d04cbca9 Merge branch 'master' into protocol-compression-auto 2021-04-15 00:24:07 +03:00
tavplubix
2479c80fb7
Merge branch 'master' into fix_attach_mv 2021-04-15 00:07:48 +03:00
tavplubix
021cafff49
Merge pull request #23041 from ClickHouse/fix_testkeeper_multi_response
Fix multi response in TestKeeper
2021-04-14 23:25:40 +03:00
Ivan
57f61c954c
Another attempt to enable pytest (#22664)
* Fix some tests

* Fix tests
2021-04-14 19:35:17 +03:00
Alexey Milovidov
3b1adbfea4 Fix test 2021-04-14 16:48:12 +03:00
alexey-milovidov
496c2e45d0
Merge pull request #23036 from Enmk/fix_extractAllGroupsHorizontal_max_matches
Fixed erroneus failure of extractAllGroupsHorizontal on large columns
2021-04-14 15:57:19 +03:00
Ivan
2b78765957
Merge branch 'master' into postgresql-protocol-with-row-policy 2021-04-14 14:50:28 +03:00
alexey-milovidov
f8ce5547aa
Merge pull request #21318 from azat/servers-pool-wait
Fix SIGSEGV by waiting servers thread pool
2021-04-14 14:15:07 +03:00
Alexander Tokmakov
c34e27ed1c fix test 2021-04-14 14:07:56 +03:00
alexey-milovidov
d3f8a9c23a
Merge pull request #23044 from ClickHouse/array-has-any-all-generic
Fix unfinished code in GatherUtils #20272
2021-04-14 13:57:30 +03:00
alexey-milovidov
35260089e0
Merge pull request #23040 from ClickHouse/remove-useless-parts-from-suggest
Remove non-essential parts from Suggest
2021-04-14 13:55:25 +03:00
alexey-milovidov
86e20905e5
Merge pull request #23008 from ClickHouse/add-test-2719
Add a test for #2719
2021-04-14 13:54:36 +03:00
tavplubix
caf97d297b
Update arcadia_skip_list.txt 2021-04-14 12:17:41 +03:00
Nikita Mikhaylov
c0ed151239
Merge pull request #22012 from nikitamikhaylov/s3-distributed
Table function `s3Cluster`
2021-04-14 10:23:43 +03:00
songenjie
f731739fab fix suggests 2021-04-14 10:05:41 +08:00
Alexey Milovidov
311011caf8 Merge branch 'remove-useless-parts-from-suggest' of github.com:yandex/ClickHouse into remove-useless-parts-from-suggest 2021-04-14 01:08:32 +03:00
Alexey Milovidov
58281eadc0 Mark test as long 2021-04-14 01:08:09 +03:00
tavplubix
5df608a11b
Merge pull request #23043 from ClickHouse/improve_hung_check
Improve hung check in Stress tests
2021-04-14 00:29:52 +03:00
Vasily Nemkov
77bdb5b391 Fixed erroneus failure of extractAllGroupsHorizontal on large columns 2021-04-14 00:17:06 +03:00
Alexey Milovidov
4914860f91 Fix style 2021-04-13 22:41:07 +03:00
Nikita Mikhaylov
a15757a9c9 better renaming 2021-04-13 22:39:43 +03:00
Nikita Mikhaylov
7c2b662e28 delete file 2021-04-13 22:39:42 +03:00
Nikita Mikhaylov
4465a0627f better 2021-04-13 22:39:42 +03:00
Nikita Mikhaylov
efef179b89 remove prints 2021-04-13 22:39:42 +03:00
Nikita Mikhaylov
9144bc7176 Update 01801_s3_distributed.sh 2021-04-13 22:39:42 +03:00
Nikita Mikhaylov
36a8419f60 style 2021-04-13 22:39:42 +03:00
Nikita Mikhaylov
6f7f3a4ec5 better test 2021-04-13 22:39:42 +03:00
Nikita Mikhaylov
6f268476e6 chmod 2021-04-13 22:39:42 +03:00
Nikita Mikhaylov
3b22375c36 add func test 2021-04-13 22:39:42 +03:00
Alexey Milovidov
7254ed5e7f This is correct 2021-04-13 22:32:10 +03:00
Alexey Milovidov
f7da292d2a Merge branch 'master' into array-has-any-all-generic 2021-04-13 22:16:33 +03:00
Alexey Milovidov
39d7f50e8a Fix style 2021-04-13 22:15:15 +03:00
Alexander Tokmakov
05e4c8d3ef fix attach mv in atomic db 2021-04-13 22:13:26 +03:00
alexey-milovidov
1b61580fa3
Update 01676_clickhouse_client_autocomplete.sh 2021-04-13 21:58:04 +03:00
Azat Khuzhin
3afa94612a Add a test to ensure that server will wait the server thread pools
v2: add into skip_list
v3: print server log on error
v4: increase sleep time to trigger some issues under TSAN
v5: avoid ports overlaps
v6: avoid endless loops to print server log on failure
2021-04-13 21:37:38 +03:00
Alexey Milovidov
a29334de7c Fix test 2021-04-13 20:23:14 +03:00
Alexey Milovidov
4a14816ef2 Merge branch 'master' into add-test-2719 2021-04-13 20:22:39 +03:00
Alexey Milovidov
58ef54dd63 Fix test 2021-04-13 20:21:27 +03:00
Alexey Milovidov
63a272a533 Fix test 2021-04-13 20:15:18 +03:00
Alexey Milovidov
924eb69217 Fix test 2021-04-13 20:14:29 +03:00
Alexey Milovidov
919e96dbbe Fix test 2021-04-13 20:12:40 +03:00
Alexey Milovidov
a54985458d Add a test 2021-04-13 20:10:27 +03:00
Pavel Kruglov
0518349333 Update reference 2021-04-13 19:37:59 +03:00
Kruglov Pavel
6350f734dc
Merge branch 'master' into datasketches-uniq 2021-04-13 19:34:15 +03:00
Pavel Kruglov
6ce9873a76 Move all uniqThetaSketch tests into one file, add it in fasttest and arcadia skip lists 2021-04-13 19:33:15 +03:00
tavplubix
da681d9907
Merge pull request #22998 from ClickHouse/fix_22989
Fix assertion when filtering tables in StorageMerge
2021-04-13 18:57:24 +03:00
tavplubix
35c9619444
Update 01181_db_atomic_drop_on_cluster.sql 2021-04-13 18:17:43 +03:00
Nikolai Kochetov
531e9ba6e3 Skip test for antlr. 2021-04-13 17:37:59 +03:00
vdimir
5747fa0216
Test option allow_experimental_funnel_functions 2021-04-13 17:34:57 +03:00
Alexander Tokmakov
fdf3cf378f fix testkeeper multi response 2021-04-13 15:49:40 +03:00
hexiaoting
4f36ac7f64 Fix error 2021-04-13 17:31:49 +08:00
Nikolai Kochetov
9b67067f05 Fix flappy test. 2021-04-13 11:53:23 +03:00
Maksim Kita
305d3d6b16
Merge pull request #22978 from ClickHouse/filter-by-virtual-columns-fix
Fix trivial mistake in filtering by virtual columns
2021-04-13 11:42:16 +03:00
Maksim Kita
e687fc320f
Merge pull request #22997 from ClickHouse/increase-max-uri-size
Increase `max_uri_size` to 1 MiB by default
2021-04-13 11:26:23 +03:00
Nikolai Kochetov
e731dfe650
Merge pull request #22991 from ClickHouse/untuple-and-subquery
Fix subquery with untuple.
2021-04-13 09:53:13 +03:00
songenjie
fbd26789af [test] show privileges 2021-04-13 14:08:26 +08:00
hexiaoting
77c460e8d1 Merge remote-tracking branch 'origin/master' into dev-sumcount 2021-04-13 11:14:14 +08:00
hexiaoting
52bdec396b Merge remote-tracking branch 'origin/master' into dev_nested_upadte 2021-04-13 09:56:47 +08:00
alexey-milovidov
ee9aaab4bc
Merge pull request #22937 from Enmk/formatDateTime_toDateTime64_fixes
Fixes: formatDateTime and toDateTime64
2021-04-13 01:40:25 +03:00
alexey-milovidov
d239c66fd3
Merge pull request #21511 from azat/optimize_skip_unused_shards-improvement
Rewrite IN in query for remote shards to exclude values that do not belong to the shard
2021-04-13 01:18:11 +03:00
Alexey Milovidov
61816ad076 Add a test for #2719 2021-04-13 00:57:08 +03:00
Alexey Milovidov
5172de3e74 Add test case 2021-04-13 00:12:07 +03:00
Azat Khuzhin
a497d4d462 Do not perform optimize_skip_unused_shards for cluster with one node 2021-04-12 22:18:31 +03:00
Alexey Milovidov
d04541446c Fix test 2021-04-12 22:04:30 +03:00
Alexander Tokmakov
ad414bab05 fix assertion when filtering tables in StorageMerge 2021-04-12 22:04:26 +03:00
kssenii
1251b3260c Merge branch 'postgresql-protocol-with-row-policy' of github.com:kssenii/ClickHouse into postgresql-protocol-with-row-policy 2021-04-12 18:42:15 +00:00
kssenii
9089f44a50 Fix tests 2021-04-12 18:40:34 +00:00
Nikolai Kochetov
f6d86d6032 Merge branch 'master' into add-read-from-mt-step 2021-04-12 15:23:32 +03:00
Nikolai Kochetov
0448e1415f Fix subquery with untuple. 2021-04-12 15:15:55 +03:00
Maksim Kita
b9fe85d537
Merge pull request #22964 from ClickHouse/uniq-up-to-ubsan
Check out of range values in FieldVisitorConverToNumber
2021-04-12 11:50:19 +03:00
Azat Khuzhin
de64b6e987 Cleanup 01756_optimize_skip_unused_shards_rewrite_in 2021-04-12 10:37:28 +03:00
Azat Khuzhin
79bd8d4d3f Respect optimize_skip_unused_shards_rewrite_in with optimize_skip_unused_shards_limit 2021-04-12 10:37:28 +03:00
Azat Khuzhin
fbb386dca5 Rewrite IN in query for remote shards to exclude values that does not belongs to shard
v2: fix optimize_skip_unused_shards_rewrite_in for sharding_key wrapped into function
v3: fix column name for optimize_skip_unused_shards_rewrite_in
v4: fix optimize_skip_unused_shards_rewrite_in with Null
v5:
- squash with Remove query argument for IStreamFactory::createForShard()
- use proper column after function execution (using sharding_key_column_name)
- update the test reference since (X) now is tuple(X)
2021-04-12 10:37:28 +03:00
Dmitry Krylov
a5a4fbdb00 Fix test filenames 2021-04-12 13:09:36 +10:00
Dmitry Krylov
18f58b0c49 Fix test filenames 2021-04-12 12:16:20 +10:00
Dmitry Krylov
b5f6de3cf9 Renaming tests 2021-04-12 10:23:31 +10:00
Dmitry Krylov
160d4a756e Tests for errors and tests for multi arrays 2021-04-12 10:23:31 +10:00
Dmitry Krylov
517ef8ebf4 Bug with string functions in arrayFold fixed 2021-04-12 10:23:31 +10:00
Dmitry Krylov
21941bffc8 Tests for arrayFold 2021-04-12 10:23:31 +10:00
Kseniia Sumarokova
71484fcfbd
Merge branch 'master' into postgresql-protocol-with-row-policy 2021-04-12 00:12:49 +03:00
kssenii
792d57d630 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into postgresql-protocol-with-row-policy 2021-04-11 21:10:33 +00:00
Alexey Milovidov
582ce69ee0 Add a test #20019 2021-04-11 22:40:58 +03:00
Maksim Kita
b571656fd7
Merge pull request #22931 from Enmk/dateDiff_DateTime64_fix
Fixed dateDiff for DateTime64
2021-04-11 21:36:24 +03:00
Maksim Kita
aa6183af86
Merge pull request #22971 from azat/max_part_removal_threads
Respect max_part_removal_threads for ReplicatedMergeTree
2021-04-11 21:14:47 +03:00
Azat Khuzhin
24d2325aa7 Mark 01810_max_part_removal_threads as long 2021-04-11 14:40:12 +03:00
Alexey Milovidov
e3db28ac1e Fix test 2021-04-11 13:27:49 +03:00
Maksim Kita
20d5d550c4
Merge pull request #22960 from kitaisreal/dictionary-added-decimal256-attribute-type-support
Dictionary added Decimal256 attribute type support
2021-04-11 13:07:00 +03:00
Maksim Kita
95d3571ab9 Added test to skiplist 2021-04-11 12:03:55 +03:00
Azat Khuzhin
2061e581e6 Cover max_part_removal_threads 2021-04-11 11:57:58 +03:00
Alexey Milovidov
d369da6643 Update tests 2021-04-11 00:52:42 +03:00
Alexey Milovidov
1f2226b9db Check out of range values in FieldVisitorConverToNumber 2021-04-10 23:38:14 +03:00
alexey-milovidov
e9b39c40f8
Merge pull request #22947 from azat/inactive_parts_to_throw_insert-fix
Fix inactive_parts_to_throw_insert=0 with inactive_parts_to_delay_insert>0
2021-04-10 23:21:16 +03:00
alexey-milovidov
61e3cde428
Merge pull request #22944 from ClickHouse/aku/less-flaky
less flaky test
2021-04-10 23:15:10 +03:00
Maksim Kita
50f76c5837 Remove tests 2021-04-10 22:31:10 +03:00
Maksim Kita
34b026ae32 Fixed test 2021-04-10 21:30:23 +03:00
Maksim Kita
7df43891c1 Dictionary added Decimal256 attribute type support 2021-04-10 19:53:21 +03:00
pingyu
df78a1b3fd address review comments 2021-04-10 23:00:34 +08:00