thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 00:22:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
90,395 Commits 9,167 Branches 1,781 Tags 2.1 GiB
fe2e5d722c
Commit Graph

90395 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Kruglov Pavel
fe2e5d722c
Merge pull request #37826 from azat/remote-query-fix 
Fix possible "No more packets are available" for distributed queries
 2022-06-07 11:57:26 +02:00
Kseniia Sumarokova
edc6b68801
Merge pull request #37853 from Vxider/fire-when-inserted 
Fire and clean windows in WindowView only when data is inserted
 2022-06-07 11:24:50 +02:00
Kseniia Sumarokova
4272ca8836
Merge pull request #36060 from Varinara/master 
Add feature disks (ls, C, list-disks, disk, help)
 2022-06-07 11:22:23 +02:00
Vitaly Baranov
d199478169
Merge pull request #37303 from ClickHouse/fix_trash 
Try to fix some trash
 2022-06-07 10:17:39 +02:00
Robert Schulze
07ba122572
Merge pull request #37642 from amosbird/less-flaky-jbod-test 
Less flaky jbod rebalancer test
 2022-06-07 09:16:09 +02:00
Azat Khuzhin
078678237e Fix possible "No more packets are available" for distributed queries 
CI founds the following case:

<details>

    2022.05.25 22:36:06.778808 [ 3037 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Fatal> : Logical error: 'No more packets are available.'.
    2022.05.25 22:42:24.960075 [ 17397 ] {} <Fatal> BaseDaemon: ########################################
    2022.05.25 22:42:24.971173 [ 17397 ] {} <Fatal> BaseDaemon: (version 22.6.1.1, build id: 9A1F9489854CED36) (from thread 3037) (query_id: 77743723-1fcd-4b3d-babc-d0615e3ff40e) (query: SELECT * FROM
    2022.05.25 22:42:25.046871 [ 17397 ] {} <Fatal> BaseDaemon: 5. ./build_docker/../src/Common/Exception.cpp:47: DB::abortOnFailedAssertion()
    2022.05.25 22:42:25.181449 [ 17397 ] {} <Fatal> BaseDaemon: 6. ./build_docker/../src/Common/Exception.cpp:70: DB::Exception::Exception()
    2022.05.25 22:42:25.367710 [ 17397 ] {} <Fatal> BaseDaemon: 7. ./build_docker/../src/Client/MultiplexedConnections.cpp:0: DB::MultiplexedConnections::receivePacketUnlocked()
    2022.05.25 22:42:25.414201 [ 17397 ] {} <Fatal> BaseDaemon: 8. ./build_docker/../src/Client/MultiplexedConnections.cpp:0: DB::MultiplexedConnections::receivePacket()
    2022.05.25 22:42:25.493066 [ 17397 ] {} <Fatal> BaseDaemon: 9. ./build_docker/../src/QueryPipeline/RemoteQueryExecutor.cpp:279: DB::RemoteQueryExecutor::read()
    2022.05.25 22:42:25.612679 [ 17397 ] {} <Fatal> BaseDaemon: 10. ./build_docker/../src/Processors/Sources/RemoteSource.cpp:0: DB::RemoteSource::tryGenerate()

Here are additional logs for this query:
    $ pigz -cd clickhouse-server.stress.log.gz | fgrep -a 77743723-1fcd-4b3d-babc-d0615e3ff40e | fgrep -e Connection -e Distributed -e Fatal
    2022.05.25 22:36:04.698671 [ 6613 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Trace> Connection (127.0.0.2:9000): Connecting. Database: (not specified). User: default
    2022.05.25 22:36:04.722568 [ 3419 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Trace> Connection (127.0.0.2:9000): Connecting. Database: (not specified). User: default
    2022.05.25 22:36:05.014432 [ 6613 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Trace> Connection (127.0.0.2:9000): Connected to ClickHouse server version 22.6.1.
    2022.05.25 22:36:05.091397 [ 6613 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Debug> Connection (127.0.0.2:9000): Sent data for 2 scalars, total 2 rows in 0.000125814 sec., 15602 rows/sec., 68.00 B (517.81 KiB/sec.), compressed 0.4594594594594595 times to 148.00 B (1.10 MiB/sec.)
    2022.05.25 22:36:05.301301 [ 3419 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Trace> Connection (127.0.0.2:9000): Connected to ClickHouse server version 22.6.1.
    2022.05.25 22:36:05.343140 [ 3419 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Debug> Connection (127.0.0.2:9000): Sent data for 2 scalars, total 2 rows in 0.000116304 sec., 16889 rows/sec., 68.00 B (559.80 KiB/sec.), compressed 0.4594594594594595 times to 148.00 B (1.19 MiB/sec.)
    2022.05.25 22:36:06.682535 [ 6613 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Trace> StorageDistributed (remote): (127.0.0.2:9000) Cancelling query because enough data has been read
    2022.05.25 22:36:06.778808 [ 3037 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Fatal> : Logical error: 'No more packets are available.'.
    2022.05.25 22:36:06.789505 [ 3419 ] {77743723-1fcd-4b3d-babc-d0615e3ff40e} <Trace> StorageDistributed (remote): (127.0.0.2:9000) Cancelling query because enough data has been read
    2022.05.25 22:42:24.971173 [ 17397 ] {} <Fatal> BaseDaemon: (version 22.6.1.1, build id: 9A1F9489854CED36) (from thread 3037) (query_id: 77743723-1fcd-4b3d-babc-d0615e3ff40e) (query: SELECT * FROM

</details>

So between cancelling different sources the LOGICAL_ERROR occured, I
believe that this is because of the race:

    T1:                                        T2:
    RemoteQueryExecutor::read()
    checks was_cancelled
                                               RemoteQueryExecutor::tryCancel()
                                               connections->cancel()
    calls connections->receivePacket()

Note, for this problem async_socket_for_remote/use_hedged_requests
should be disabled, and original settings was:
- --max_parallel_replicas=3
- --use_hedged_requests=false
- --allow_experimental_parallel_reading_from_replicas=3

CI: https://s3.amazonaws.com/clickhouse-test-reports/37469/41cb029ed23e77f3a108e07e6b1b1bcb03dc7fcf/stress_test__undefined__actions_/fatal_messages.txt
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-07 08:20:32 +03:00
mergify[bot]
7a76a7a606
Merge branch 'master' into master 2022-06-06 19:44:32 +00:00
mergify[bot]
e237e44b69
Merge branch 'master' into fire-when-inserted 2022-06-06 19:22:55 +00:00
alesapin
5faaf1b553
Merge pull request #37884 from nickitat/update_protobuf_files 
Update protobuf files for kafka and rabbitmq [fix integration tests]
 2022-06-06 20:57:21 +02:00
Anton Popov
d40b23272e
Merge pull request #37755 from CurtizJ/fix-mutations-again 
Return back #37266
 2022-06-06 20:22:03 +02:00
Dmitry Novik
fe257a14e9
Merge pull request #37838 from ClickHouse/qoega-patch-2 
Space in {} shows it on final page
 2022-06-06 19:51:20 +02:00
Maksim Kita
612172def5
Merge pull request #37720 from kitaisreal/executable-user-defined-functions-parameters 
Executable user defined functions support parameters
 2022-06-06 16:51:56 +02:00
Varinara
1f8fab41f1 Fixe2: allow config path at any position 2022-06-06 16:52:58 +03:00
Varinara
6aa9e5d649 Fixe: allow config path at any position 2022-06-06 16:52:58 +03:00
Varinara
e35d1460bf Corrections 2022-06-06 16:52:58 +03:00
Varinara
a330d3cb4a Corrections 2022-06-06 16:52:58 +03:00
Varinara
f5d4e9ccc1 Corrections 2022-06-06 16:52:58 +03:00
Varinara
354ef2e3b8 Corrections 2022-06-06 16:52:58 +03:00
Varinara
51409703e0 Corrections 2022-06-06 16:52:58 +03:00
Varinara
ed6e8176fe Add basic commands for disk tool (list-disks, list, move, remove, link, copy, read, write) + tests 2022-06-06 16:52:58 +03:00
Nickita Taranov
9fd9836237 update other files 2022-06-06 15:31:20 +02:00
Nickita Taranov
90f023d65f impl 2022-06-06 13:09:48 +02:00
Robert Schulze
e39e5adf74
Merge pull request #37796 from azat/default-clang 
Use clang compiler by default and cleanup cmake preload
 2022-06-05 20:37:35 +02:00
Robert Schulze
2d87af2a15
Merge pull request #37647 from DevTeamBK/Fix-all-CheckTriviallyCopyableMove-Errors 
Fix errors of CheckTriviallyCopyableMove type
 2022-06-05 19:58:47 +02:00
Alexey Milovidov
a403f1cd1b
Update CHANGELOG.md 2022-06-05 15:01:25 +03:00
alesapin
959fd2150c
Merge pull request #37829 from ClickHouse/nickitat-patch-2 
Fix build (packager)
 2022-06-05 13:48:41 +02:00
mergify[bot]
ba5df6a8f9
Merge branch 'master' into nickitat-patch-2 2022-06-04 18:04:53 +00:00
Vxider
d4f0e8d4c2 update code style 2022-06-04 17:14:42 +00:00
Vxider
1f10276686 fire and clean only when data inserted 2022-06-04 16:55:46 +00:00
Alexey Milovidov
295f0a0557
Update gui.md 2022-06-04 14:41:42 +03:00
Alexey Milovidov
fd14d168df
Merge pull request #37635 from kl7sn/master 
add clickvisual intro
 2022-06-04 14:36:43 +03:00
Alexey Milovidov
b81a92ca8d
Merge pull request #37836 from vdimir/fix-doc-check 
Fix docs check (remove git clean for yarn.lock)
 2022-06-04 14:31:33 +03:00
Alexander Tokmakov
a51978a4e0
Merge pull request #37846 from ClickHouse/hotfix_for_func_tests2 
Hotfix for minio in functional tests 2
 2022-06-04 13:57:53 +03:00
Alexey Milovidov
f860407af5
Merge pull request #37777 from ClickHouse/avx512_tail_zero 
Use multitarget framework for numZerosInTail implementation
 2022-06-04 01:46:56 +03:00
Alexander Tokmakov
1ab5dcae38 fix for aarch64 2022-06-03 23:49:06 +02:00
Alexander Tokmakov
ddd1ae5fe8
Merge pull request #37845 from ClickHouse/hotfix_for_func_tests 
Hotfix for minio in functional tests
 2022-06-04 00:47:18 +03:00
Alexander Tokmakov
c21783273f fix 2022-06-03 21:58:58 +02:00
Alexander Tokmakov
66f8c69c15 fix 2022-06-03 21:53:44 +02:00
HeenaBansal2009
4cb561b070 Fix new warning from BuilderBinTidy 2022-06-03 11:47:36 -07:00
Alexander Tokmakov
5916633344 hotfix for minio in functional tests 2022-06-03 20:47:26 +02:00
Kseniia Sumarokova
7632de911d
Merge pull request #37807 from Vxider/deley-cleanup 
Delay schedule of the cleaning task in WindowView
 2022-06-03 19:48:57 +02:00
Maksim Kita
b4cc8ce22b Fixed style check 2022-06-03 18:06:59 +02:00
Maksim Kita
23b92cbe10 Fixed style check 2022-06-03 18:06:59 +02:00
Maksim Kita
d14193b3ad Executable user defined functions extract parameters name and type from command value 2022-06-03 18:06:59 +02:00
Maksim Kita
c4da2540e9 Added integration tests 2022-06-03 18:06:59 +02:00
Maksim Kita
549a55e4a2 Added functional tests 2022-06-03 18:05:37 +02:00
Maksim Kita
6c5ec68a7c Executable user defined functions support parameters 2022-06-03 18:05:37 +02:00
Alexander Tokmakov
084dd6f3c2
Merge pull request #37767 from excitoon-favorites/removeperrequestconfigurationfromawssdkcpp 
Moved `ClientConfigurationPerRequest` to ClickHouse
 2022-06-03 17:42:50 +03:00
Azat Khuzhin
7220fd296f Surround ENV{} in quotes in PreLoad.cmake 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-03 17:30:43 +03:00
Azat Khuzhin
6647333f5f Do not set clang as default if CC/CXX env is set 
Since some build systems may change the compiler via those env
variables.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-06-03 17:29:41 +03:00