Commit Graph

37234 Commits

Author SHA1 Message Date
Vladimir C
0042c20770
Merge pull request #46054 from alexX512/bug_fix_pulling_pipeline 2023-02-09 10:50:46 +01:00
taiyang-li
e1fed0352e remove useless code 2023-02-09 16:32:11 +08:00
taiyang-li
19ca0ec4af add passes for rewriting arrayexists 2023-02-09 16:30:53 +08:00
Antonio Andelic
ae731b739a Prefer explicitly defined creds for S3 2023-02-09 08:13:16 +00:00
KitKatKKK
54513d1db1
Merge branch 'master' into addParts 2023-02-09 15:41:49 +08:00
Alexey Milovidov
3a75ede60a Implement #16733 2023-02-09 08:41:47 +01:00
Alexey Milovidov
cb847172ea Fix something 2023-02-09 08:39:46 +01:00
taiyang-li
af7a6abf80 fix bugs 2023-02-09 15:15:08 +08:00
Alexey Milovidov
a40ef2bf18 Make it better 2023-02-09 08:09:19 +01:00
Alexey Milovidov
d9fbf643bc
Merge pull request #45226 from hanfei1991/hanfei/gwp-asan
Introduce llvm/gwp-asan
2023-02-09 09:24:52 +03:00
pufit
7cf71d1f82
Merge pull request #46144 from ClickHouse/46131-fix-config-attributes-merge
Fix config merge for XML attributes.
2023-02-08 23:28:13 -05:00
taiyang-li
1ce12c8ab5 add visitor files 2023-02-09 12:26:32 +08:00
taiyang-li
48f0fb0d52 rewrite array exists to has 2023-02-09 12:06:42 +08:00
Alexey Milovidov
8392b35d50 Speed up countDigits 2023-02-09 04:39:12 +01:00
attack204
a5d7f002ec beauty 2023-02-09 11:03:04 +08:00
attack204
9ce15279ae reformat 2023-02-09 10:54:18 +08:00
zk_kiger
886e821d1e
Merge branch 'master' into improve_format_datetime_joda 2023-02-09 10:08:29 +08:00
Alexey Milovidov
66043eec24
Merge branch 'master' into decimal-performance 2023-02-09 04:59:37 +03:00
attack204
f65756c0c8 fix style 2023-02-09 09:34:11 +08:00
Alexey Milovidov
292a5abbc9 Merge remote-tracking branch 'origin/master' into with-fill-bigint 2023-02-09 01:47:51 +01:00
Alexander Tokmakov
4fd4058259
Merge pull request #45629 from arthurpassos/fix_cares_crash
Cancel c-ares failed requests and retry on system interrupts to prevent callbacks with dangling references and premature resolution failures
2023-02-09 02:29:29 +03:00
Vitaly Baranov
4869d3806c Add setting check_referential_table_dependencies to check referential dependencies on DROP TABLE. 2023-02-08 23:56:59 +01:00
Ilya Yatsishin
9f480b8fa2
Merge pull request #46132 from azat/file-fd-schema-inference 2023-02-08 23:23:32 +01:00
Alexander Tokmakov
648812b652
Merge pull request #46003 from azat/client-settings-fix
Fix applying settings for FORMAT on the client
2023-02-09 01:06:35 +03:00
Alexander Tokmakov
8101b044fa
Merge pull request #46091 from azat/sanity-assertions
Sanity assertions for closing file descriptors
2023-02-09 01:02:03 +03:00
Alexander Tokmakov
65cbb0fcfc
Merge pull request #46138 from vitlibar/fix-dependency-checks
Fix dependency checks
2023-02-09 00:54:40 +03:00
Anton Popov
31adebdca8
Merge pull request #46045 from azat/compact-nested-fix
Fix reading of non existing nested columns with multiple level in compact parts
2023-02-08 22:54:11 +01:00
Han Fei
64b84f8e31 fix style 2023-02-08 22:16:28 +01:00
kssenii
b0b865c32e Resubmit prefetches 2023-02-08 21:26:24 +01:00
serxa
cfb8291029 Cleanup disk unittest 2023-02-08 18:14:05 +00:00
Han Fei
8f665b5bbf fix 2023-02-08 18:28:06 +01:00
Sergei Trifonov
b0fc551c27
Merge branch 'master' into io-scheduler-integration 2023-02-08 18:16:00 +01:00
Han Fei
a4efb1fbda fix compile 2023-02-08 18:06:36 +01:00
attack204
ecaa97c5b1 fix style 2023-02-08 23:45:39 +08:00
Han Fei
d9aab84701 fix fork hang 2023-02-08 16:20:42 +01:00
pufit
e833decd88 try to fix memory leak 2023-02-08 15:17:46 +00:00
attack204
1328725054 fix style 2023-02-08 22:58:31 +08:00
Antonio Andelic
45d4ba59dc
Merge pull request #46068 from bigo-sg/alloc_map_metrics
Add new metric to record allocations times and bytes using mmap
2023-02-08 15:49:20 +01:00
attack204
01cac6c49b fix style 2023-02-08 22:49:10 +08:00
attack204
752d1f81b0 fix style 2023-02-08 22:36:07 +08:00
attack204
1fdf3659da fix style 2023-02-08 22:29:23 +08:00
Vladimir C
247d6c1edd
Merge pull request #44730 from bigo-sg/optimize_aggregate_function_withif 2023-02-08 15:26:47 +01:00
attack204
41daf88d64 fix style 2023-02-08 22:20:47 +08:00
attack204
87a90e0621
Merge branch 'master' into addParts 2023-02-08 22:17:04 +08:00
Maksim Kita
77ec255d7c
Merge pull request #45396 from kitaisreal/hashed-dictionary-sharded-nullable-fix
HashedDictionary sharded fix nullable values
2023-02-08 17:15:10 +03:00
attack204
820e5bd9c0 fix style 2023-02-08 22:15:05 +08:00
attack204
7c6e30ebe2 fix pointer bug 2023-02-08 22:02:58 +08:00
attack204
b1fc12c162 delete extra API and use dynamic_cast to compute 2023-02-08 21:52:13 +08:00
Anton Popov
f0b0eacbad
Merge pull request #45992 from CurtizJ/fix-type-object-analyzer
Fix basic functionality with type `Object` and new analyzer
2023-02-08 14:25:17 +01:00
Anton Popov
62dfac1425
Merge pull request #46103 from bigo-sg/improve_pad_string
Fix doc and enable int types for pad
2023-02-08 14:24:04 +01:00
Smita Kulkarni
87ec32f235 Updated to use znode_name instead of log_entry_id - Updated checking of SYSTEM SYNC REPLICA 2023-02-08 14:07:06 +01:00
robot-clickhouse-ci-1
99274f1db1
Merge pull request #46143 from ClickHouse/evillique-patch-2
Interpret `cluster_name` identifier in `s3Cluster` function as literal
2023-02-08 14:06:16 +01:00
Alexander Gololobov
a7c30eecf4
Merge pull request #46141 from ClickHouse/fix-assertion-in-statistics
Fix assertion in statistical functions
2023-02-08 13:42:02 +01:00
attack204
b3e2f99f4f
Merge branch 'master' into addParts 2023-02-08 20:27:54 +08:00
attack204
9e1081b79a add parts, active_parts total_marks to system.tables 2023-02-08 20:23:06 +08:00
Robert Schulze
6ff232d782
Merge branch 'master' into rs/fix-fragile-linking 2023-02-08 12:51:12 +01:00
Kruglov Pavel
4e2918cee3
Merge branch 'master' into parquet-fixed-binary 2023-02-08 12:31:13 +01:00
Kruglov Pavel
8bdb1c3453
Merge pull request #44728 from bigo-sg/improve_count_if
Improve count if rewrite
2023-02-08 12:21:29 +01:00
Kseniia Sumarokova
f6ebe11350
Merge pull request #46108 from azat/azure-fix
Fix test_merge_tree_azure_blob_storage::test_zero_copy_replication test
2023-02-08 12:04:46 +01:00
Robert Schulze
b79ead9c84
Move poco to base/poco/ (#46075)
* Replicate poco into base/poco/

* De-register poco submodule

* Build poco from ClickHouse

* Exclude poco from stylecheck

* Exclude poco from whitespace check

* Exclude poco from typo check

* Remove x bit from sources/headers (the style check complained)

* Exclude poco from duplicate include check

* Fix fasttest

* Remove contrib/poco-cmake/*

* Simplify poco build descriptions

* Remove poco stuff not used by ClickHouse

* Glob poco sources

* Exclude poco from clang-tidy
2023-02-08 12:04:11 +01:00
Kseniia Sumarokova
693006ba42
Merge pull request #46083 from kssenii/simplify-storage-s3-configuration
Simplify code around storages s3/hudi/delta-lake
2023-02-08 12:02:38 +01:00
Kruglov Pavel
0e5ceae896
Merge pull request #45296 from bigo-sg/improve_multi_if
Improve performance of function multiIf by columnar executing
2023-02-08 11:33:12 +01:00
Vladimir C
8385263ba9
Add in code doc to sipHash128Reference 2023-02-08 11:04:58 +01:00
Azat Khuzhin
151ba92a2e Fix reading of non existing nested columns with multiple level in compact parts
Consider the following example:

    CREATE TABLE data (root.array_str Array(UInt8)) ENGINE = MergeTree() ORDER BY tuple();
    INSERT INTO data VALUES ([]);
    ALTER TABLE data ADD COLUMN root.nested_array Array(Array(UInt8));

In this case the first part will not have data for root.nested_array,
and thanks to #37152 it will simply read offsets column from
root.array_str, however since root.nested_array is a nested array, it
will try to read elements from the same offsets stream and if you are
lucky enough you will get one of the following errors:

- Cannot read all data. Bytes read: 1. Bytes expected: 8.: (while reading column root.nested_array): While executing MergeTreeInOrder. (CANNOT_READ_ALL_DATA)
- DB::Exception: Array size is too large: 8233460228287709730: (while reading column serp.serp_features): While executing MergeTreeInOrder.

So to address this, findColumnForOffsets() had been changed to return
the level of the column too, to allow to read only up to this level.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 10:21:40 +01:00
Igor Nikonov
72c393e7c4
Merge pull request #46014 from ClickHouse/inorder-optimization-update-sorting-properties
Update sorting properties after reading in order applied
2023-02-08 10:19:47 +01:00
Alexey Milovidov
4f2a58ddbd Fix style 2023-02-08 08:44:31 +01:00
kigerzhang
a6d7e37815 fix test reference 2023-02-08 15:41:17 +08:00
Alexey Milovidov
a9ec73a209 Fix strange trash 2023-02-08 08:26:27 +01:00
Alexey Milovidov
0791b85f57 Remove bits of trash 2023-02-08 08:18:31 +01:00
Alexey Milovidov
d66beb9ac4 Allow accurate comparison of Big Int with other integers 2023-02-08 07:56:00 +01:00
Azat Khuzhin
758deac715 Do not check close() return value in BaseDaemon::closeFDs()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 05:52:35 +01:00
Azat Khuzhin
0b37344b26 Use BAD_ARGUMENTS over LOGICAL_ERROR for schema inference error file() over fd
Otherwise the following leads to SIGSEGV in debug/sanitizers builds:

  echo '0000000000Custom NULL representation0000000000' | clickhouse-local -q "desc file('-', 'TSV')"

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-08 05:36:49 +01:00
taiyang-li
51f565a470 fix ast fuzzer error 2023-02-08 12:13:29 +08:00
Alexey Milovidov
69d3575ce5 Fix style, remove trash 2023-02-08 05:12:23 +01:00
Alexey Milovidov
2dc014254e Update tests 2023-02-08 03:37:46 +01:00
Alexey Milovidov
924f19e94a
Update AzureBlobStorageAuth.cpp 2023-02-08 04:12:00 +03:00
pufit
c066c0dfdb Fix config merge for an attributes 2023-02-07 23:46:13 +00:00
Nikolay Degterinsky
4040b9c91b
Interpret cluster_name identifier in s3Cluster function as literal 2023-02-08 00:39:19 +01:00
Alexey Milovidov
41722a6163 Fix assertion in statistical functions 2023-02-08 00:15:32 +01:00
Alexey Milovidov
55c3bbb739 Fix assertion in statistical functions 2023-02-08 00:09:41 +01:00
Kseniia Sumarokova
a5d3b00699
Merge pull request #46010 from kssenii/named-collections-fix-access
Fix named collections access
2023-02-07 23:20:22 +01:00
Smita Kulkarni
8c9d994fd7 Extended scope of state_mutex while adding subscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 22:04:17 +01:00
Azat Khuzhin
911fabd0dc Fix applying settings for FORMAT on the client
Previously the following query does not works correctly:

    SELECT number FROM numbers(5) SETTINGS output_format_json_array_of_rows = 1 FORMAT JSONEachRow

While this one works OK:

    SELECT number FROM numbers(5) FORMAT JSONEachRow SETTINGS output_format_json_array_of_rows = 1

The problem is in which AST those settings are stored, use the logic as
executeQuery() has to apply them:

  c83f701696/src/Interpreters/executeQuery.cpp (L467-L497)

Note, the only problem should be with the settings for FORMAT, since
client applies thoes settings (and formats) locally w/o server, while in
case of i.e. HTTP it will be applied on the server and everything will
works fine.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 18:29:40 +01:00
Kseniia Sumarokova
41dbdcff67
Merge branch 'master' into simplify-storage-s3-configuration 2023-02-07 18:09:34 +01:00
Azat Khuzhin
d21f6a0bd6 Fix WriteBufferFromFile destructor after close()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 17:59:05 +01:00
Smita Kulkarni
ecea28a832 Fixed style check - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 17:27:34 +01:00
Nikolai Kochetov
3912f5a333
Merge pull request #45681 from CurtizJ/compact-parts-vertical-merge
Allow vertical merges from compact to wide parts
2023-02-07 17:09:17 +01:00
Smita Kulkarni
34341ddabe Updated locks and removed getLogEntryIds function - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 16:57:58 +01:00
Zhiguo Zhou
b43ffb98e8
Vectorize filter generation of ColumnNullable in FilterDescription (#45962)
This commit achieved the data parallelism for filter generations of
the nullable columns by replacing the logical AND operator with the
bitwise one, which could be auto-vectorized by the compiler.
2023-02-07 16:33:01 +01:00
kssenii
40deaf1661 Fix clang-tidy 2023-02-07 16:30:04 +01:00
Han Fei
0f7defb87f
Merge branch 'master' into hanfei/gwp-asan 2023-02-07 14:55:55 +01:00
Sema Checherinda
52d4e78b7f
Merge pull request #45907 from CheSema/forbid-wal-on-s3
do not run wal on remote disks
2023-02-07 14:48:00 +01:00
Yakov Olkhovskiy
4e7dffafe4
Merge pull request #46087 from ClickHouse/fix-ip-bloom
Allow bloom filter for IPv4 and IPv6
2023-02-07 08:29:28 -05:00
Yakov Olkhovskiy
909a772701
Merge pull request #45375 from ClibMouse/window_view_fix
Window view functional test failed on platform s390x
2023-02-07 08:23:50 -05:00
Robert Schulze
10af0b3e49
Reduce redundancies 2023-02-07 12:27:23 +00:00
Vitaly Baranov
6555b48132 Disable evaluating the right part of IN operator while analyzing dependencies. 2023-02-07 13:21:30 +01:00
Han Fei
021e6e90cc
Merge pull request #45631 from hanfei1991/hanfei/regexp-refine
RegExpTreeDict use re2 engines when processing heavy regexps
2023-02-07 13:21:22 +01:00
Vitaly Baranov
324b0b6896 Fix DDLDependencyVisitor for an empty table name. 2023-02-07 13:21:18 +01:00
Azat Khuzhin
fe832c4418 Fix TOCTOU while checking for container existence in azure_blob_storage
This is a simple time-of-check vs time-of-use, since between checking
does such container exist and creating one, there is a time window.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 12:51:06 +01:00
kssenii
9485873a2f Fix integration test 2023-02-07 12:45:23 +01:00
Robert Schulze
783e26d2ba
Cosmetics 2023-02-07 11:42:31 +00:00
Robert Schulze
08c1f8346e
Merge remote-tracking branch 'origin/master' into rs/fix-fragile-linking 2023-02-07 11:22:00 +00:00
Smita Kulkarni
fb765696b6 Removed state_mutex lock from addSubscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 12:19:58 +01:00
Robert Schulze
690d873126
Merge pull request #46088 from ClickHouse/rs/fix-liburing-build
Fix build with `-DENABLE_LIBURING=0` (or `-DENABLE_LIBRARIES=0`)
2023-02-07 12:16:14 +01:00
Sergei Trifonov
950c04cb0e
Merge pull request #44907 from azat/dist/async-INSERT-error-message-fix
Fix error message for a broken distributed batches ("While sending batch")
2023-02-07 12:14:52 +01:00
Vitaly Baranov
f021c0eab6
Merge pull request #46058 from vitlibar/remove-unnecessary-execute-for-const-expr
Remove unnecessary execute() while evaluating a constant expression.
2023-02-07 12:09:37 +01:00
Robert Schulze
f9b6c10700
Merge pull request #46072 from ClickHouse/rs/follow-up-to-46057
Smallish follow-up to #46057
2023-02-07 11:52:51 +01:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
taiyang-li
f41f41c78c fix doc; enable int type for pad 2023-02-07 18:25:36 +08:00
Salvatore Mesoraca
476342602b
Functions: Hashing: add sipHash128Reference{,Keyed} 2023-02-07 11:19:04 +01:00
Salvatore Mesoraca
001b714d3e
Common: SipHash: add original 128-bit output implementation 2023-02-07 11:19:04 +01:00
Smita Kulkarni
135615cda6 Removed unwanted check from before callback - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:27:45 +01:00
Smita Kulkarni
ef29b61786 Updated callback to return log entry ids - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:02:38 +01:00
Smita Kulkarni
f34ef86332 Moved background task trigger before getting log entries to wait - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 08:49:41 +01:00
mateng915
708111b62f
Merge branch 'master' into replicas_status_api_optimize 2023-02-07 14:51:27 +08:00
zk_kiger
294cb5acf4
Merge branch 'ClickHouse:master' into improve_format_datetime_joda 2023-02-07 11:59:11 +08:00
kigerzhang
1dbfd5b3f4 Merge remote-tracking branch 'origin/improve_format_datetime_joda' into improve_format_datetime_joda 2023-02-07 10:05:59 +08:00
kigerzhang
46161bc4e9 fix style 2023-02-07 10:03:03 +08:00
Anton Popov
7dfea59267 remove an assertion 2023-02-07 00:50:41 +00:00
Alexander Tokmakov
13da43ead8
Merge branch 'master' into fix_test_00002 2023-02-07 03:25:42 +03:00
Alexey Milovidov
f1b8d1d9d7 Improve performance of Decimal conversion when scale does not change 2023-02-07 00:27:12 +01:00
Anton Popov
3ad5a085da
Merge pull request #45987 from CurtizJ/fix-sparse-columns-crash
Fix `INTERSECT` and `EXCEPT` with sparse columns
2023-02-06 23:01:02 +01:00
Azat Khuzhin
e83163e25f Add sanity check of evtimer_del() in QueryProfiler
Saw this one time on CI with EINVAL [1], while this was EINVAL this
time, next time it can be completelly different fd and break something
in a different place.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/1716af465d376f5335720b5045bcccdd9e1823aa/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:05 +01:00
Han Fei
d1d893275a fix 2023-02-06 18:46:23 +01:00
kssenii
6cea67d58b Cleanup 2023-02-06 18:11:33 +01:00
Robert Schulze
8840aa9242
Fix build with -DENABLE_LIBURING=0 (or -DENABLE_LIBRARIES=0)
Follow-up to #38456

The problem was that code which uses liburing was conditionally build
depending on define OS_LINUX and not based on whether liburing was
enabled/disabled at build time.
2023-02-06 16:57:42 +00:00
Yakov Olkhovskiy
e433c26cf9 allow bloom filter for IPv4 and IPv6 2023-02-06 16:30:18 +00:00
Han Fei
eb76041312 address comments and add one more test 2023-02-06 17:26:20 +01:00
Alexander Tokmakov
af655eb7dc
Merge pull request #45889 from CheSema/release-merge-blocker-drop-part
do not block merges when old parts are droping in drop queries
2023-02-06 19:09:09 +03:00
kssenii
ab0dedf0c8 Simplify code around storage s3 configuration 2023-02-06 16:23:17 +01:00
Anton Popov
3850a1969d
Merge branch 'master' into fix-memory-leak-azure 2023-02-06 16:21:56 +01:00
Suzy Wang
6edbffa3cc
Merge branch 'master' into window_view_fix 2023-02-06 10:06:04 -05:00
alesapin
e999f66234
Merge pull request #46040 from azat/backup-fix-race
Fix data race in BACKUP
2023-02-06 15:20:44 +01:00
Alexander Tokmakov
98a4e1ab2c better comment 2023-02-06 15:08:30 +01:00
Alexander Tokmakov
86feaae253 Merge branch 'master' into explicit_drop_part_entry_type 2023-02-06 14:59:59 +01:00
Alexander Tokmakov
e9f770d89d fix 2023-02-06 14:03:14 +01:00
zk_kiger
602e697b31
Merge branch 'ClickHouse:master' into improve_format_datetime_joda 2023-02-06 20:18:23 +08:00
alesapin
b94f9f8006
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica 2023-02-06 12:38:39 +01:00
Kseniia Sumarokova
38c001ca42
Merge pull request #45957 from xiedeyantu/s3_file_not_found
Throw an error on no files satisfying S3 wildcard
2023-02-06 12:32:12 +01:00
Alexander Gololobov
a784750e66
Merge pull request #45949 from bigo-sg/improve_decimal
Improve performance of ColumnArray::filter/replicate  for big int and decimal
2023-02-06 12:27:19 +01:00
Alexander Gololobov
d18364476d
Merge pull request #46047 from azat/system.processes-elapsed-fix
Fix elapsed column in system.processes (10x error)
2023-02-06 12:26:05 +01:00
Alexey Perevyshin
7a4d658a46
Merge branch 'master' into bug_fix_pulling_pipeline 2023-02-06 14:24:26 +03:00
zk_kiger
4c0d3651c1
Merge branch 'master' into improve_format_datetime_joda 2023-02-06 19:22:45 +08:00
Vladimir C
5686703e79
Merge pull request #46053 from ucasfl/json-columns
Closes https://github.com/ClickHouse/ClickHouse/issues/46024
2023-02-06 12:22:13 +01:00
zk_kiger
b13eaf5e68
Merge branch 'master' into improve_format_datetime_joda 2023-02-06 19:16:10 +08:00
Sema Checherinda
734d3a318b
const auto ref in the loop 2023-02-06 12:09:33 +01:00
Robert Schulze
4c89327c9f
Add TODO comment to MultiVersion.h
Follow-up to #46057
2023-02-06 11:04:58 +00:00
Robert Schulze
fa131edba5
Merge pull request #46057 from k-morozov/refactoring/multiversion-atomic-functions
MultiVersion: change mutex to lock-free
2023-02-06 11:55:27 +01:00
Vladimir C
e3712bb2c6
Merge pull request #45961 from ClickHouse/vdimir/sparkbar-fix 2023-02-06 11:52:15 +01:00
Maksim Kita
e8d66fb1a2 HashedDictionary sharded fix nullable values 2023-02-06 10:50:58 +01:00
taiyang-li
7b10ac8d5b add new metric to record allocations times and bytes using mmap 2023-02-06 17:50:45 +08:00
Antonio Andelic
3c2fafe07e Use correct name resolution 2023-02-06 09:12:03 +00:00
Alexey Perevyshin
10f3c9f640
Merge branch 'master' into bug_fix_pulling_pipeline 2023-02-06 12:00:24 +03:00
Antonio Andelic
7c8a25a18e Correctly use merge tree setting constraints 2023-02-06 08:30:09 +00:00
李扬
444373679a
Merge branch 'master' into improve_decimal 2023-02-06 13:08:51 +08:00
mateng915
3e5d3914ba
Merge branch 'master' into replicas_status_api_optimize 2023-02-06 09:58:31 +08:00
Robert Schulze
4a328828b5
Merge pull request #45758 from ClickHouse/qc-max_cache_size
Make Query Cache server-level settings reconfigurable at runtime
2023-02-05 21:55:37 +01:00
Robert Schulze
84b9ff450f
Fix terribly broken, fragile and potentially cyclic linking
Sorry for the clickbaity title. This is about static method
ConnectionTimeouts::getHTTPTimeouts(). It was be declared in header
IO/ConnectionTimeouts.h, and defined in header
IO/ConnectionTimeoutsContext.h (!). This is weird and caused issues with
linking on s390x (##45520). There was an attempt to fix some
inconsistencies (#45848) but neither did @Algunenano nor me at first
really understand why the definition is in the header.

Turns out that ConnectionTimeoutsContext.h is only #include'd from
source files which are part of the normal server build BUT NOT part of
the keeper standalone build (which must be enabled via CMake
-DBUILD_STANDALONE_KEEPER=1). This dependency was not documented and as
a result, some misguided workarounds were introduced earlier, e.g.
0341c6c54b

The deeper cause was that getHTTPTimeouts() is passed a "Context". This
class is part of the "dbms" libary which is deliberately not linked by
the standalone build of clickhouse-keeper. The context is only used to
read the settings and the "Settings" class is part of the
clickhouse_common library which is linked by clickhouse-keeper already.

To resolve this mess, this PR

- creates source file IO/ConnectionTimeouts.cpp and moves all
  ConnectionTimeouts definitions into it, including getHTTPTimeouts().

- breaks the wrong dependency by passing "Settings" instead of "Context"
  into getHTTPTimeouts().

- resolves the previous hacks
2023-02-05 20:49:34 +00:00
Vitaly Baranov
a3423ce196 Remove unnecessary execute() while evaluating a constant expression. 2023-02-05 20:26:34 +01:00
Han Fei
baa345fa64 remove logs 2023-02-05 18:06:06 +01:00
Han Fei
532b341de9
Merge pull request #45975 from ucasfl/_part
use LowCardnality for _part and _partition_id virtual column
2023-02-05 18:00:46 +01:00
Robert Schulze
9b841d67e8
Merge remote-tracking branch 'origin/master' into qc-max_cache_size 2023-02-05 16:47:02 +00:00
Konstantin Morozov
ff05162904 change mutex to lock-free 2023-02-05 19:25:09 +03:00
Antonio Andelic
12569da984 Merge branch 'master' into add-support-for-settings-alias 2023-02-05 16:08:57 +00:00
Igor Nikonov
089a0009ad Polishing
+ try to stabilize distinct in order perf test
2023-02-05 13:38:20 +00:00
alexX512
ea07f08f75 Fix bug with wrong checking of execution finish in PullingAsyncPipeline 2023-02-05 13:23:26 +00:00
flynn
f89a6cf68d Improve format JSONColumns when result is empty 2023-02-05 13:13:21 +00:00
kssenii
a7eb1b1419 Fix integration test 2023-02-04 22:57:30 +01:00
Azat Khuzhin
1307e6d323 Fix elapsed column in system.processes (10x error)
Fixes: #43455 (cc @Algunenano)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 22:37:11 +01:00
bkuschel
1f3b1c697f
Add newline 2023-02-04 15:39:28 -05:00
bkuschel
dc995f7c67
Fix size,free ctx,formatting 2023-02-04 15:03:04 -05:00
Boris Kuschel
d9f3698a43
Fix copy/pasta 2023-02-04 14:59:47 -05:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl 2023-02-04 14:59:34 -05:00
Joanna Hulboj
e1f345cc6b Improve behaviour of conversion into Date for boundary value 65535 - with fixed tests 2023-02-04 18:47:42 +00:00
kssenii
5abbc7cad6 Cleanup 2023-02-04 19:41:41 +01:00
kssenii
1cbff88a7c Fix integration test 2023-02-04 19:31:19 +01:00
Alexander Gololobov
4ef09ecc0f
Update gtest_azure_sdk.cpp 2023-02-04 19:05:05 +01:00
xiedeyantu
f13eedd644 change settings name 2023-02-04 22:11:14 +08:00
kssenii
cce23cee51 Fix build 2023-02-04 13:49:32 +01:00
flynn
519bb173e8 Forbid wrong create view syntax 2023-02-04 12:47:17 +00:00
Azat Khuzhin
a3a5867b07 Fix data race in BACKUP
Fixes the following data race:

<details>

WARNING: ThreadSanitizer: data race (pid=1)
  Write of size 8 at 0x7b580016ff20 by thread T218 (mutexes: write M0):
    0 DB::BackupImpl::writeFile() build_docker/../src/Backups/BackupImpl.cpp:1000:9 (clickhouse+0x1bd0b7a6) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)
    1 DB::writeBackupEntries()::$_0::operator()(bool) const build_docker/../src/Backups/BackupUtils.cpp:109:25 (clickhouse+0x1bc19cda) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)

  Previous read of size 8 at 0x7b580016ff20 by thread T238:
    0 DB::BackupImpl::writeFile() build_docker/../src/Backups/BackupImpl.cpp:956:14 (clickhouse+0x1bd0ae8d) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)
    1 DB::writeBackupEntries()::$_0::operator()(bool) const build_docker/../src/Backups/BackupUtils.cpp:109:25 (clickhouse+0x1bc19cda) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 11:09:11 +01:00
Han Fei
9ea3de14ce use re2 by default 2023-02-04 10:53:54 +01:00
Alexey Milovidov
496cacf25e
Merge pull request #45985 from ClickHouse/fix-crash-in-regression
Fix crash in stochasticLinearRegression.
2023-02-04 03:01:46 +01:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Anton Popov
e9f80c650a fix memory leak at creation of curl connection in azure sdk 2023-02-03 20:10:39 +00:00
kssenii
536c02ca8a Adding custom field continued 2023-02-03 21:05:18 +01:00
kssenii
5f124263a6 Revert changes with complex SettingsChanges 2023-02-03 21:04:45 +01:00
Anton Popov
20ebd38242
Merge branch 'master' into fix-sparse-columns-crash 2023-02-03 21:00:02 +01:00
Antonio Andelic
60e5ee84c2 Extract common code 2023-02-03 18:44:56 +00:00
Antonio Andelic
3a8ba689f2 Update tests and system.settings 2023-02-03 18:26:31 +00:00
Antonio Andelic
8929838fcc Merge branch 'master' into add-support-for-settings-alias 2023-02-03 17:47:00 +00:00
Antonio Andelic
8a28279065 Better constraint resolution 2023-02-03 17:34:05 +00:00
vdimir
1e45033531
Update AggregateFunctionSparkbar 2023-02-03 17:22:08 +00:00
Igor Nikonov
f49f5d7091 Update tests
+ updadte sorting properties after applying aggregation in order
2023-02-03 17:10:31 +00:00
Anton Popov
a394f9c92a check is storage supports subcolumns 2023-02-03 17:05:57 +00:00
Alexander Tokmakov
3f11948bb0
Merge branch 'master' into stack_trace_in_part_log 2023-02-03 20:05:00 +03:00
Alexander Tokmakov
7e6f7c79f2
Merge pull request #45457 from FrankChen021/exception_time
Add last_exception_time to replication_queue
2023-02-03 20:00:15 +03:00
kssenii
12b62de374 Add field CustomType 2023-02-03 17:07:02 +01:00
Han Fei
061204408a
Merge pull request #45952 from ucasfl/tuple
Fix tupleElement with Null arguments
2023-02-03 16:15:54 +01:00
Anton Popov
88f2068bfb
Merge branch 'master' into fix-sparse-columns-crash 2023-02-03 16:01:11 +01:00