Commit Graph

37234 Commits

Author SHA1 Message Date
Robert Schulze
783e26d2ba
Cosmetics 2023-02-07 11:42:31 +00:00
Robert Schulze
08c1f8346e
Merge remote-tracking branch 'origin/master' into rs/fix-fragile-linking 2023-02-07 11:22:00 +00:00
Smita Kulkarni
fb765696b6 Removed state_mutex lock from addSubscriber - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 12:19:58 +01:00
Robert Schulze
690d873126
Merge pull request #46088 from ClickHouse/rs/fix-liburing-build
Fix build with `-DENABLE_LIBURING=0` (or `-DENABLE_LIBRARIES=0`)
2023-02-07 12:16:14 +01:00
Sergei Trifonov
950c04cb0e
Merge pull request #44907 from azat/dist/async-INSERT-error-message-fix
Fix error message for a broken distributed batches ("While sending batch")
2023-02-07 12:14:52 +01:00
Vitaly Baranov
f021c0eab6
Merge pull request #46058 from vitlibar/remove-unnecessary-execute-for-const-expr
Remove unnecessary execute() while evaluating a constant expression.
2023-02-07 12:09:37 +01:00
Robert Schulze
f9b6c10700
Merge pull request #46072 from ClickHouse/rs/follow-up-to-46057
Smallish follow-up to #46057
2023-02-07 11:52:51 +01:00
Azat Khuzhin
8cc41b7f41 Check return value of ::close()
Note, that according close(2), EINTR should not be retriable for close()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-07 11:28:22 +01:00
taiyang-li
f41f41c78c fix doc; enable int type for pad 2023-02-07 18:25:36 +08:00
Salvatore Mesoraca
476342602b
Functions: Hashing: add sipHash128Reference{,Keyed} 2023-02-07 11:19:04 +01:00
Salvatore Mesoraca
001b714d3e
Common: SipHash: add original 128-bit output implementation 2023-02-07 11:19:04 +01:00
Smita Kulkarni
135615cda6 Removed unwanted check from before callback - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:27:45 +01:00
Smita Kulkarni
ef29b61786 Updated callback to return log entry ids - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 10:02:38 +01:00
Smita Kulkarni
f34ef86332 Moved background task trigger before getting log entries to wait - Updated checking of SYSTEM SYNC REPLICA 2023-02-07 08:49:41 +01:00
mateng915
708111b62f
Merge branch 'master' into replicas_status_api_optimize 2023-02-07 14:51:27 +08:00
zk_kiger
294cb5acf4
Merge branch 'ClickHouse:master' into improve_format_datetime_joda 2023-02-07 11:59:11 +08:00
kigerzhang
1dbfd5b3f4 Merge remote-tracking branch 'origin/improve_format_datetime_joda' into improve_format_datetime_joda 2023-02-07 10:05:59 +08:00
kigerzhang
46161bc4e9 fix style 2023-02-07 10:03:03 +08:00
Anton Popov
7dfea59267 remove an assertion 2023-02-07 00:50:41 +00:00
Alexander Tokmakov
13da43ead8
Merge branch 'master' into fix_test_00002 2023-02-07 03:25:42 +03:00
Alexey Milovidov
f1b8d1d9d7 Improve performance of Decimal conversion when scale does not change 2023-02-07 00:27:12 +01:00
Anton Popov
3ad5a085da
Merge pull request #45987 from CurtizJ/fix-sparse-columns-crash
Fix `INTERSECT` and `EXCEPT` with sparse columns
2023-02-06 23:01:02 +01:00
Azat Khuzhin
e83163e25f Add sanity check of evtimer_del() in QueryProfiler
Saw this one time on CI with EINVAL [1], while this was EINVAL this
time, next time it can be completelly different fd and break something
in a different place.

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/45654/1716af465d376f5335720b5045bcccdd9e1823aa/fast_test.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-06 20:13:05 +01:00
Han Fei
d1d893275a fix 2023-02-06 18:46:23 +01:00
kssenii
6cea67d58b Cleanup 2023-02-06 18:11:33 +01:00
Robert Schulze
8840aa9242
Fix build with -DENABLE_LIBURING=0 (or -DENABLE_LIBRARIES=0)
Follow-up to #38456

The problem was that code which uses liburing was conditionally build
depending on define OS_LINUX and not based on whether liburing was
enabled/disabled at build time.
2023-02-06 16:57:42 +00:00
Yakov Olkhovskiy
e433c26cf9 allow bloom filter for IPv4 and IPv6 2023-02-06 16:30:18 +00:00
Han Fei
eb76041312 address comments and add one more test 2023-02-06 17:26:20 +01:00
Alexander Tokmakov
af655eb7dc
Merge pull request #45889 from CheSema/release-merge-blocker-drop-part
do not block merges when old parts are droping in drop queries
2023-02-06 19:09:09 +03:00
kssenii
ab0dedf0c8 Simplify code around storage s3 configuration 2023-02-06 16:23:17 +01:00
Anton Popov
3850a1969d
Merge branch 'master' into fix-memory-leak-azure 2023-02-06 16:21:56 +01:00
Suzy Wang
6edbffa3cc
Merge branch 'master' into window_view_fix 2023-02-06 10:06:04 -05:00
alesapin
e999f66234
Merge pull request #46040 from azat/backup-fix-race
Fix data race in BACKUP
2023-02-06 15:20:44 +01:00
Alexander Tokmakov
98a4e1ab2c better comment 2023-02-06 15:08:30 +01:00
Alexander Tokmakov
86feaae253 Merge branch 'master' into explicit_drop_part_entry_type 2023-02-06 14:59:59 +01:00
Alexander Tokmakov
e9f770d89d fix 2023-02-06 14:03:14 +01:00
zk_kiger
602e697b31
Merge branch 'ClickHouse:master' into improve_format_datetime_joda 2023-02-06 20:18:23 +08:00
alesapin
b94f9f8006
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica 2023-02-06 12:38:39 +01:00
Kseniia Sumarokova
38c001ca42
Merge pull request #45957 from xiedeyantu/s3_file_not_found
Throw an error on no files satisfying S3 wildcard
2023-02-06 12:32:12 +01:00
Alexander Gololobov
a784750e66
Merge pull request #45949 from bigo-sg/improve_decimal
Improve performance of ColumnArray::filter/replicate  for big int and decimal
2023-02-06 12:27:19 +01:00
Alexander Gololobov
d18364476d
Merge pull request #46047 from azat/system.processes-elapsed-fix
Fix elapsed column in system.processes (10x error)
2023-02-06 12:26:05 +01:00
Alexey Perevyshin
7a4d658a46
Merge branch 'master' into bug_fix_pulling_pipeline 2023-02-06 14:24:26 +03:00
zk_kiger
4c0d3651c1
Merge branch 'master' into improve_format_datetime_joda 2023-02-06 19:22:45 +08:00
Vladimir C
5686703e79
Merge pull request #46053 from ucasfl/json-columns
Closes https://github.com/ClickHouse/ClickHouse/issues/46024
2023-02-06 12:22:13 +01:00
zk_kiger
b13eaf5e68
Merge branch 'master' into improve_format_datetime_joda 2023-02-06 19:16:10 +08:00
Sema Checherinda
734d3a318b
const auto ref in the loop 2023-02-06 12:09:33 +01:00
Robert Schulze
4c89327c9f
Add TODO comment to MultiVersion.h
Follow-up to #46057
2023-02-06 11:04:58 +00:00
Robert Schulze
fa131edba5
Merge pull request #46057 from k-morozov/refactoring/multiversion-atomic-functions
MultiVersion: change mutex to lock-free
2023-02-06 11:55:27 +01:00
Vladimir C
e3712bb2c6
Merge pull request #45961 from ClickHouse/vdimir/sparkbar-fix 2023-02-06 11:52:15 +01:00
Maksim Kita
e8d66fb1a2 HashedDictionary sharded fix nullable values 2023-02-06 10:50:58 +01:00
taiyang-li
7b10ac8d5b add new metric to record allocations times and bytes using mmap 2023-02-06 17:50:45 +08:00
Antonio Andelic
3c2fafe07e Use correct name resolution 2023-02-06 09:12:03 +00:00
Alexey Perevyshin
10f3c9f640
Merge branch 'master' into bug_fix_pulling_pipeline 2023-02-06 12:00:24 +03:00
Antonio Andelic
7c8a25a18e Correctly use merge tree setting constraints 2023-02-06 08:30:09 +00:00
李扬
444373679a
Merge branch 'master' into improve_decimal 2023-02-06 13:08:51 +08:00
mateng915
3e5d3914ba
Merge branch 'master' into replicas_status_api_optimize 2023-02-06 09:58:31 +08:00
Robert Schulze
4a328828b5
Merge pull request #45758 from ClickHouse/qc-max_cache_size
Make Query Cache server-level settings reconfigurable at runtime
2023-02-05 21:55:37 +01:00
Robert Schulze
84b9ff450f
Fix terribly broken, fragile and potentially cyclic linking
Sorry for the clickbaity title. This is about static method
ConnectionTimeouts::getHTTPTimeouts(). It was be declared in header
IO/ConnectionTimeouts.h, and defined in header
IO/ConnectionTimeoutsContext.h (!). This is weird and caused issues with
linking on s390x (##45520). There was an attempt to fix some
inconsistencies (#45848) but neither did @Algunenano nor me at first
really understand why the definition is in the header.

Turns out that ConnectionTimeoutsContext.h is only #include'd from
source files which are part of the normal server build BUT NOT part of
the keeper standalone build (which must be enabled via CMake
-DBUILD_STANDALONE_KEEPER=1). This dependency was not documented and as
a result, some misguided workarounds were introduced earlier, e.g.
0341c6c54b

The deeper cause was that getHTTPTimeouts() is passed a "Context". This
class is part of the "dbms" libary which is deliberately not linked by
the standalone build of clickhouse-keeper. The context is only used to
read the settings and the "Settings" class is part of the
clickhouse_common library which is linked by clickhouse-keeper already.

To resolve this mess, this PR

- creates source file IO/ConnectionTimeouts.cpp and moves all
  ConnectionTimeouts definitions into it, including getHTTPTimeouts().

- breaks the wrong dependency by passing "Settings" instead of "Context"
  into getHTTPTimeouts().

- resolves the previous hacks
2023-02-05 20:49:34 +00:00
Vitaly Baranov
a3423ce196 Remove unnecessary execute() while evaluating a constant expression. 2023-02-05 20:26:34 +01:00
Han Fei
baa345fa64 remove logs 2023-02-05 18:06:06 +01:00
Han Fei
532b341de9
Merge pull request #45975 from ucasfl/_part
use LowCardnality for _part and _partition_id virtual column
2023-02-05 18:00:46 +01:00
Robert Schulze
9b841d67e8
Merge remote-tracking branch 'origin/master' into qc-max_cache_size 2023-02-05 16:47:02 +00:00
Konstantin Morozov
ff05162904 change mutex to lock-free 2023-02-05 19:25:09 +03:00
Antonio Andelic
12569da984 Merge branch 'master' into add-support-for-settings-alias 2023-02-05 16:08:57 +00:00
Igor Nikonov
089a0009ad Polishing
+ try to stabilize distinct in order perf test
2023-02-05 13:38:20 +00:00
alexX512
ea07f08f75 Fix bug with wrong checking of execution finish in PullingAsyncPipeline 2023-02-05 13:23:26 +00:00
flynn
f89a6cf68d Improve format JSONColumns when result is empty 2023-02-05 13:13:21 +00:00
kssenii
a7eb1b1419 Fix integration test 2023-02-04 22:57:30 +01:00
Azat Khuzhin
1307e6d323 Fix elapsed column in system.processes (10x error)
Fixes: #43455 (cc @Algunenano)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 22:37:11 +01:00
bkuschel
1f3b1c697f
Add newline 2023-02-04 15:39:28 -05:00
bkuschel
dc995f7c67
Fix size,free ctx,formatting 2023-02-04 15:03:04 -05:00
Boris Kuschel
d9f3698a43
Fix copy/pasta 2023-02-04 14:59:47 -05:00
Boris Kuschel
1d4cf4fe69
Add encryption support with openssl 2023-02-04 14:59:34 -05:00
Joanna Hulboj
e1f345cc6b Improve behaviour of conversion into Date for boundary value 65535 - with fixed tests 2023-02-04 18:47:42 +00:00
kssenii
5abbc7cad6 Cleanup 2023-02-04 19:41:41 +01:00
kssenii
1cbff88a7c Fix integration test 2023-02-04 19:31:19 +01:00
Alexander Gololobov
4ef09ecc0f
Update gtest_azure_sdk.cpp 2023-02-04 19:05:05 +01:00
xiedeyantu
f13eedd644 change settings name 2023-02-04 22:11:14 +08:00
kssenii
cce23cee51 Fix build 2023-02-04 13:49:32 +01:00
flynn
519bb173e8 Forbid wrong create view syntax 2023-02-04 12:47:17 +00:00
Azat Khuzhin
a3a5867b07 Fix data race in BACKUP
Fixes the following data race:

<details>

WARNING: ThreadSanitizer: data race (pid=1)
  Write of size 8 at 0x7b580016ff20 by thread T218 (mutexes: write M0):
    0 DB::BackupImpl::writeFile() build_docker/../src/Backups/BackupImpl.cpp:1000:9 (clickhouse+0x1bd0b7a6) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)
    1 DB::writeBackupEntries()::$_0::operator()(bool) const build_docker/../src/Backups/BackupUtils.cpp:109:25 (clickhouse+0x1bc19cda) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)

  Previous read of size 8 at 0x7b580016ff20 by thread T238:
    0 DB::BackupImpl::writeFile() build_docker/../src/Backups/BackupImpl.cpp:956:14 (clickhouse+0x1bd0ae8d) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)
    1 DB::writeBackupEntries()::$_0::operator()(bool) const build_docker/../src/Backups/BackupUtils.cpp:109:25 (clickhouse+0x1bc19cda) (BuildId: 3558ba44526114e01870f02cc410103fa6cb8de3)

</details>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-04 11:09:11 +01:00
Han Fei
9ea3de14ce use re2 by default 2023-02-04 10:53:54 +01:00
Alexey Milovidov
496cacf25e
Merge pull request #45985 from ClickHouse/fix-crash-in-regression
Fix crash in stochasticLinearRegression.
2023-02-04 03:01:46 +01:00
Alexey Milovidov
22bd0b6f69
Merge pull request #38983 from CurtizJ/randomize-mt-settings
Allow to randomize merge tree settings in tests
2023-02-04 02:59:52 +01:00
Anton Popov
e9f80c650a fix memory leak at creation of curl connection in azure sdk 2023-02-03 20:10:39 +00:00
kssenii
536c02ca8a Adding custom field continued 2023-02-03 21:05:18 +01:00
kssenii
5f124263a6 Revert changes with complex SettingsChanges 2023-02-03 21:04:45 +01:00
Anton Popov
20ebd38242
Merge branch 'master' into fix-sparse-columns-crash 2023-02-03 21:00:02 +01:00
Antonio Andelic
60e5ee84c2 Extract common code 2023-02-03 18:44:56 +00:00
Antonio Andelic
3a8ba689f2 Update tests and system.settings 2023-02-03 18:26:31 +00:00
Antonio Andelic
8929838fcc Merge branch 'master' into add-support-for-settings-alias 2023-02-03 17:47:00 +00:00
Antonio Andelic
8a28279065 Better constraint resolution 2023-02-03 17:34:05 +00:00
vdimir
1e45033531
Update AggregateFunctionSparkbar 2023-02-03 17:22:08 +00:00
Igor Nikonov
f49f5d7091 Update tests
+ updadte sorting properties after applying aggregation in order
2023-02-03 17:10:31 +00:00
Anton Popov
a394f9c92a check is storage supports subcolumns 2023-02-03 17:05:57 +00:00
Alexander Tokmakov
3f11948bb0
Merge branch 'master' into stack_trace_in_part_log 2023-02-03 20:05:00 +03:00
Alexander Tokmakov
7e6f7c79f2
Merge pull request #45457 from FrankChen021/exception_time
Add last_exception_time to replication_queue
2023-02-03 20:00:15 +03:00
kssenii
12b62de374 Add field CustomType 2023-02-03 17:07:02 +01:00
Han Fei
061204408a
Merge pull request #45952 from ucasfl/tuple
Fix tupleElement with Null arguments
2023-02-03 16:15:54 +01:00
Anton Popov
88f2068bfb
Merge branch 'master' into fix-sparse-columns-crash 2023-02-03 16:01:11 +01:00
Robert Schulze
85cbb9288c
Merge pull request #45456 from FrankChen021/uncaught_exception
Fix uncaught exception in HTTPHandler
2023-02-03 15:26:02 +01:00
Nikita Mikhaylov
33877b5e00
Parallel replicas. Part [2] (#43772) 2023-02-03 14:34:18 +01:00
Antonio Andelic
d5117f2aa6
Define S3 client with bucket and endpoint resolution (#45783)
* Update aws

* Define S3 client with bucket and endpoint resolution

* Add defines for ErrorCodes

* Use S3Client everywhere

* Remove unused errorcode

* Add DROP S3 CLIENT CACHE query

* Add a comment

* Fix style

* Update aws

* Update reference files

* Add missing include

* Fix unit test

* Remove unneeded declarations

* Correctly use RetryStrategy

* Rename S3Client to Client

* Fix retry count

* fix clang-tidy warnings
2023-02-03 14:30:52 +01:00
Han Fei
2656027c9f make it work if we dont define use_vectorscan macro 2023-02-03 14:25:53 +01:00
Anton Popov
cdbe145bc1
Merge pull request #45796 from CurtizJ/fix-leak-in-azure-sdk
Fix test `test_azure_blob_storage_zero_copy_replication ` (memory leak in azure sdk)
2023-02-03 14:16:19 +01:00
Igor Nikonov
ed00db7580 Update sorting properties after reading in order applied 2023-02-03 13:15:06 +00:00
kssenii
fe3a755064 Fix test after incorrect merge with master 2023-02-03 14:05:59 +01:00
Vitaly Baranov
45d2d678ab
Merge pull request #45800 from vitlibar/rename-new-columns-in-system-backups
Rename new columns in system.backups
2023-02-03 14:00:16 +01:00
Azat Khuzhin
a196f995b1 Fix error message for a broken distributed batches ("While sending batch")
There was an error from the begginning that does not respect
file_indices, and iterate only over file_index_to_path, while this is
not correct, since there can be less files then in file_index_to_path,
and this is what file_indices for.

Note, that only an error message was wrong, logic was fine. You can
verify this by the logs:

    2022.12.07 11:55:50.951976 [ 39217 ] {} <Debug> default.dist.DirectoryMonitor: Sending a batch of 10 files to localhost:9000 (128.42 thousand rows, 36.32 MiB bytes).
    2022.12.07 11:55:50.953762 [ 39217 ] {} <Error> default.dist.DirectoryMonitor: Code: 516. DB::Exception: Received from localhost:9000. DB::Exception: Interserver authentication failed. Stack trace:
    ...
    : While sending batch, nums: 62, files: /work6/clickhouse/data/default/dist/shard1_replica1/66827258.bin

As you can see "Sending a batch of 10 files" but "nums: 62"

Fixes: #23856
Refs: #41813
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-03 13:54:40 +01:00
Alexey Milovidov
3e3df376c0
Merge pull request #45995 from CurtizJ/check-dynamic-columns
Check dynamic columns of part before its commit
2023-02-03 15:39:54 +03:00
Alexey Milovidov
c91b5c264f
Merge pull request #45940 from ClickHouse/fix-uring
Fix IO URing
2023-02-03 15:36:29 +03:00
Sema Checherinda
e0db071563
Merge branch 'master' into release-merge-blocker-drop-part 2023-02-03 13:35:51 +01:00
kssenii
486c10bde1 Fix named collections access 2023-02-03 13:18:54 +01:00
Sema Checherinda
fe0b13e9f4
Merge pull request #45458 from FrankChen021/better_postpone_reason
Show the name of replica that is executing a merge in the postpone_reason
2023-02-03 13:15:10 +01:00
Nikolai Kochetov
9cabbd07cc
Merge branch 'master' into fix-crash-in-regression 2023-02-03 12:38:29 +01:00
Antonio Andelic
cb0e338d70
Revert "Improve behaviour of conversion into Date for boundary value 65535" 2023-02-03 12:10:39 +01:00
Kseniia Sumarokova
ef7acb9b66
Merge pull request #44404 from kssenii/storage-rabbitmq-fix-flush
RabbitMQ - fix writing many small blocks by flushing data only exactly by flush_interval_ms or by max_block_size
2023-02-03 11:50:12 +01:00
Robert Schulze
f72286c8f3
Merge branch 'master' into qc-max_cache_size 2023-02-03 10:54:35 +01:00
Robert Schulze
6908093787
Merge pull request #45973 from ClickHouse/final-codecs
Add "final" specifier to some classes
2023-02-03 10:52:59 +01:00
Antonio Andelic
e507721557
Merge branch 'master' into optimize_parquet_reader 2023-02-03 10:24:18 +01:00
flynn
3d9b8ba991 Merge branch 'master' of github.com:ClickHouse/ClickHouse into tuple 2023-02-03 07:48:57 +00:00
Smita Kulkarni
123f3cfe1f Used unordered_set for log entries and fixed the callback function - Updated checking of SYSTEM SYNC REPLICA 2023-02-03 08:48:16 +01:00
Frank Chen
7831cf85db Revert an extra change 2023-02-03 15:36:12 +08:00
Frank Chen
d38adfab30 Merge two overridden functions as one 2023-02-03 15:27:45 +08:00
flynn
d119367d7d fix 2023-02-03 07:06:58 +00:00
Alexey Milovidov
108d1c3442
Merge pull request #45872 from ClickHouse/fix-trash-query-kind
Remove trash, add a feature and fix a bug
2023-02-03 09:58:43 +03:00
Alexey Milovidov
4e849052d1
Merge pull request #45983 from azat/fuzzy-search-fixes
Avoid leaving symbols leftovers for query fuzzy search
2023-02-03 09:21:05 +03:00
Alexey Milovidov
700503d64a Fix IO URing 2023-02-03 07:00:40 +01:00
chen
07a6de1713
Merge branch 'master' into s3_file_not_found 2023-02-03 12:29:17 +08:00
xiedeyantu
562642ab7f add settings s3_allow_throw_if_mismatch_files 2023-02-03 12:27:13 +08:00
Frank Chen
d3a05a11da Merge remote-tracking branch 'remotes/github/master' into stack_trace_in_part_log 2023-02-03 11:39:43 +08:00
Frank Chen
7af5ae7f2e
Merge branch 'master' into better_postpone_reason 2023-02-03 11:20:37 +08:00
Frank Chen
7ad4b3176a Clean code 2023-02-03 11:13:45 +08:00
Frank Chen
93ead69b7f Resolve review comments 2023-02-03 11:05:54 +08:00
李扬
8b339611b9
Merge branch 'master' into improve_decimal 2023-02-03 11:00:19 +08:00
Anton Popov
8ca602a148 check dynamic columns of part before its commit 2023-02-03 02:58:28 +00:00
Anton Popov
08b618205d fix basic functionality with type Object and new analyzer 2023-02-03 01:52:07 +00:00
Alexey Milovidov
ebbc22bcf1 Fix error 2023-02-03 02:16:30 +01:00
Anton Popov
ca20b1e32f fix INTERSECT and EXCEPT with sparse columns 2023-02-03 00:17:55 +00:00
Alexander Gololobov
ccc96ab9cc
Added BAD_ARGUMENTS 2023-02-02 21:50:13 +01:00
Suzy Wang
503c64a45d Update as suggested 2023-02-02 20:44:32 +00:00
Suzy Wang
716d2c4ffb Update as suggested 2023-02-02 20:41:06 +00:00
kssenii
a391de18a1 Merge remote-tracking branch 'upstream/master' into allow-single-disk-instead-of-storage-policy 2023-02-02 20:49:41 +01:00
Robert Schulze
b1889b0284
Make the naming a little less confusing 2023-02-02 19:18:39 +00:00
Alexey Milovidov
0c7de1941c
Update AggregateFunctionMLMethod.h 2023-02-02 22:14:06 +03:00
Robert Schulze
0e5a10b856
Merge pull request #45751 from ClickHouse/qc-better-logging
Improve logging in Query Cache
2023-02-02 20:11:18 +01:00
Nikolai Kochetov
6b77c1759c Fix crash in stochasticLinearRegression. 2023-02-02 19:08:23 +00:00
Azat Khuzhin
ef2bc589fa Avoid client prompt overlap after query fuzzy search
Under certain conditions it is possible for skim to overlap the prompt,
well, not overlap, but not re-render it, and so the client does not have
a nice prompt.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-02 19:31:45 +01:00
Antonio Andelic
a12d87890f
Merge branch 'master' into optimize_parquet_reader 2023-02-02 17:45:00 +01:00
flynn
2d1dd694c6 make _table LowCardinality 2023-02-02 16:33:31 +00:00
flynn
f88a8bac19 fix 2023-02-02 16:22:09 +00:00
flynn
bc38ebaf52 use LowCardnality for _part and _partition_id virtual column
fix
2023-02-02 16:20:29 +00:00
pufit
0c13870eb1
Merge pull request #44680 from FFFFFFFHHHHHHH/corrMatrix
add corrMatrix,covarSampMatrix,covarPopMatrix AggregateFunction
2023-02-02 11:06:06 -05:00
Suzy Wang
1619971b95
Merge branch 'master' into window_view_fix 2023-02-02 11:04:38 -05:00
Robert Schulze
3472ed4f0d
Make some classes 'final' 2023-02-02 15:59:39 +00:00
Alexey Milovidov
0ba246ca53
Merge pull request #45914 from jh0x/improve-into-date-from-uint16
Improve behaviour of conversion into Date for boundary value 65535
2023-02-02 18:54:53 +03:00
Yakov Olkhovskiy
57f26f8c7e
Merge pull request #45865 from ClickHouse/fix-ipv4-cast
Allow implicit narrowing conversion UInt64 => IPv4
2023-02-02 10:53:23 -05:00
vdimir
212b800771
wip AggregateFunctionSparkbar 2023-02-02 15:44:21 +00:00
Alexander Gololobov
ec3bb0c04e
Merge pull request #45794 from ClickHouse/parallelize_is_storage_touched_by_mutations
Do not restrict count() query to 1 thread in isStorageTouchedByMutations()
2023-02-02 16:44:11 +01:00
Kseniia Sumarokova
6705fafef9
Merge branch 'master' into storage-rabbitmq-fix-flush 2023-02-02 16:06:51 +01:00
Han Fei
a2e43bc333 log for ci 2023-02-02 14:40:09 +01:00
vdimir
91c93ba8f8
Update AggregateFunctionSparkbar 2023-02-02 13:23:46 +00:00
Antonio Andelic
a39e4e24c6
Merge branch 'master' into optimize_parquet_reader 2023-02-02 14:18:00 +01:00
Sema Checherinda
44be0f41dd
Merge branch 'master' into release-merge-blocker-drop-part 2023-02-02 14:12:40 +01:00
Antonio Andelic
f613bfd8d2 Merge branch 'master' into add-support-for-settings-alias 2023-02-02 11:15:39 +00:00
xiedeyantu
e22cc0eb98 Throw an error on no files satisfying S3 wildcard 2023-02-02 19:13:34 +08:00
Robert Schulze
8055b7ed07
Merge branch 'master' into qc-better-logging 2023-02-02 11:45:37 +01:00
Robert Schulze
53e1c9cd08
Merge branch 'master' into qc-max_cache_size 2023-02-02 11:45:29 +01:00
taiyang-li
fd05d3516c improve performance of ColumnArray::replicate for big int and decimal 2023-02-02 17:21:41 +08:00
Vitaly Baranov
b8078acce2
Merge pull request #45774 from vitlibar/wiping-sensitive-info-in-named-collection-overrides
Mask sensitive info in named collection's overrides
2023-02-02 10:06:59 +01:00
flynn
8513e5a721 Fix tupleElement with Null arguments 2023-02-02 08:48:13 +00:00
taiyang-li
52d5428d0a improve performance of ColumnArray::filter 2023-02-02 15:42:58 +08:00
Yakov Olkhovskiy
f5811a3d5a
Merge branch 'master' into fix-unsorted-array 2023-02-01 22:36:52 -05:00
Alexey Milovidov
20ab290e78 Merge remote-tracking branch 'origin/master' into fix-trash-query-kind 2023-02-02 04:36:40 +01:00
Alexey Milovidov
87acc6e1f3
Merge pull request #45888 from ClickHouse/fix-tidy-build
Fix clang-tidy error in Keeper `Changelog`
2023-02-02 06:34:54 +03:00
Alexey Milovidov
62bfdb349a Merge branch 'master' into fix-trash-query-kind 2023-02-02 04:26:49 +01:00
Alexey Milovidov
099532ecc5
Merge pull request #45867 from Algunenano/improve_obfuscator
Improve how the obfuscator deals with queries
2023-02-02 04:23:06 +03:00
Alexey Milovidov
8e684170fe Fix even more trash 2023-02-02 02:11:16 +01:00
Alexey Milovidov
97b6934ed6
Update ParquetBlockInputFormat.cpp 2023-02-02 02:42:21 +03:00
Alexey Milovidov
1682078f1a
Merge pull request #45873 from FFFFFFFHHHHHHH/dev_format
Allow a three-argument version for table function format
2023-02-02 02:40:31 +03:00
Suzy Wang
5b3054492d
Update src/Interpreters/Aggregator.h
Co-authored-by: Yakov Olkhovskiy <99031427+yakov-olkhovskiy@users.noreply.github.com>
2023-02-01 15:21:34 -05:00
Sema Checherinda
7c416477ac do not run wal on remote disks 2023-02-01 20:03:45 +01:00
Joanna Hulboj
e57492c214 Improve behaviour of conversion into Date for boundary value 65535 2023-02-01 18:22:06 +00:00
Nikolay Degterinsky
542f54cf2d
Merge pull request #45829 from Algunenano/fix_qualified_asterisk_children
Fix ASTQualifiedAsterisk cloning
2023-02-01 19:20:47 +01:00
kssenii
bbf060bf89 Fix test 2023-02-01 18:22:05 +01:00
Sema Checherinda
3e1b17e4cf
fix build 2023-02-01 17:09:43 +01:00
Anton Popov
9f26e16963 loose the assertion 2023-02-01 15:31:06 +00:00
Anton Popov
8dd6dbc452
Merge pull request #45857 from CurtizJ/fix-minor-mistake
Fix minor mistake after refactoring
2023-02-01 15:33:19 +01:00
Sema Checherinda
41a1dddc7a
Merge branch 'master' into better_postpone_reason 2023-02-01 15:16:34 +01:00
Han Fei
90153c11fc fix matching priority 2023-02-01 15:09:04 +01:00
Antonio Andelic
85cfee4bb9 Better alias definition 2023-02-01 13:54:03 +00:00
Alexander Tokmakov
aba4a00a17 fix 2023-02-01 14:47:57 +01:00
Nikolai Kochetov
6cd0b51127
Merge pull request #45871 from ClickHouse/fix-ipv6-parser
Fix ipv6 parser
2023-02-01 14:28:54 +01:00
Antonio Andelic
88c1744975
Better 2023-02-01 14:25:58 +01:00
Sema Checherinda
db2aa48c91 do not block merges when old parts are droping in drop queries 2023-02-01 13:30:56 +01:00
Antonio Andelic
5de6f86c27 Fix clang-tidy error 2023-02-01 12:28:44 +00:00
Vladimir C
7c6281c446
Merge pull request #45581 from Avogar/fix-date-inference 2023-02-01 13:04:12 +01:00
Vladimir C
0d48eed68f
Merge pull request #45848 from Algunenano/fix_connection_timeouts_context_include 2023-02-01 12:53:50 +01:00
Vladimir C
dad838859b
Merge pull request #44489 from canhld94/ch_canh_fix_sparkbar 2023-02-01 12:50:00 +01:00
Igor Nikonov
04c9fcddcb
Merge pull request #45822 from taofengliu/planner_bug
A bug fix for Planner
2023-02-01 12:43:24 +01:00
Igor Nikonov
5143131179
Merge pull request #45817 from taofengliu/bug_fix
A bug fix for QueryTreeBuilder
2023-02-01 11:44:42 +01:00
Robert Schulze
216636f984
Make query cache global settings re-configurable 2023-02-01 10:35:19 +00:00
liuneng
17fc22a21e add parquet max_block_size setting 2023-02-01 18:29:20 +08:00
Robert Schulze
8a9493aeb9
Update QueryCache.cpp 2023-02-01 11:28:00 +01:00
Robert Schulze
f6259fbd65
Query cache: Improve logging 2023-02-01 10:24:17 +00:00
Robert Schulze
b512316586
Merge pull request #45682 from ClickHouse/rename-qrc-to-qc
Rename "Query Result Cache" to "Query Cache"
2023-02-01 11:23:29 +01:00
Raúl Marín
61dfebd299 Upstyle 2023-02-01 11:11:03 +01:00
Alexander Gololobov
e705f11ad1
Merge pull request #45786 from ClickHouse/delete_on_cluster
Support DELETE ON CLUSTER
2023-02-01 10:52:01 +01:00
Antonio Andelic
ec04cf6876 Merge branch 'master' into add-support-for-settings-alias 2023-02-01 09:01:01 +00:00
Antonio Andelic
a3e3b65b32
Merge branch 'master' into keeper-use-fallocate 2023-02-01 09:05:49 +01:00
liuneng
cda9b0beea optimize parquet reader 2023-02-01 15:54:10 +08:00
robot-ch-test-poll2
202fa9fa37
Merge pull request #45859 from FArthur-cmd/show_engines_support
Add support for SHOW ENGINES query
2023-02-01 07:32:56 +01:00
FFFFFFFHHHHHHH
eca344eff1
Update src/TableFunctions/TableFunctionFormat.cpp
Co-authored-by: flynn <fenglv15@mails.ucas.ac.cn>
2023-02-01 14:12:36 +08:00
Alexey Milovidov
bf9f62dcbd
Merge pull request #38456 from sauliusvl/iouring
Re-introduce io_uring read method
2023-02-01 06:41:32 +03:00
fhbai
d0fc3d9d4e allow a three-argument version for table function format 2023-02-01 11:17:14 +08:00
Alexey Milovidov
9b908a0be0 Fix trash around query kind, part 2 2023-02-01 03:31:31 +01:00
Alexey Milovidov
5c4db119fa Fix trash around query kind, part 1 2023-02-01 03:11:54 +01:00
Alexey Milovidov
c7f9cf6587
Update InterpreterShowEngineQuery.h 2023-02-01 04:57:58 +03:00
Yakov Olkhovskiy
3d64c84571 fix ipv6 parser 2023-02-01 01:02:58 +00:00
Alexey Milovidov
95e267561a
Update AggregateFunctionSparkbar.h 2023-02-01 00:46:37 +03:00
Vitaly Baranov
96b140cc95 Rename columns in system.backups: num_files, num_processed_files, processed_files_size
num_processed_files -> num_files (BACKUP) / files_read (RESTORE)
processed_files_size -> total_size (BACKUP) / bytes_read (RESTORE)
2023-01-31 22:45:41 +01:00
Alexey Milovidov
1cb7574498
Update AggregateFunctionSparkbar.h 2023-02-01 00:44:27 +03:00
Raúl Marín
0b201ebff2 Improve how the obfuscator deals with queries 2023-01-31 20:19:32 +01:00
Yakov Olkhovskiy
f4ef21cb2f allow implicit narrowing conversion UInt64 => IPv4 2023-01-31 19:04:21 +00:00
Alexey Milovidov
075dfe9005
Merge pull request #45750 from ucasfl/arrow-duration
Arrow support duration type
2023-01-31 20:34:38 +03:00
kssenii
4a1bdcf24c Merge remote-tracking branch 'upstream/master' into storage-rabbitmq-fix-flush 2023-01-31 18:11:26 +01:00
Antonio Andelic
ece92fa866
Update src/Coordination/Changelog.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-01-31 17:11:18 +01:00
Han Fei
24b8322bc9 Merge branch 'master' into hanfei/regexp-refine 2023-01-31 17:03:51 +01:00
Anton Popov
1c4174750d fix mistake after refactoring 2023-01-31 15:48:14 +00:00
FArthur-cmd
a8e38738e9 add support for show engines query 2023-01-31 18:35:10 +03:00
Raúl Marín
7c31cb7adc Proper includes for ConnectionTimeoutsContext.h 2023-01-31 16:11:32 +01:00
Alexander Gololobov
96cb23a6a1 Break on first non-empty block 2023-01-31 15:49:56 +01:00
Antonio Andelic
8457d3bf3d Apply comments 2023-01-31 14:18:54 +00:00
Han Fei
716518f143
Merge branch 'master' into hanfei/gwp-asan 2023-01-31 15:01:25 +01:00
Antonio Andelic
1786237be6 Merge branch 'master' into keeper-use-fallocate 2023-01-31 13:53:47 +00:00
Vitaly Baranov
6165625e27
Update src/Parsers/ASTFunction.cpp
Co-authored-by: SmitaRKulkarni <64093672+SmitaRKulkarni@users.noreply.github.com>
2023-01-31 14:43:48 +01:00
Vitaly Baranov
c6be69568a
Update src/Parsers/ASTFunction.cpp
Co-authored-by: SmitaRKulkarni <64093672+SmitaRKulkarni@users.noreply.github.com>
2023-01-31 14:43:30 +01:00
Robert Schulze
5f91a78fda
Merge pull request #45652 from ClickHouse/block-delta-gorilla
Mark delta/doubledelta codec followed by Gorilla/FPC as suspicious
2023-01-31 14:06:57 +01:00
Raúl Marín
bacfe7ffa5 Fix ASTQualifiedAsterisk cloning 2023-01-31 14:02:46 +01:00
taiyang-li
7825ee95e9 merge master and solve conflicts 2023-01-31 20:49:59 +08:00
taofengliu
aae5d302be bug fix 2023-01-31 20:49:21 +08:00
Alexander Tokmakov
7862990721 Merge branch 'master' into explicit_drop_part_entry_type 2023-01-31 13:49:04 +01:00
Alexander Tokmakov
2e8100b6e4 make separate DROP_PART log entry type 2023-01-31 13:37:56 +01:00
Anton Popov
9f4658151e
Merge pull request #45799 from ClickHouse/func-iptypes-empty
Add empty/notEmpty function support for IP types
2023-01-31 13:37:23 +01:00
Alexander Tokmakov
51b0f66e6b
Merge pull request #45793 from ClickHouse/fix_part_check_cancellation
Fix race condition on a part check cancellation
2023-01-31 14:15:17 +03:00
FFFFFFFHHHHHHH
eb7df4e403 fix 2023-01-31 18:45:37 +08:00
刘陶峰
2014cc5fa7
Merge branch 'master' into bug_fix 2023-01-31 18:42:52 +08:00
taofengliu
95ebfbe0c7 bug fix 2023-01-31 18:34:17 +08:00
Robert Schulze
170fff16e4
Merge pull request #45816 from ClickHouse/minor-doc-fixes
Minor doc follow-up to #45382
2023-01-31 11:32:48 +01:00
Kseniia Sumarokova
7d53f8bbf6
Merge pull request #45591 from bharatnc/ncb/odbc-connection-pool-fixes
fixes to use the odbc_bridge_use_connection_pooling setting correctly
2023-01-31 11:31:59 +01:00
Robert Schulze
44a5e9cb17
Minor doc follow-up to #45382 2023-01-31 10:31:01 +00:00
Robert Schulze
fdd6c77480
Merge pull request #45382 from bigo-sg/improve_position
Add fastpath for function position when needle is empty
2023-01-31 11:22:31 +01:00
taiyang-li
d2e97fb94d remove columnar impl when instructions contains short 2023-01-31 18:13:01 +08:00
taiyang-li
2d7c357d61 implement columnar version for multiIf when instructions contains short 2023-01-31 18:00:31 +08:00
Robert Schulze
325c6bdf3d
Renaming: "Query Result Cache" --> "Query Cache"
Reasons:

- The cache will at some point store intermediate results as opposed to
  only query results. We should change the terminology now without
  having to worry about backward compat.

- Equivalent caches in MySQL (1) and Starrocks (2) are called "query
  cache".

- The new name is ca. 13.8% more catchy.

(1) https://dev.mysql.com/doc/refman/5.6/en/query-cache.html
(2) https://docs.starrocks.io/en-us/2.5/using_starrocks/query_cache
2023-01-31 09:54:34 +00:00
Robert Schulze
659a64a1d9
Merge pull request #45679 from ClickHouse/untangle-query-result-cache-settings
Untangle configuration of query result cache
2023-01-31 10:44:14 +01:00
Alexander Gololobov
f9133f3d85
Merge pull request #45791 from ClickHouse/fix_drop_hung
Fix bug in tables drop which can lead to potential query hung
2023-01-31 10:11:11 +01:00
FFFFFFFHHHHHHH
c64ffc6389 fix style 2023-01-31 15:59:35 +08:00
FFFFFFFHHHHHHH
0a6cc61fd9 Merge branch 'corrMatrix' of github.com:FFFFFFFHHHHHHH/ClickHouse into corrMatrix 2023-01-31 15:50:28 +08:00
FFFFFFFHHHHHHH
78f2d6fb25 fix 2023-01-31 15:44:33 +08:00
taiyang-li
4cf11d9a84 change as request 2023-01-31 10:48:02 +08:00
kigerzhang
e1c9b8c155 Add new functionality to the function FormatDataTime 2023-01-31 10:20:59 +08:00
Duc Canh Le
e8ebd2e845 updateFrame returns size_t 2023-01-31 10:04:19 +08:00
Duc Canh Le
ae98847d31 Merge branch 'master' into ch_canh_fix_sparkbar 2023-01-31 10:01:16 +08:00
Alexey Milovidov
40b00432d2
Merge pull request #45737 from chhetripradeep/pchhetri/fix-45690
Set compression method and level for backup writer
2023-01-31 04:14:57 +03:00
Alexey Milovidov
7aa10a430a
Merge branch 'master' into hanfei/gwp-asan 2023-01-31 04:13:59 +03:00
Anton Popov
31e8b692f4 fix typo 2023-01-31 01:13:23 +00:00
Anton Popov
839cd614fb fix memory leak in azure sdk 2023-01-31 01:01:10 +00:00
Bharat Nallan
f1d6e3b908
Merge branch 'master' into ncb/odbc-connection-pool-fixes 2023-01-30 15:49:04 -08:00
Alexander Gololobov
93b82a2c44 Use multithreaded executor in isStorageTouchedByMutations() 2023-01-30 23:48:52 +01:00
Ilya Yatsishin
8d6df7ed58
Merge pull request #45785 from Algunenano/generate_random_types 2023-01-30 23:03:12 +01:00
Alexander Gololobov
4eea3de654 Do not restrict count() query to 1 thread in isStorageTouchedByMutations() 2023-01-30 22:29:28 +01:00
Yakov Olkhovskiy
79d82a3587 add empty/notEmpty function support for IP types 2023-01-30 20:37:08 +00:00
Alexey Milovidov
f46bfaa1c9
Merge pull request #45760 from ClickHouse/fix-trash
Remove trash
2023-01-30 22:53:32 +03:00
Vitaly Baranov
d95d8bcb26 Rename isCollectionNameArgument() -> isNamedCollectionName() and add comments. 2023-01-30 19:31:32 +01:00
Alexander Tokmakov
e42cd3163f fix race condition on a part check cancellation 2023-01-30 18:48:20 +01:00
Alexander Gololobov
863548114d force_wait flag is no longer needed 2023-01-30 18:38:28 +01:00
Pradeep Chhetri
455bd1a14a
Merge branch 'master' into pchhetri/fix-45690 2023-01-31 00:48:46 +08:00
Vitaly Baranov
2e3a3cc4dc
Merge pull request #45701 from vitlibar/add-setting-allow-head-object-request
Add new S3 setting allow_head_object_request
2023-01-30 17:41:09 +01:00
Bharat Nallan Chakravarthy
0d2e4fcc15 set use_connection_pooling from settings everywhere 2023-01-30 08:22:48 -08:00
alesapin
9ecf6e70a9 Make disk object storage compatible with other storages 2023-01-30 17:16:07 +01:00
Robert Schulze
abac59477b
Update src/Core/Settings.h
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
2023-01-30 17:12:01 +01:00
Robert Schulze
b42383f0d4
Update src/Core/Settings.h
Co-authored-by: Igor Nikonov <954088+devcrafter@users.noreply.github.com>
2023-01-30 17:11:53 +01:00
Han Fei
4971358de5 fix init 2023-01-30 17:07:01 +01:00
alesapin
be58d5d1af Fix bug in tables drop which can lead to potential query hung 2023-01-30 17:00:28 +01:00
Alexander Gololobov
de841b29c7 Support delete ON CLUSTER 2023-01-30 16:42:52 +01:00
Arthur Passos
7b1ceaa2c5
Merge branch 'master' into fix_cares_crash 2023-01-30 12:05:56 -03:00
Arthur Passos
513f430334 Add setting to enable/disable reverseDNSQuery function 2023-01-30 12:04:37 -03:00
Alexander Gololobov
386ae9266d Rewrite DELETE into ALTER UPDATE _row_exists=0 2023-01-30 15:46:17 +01:00
Raúl Marín
997fad4e8d GenerateRandom: Add support for maps 2023-01-30 15:23:22 +01:00
Robert Schulze
27b978381b
Use more speaking setting names 2023-01-30 14:20:43 +00:00
Pradeep Chhetri
deaa70fb14
Merge branch 'master' into pchhetri/fix-45690 2023-01-30 21:35:16 +08:00
Raúl Marín
05d8cfc714 GenerateRandom: Add support to IPv4 and IPv6 types 2023-01-30 14:18:25 +01:00
Vladimir C
e7e8ae979f
Merge pull request #45271 from jh0x/feature-array-shuffle 2023-01-30 11:54:07 +01:00
Vitaly Baranov
6ee9971931 Mask sensitive info in named collection's overrides. 2023-01-30 11:33:21 +01:00
Robert Schulze
7cc1c19227
Fix typo 2023-01-30 10:25:16 +00:00
Robert Schulze
66392b873c
Merge pull request #45513 from aiven-sal/aiven-sal/siphash_pr
Keyed SipHash
2023-01-30 11:10:00 +01:00
Robert Schulze
8fa9db3c8b
Merge pull request #45757 from ClickHouse/rs-fix-typo
Fix typo + add boringssl comment
2023-01-30 11:06:57 +01:00
taiyang-li
c45111349f Merge branch 'master' into improve_multi_if 2023-01-30 16:32:55 +08:00
Vitaly Baranov
38910412c4
Merge pull request #42244 from AVMusorin/fix_backup_restore_num_files
Added num_processed_files and processed_files_size for backup and restore processes
2023-01-30 09:24:49 +01:00