Commit Graph

82920 Commits

Author SHA1 Message Date
Anton Popov
79144f8b91
Update 02211_shcema_inference_from_stdin.sh 2022-02-14 17:26:48 +03:00
avogar
a1759d1aa0 Fix test 2022-02-10 18:38:28 +03:00
avogar
7d92d9d060 Fix tests 2022-02-10 18:37:27 +03:00
avogar
a69905d378 Fix 2022-02-10 18:23:52 +03:00
avogar
9bbbbdcdd6 Improve schema inference in clickhouse-local 2022-02-10 18:23:52 +03:00
Kruglov Pavel
738355b724
Merge pull request #34408 from vitlibar/split-and-rename-compression-fields-in-grpc
Split and rename compression fields in gRPC
2022-02-10 15:40:20 +03:00
Kruglov Pavel
bf8c028533
Merge pull request #34479 from Avogar/fix-filesystem-error
Fix possible error 'file_size: Operation not supported'
2022-02-10 14:17:05 +03:00
Kruglov Pavel
a4f5610764
Merge pull request #34476 from CurtizJ/avoid-settings-copy
Avoid unnecessary copying of `Settings`
2022-02-10 14:13:46 +03:00
Maksim Kita
309af64475
Merge pull request #34475 from DevTeamBK/nested_column
accessing nested_column after already moved to data
2022-02-10 11:34:19 +01:00
Maksim Kita
9a757c0ed1
Merge pull request #34471 from den-crane/test/13907
test for #13907 toColumnTypeName_toLowCardinality_const
2022-02-10 11:30:10 +01:00
Maksim Kita
3a0e71ca14
Merge pull request #34472 from genzgd/fix_rocks_m1
Remove invalid IOS setting for RocksDB CMAKE to fix Apple M1 build
2022-02-10 11:26:36 +01:00
Maksim Kita
7a30d490a1
Merge pull request #34406 from ClickHouse/fix-removing-order-in-CreatingSetsTransform
Fix wrong destruction order in CreatingSetsTransform.
2022-02-10 11:24:18 +01:00
Kruglov Pavel
8385dc27c2
Fix test 2022-02-10 12:19:01 +03:00
Anton Popov
298838f891 avoid unnecessary copying of Settings 2022-02-10 12:13:51 +03:00
Nikolay Degterinsky
fe7cdd14f7
Merge pull request #34481 from cnmade/PR202202101442
sync translate to zh: Update roadmap.md
2022-02-10 10:46:39 +03:00
Nikolay Degterinsky
34092fa2a3
Merge pull request #34401 from LittleJake/patch-1
Update query_thread_log.md
2022-02-10 09:45:37 +03:00
cnmade
c9d27fcea3 sync translate to zh: Update roadmap.md 2022-02-10 14:45:34 +08:00
alexey-milovidov
6a9f570efd
Update roadmap.md 2022-02-10 09:26:37 +03:00
avogar
bfa96463ca Fix possible error 'file_size: Operation not supported' 2022-02-10 09:23:27 +03:00
mergify[bot]
5577492e30
Merge branch 'master' into test/13907 2022-02-09 21:14:38 +00:00
Vitaly Baranov
77d9cddfec Replace clickhouse_grpc.proto in a test with symlink. 2022-02-10 02:46:05 +07:00
Vitaly Baranov
1341b4b4de Rename QueryInfo's field result_compression -> transport_compression_type and change its type for better consistency.
Make the previous field obsolete.
2022-02-10 02:46:05 +07:00
Vitaly Baranov
1f6b65d39d gRPC: Split compression_type field into input_compression_type and output_compression_type.
Make the previous field obsolete.
2022-02-10 02:46:05 +07:00
Maksim Kita
15e1da5bef
Merge pull request #34434 from cnmade/PF202202091030
sync to zh: sql-reference/data-types/int-uint: sync translate to zh
2022-02-09 20:38:11 +01:00
Rajkumar
b6a1a13327 clang-tidy reported nested_column already moved to data 2022-02-09 11:36:31 -08:00
Geoff Genz
d19ee89d9d Remove invalid IOS setting for RocksDB CMAKE to fix Apple M1 build 2022-02-09 12:17:23 -07:00
Denny Crane
ca0d78295a test for #13907 toColumnTypeName_toLowCardinality_const 2022-02-09 14:19:50 -04:00
mergify[bot]
6925e3d2bc
Merge branch 'master' into PF202202091030 2022-02-09 16:27:17 +00:00
Maksim Kita
e0dfc9cd38
Merge pull request #34454 from kitaisreal/dictionary-get-http-json-test
Added test 33734
2022-02-09 17:21:03 +01:00
Kruglov Pavel
4ec8da73c4
Merge pull request #34448 from Avogar/fix-url-engine
Fix bug in URL engine
2022-02-09 19:19:05 +03:00
mergify[bot]
d78525bd10
Merge branch 'master' into fix-removing-order-in-CreatingSetsTransform 2022-02-09 13:55:52 +00:00
Nikolai Kochetov
38fb50f736
Merge pull request #33958 from Algunenano/mv_cacheable_scalars
Scalar cache improvements
2022-02-09 16:46:53 +03:00
Maksim Kita
0658fb3256 Added test 33734 2022-02-09 12:06:17 +00:00
Anton Popov
822b58247a
Merge pull request #34132 from CurtizJ/fix-distributed-inserts
Fix inserts to distributed tables in case of change of native protocol
2022-02-09 14:58:44 +03:00
Kruglov Pavel
e0e36c256e
Fix style 2022-02-09 14:44:46 +03:00
Maksim Kita
9f29c977de
Merge pull request #34234 from azat/agg-leak
Fix memory leak in AggregatingInOrderTransform
2022-02-09 12:42:04 +01:00
Kruglov Pavel
4ec0f6f091
Merge pull request #33824 from ManagedDatabases/client-fault-tolerant-connection
Client fault tolerant connection
2022-02-09 14:26:11 +03:00
alesapin
f1762de790
Merge pull request #34450 from ClickHouse/fix_style
Fix style
2022-02-09 14:14:23 +03:00
alesapin
b84a171aa7 Fix style 2022-02-09 14:13:53 +03:00
Kruglov Pavel
892e9e80d3
Merge pull request #34415 from Avogar/short-circuit-bug
Fix possible error 'Cannot convert column Function to mask'
2022-02-09 14:04:30 +03:00
mergify[bot]
fd5caa3196
Merge branch 'master' into short-circuit-bug 2022-02-09 11:04:19 +00:00
avogar
7baf23f35f Fix bug URL engine 2022-02-09 13:53:54 +03:00
alesapin
437940b29d
Merge pull request #34422 from ClickHouse/add_settings_to_part_size_in_s3
Add settings for multipart upload part size in s3
2022-02-09 12:51:20 +03:00
mergify[bot]
fe39f2bd83
Merge branch 'master' into patch-1 2022-02-09 09:47:20 +00:00
Nikolay Degterinsky
05b89ee865
Merge pull request #34443 from fanofxiaofeng/patch-3
remove (nearly) duplicated description
2022-02-09 12:41:54 +03:00
Anton Popov
4d6e048d46
Merge pull request #34435 from fanofxiaofeng/patch-2
the `name` field seems to be missing
2022-02-09 11:56:37 +03:00
靳阳
cad23926aa
remove (nearly) duplicate description
remove (nearly) duplicate description
2022-02-09 16:48:31 +08:00
Kseniia Sumarokova
e4d6125dd5
Merge pull request #34410 from kssenii/fixing-test-storage-postgresql
Fixing test_storage_postgresql
2022-02-09 09:36:54 +01:00
Kseniia Sumarokova
86956ca08b
Merge pull request #34392 from kssenii/http-buffer-skip-not-found-url-for-globs
Allow to skip not found urls for globs
2022-02-09 09:32:09 +01:00
Azat Khuzhin
4fa2ae76bc Fix memory leak in AggregatingInOrderTransform
Reproducer:

    # NOTE: we need clickhouse from 33957 since right now LSan is broken due to getauxval().
    $ url=https://s3.amazonaws.com/clickhouse-builds/33957/e04b862673644d313712607a0078f5d1c48b5377/package_asan/clickhouse
    $ wget $url -o clickhouse-asan
    $ chmod +x clickhouse-asan
    $ ./clickhouse-asan server &

    $ ./clickhouse-asan client
    :) create table data (key Int, value String) engine=MergeTree() order by key
    :) insert into data select number%5, toString(number) from numbers(10e6)

    # usually it is enough one query, benchmark is just for stability of the results
    # note, that if the exception was not happen from AggregatingInOrderTransform then add --continue_on_errors and wait
    $ ./clickhouse-asan benchmark --query 'select key, uniqCombined64(value), groupArray(value) from data group by key' --optimize_aggregation_in_order=1 --memory_tracker_fault_probability=0.01, max_untracked_memory='2Mi'

LSan report:

    ==24595==ERROR: LeakSanitizer: detected memory leaks

    Direct leak of 3932160 byte(s) in 6 object(s) allocated from:
        0 0xcadba93 in realloc ()
        1 0xcc108d9 in Allocator<false, false>::realloc() obj-x86_64-linux-gnu/../src/Common/Allocator.h:134:30
        2 0xde19eae in void DB::PODArrayBase<>::realloc<DB::Arena*&>(unsigned long, DB::Arena*&) obj-x86_64-linux-gnu/../src/Common/PODArray.h:161:25
        3 0xde5f039 in void DB::PODArrayBase<>::reserveForNextSize<DB::Arena*&>(DB::Arena*&) obj-x86_64-linux-gnu/../src/Common/PODArray.h
        4 0xde5f039 in void DB::PODArray<>::push_back<>(DB::GroupArrayNodeString*&, DB::Arena*&) obj-x86_64-linux-gnu/../src/Common/PODArray.h:432:19
        5 0xde5f039 in DB::GroupArrayGeneralImpl<>::add() const obj-x86_64-linux-gnu/../src/AggregateFunctions/AggregateFunctionGroupArray.h:465:31
        6 0xde5f039 in DB::IAggregateFunctionHelper<>::addBatchSinglePlaceFromInterval() const obj-x86_64-linux-gnu/../src/AggregateFunctions/IAggregateFunction.h:481:53
        7 0x299df134 in DB::Aggregator::executeOnIntervalWithoutKeyImpl() obj-x86_64-linux-gnu/../src/Interpreters/Aggregator.cpp:869:31
        8 0x2ca75f7d in DB::AggregatingInOrderTransform::consume() obj-x86_64-linux-gnu/../src/Processors/Transforms/AggregatingInOrderTransform.cpp:124:13

    ...

    SUMMARY: AddressSanitizer: 4523184 byte(s) leaked in 12 allocation(s).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-02-09 09:23:56 +03:00