Commit Graph

57740 Commits

Author SHA1 Message Date
Azat Khuzhin
80f448a466 tests/integration: preserve mysql docker logs in test_materialize_mysql_database 2021-02-20 22:09:01 +03:00
Azat Khuzhin
6873ad1983 tests/integration: fix yamllint issues in docker-compose.yaml for mysql 2021-02-20 22:09:01 +03:00
robot-clickhouse
e49d90405c Update version_date.tsv after release 20.12.7.3 2021-02-20 20:39:18 +03:00
robot-clickhouse
4fa822dd28 Update version_date.tsv after release 21.1.5.4 2021-02-20 20:21:55 +03:00
tavplubix
a697b578bc
Merge pull request #16193 from ClickHouse/database_replicated
DatabaseReplicated: continuation of #10485
2021-02-20 19:39:34 +03:00
robot-clickhouse
fe159de141 Update version_date.tsv after release 21.2.4.6 2021-02-20 19:30:27 +03:00
alexey-milovidov
316cdf5039
Merge pull request #20978 from ClickHouse/little-better
Just little better
2021-02-20 17:53:07 +03:00
alexey-milovidov
e336abad1c
Merge pull request #20981 from azat/http-client-reset-uncaught-exception
Fix uncaught exception when HTTP client goes away
2021-02-20 16:30:04 +03:00
Alexander Tokmakov
863c099254 fix 2021-02-20 15:57:07 +03:00
alexey-milovidov
04f5b72391
Merge pull request #20995 from amosbird/ubsanfix2
Suppress signed overflow in AggregateFunctionGroupArrayMoving 2
2021-02-20 14:25:36 +03:00
Maksim Kita
c5643c47d0
Merge pull request #20970 from kitaisreal/function-sum-map-decimal-fix
Function sumMap decimal fix
2021-02-20 13:43:12 +03:00
Alexey Milovidov
d947dbc185 Add test to skip list 2021-02-20 11:44:35 +03:00
Alexey Milovidov
09b4c04c1e Merge branch 'master' into little-better 2021-02-20 11:27:40 +03:00
alexey-milovidov
a79ccce074
Merge pull request #20980 from den-crane/tests/test_17761
test for decimal ( p , s) in dictionaries
2021-02-20 10:56:28 +03:00
Nikolai Kochetov
2f67cc02c1
Merge pull request #20881 from azat/async-task-queue-wait-fix
Fix 'Empty task was returned from async task queue' on query cancellation
2021-02-20 10:56:04 +03:00
alexey-milovidov
9c48fcfdef
Merge pull request #20882 from azat/distributed_group_by_no_merge-improvements
Do only merging of sorted blocks on initiator with distributed_group_by_no_merge=2
2021-02-20 10:36:32 +03:00
alesapin
a860e3e758
Merge pull request #20864 from azat/fasttest-backtrace-on-failure
Improve backtrace catching on server failures in CI for fast-tests
2021-02-20 10:20:56 +03:00
Azat Khuzhin
1ccb333ac5 Fix WriteBufferFromHTTPServerResponse usage in other places (add missing finalize())
Since I saw the following:

    0. DB::WriteBufferFromOStream::nextImpl()
    1. DB::WriteBufferFromHTTPServerResponse::nextImpl()
    2. DB::WriteBufferFromHTTPServerResponse::finalize()
    3. DB::WriteBufferFromHTTPServerResponse::~WriteBufferFromHTTPServerResponse()
    4. DB::StaticRequestHandler::handleRequest(Poco::Net::HTTPServerRequest&, Poco::Net::HTTPServerResponse&)
    5. Poco::Net::HTTPServerConnection::run()
    6. Poco::Net::TCPServerConnection::start()
2021-02-20 10:15:38 +03:00
Azat Khuzhin
5d36ceaaee Fix WriteBufferFromHTTPServerResponse usage in odbc-bridge 2021-02-20 10:15:38 +03:00
alexey-milovidov
b4196c8e68
Merge pull request #20168 from ClickHouse/in-memory-compression
Compression for Memory tables
2021-02-20 09:49:37 +03:00
alexey-milovidov
4390cb3d73
Update config.xml 2021-02-20 09:49:02 +03:00
Amos Bird
487fb09ff6
Suppress signed overflow in AggregateFunctionGroupArrayMoving 2 2021-02-20 14:11:01 +08:00
alexey-milovidov
59673ef9ae
Merge pull request #20989 from azat/PIPE_BUF-terminate_handler
Increase buffer for uncaught exception / std::terminate
2021-02-20 09:10:30 +03:00
alexey-milovidov
e8583ddfe2
Update BaseDaemon.cpp 2021-02-20 09:10:15 +03:00
Anton Popov
6ca51c2b8d
Merge pull request #20450 from lehasm/alexey-sm-DOCSUP-5974-document-decodeXMLComponent
DOCSUP-5974: documented decodeXMLComponent function
2021-02-20 03:03:18 +03:00
Alexander Tokmakov
2a36d6cb55 review suggestions 2021-02-20 02:41:58 +03:00
Maksim Kita
131fdb4507
Merge pull request #20958 from ClickHouse/fix-eintr-for-epoll-wait
Check for EINTR in epoll_wait
2021-02-20 00:28:19 +03:00
Azat Khuzhin
d0fe8900f9 Fix bash syntax in 01731_async_task_queue_wait 2021-02-20 00:04:28 +03:00
Azat Khuzhin
657bb33e73 Merge remote-tracking branch 'upstream/master' into async-task-queue-wait-fix
Merge upstream/master to debug possible uncaught exceptions with gdb
diagnostics merged.
2021-02-20 00:01:21 +03:00
Azat Khuzhin
f5893778cb Do not use view() in 01731_async_task_queue_wait to fix ANTLR parser 2021-02-20 00:01:13 +03:00
Azat Khuzhin
7474a7e3ca Increase buffer for uncaught exception / std::terminate
Use PIPE_BUF over some magic number 1024 in terminate_handler, since
according to pipe(7):

    PIPE_BUF
           POSIX.1  says  that  write(2)s of less than PIPE_BUF bytes must be atomic

Also note that 1024, is too small, especially for C++ stacktraces (and
especially for debug builds, that contains lots of non-inlined helpers
for various ptrs).
2021-02-19 22:45:06 +03:00
Alexey Milovidov
0f77b6fd95 Even more better 2021-02-19 22:01:45 +03:00
Azat Khuzhin
fba1c7fcc1 Fix uncaught exception when HTTP client goes away
Even after #20464 it was still possible, for example [1].

    2021.02.19 11:40:21.886191 [ 68373 ] {} <Trace> DynamicQueryHandler: Request URI: /?database=test_ds2d6y&log_comment=/usr/share/clickhouse-test/queries/0_stateless/01302_aggregate_state_exception_memory_leak.sh&enable_http_compression=1&http_zlib_compression_level=1

    <snip>

    2021.02.19 11:41:35.289940 [ 365 ] {} <Fatal> BaseDaemon: (version 21.3.1.6058, build id: 8D46D65205E2C8B7FE408A0B4EC76CA0483F9E92) (from thread 68373) Terminate called for uncaught exception:
    Code: 24, e.displayText() = DB::Exception: Cannot write to ostream at offset 262568, Stack trace (when copying this message, always include the lines below):

    0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x15b3c7db in /usr/bin/clickhouse
    1. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:56: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x8aba66e in /usr/bin/clickhouse
    2. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::nextImpl() @ 0x8b8c105 in /usr/bin/clickhouse
    3. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x8b8c537 in /usr/bin/clickhouse
    4. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:44: DB::Write

  [1]: https://clickhouse-test-reports.s3.yandex.net/16481/5d150cce4778dd14f58dcff67435bdec1efa155b/stress_test_(thread).html#fail1

And according to this partial stacktrace it seems that the dtor of
WriteBufferFromOStream was called from
WriteBufferFromHTTPServerResponse, since the class name starts from
DB::Write*

The problem is that if first time WriteBufferFromOStream::next() fails,
it will reset position to make next write no-op, however
WriteBufferFromHTTPServerResponse::next() will set position to available
buffer back, and next() will throw again, but this time it can be from
dtor.
2021-02-19 22:00:57 +03:00
Denis Zhuravlev
66e775ef88 test for decimal ( p , s) in dictionaries 2021-02-19 14:53:34 -04:00
Alexey Milovidov
252bcccdda Just little better 2021-02-19 21:32:39 +03:00
alexey-milovidov
a78523cf01
Merge pull request #20208 from vzakaznikov/ldap_docs
Adding documentation on how to use LDAP server as external user authenticator or directory
2021-02-19 20:56:01 +03:00
Maksim Kita
fc03c1013c
Fixed style check 2021-02-19 20:42:51 +03:00
alexey-milovidov
2299930c31
Merge pull request #20545 from kssenii/rabbit-format-settings
rabbitmq: add missing format factory settings
2021-02-19 20:24:17 +03:00
alexey-milovidov
91de5628f0
Merge pull request #20866 from CurtizJ/fix-distinct-state
Fix usage of 'distinct' combinator with 'state' combinator
2021-02-19 20:22:53 +03:00
Maksim Kita
0b5213c80d
Added comment 2021-02-19 19:49:19 +03:00
tavplubix
3509fe88d8
Merge pull request #20878 from ClickHouse/fix_18926
Fix COM_FIELD_LIST response in MySQL protocol
2021-02-19 19:25:54 +03:00
Maksim Kita
b84112a603 Function sumMap decimal fix 2021-02-19 19:25:50 +03:00
alexey-milovidov
ceacae4ee4
Merge pull request #20462 from azat/stress-backtrace-on-failure
Improve backtrace catching on server failures in CI for stress tests
2021-02-19 17:33:29 +03:00
alesapin
ea27c3ca32 Add gdb to fasttest image 2021-02-19 16:41:46 +03:00
alesapin
bebc66b0ca
Merge pull request #20960 from kssenii/fixed-aerospike-version
Fix push to dockerhub
2021-02-19 16:22:24 +03:00
Ivan
414f470c79
Make Poco HTTP Server zero-copy again (#19516)
* Refactoring: part 1

* Refactoring: part 2

* Handle request using ReadBuffer interface

* Struggles with ReadBuffer's

* Fix URI parsing

* Implement parsing of multipart/form-data

* Check HTTP_LENGTH_REQUIRED before eof() or will hang

* Fix HTTPChunkedReadBuffer

* Fix build and style

* Fix test

* Resist double-eof

* Fix arcadian build
2021-02-19 15:51:26 +03:00
Nikolai Kochetov
866dfaec79
Update 01731_async_task_queue_wait.sh 2021-02-19 15:25:22 +03:00
Maksim Kita
71c65b5d82
Merge pull request #20611 from kitaisreal/rename-untyped-function-reinterpret-as
Rename untyped function reinterpretAs into reinterpret
2021-02-19 14:35:00 +03:00
Nikolai Kochetov
df1cf481cf
Update 01731_async_task_queue_wait.sh 2021-02-19 14:14:31 +03:00
Nikolai Kochetov
8f8a4f6423
Update 01731_async_task_queue_wait.sh 2021-02-19 13:59:38 +03:00