KinderRiven
081cd4938a
fix style
2022-08-11 00:11:40 +08:00
KinderRiven
9d83b93e88
fix rebase
2022-08-11 00:11:40 +08:00
KinderRiven
50fd740ec3
fix
2022-08-11 00:11:40 +08:00
KinderRiven
c5f9022510
fix
2022-08-11 00:11:40 +08:00
KinderRiven
43cf771657
better
2022-08-11 00:11:40 +08:00
KinderRiven
ffaf44c1c1
fix style
2022-08-11 00:11:40 +08:00
KinderRiven
7f54fa726b
Decoupling cache functions and algorithms
2022-08-11 00:11:40 +08:00
Kseniia Sumarokova
a4d513657c
Merge pull request #40010 from ClickHouse/catboost-further-preparation
...
Further preparation for catboost integration into library-bridge
2022-08-10 17:35:12 +02:00
kssenii
0ff5609738
Finish support for persistent files
2022-08-10 16:54:59 +02:00
Nikita Mikhaylov
8e8e845a89
Merge branch 'master' into separate-counter-for-rss-in-memory-tracker
2022-08-10 16:44:24 +02:00
Duc Canh Le
bf5e9173ad
fix hashMethodOneNumber constructor
2022-08-10 21:01:09 +08:00
Duc Canh Le
ec49f7b3a3
fix style
2022-08-10 19:28:08 +08:00
Duc Canh Le
17fa8076e3
better implementation
2022-08-10 18:59:13 +08:00
Duc Canh Le
7910a93b02
fix other hash methods and add tests
2022-08-10 18:59:13 +08:00
Duc Canh Le
1a08161dbf
simplify solution
2022-08-10 18:59:13 +08:00
Duc Canh Le
cdd5b32d29
fix HashMethodOneNumber with const column
2022-08-10 18:59:13 +08:00
kssenii
7b66b96ec5
Minor change
2022-08-10 12:20:54 +02:00
kssenii
5c3227ba56
Merge master
2022-08-10 12:00:34 +02:00
Antonio Andelic
4023d4a37a
Add support for drop/truncate and tests
2022-08-10 07:24:56 +00:00
Alexey Milovidov
33e43cc6f9
Merge branch 'master' into server-side-time
2022-08-10 07:28:15 +03:00
Robert Schulze
05ea33c897
Revert "Revert "ColumnVector: optimize filter with AVX512VBMI2 compress store""
...
This reverts commit 5524706b78
.
2022-08-09 17:00:13 +00:00
Kruglov Pavel
5ebf230dbb
Merge pull request #39426 from kitaisreal/shell-command-wait-pid-refactoring
...
ShellCommand wait pid refactoring
2022-08-09 11:48:20 +02:00
Roman Vasin
96598e3574
Replace normalizeDayNum() by std::clamp()
2022-08-09 08:52:02 +00:00
alexX512
21624708aa
Fix tidy build
2022-08-09 08:36:49 +00:00
alexX512
c9c26d4898
Fix review
2022-08-08 21:34:24 +00:00
Robert Schulze
e0d5020a92
Add simple versioning to the *-bridge-to-server protocol
...
- In general, it is expected that clickhouse-*-bridges and
clickhouse-server were build from the same source version (e.g. are
upgraded "atomically"). If that is not the case, we should at least
be able to detect the mismatch and abort.
- This commit adds a URL parameter "version", defined in a header shared
by the server and bridges. The bridge returns an error in case of
mismatch.
- The version is *not* send and checked for "ping" requests (used for
handshake), only for regular requests send after handshake. This is
because the internally thrown server-side exception due to HTTP
failure does not propagate the exact HTTP error (it only stores the
error as text), and as a result, the server-side handshake code
simply retries in case of error with exponential backoff and finally
fails with a "timeout error". This is reasonable as pings typically
fail due to time out. However, without a rework of HTTP exceptions,
version mismatch during ping would also appear as "timeout" which is
too misleading. The behavior may be changed later if needed.
- Note that introducing a version parameter does not represent a
protocol upgrade itself. Bridges older than the server will simply
ignore the field. Only servers older than the bridges receive an error
but such a situation should never occur in practice.
2022-08-08 19:40:37 +00:00
Alexey Milovidov
db85ebfaa7
Add server-side time to Progress
2022-08-08 06:55:41 +02:00
Alexey Milovidov
5524706b78
Revert "ColumnVector: optimize filter with AVX512VBMI2 compress store"
2022-08-08 05:03:15 +03:00
alexX512
f16c668a0c
Delete Args from CacheBase
2022-08-07 20:44:26 +00:00
alexX512
1c9d40e4a8
Fix build error
2022-08-07 20:37:11 +00:00
alexX512
269631cfbe
Fix typo
2022-08-07 20:02:32 +00:00
alexX512
62f84b88eb
Review fixes
2022-08-07 20:02:21 +00:00
alexX512
8adf9f2448
fix compile error
2022-08-07 19:59:39 +00:00
alexX512
2be72560f4
Add loading of mark cache policy
2022-08-07 19:59:39 +00:00
alexX512
a057e1607a
Fix remove operation, add evict ion i from cachef number of elements greater than max_elements_size
2022-08-07 19:59:39 +00:00
alexX512
8be62770aa
Test with SLRU and debug logs
2022-08-07 19:59:39 +00:00
alexX512
c044fee7a0
Test with LRU
2022-08-07 19:59:39 +00:00
alexX512
a238e349cd
Unblocking get max_size
2022-08-07 19:59:39 +00:00
alexX512
daab74925c
Test with default cache policy = SLRU
2022-08-07 19:59:39 +00:00
alexX512
994a9fc005
Minor fixes
2022-08-07 19:59:38 +00:00
alexX512
50a8887ab9
Add [[maybe_unused]] locks and delete all objects from cache queue
2022-08-07 19:59:38 +00:00
alexX512
69cc89e36e
Check with default cache policy = LRU
2022-08-07 19:59:38 +00:00
alexX512
a94950d3ac
Test only with LRU
2022-08-07 19:59:38 +00:00
alexX512
9940b69bd7
Include fix in ICachePolicy.h
2022-08-07 19:59:38 +00:00
alexX512
910645a52a
Include fix in SLRUCachePolicy.h
2022-08-07 19:59:38 +00:00
alexX512
4f52efd4bb
Build fix
2022-08-07 19:59:38 +00:00
alexX512
6bf29cb610
Change class LRUCache to class CachBase. Check running CacheBase with default pcahce policy SLRU
2022-08-07 19:59:30 +00:00
alexX512
c606ccc75d
Fix formatting problems
2022-08-07 19:16:40 +00:00
alexX512
1133e42367
Add CacheBase clas instead of LRUCache and SLRUCache fo simpler configuration oache policiesf
2022-08-07 19:16:40 +00:00
alexX512
a0d2da7261
Add tests for SLRU cache
2022-08-07 19:16:40 +00:00
AlPerevyshin
d7bdf9e601
Add SLRU cache
2022-08-07 19:16:38 +00:00
avogar
9b1a267203
Refactor, remove TTL, add size limit, add system table and system query
2022-08-05 16:20:15 +00:00
kssenii
91f4143b6e
Merge master
2022-08-05 12:14:08 +02:00
Alexey Milovidov
3130aa7218
Merge pull request #39732 from HarryLeeIBM/hlee-s390x-unaligned
...
Fix Endian issue in SipHash for s390x
2022-08-05 07:24:57 +03:00
kssenii
7a9b0bc47f
Merge master
2022-08-05 01:48:52 +02:00
Alexey Milovidov
24ee944986
Update TaskStatsInfoGetter.cpp
2022-08-04 07:34:36 +03:00
Fangyuan Deng
0bf5c3d1a1
Merge branch 'master' into fix_netlink_leak
2022-08-04 11:42:17 +08:00
pzhdfy
848a349e42
fix potential netlink leak when init fail in TaskStatsInfoGetter
2022-08-04 11:37:27 +08:00
Alexey Milovidov
f474eb957d
Merge pull request #39758 from ClickHouse/tsan_clang_15
...
Try clang-15 for build with tsan
2022-08-04 01:56:52 +03:00
Nikita Mikhaylov
f144eae388
Fix typo and extra dots in exception messages from OverCommitTracker ( #39858 )
2022-08-03 15:23:07 +02:00
Robert Schulze
00a7c8733b
Merge pull request #39633 from guowangy/filter-vbmi2
...
ColumnVector: optimize filter with AVX512VBMI2 compress store
2022-08-03 09:23:24 +02:00
Frank Chen
035896fa16
Fix build check
2022-08-02 20:18:42 +08:00
Frank Chen
1c9b462c80
Merge remote-tracking branch 'origin/master' into tracing_context_propagation
2022-08-02 20:18:22 +08:00
Alexander Tokmakov
b4c4448f0f
fix
2022-08-02 12:07:38 +02:00
Alexander Tokmakov
82b50e79cf
Merge branch 'master' into tsan_clang_15
2022-08-02 13:00:55 +03:00
Frank Chen
57dde8c250
Clean up header inclusion
...
Signed-off-by: Frank Chen <frank.chen021@outlook.com>
2022-08-02 15:43:19 +08:00
Alexey Milovidov
316528817b
Merge pull request #39179 from azat/fsync-profile-events
...
Add profile events for fsync
2022-08-02 05:44:35 +03:00
Wangyang Guo
6a7213291b
Merge master and resolve conflict
2022-08-02 10:40:40 +08:00
Frank Chen
40c6e4c0d6
Merge remote-tracking branch 'origin/master' into tracing_context_propagation
2022-08-02 10:02:09 +08:00
Alexander Tokmakov
ecf7ce1f74
Merge branch 'master' into zookeeper_client_fault_injection
2022-08-01 20:49:01 +02:00
Alexander Tokmakov
0d68b1c67f
fix build with clang-15
2022-08-01 18:00:54 +02:00
Robert Schulze
bf574b9154
Merge pull request #39760 from ClickHouse/bit-fiddling
...
Use std::popcount, ::countl_zero, ::countr_zero functions
2022-08-01 17:04:51 +02:00
Alexander Tokmakov
80f9ba9186
Merge pull request #39690 from ClickHouse/show-addresses-in-stack-traces
...
Configuration parameter to hide addresses in stack traces
2022-08-01 14:20:37 +03:00
Wangyang Guo
b05be56eef
ColumnVector: naming style fix
2022-08-01 10:16:15 +08:00
Robert Schulze
d39259a4c0
More conversions
2022-07-31 22:06:02 +00:00
Azat Khuzhin
3e627e2861
Add profile events for fsync
...
The following new provile events had been added:
- FileSync - Number of times the F_FULLFSYNC/fsync/fdatasync function was called for files.
- DirectorySync - Number of times the F_FULLFSYNC/fsync/fdatasync function was called for directories.
- FileSyncElapsedMicroseconds - Total time spent waiting for F_FULLFSYNC/fsync/fdatasync syscall for files.
- DirectorySyncElapsedMicroseconds - Total time spent waiting for F_FULLFSYNC/fsync/fdatasync syscall for directories.
v2: rewrite test to sh with retries
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-31 23:19:30 +03:00
kssenii
e5f4a619ed
Merge master
2022-07-31 20:24:40 +03:00
Robert Schulze
a7734672b9
Use std::popcount, ::countl_zero, ::countr_zero functions
...
- Introduced with the C++20 <bit> header
- The problem with __builtin_c(l|t)z() is that 0 as input has an
undefined result (*) and the code did not always check. The std::
versions do not have this issue.
- In some cases, we continue to use buildin_c(l|t)z(), (e.g. in
src/Common/BitHelpers.h) because the std:: versions only accept
unsigned inputs (and they also check that) and the casting would be
ugly.
(*) https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
2022-07-31 15:16:51 +00:00
Robert Schulze
52d08d9db4
Merge pull request #39520 from ClickHouse/no-split-binary
...
Remove SPLIT_BINARY
2022-07-31 14:23:31 +02:00
Alexey Milovidov
d285648a37
Merge branch 'master' into shell-command-wait-pid-refactoring
2022-07-31 02:57:46 +03:00
Robert Schulze
85773e0926
Merge pull request #38615 from liyinsg/simplified_function_registration_interface
...
Simplified function registration interface
2022-07-31 00:18:37 +02:00
Alexey Milovidov
c0d7b6efc3
Suggestions from @tavplubix
2022-07-30 01:45:06 +02:00
Alexey Milovidov
4aa96767d5
Merge branch 'master' of github.com:ClickHouse/ClickHouse into show-addresses-in-stack-traces
2022-07-30 01:44:04 +02:00
HarryLeeIBM
cc73b53116
Fix Endian issue in SipHash for s390x
2022-07-29 13:21:50 -07:00
Robert Schulze
3d1797f75f
Merge remote-tracking branch 'origin/master' into no-split-binary
2022-07-29 12:17:43 +00:00
Robert Schulze
a3c52f1140
Merge pull request #39679 from azat/fix-utils
...
Fix utils build on CI
2022-07-29 14:02:53 +02:00
Azat Khuzhin
498c8b3c52
Fix clang-tidy in utils/examples
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-29 11:36:51 +03:00
Li Yin
4088c0a7f3
Automated function registration
...
Automated register all functions with below naming convention by
iterating through the symbols:
void DB::registerXXX(DB::FunctionFactory &)
2022-07-29 15:39:50 +08:00
Alexey Milovidov
552b517e59
Allow to hide addresses in stack traces
2022-07-29 00:13:02 +02:00
Azat Khuzhin
e1f8cff3b4
Add duration_ms into system.zookeeper_log
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-28 22:34:51 +03:00
Robert Schulze
199e254777
Merge remote-tracking branch 'origin/master' into no-split-binary
2022-07-28 15:54:22 +00:00
Antonio Andelic
15e999f8bc
Merge pull request #39096 from ClickHouse/keeper-version-check
...
Add version for Keeper API
2022-07-28 10:10:49 +02:00
Sergei Trifonov
edf6b02723
Merge pull request #37558 from ClickHouse/concurrency-control
...
add concurrency control for pipeline executors
2022-07-28 08:56:24 +02:00
Yakov Olkhovskiy
f1bc767ccf
Merge pull request #39627 from HarryLeeIBM/hlee-s390x-wide_int
...
Fix wide integer unit tests on s390x platform
2022-07-27 21:30:12 -04:00
Alexander Tokmakov
8fc075a527
Merge pull request #39619 from ClickHouse/try-do-enable-global-allocations-for-attach
...
Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread
2022-07-27 13:13:04 +03:00
Kruglov Pavel
381ea139c2
Merge branch 'master' into schema-inference-cache
2022-07-27 11:35:36 +02:00
Antonio Andelic
904a05ac21
Merge pull request #39496 from azat/custom-tld-exclamation-asterisk
...
Add support of !/* (exclamation/asterisk) in custom TLDs
2022-07-27 08:55:49 +02:00
Wangyang Guo
e6752d687f
TargetSpecific: add AVX512VBMI2 support
2022-07-27 13:30:43 +08:00
Wangyang Guo
50fdbcdc12
CpuId: add AVX512VBMI2 detection
2022-07-27 13:30:43 +08:00
HarryLeeIBM
d475086100
Fix wide integer unit test
2022-07-26 12:57:45 -07:00
Nikolai Kochetov
f1818a9103
Make only one possible public ctor in MemoryTrackerBlockerInThread
2022-07-26 19:04:20 +00:00
Nikolai Kochetov
dcb86eca0b
Make only one possible public ctor in MemoryTrackerBlockerInThread
2022-07-26 19:03:26 +00:00
Nikolai Kochetov
fa0707b4e7
Review fixes.
2022-07-26 17:51:09 +00:00
Nikolai Kochetov
33ce662d3e
Replace MemoryTrackerBlockerInThread to LockMemoryExceptionInThread in some places. Reduced MemoryTrackerBlockerInThread level to User.
2022-07-26 15:22:00 +00:00
Kruglov Pavel
c683cb252f
Merge pull request #39227 from amosbird/rename-log1
...
Rename log when rename merge tree tables
2022-07-26 17:12:44 +02:00
Sergei Trifonov
24ab5fbb86
fix finish() condition to account only active threads
2022-07-26 11:32:45 +02:00
Antonio Andelic
35b61cc94e
Merge branch 'master' into keeper-version-check
2022-07-26 07:47:57 +00:00
Azat Khuzhin
1d4a7c7290
Add support of !/* (exclamation/asterisk) in custom TLDs
...
Public suffix list may contain special characters (you may find format
here - [1]):
- asterisk (*)
- exclamation mark (!)
[1]: https://github.com/publicsuffix/list/wiki/Format
It is easier to describe how it should be interpreted with an examples.
Consider the following part of the list:
*.sch.uk
*.kawasaki.jp
!city.kawasaki.jp
And here are the results for `cutToFirstSignificantSubdomainCustom()`:
If you have only asterisk (*):
foo.something.sheffield.sch.uk -> something.sheffield.sch.uk
sheffield.sch.uk -> sheffield.sch.uk
If you have exclamation mark (!) too:
foo.kawasaki.jp -> foo.kawasaki.jp
foo.foo.kawasaki.jp -> foo.foo.kawasaki.jp
city.kawasaki.jp -> city.kawasaki.jp
some.city.kawasaki.jp -> city.kawasaki.jp
TLDs had been verified wit the following script [2], to match with
python publicsuffix2 module.
[2]: https://gist.github.com/azat/c1a7a9f1e3519793134ef4b1df5461a6
v2: fix StringHashTable padding requirements
Fixes : #39468
Follow-up for: #17748
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-26 08:34:30 +03:00
Roman Vasin
b462366415
Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-485
2022-07-25 17:55:47 +00:00
Roman Vasin
b412ea5f6d
Improve generateRandom() for Date32; fix tests 01087_table_function_generate, 01277_fromUnixTimestamp64, 01691_DateTime64_clamp and 01702_toDateTime_from_string_clamping
2022-07-25 17:06:11 +00:00
Sergei Trifonov
d9d1381c3f
Merge branch 'master' into concurrency-control
2022-07-25 14:16:46 +02:00
mergify[bot]
f667eff025
Merge branch 'master' into shell-command-wait-pid-refactoring
2022-07-25 11:42:05 +00:00
Robert Schulze
24c74da473
Merge pull request #39430 from azat/getauxval-fix
...
Fix LSan by fixing getauxval() (resubmit v4)
2022-07-25 10:43:09 +02:00
Alexey Milovidov
388d06fda1
Merge pull request #39535 from ClickHouse/stringref
...
Less usage of StringRef
2022-07-25 04:06:11 +03:00
Azat Khuzhin
93f876b58a
Add a test for LSan
...
(cherry picked from commit 51e7c41883
)
v2: fix type check
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-25 01:21:40 +03:00
Robert Schulze
4333750985
Less usage of StringRef
...
... replaced by std::string_view, see #39262
2022-07-24 18:33:52 +00:00
Robert Schulze
73c04b64e3
Merge pull request #39493 from nicelulu/fix_build_osx
...
Fix build on mac osx
2022-07-24 18:11:34 +02:00
Robert Schulze
c788e05c77
Merge pull request #39292 from zvonand/zvonand-b58-datatype
...
Simplify Base58 encoding/decoding
2022-07-24 18:09:40 +02:00
Andrey Zvonov
032fcab70e
set char to be explicitely signed
2022-07-24 14:23:22 +02:00
Alexey Milovidov
071374b152
Remove SPLIT_BINARY
2022-07-24 01:15:54 +02:00
Constantine Peresypkin
d645d03e89
fix -DENABLE_EXAMPLES=1
in master
2022-07-23 19:00:52 +02:00
Antonio Andelic
6aff87d4b5
Ignore system paths from snapshots and logstore
2022-07-23 13:46:59 +00:00
Antonio Andelic
46a6fbd7aa
Small polish
2022-07-22 11:03:07 +00:00
zhangxiao871
0d4d1e66b5
Fix build
2022-07-22 18:53:44 +08:00
Alexander Tokmakov
bed2206ae9
Merge pull request #39460 from ClickHouse/remove_some_dead_and_commented_code
...
Remove some dead and commented code
2022-07-22 13:24:34 +03:00
Roman Vasin
0b102c6d1f
Fix code style
2022-07-22 08:24:05 +00:00
Antonio Andelic
3040ff0959
Merge branch 'master' into keeper-version-check
2022-07-22 08:07:55 +00:00
Roman Vasin
74d2bf8d95
Fix gTest for DateLUTTest
2022-07-22 07:49:02 +00:00
Kruglov Pavel
9252f42b4c
Merge branch 'master' into schema-inference-cache
2022-07-21 18:59:14 +02:00
Robert Schulze
ea0a3bf600
Merge branch 'master' into stringref-to-string_view
2022-07-21 18:33:06 +02:00
Maksim Kita
0159fe1274
Merge branch 'master' into shell-command-wait-pid-refactoring
2022-07-21 16:38:28 +02:00
Andrey Zvonov
e473606cd1
Merge branch 'master' into zvonand-b58-datatype
2022-07-21 15:55:05 +02:00
Alexander Tokmakov
9e9969cea7
Merge pull request #37827 from arthurpassos/host_regexp_multiple_domains
...
Test host_regexp against all PTR records instead of only one
2022-07-21 16:43:05 +03:00
Alexander Tokmakov
a8da5d96fc
remove some dead and commented code
2022-07-21 15:05:48 +02:00
Maksim Kita
7f4a1b8bb8
ShellCommand wait pid refactoring
2022-07-21 11:45:09 +02:00
Nikolai Kochetov
e15967e9db
Merge pull request #38475 from ClickHouse/additional-filters
...
Additional filters for a table (from setting)
2022-07-21 07:52:04 +02:00
Alexey Milovidov
4305eacd92
Merge pull request #39434 from ClickHouse/revert-39299-fix-lsan-v3
...
Revert "[RFC] Fix LSan by fixing getauxval()"
2022-07-21 06:47:54 +03:00
Alexey Milovidov
f4f5a5e044
Merge pull request #39397 from azat/fix-extractAll
...
Fix UB (stack-use-after-scope) in extactAll()
2022-07-21 05:21:18 +03:00
Alexey Milovidov
72dda35108
Revert "[RFC] Fix LSan by fixing getauxval()"
2022-07-21 04:34:04 +03:00
Nikolai Kochetov
91043351aa
Fixing build.
2022-07-20 20:30:16 +00:00
Kseniia Sumarokova
3759ee76a7
Merge pull request #39386 from ClickHouse/kssenii-patch-4
...
Rethrow exception on cache initialisation on server startup, better error message
2022-07-20 21:26:25 +02:00
Roman Vasin
e3192cf753
Correct docs to reflect new range 1900..2299 for Date32 and DateTime64; Cleanup code
2022-07-20 15:19:02 +00:00
zvonand
11b8d788ca
small improvements
2022-07-20 13:36:47 +02:00
Kruglov Pavel
3046cd6d29
Merge branch 'master' into schema-inference-cache
2022-07-20 13:30:42 +02:00
Kseniia Sumarokova
0840dfe2e0
Update LRUFileCache.cpp
2022-07-20 11:42:24 +02:00
Maksim Kita
d3ce4ffc88
Merge pull request #38929 from pkit/pkit/wait_pid_fix
...
fix long wait for process exit in ShellCommand
2022-07-20 11:26:38 +02:00
Azat Khuzhin
18eb8b6d48
Fix UB (stack-use-after-scope) in extactAll()
...
After #37544 OptimizedRegularExpressionImpl started to be moved, but
StringSearcher is not copyable since it holds pointers that goes out of
scope after move (before Regexps::get() returns std::shared_ptr<Regexp>
but it had been replaced with Regexps::createRegexp() that returns
Regexp object).
<details>
<summary>ASan report</summary>
==48348==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7fff577239a9 at pc 0x00001518209b bp 0x7fff57723820 sp 0x7fff57723818
READ of size 1 at 0x7fff577239a9 thread T0
0 0x1518209a in char8_t const* DB::StringSearcher<true, true>::search<char8_t>(char8_t const*, char8_t const*) const /bld/./src/Common/StringSearcher.h:730:41
1 0x1518dd3f in char8_t const* DB::StringSearcher<true, true>::search<char8_t>(char8_t const*, unsigned long) const /bld/./src/Common/StringSearcher.h:751:16
2 0x1518dd3f in OptimizedRegularExpressionImpl<false>::match(char const*, unsigned long, std::__1::vector<OptimizedRegularExpressionDetails::Match, std::__1::allocator<OptimizedRegularExpressionDetails::Match> >&, unsigned int) const /bld/./src/Common/OptimizedRegularExpression.cpp:463:54
3 0x1811cb42 in DB::ExtractAllImpl::get(char const*&, char const*&) /bld/./src/Functions/FunctionsStringArray.h:588:18
4 0x1811aa62 in DB::FunctionTokens<DB::ExtractAllImpl>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const /bld/./src/Functions/FunctionsStringArray.h:704:30
5 0x14fe17b4 in DB::IFunction::executeImplDryRun(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const /bld/./src/Functions/IFunction.h:409:16
Address 0x7fff577239a9 is located in stack of thread T0 at offset 201 in frame
0 0x1518d98f in OptimizedRegularExpressionImpl<false>::match(char const*, unsigned long, std::__1::vector<OptimizedRegularExpressionDetails::Match, std::__1::allocator<OptimizedRegularExpressionDetails::Match> >&, unsigned int) const /bld/./src/Common/OptimizedRegularExpression.cpp:439
</details>
CI: https://s3.amazonaws.com/clickhouse-test-reports/39342/c6f7698f9ad6ae22199182ebf7c3b2dac77d69d8/fuzzer_astfuzzerasan,actions//report.html
Fixes : #37544 (cc @rschu1ze)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-20 10:18:44 +03:00
Roman Vasin
5f9c293963
Fix addDays() and addWeeks() in upper and lower limits of Date and Date32
2022-07-19 17:29:08 +00:00
Kseniia Sumarokova
891dbccdc7
Update LRUFileCache.cpp
2022-07-19 19:18:42 +02:00
Robert Schulze
02ed126533
Update src/Common/TraceSender.cpp
...
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
2022-07-19 18:44:31 +02:00
Sergei Trifonov
499818751e
Merge pull request #39280 from ClickHouse/avg-cpu-progress
...
fix cpu usage metric in client
2022-07-19 15:17:44 +02:00
Kseniia Sumarokova
2e3ceb351e
Update LRUFileCache.cpp
2022-07-19 14:44:56 +02:00
Kseniia Sumarokova
f7bb69ef7a
Update LRUFileCache.cpp
2022-07-19 14:43:11 +02:00
Kseniia Sumarokova
af7acb1782
Update LRUFileCache.cpp
2022-07-19 14:41:31 +02:00
Kseniia Sumarokova
5ad4e9d28f
Update LRUFileCache.cpp
2022-07-19 14:33:50 +02:00
Robert Schulze
7146685f9d
Merge pull request #39299 from azat/fix-lsan-v3
...
[RFC] Fix LSan by fixing getauxval()
2022-07-19 14:27:41 +02:00
Constantine Peresypkin
246614229f
fix long wait for process exit in ShellCommand
...
fixes #38889
2022-07-19 14:07:27 +02:00
kssenii
21ebf8874e
Merge remote-tracking branch 'upstream/master' into make-cache-composable
2022-07-19 13:36:42 +02:00
Nikolai Kochetov
fc6982f9e2
Fixing test.
2022-07-19 10:10:02 +00:00
Antonio Andelic
ce570b6ee3
Add logs and 4LW for api version
2022-07-19 09:02:57 +00:00
Antonio Andelic
e6ded88ea3
Small refactoring
2022-07-19 08:51:12 +00:00
Robert Schulze
81ef1099cc
Even less usage of StringRef
...
--> see #39300
2022-07-19 07:01:06 +00:00
Nikolai Kochetov
5a3cb07711
Fix rss
2022-07-18 21:24:41 +00:00
Nikolai Kochetov
3ee3144708
Merge branch 'master' into separate-counter-for-rss-in-memory-tracker
2022-07-18 23:20:38 +02:00
Nikolai Kochetov
87e5b31598
Do not include memory buffered by allocator into drift.
2022-07-18 21:16:16 +00:00
Robert Schulze
6df3c9d799
Merge pull request #39300 from ClickHouse/stringref-to-stringview
...
First try at reducing the use of StringRef
2022-07-18 19:20:16 +02:00
Roman Vasin
28fd774df8
Correct 01821_to_date_time_ubsan and 01921_datatype_date32 tests
2022-07-18 16:44:14 +00:00
Antonio Andelic
cfc741030f
Revert to the version with path
2022-07-18 14:30:15 +00:00
kssenii
0aed5a602a
Merge master
2022-07-18 16:16:28 +02:00
Azat Khuzhin
51e7c41883
Add a test for LSan
...
v2: fix type check
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-18 16:49:49 +03:00
Sergei Trifonov
30cb4e168e
cleanup
2022-07-18 13:31:32 +02:00
Sergei Trifonov
0ffe5bd39c
fix typo and style
2022-07-18 13:26:33 +02:00
Sergei Trifonov
2593dbcaa6
reuse Common/ExponentiallySmoothedCounter.h
2022-07-18 12:21:44 +02:00
Antonio Andelic
758a61a36f
Close socket if ApiVersion wasn't processed
2022-07-18 09:43:21 +00:00
Antonio Andelic
5170ac0898
Merge branch 'master' into keeper-version-check
2022-07-18 08:57:50 +00:00
Antonio Andelic
b8ffb151dc
Some small polishing
2022-07-18 08:52:52 +00:00
Antonio Andelic
742e3d7643
Merge branch 'master' into keeper-version-check
2022-07-18 08:45:00 +00:00
Antonio Andelic
7d7c4ce4cd
Add ApiVersion request
2022-07-18 08:44:38 +00:00
Alexey Milovidov
f1256c3aef
Merge pull request #37891 from guowangy/lz4-decompress-vbmi
...
LZ4 decompress: add VBMI optimized copyOverlap32Shuffle
2022-07-18 00:37:59 +03:00
Robert Schulze
13482af4ee
First try at reducing the use of StringRef
...
- to be replaced by std::string_view
- suggested in #39262
2022-07-17 17:26:02 +00:00
Robert Schulze
fffeab2e86
Merge pull request #39262 from ClickHouse/stringref-by-value
...
Pass const StringRef by value, not by reference
2022-07-17 16:53:15 +02:00
kssenii
3ccbf5ced0
Review fixes
2022-07-17 15:13:28 +02:00
Wangyang Guo
c07c65615d
fix ENABLE_MULTITARGET_CODE not defined warning in some builds
2022-07-17 12:21:10 +08:00
kssenii
ca09c6c2c0
Fix some review comments, fix after merge
2022-07-16 23:30:54 +02:00
kssenii
8ad26b3111
Merge master
2022-07-16 22:50:03 +02:00
zvonand
3089da16be
fix identation
2022-07-16 19:07:42 +02:00
zvonand
d07a652883
merge
2022-07-16 19:05:07 +02:00
zvonand
4ab52b6873
added new DataType + fixes
2022-07-16 18:58:47 +02:00
Alexey Milovidov
e37caa5bd6
Merge pull request #39216 from Algunenano/rotational_error
...
Don't report system.errors when the disk is not rotational
2022-07-16 16:16:52 +03:00
Sergei Trifonov
82f98cfe6b
remove initial linear growth, increase avg period to 3 sec
2022-07-16 02:17:18 +02:00
Sergei Trifonov
8a5286ea4c
fix cpu usage metric in client
2022-07-16 00:27:26 +02:00
Arthur Passos
abb550d2ff
minor style fixes
2022-07-15 12:42:07 -03:00
Alexander Tokmakov
5ef7f5f494
Merge pull request #39229 from azat/fix-noexcept-scope
...
[RFC] Fix NOEXCEPT_SCOPE (before it calls std::terminate and looses the exception)
2022-07-15 18:14:56 +03:00
Robert Schulze
deda29b46b
Pass const StringRef by value, not by reference
...
See #39224
2022-07-15 11:34:56 +00:00
Kruglov Pavel
a944a92d4c
Merge pull request #39224 from Avogar/string-view-by-value
...
Pass const std::string_view by value, not by reference
2022-07-15 13:05:56 +02:00
Roman Vasin
1d0818d9cf
Set max year to 2299; Code cleanup; Make working 02245_make_datetime64 test
2022-07-15 10:33:52 +00:00
Antonio Andelic
73e0c35ab0
Use 4LW for api version
2022-07-15 10:13:39 +00:00
Robert Schulze
8e44c2c375
Merge pull request #39223 from ClickHouse/warnings
...
Turn some warnings on
2022-07-15 10:06:59 +02:00
Wangyang Guo
397a4ac888
TargetSpecific: add AVX512VBMI support
2022-07-15 15:07:09 +08:00
Sergei Trifonov
62f975da60
Merge pull request #39095 from ClickHouse/remote-io-bandwidth-limits
...
add max_remote_{read,write}_network_bandwidth_for_server settings
2022-07-14 23:14:53 +02:00
Roman Vasin
266039ea64
Correct gTests for DateLUT
2022-07-14 19:00:17 +00:00
Raúl Marín
3fd327b23a
Use std::filesystem::path::operator/
2022-07-14 19:25:40 +02:00
avogar
9291d33080
Pass const std::string_view & by value, not by reference
2022-07-14 16:11:57 +00:00
Azat Khuzhin
b20407fab9
Fix NOEXCEPT_SCOPE (before it calls std::terminate and looses the exception)
...
Current implementation of NOEXCEPT_SCOPE will not work, you cannot
rethrow exception outside the catch block, this will simply terminate
(via std::terminate) the program.
In other words NOEXCEPT_SCOPE macro will simply call std::terminate on
exception and will lost original exception.
But if NOEXCEPT_SCOPE will accept the code that should be runned w/o
exceptions, then it can catch exception and log it, rewrite it in this
way.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-14 17:16:18 +03:00
Amos Bird
96bb6e0cd2
Rename log when rename merge tree tables
2022-07-14 21:22:46 +08:00
Robert Schulze
3d734a0640
Enable -Wnested-anon-types
2022-07-14 12:36:55 +00:00
Robert Schulze
add83f7836
Merge pull request #39213 from ClickHouse/enable-wdeprecated-dynamic-exception-spec
...
Enable warning "-Wdeprecated-dynamic-exception-spec"
2022-07-14 13:09:18 +02:00
Sergei Trifonov
8a693469f0
Merge branch 'master' into remote-io-bandwidth-limits
2022-07-14 12:38:35 +02:00
Kruglov Pavel
b38241b08a
Merge branch 'master' into schema-inference-cache
2022-07-14 12:29:54 +02:00
Raúl Marín
35d3a0dd1f
Don't report system.errors when the disk is not rotational
2022-07-14 11:08:26 +02:00
Antonio Andelic
0e25dbbbeb
Fix stateless test
2022-07-14 08:01:20 +00:00
Robert Schulze
110862a11e
Merge pull request #38502 from ClibMouse/Issue_38498
...
Fixed bug in parsing {..} regex
2022-07-14 08:27:31 +02:00
Nikolai Kochetov
812143c76b
Merge pull request #39160 from azat/threadpool-fix
...
ThreadPool fixes
2022-07-13 22:54:57 +02:00
Arthur Passos
7a09aa478a
Add missing include header for osx builds
2022-07-13 17:45:30 -03:00
kssenii
615221f73b
Minor changes
2022-07-13 19:22:47 +02:00
Sergei Trifonov
f854507729
merge master and resolve conflicts
2022-07-13 19:07:28 +02:00
Heena Bansal
76cbfedd2a
Merge branch 'master' into Issue_38498
2022-07-13 11:50:26 -04:00
Antonio Andelic
f05f22aa13
Merge branch 'master' into keeper-version-check
2022-07-13 15:25:48 +00:00
Kseniia Sumarokova
71aba5b4c6
Merge pull request #38860 from kssenii/object-storages-refactor
...
Refactoring of code around object storages, added LocalObjectStorage (extracted this diff from PR #36171 )
2022-07-13 16:51:56 +02:00
Arthur Passos
7f4043a3ed
Force use of c-ares inet_net_pton and style adjustments
2022-07-13 11:51:43 -03:00
kssenii
0944183eec
Fix merge
2022-07-13 16:50:31 +02:00
Robert Schulze
87197f8f60
Enable -Wdeprecated-dynamic-exception-spec
2022-07-13 13:49:40 +00:00
Antonio Andelic
93d8b8bb61
small fixes
2022-07-13 13:01:13 +00:00
Azat Khuzhin
68789895a4
ThreadPool: incapsulate Poco::Event and std: 🧵 :id into State struct
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:51:49 +03:00
Azat Khuzhin
7ffa15b94b
ThreadPool: fix thread_id assignment
...
As found by @KochetovNicolai before this patch, lambda in
ThreadFromGlobalPool() ctor assigns value only to a copy of the
thread_id value, and so check in joinable() had been working
incorrectly, fix this by changing the value not the shared_ptr itself.
Also it is not safe to assign thread_id w/o atomics, since this can be
racy, so wrap id with std::atomic<>
Fixes : #28431
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:42:46 +03:00
Azat Khuzhin
25eb82f120
ThreadPool: do not use joinable() internally
...
joinable() should be used only outside, since internally it is enough to
know `state` to know that something is wrong.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:42:46 +03:00
Azat Khuzhin
3473b80077
ThreadPool: add some clarification comments
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-13 15:42:46 +03:00
Arthur Passos
395dada988
minor style adjustments
2022-07-13 09:40:56 -03:00
kssenii
0d2d3ac2b4
Merge master
2022-07-13 13:26:15 +02:00
Yakov Olkhovskiy
334b3f3c73
Merge pull request #38864 from azat/fix-rwlock
...
Fix waiting of shared lock after exclusive lock failure
2022-07-13 02:10:35 -04:00
Arthur Passos
d306c1b6f4
Use Strings alias instead of std::vec<std::string>>
2022-07-12 20:37:39 -03:00
Arthur Passos
cb349c05c5
minor adjustments
2022-07-12 19:27:44 -03:00
Arthur Passos
381d60c510
minor adjustments
2022-07-12 17:55:49 -03:00
Arthur Passos
397d05eb9c
Add DNSPTRResolverProvider docs
2022-07-12 14:31:33 -03:00
kssenii
6f29eada80
Merge master
2022-07-12 19:28:18 +02:00
Arthur Passos
d48690d455
Make CaresPTRResolver a singleton through DNSPTRResolverProvider, add comments and address minor comments
2022-07-12 14:21:10 -03:00
mergify[bot]
48688da835
Merge branch 'master' into concurrency-control
2022-07-12 10:57:13 +00:00
Yakov Olkhovskiy
5887deac99
Merge branch 'master' into fix-rwlock
2022-07-11 16:01:16 -04:00
Robert Schulze
1a7727a254
Prefix overridden add_executable() command with "clickhouse_"
...
A simple HelloWorld program with zero includes except iostream triggers
a build of ca. 2000 source files. The reason is that ClickHouse's
top-level CMakeLists.txt overrides "add_executable()" to link all
binaries against "clickhouse_new_delete". This links against
"clickhouse_common_io", which in turn has lots of 3rd party library
dependencies ... Without linking "clickhouse_new_delete", the number of
compiled files for "HelloWorld" goes down to ca. 70.
As an example, the self-extracting-executable needs none of its current
dependencies but other programs may also benefit.
In order to restore access to the original "add_executable()", the
overriding version is now prefixed. There is precedence for a
"clickhouse_" prefix (as opposed to "ch_"), for example
"clickhouse_split_debug_symbols". In general prefixing makes sense also
because overriding CMake commands relies on undocumented behavior and is
considered not-so-great practice (*).
(*) https://crascit.com/2018/09/14/do-not-redefine-cmake-commands/
2022-07-11 19:36:18 +02:00
Arthur Passos
dcc8c646fd
Throw proper DB::Exception in case c-ares initialization fails
2022-07-11 14:29:29 -03:00
Arthur Passos
0c6329bdd3
ares_channel unique_ptr instead of shared_ptr
2022-07-11 10:19:25 -03:00
Arthur Passos
5c221464ba
Forward declare ares_channel and apply -wno-reserved-identifier to CARESPTRResolver unit
2022-07-11 10:10:31 -03:00
Sergei Trifonov
43779ec280
add max_remote_{read,write}_network_bandwidth_for_server settings
2022-07-11 14:59:39 +02:00
Antonio Andelic
197388e29c
Fix list request
2022-07-11 12:13:50 +00:00
Antonio Andelic
41dd4e13f4
Merge branch 'master' into keeper-version-check
2022-07-11 09:38:20 +00:00
Antonio Andelic
37f799550b
Merge pull request #38072 from lingpeng0314/master
...
Add Keeper related monitoring data
2022-07-10 09:39:57 +02:00
kssenii
4c88527c8e
Review fixes
2022-07-09 19:35:07 +02:00
kssenii
bf1c99daab
Refactoring of object storages, add LocalObjectStorage
2022-07-09 12:39:31 +02:00
Frank Chen
da57a993e4
Fix CI
2022-07-09 13:43:10 +08:00
Nikolai Kochetov
b262ca7dd6
Refactoring
2022-07-08 22:04:56 +00:00
Arthur Passos
4f4acfabe5
c-ares draft wrapper and draft build rules
2022-07-08 17:52:14 -03:00
Dmitry Novik
99cef119e1
Remove logging from OvercommitTracker
2022-07-08 15:34:23 +00:00
Nikolai Kochetov
8b56695073
Review fixes.
2022-07-08 14:46:11 +00:00
Frank Chen
6ae2504e57
Fix code
2022-07-08 18:55:59 +08:00
Roman Vasin
12f4a48957
Extend LUT range to 1900..2300
2022-07-08 06:48:05 +00:00
Nikolay Degterinsky
5cd06ac488
Merge pull request #38947 from soyayaos/master
...
Rename NUMBER_OF_DIMENSIONS_MISMATHED const to NUMBER_OF_DIMENSIONS_MISMATCHED
2022-07-07 22:25:42 +02:00
Nikolai Kochetov
dcfc286bb9
Fixing tests/
2022-07-07 20:20:50 +00:00
Alexander Tokmakov
b0f8970d07
Merge pull request #38961 from Algunenano/reduce_zk_eexists
...
Stop reporting Zookeeper "Node exists" exceptions in system.errors when they are expected
2022-07-07 23:16:46 +03:00
Alexander Tokmakov
1d93dc1c9a
Merge pull request #38963 from ClickHouse/fix_38962
...
Avoid weird exception in Keeper
2022-07-07 22:01:35 +03:00
Robert Schulze
f15d9ca59c
Merge pull request #38774 from zvonand/zvonand-nnd
...
Reintroduce nonNegativeDerivative()
2022-07-07 20:39:13 +02:00
Nikolai Kochetov
c8b1d840ba
Fixing build.
2022-07-07 15:49:15 +00:00
Alexander Tokmakov
7630fc76ae
avoid weird exception
2022-07-07 17:19:05 +02:00
Nikolai Kochetov
0f231b8641
Merge branch 'master' into add-allocation-ptr-to-trace-log
2022-07-07 16:30:49 +02:00
Raúl Marín
c3935000a8
Avoid reporting ZK EEXIST errors on checkPartChecksumsAndCommit
2022-07-07 16:10:05 +02:00
Alexander Tokmakov
fdd2db4ace
Move check for denied allocations ( #38858 )
...
* move check for denied allocations
* remove include
* make hardening softer
2022-07-07 14:24:36 +02:00
Nikolai Kochetov
dcdf2e4527
Track allocation ptr in system.trace_log. Add aggregate function for flamegraph.
2022-07-07 11:54:41 +00:00
Antonio Andelic
e96af48e28
Polish
2022-07-07 11:35:02 +00:00
Frank Chen
47da972277
Allows re-entering on thread context to make code more robust.
2022-07-07 17:45:08 +08:00
Frank Chen
4ef85164aa
Fix file name
2022-07-07 17:44:50 +08:00
Frank Chen
93dc109e36
Fix code
2022-07-07 17:44:19 +08:00
Frank Chen
c0a67dc6b9
Add API to simplify user code
2022-07-07 17:44:05 +08:00
Frank Chen
57a7e4a7c9
Remove old API reference
2022-07-07 17:42:35 +08:00
Frank Chen
32931857f0
Propagate tracing context across threads
2022-07-07 17:41:43 +08:00
Frank Chen
2e8c530bed
Move thread trace context out of ThreadStatus
2022-07-07 17:41:10 +08:00
Vladimir Galunshchikov
cacc833da6
Rename NUMBER_OF_DIMENSIONS_MISMATHED const to NUMBER_OF_DIMENSIONS_MISMATCHED
2022-07-07 11:15:59 +03:00
Alexey Milovidov
02adad3f27
Merge pull request #37860 from amosbird/remove-duplicated-log
...
Remove duplicate peak mem log
2022-07-07 08:16:06 +03:00
Andrey Zvonov
7de39d9b15
Merge branch 'master' of github.com:ClickHouse/ClickHouse into zvonand-nnd
2022-07-06 10:59:35 +03:00
HeenaBansal2009
d89ba2e5d9
Review Comments
2022-07-05 21:18:39 -07:00
Azat Khuzhin
98cd92017e
Fix waiting of shared lock after exclusive lock failure
...
When WRITE lock attemp fails (exclusive lock for ALTER/DELETE), and
there are multiple READ locks (shared lock for SELECT/INSERT), i.e. one
INSERT is in progress and one SELECT is queued after ALTER/DELETE
started but before it fails, this SELECT will wait until INSERT will
finishes.
This happens because in case of WRITE lock failure it does not notify
the next READ lock that can be acquired.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-07-05 19:12:47 +03:00
Kseniia Sumarokova
3e803006a2
Merge pull request #37171 from tchepavel/nats-integration
...
Nats Integration
2022-07-05 17:47:02 +02:00
kssenii
2281f16c15
Fixes
2022-07-05 13:17:44 +02:00
alesapin
bd8a3ee841
Merge pull request #38338 from ClickHouse/zookeeper-add-extra-list-argument
...
Extend ZooKeeper list request with support for filtering persistent or ephemeral nodes only
2022-07-05 12:53:51 +02:00
kssenii
b52084265c
Merge master
2022-07-04 21:37:43 +02:00
Kseniia Sumarokova
6c3d648f49
Merge branch 'master' into nats-integration
2022-07-04 21:06:07 +02:00
zvonand
8a270c01e9
fix floating point in intervals
2022-07-04 20:45:05 +03:00
Arthur Passos
5c00dcd884
Link cpp-dns/udns unconditionally and update submodules to clickhouse fork
2022-07-04 10:07:03 -03:00
Arthur Passos
dcda1c5eb9
Fix style case and DNS error message
2022-07-04 10:06:27 -03:00
Arthur Passos
d66154e697
Test host_regexp against all PTR records instead of only one
2022-07-04 10:05:28 -03:00
Kruglov Pavel
3d47416f8b
Merge pull request #38559 from ClickHouse/Avogar-patch-1
...
Add logging in Epoll and TimerDescriptor in case of EINTR
2022-07-04 15:05:08 +02:00
Alexey Milovidov
7adc87a37d
Merge pull request #38413 from nickitat/cache_values_inside_hash_table_grower
...
Precalculate values inside `HashTableGrower`
2022-07-02 23:30:24 +03:00
Kruglov Pavel
eaf8397c13
Fix style
2022-07-01 19:51:07 +02:00
Kruglov Pavel
fe0dad5429
Update src/Common/TimerDescriptor.cpp
2022-07-01 16:23:20 +02:00
Kruglov Pavel
4550acdc35
Update src/Common/Epoll.cpp
...
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2022-07-01 16:23:03 +02:00
Robert Schulze
2a1ede0f5a
Merge pull request #38589 from ClickHouse/fix-zero-bytes-in-haystack
...
Fix countSubstrings() & position() on patterns with 0-bytes
2022-07-01 16:15:43 +02:00
zvonand
3b5332d15e
Revert "Revert "Non Negative Derivative window function""
...
This reverts commit dea3b5bfce
.
2022-07-01 18:59:07 +05:00
Nikolai Kochetov
b7529986c0
Use separate counter for RSS in global memory tracker.
2022-07-01 12:09:32 +00:00
Vitaly Baranov
cadb496894
Merge pull request #38537 from vitlibar/backup-improvements-8
...
Backup Improvements 8
2022-07-01 11:20:46 +02:00
Alexey Milovidov
20841f0e1e
Merge pull request #38551 from ClickHouse/revert-37628-non-neg-deriv
...
Revert "Non Negative Derivative window function"
2022-07-01 02:46:28 +03:00
Robert Schulze
1e3b5bfcb7
Fix test 00233_position_function_family
2022-06-30 11:43:25 +00:00
Vitaly Baranov
461a31f237
Improve gathering metadata for backup - part 2.
2022-06-30 08:37:17 +02:00
Robert Schulze
81bb2242fd
Fix countSubstrings() & position() on patterns with 0-bytes
...
SQL functions countSubstrings(), countSubstringsCaseInsensitive(),
countSubstringsUTF8(), position(), positionCaseInsensitive(),
positionUTF8() with non-const pattern argument use fallback sorters
LibCASCIICaseSensitiveStringSearcher and LibCASCIICaseInsensitiveStringSearcher
which call ::strstr(), resp. ::strcasestr(). These functions assume that
the haystack is 0-terminated and they even document that. However, the
callers did not check if the haystack contains 0-byte (perhaps because
its sort of expensive). As a consequence, if the haystack contained a
zero byte in it's payload, matches behind this zero byte were ignored.
create table t (id UInt32, pattern String) engine = MergeTree() order by id;
insert into t values (1, 'x');
select countSubstrings('aaaxxxaa\0xxx', pattern) from t;
We returned 3 before this commit, now we return 6
2022-06-29 21:41:18 +00:00
Nikita Taranov
7d2e8b0883
clean up
2022-06-29 22:15:12 +02:00
Kruglov Pavel
77873e75bf
Update TimerDescriptor.cpp
2022-06-29 13:01:14 +02:00
Kruglov Pavel
30fd086b5e
Add logging in Epoll and TimerDescriptor in case of EINTR
2022-06-29 12:59:18 +02:00
Antonio Andelic
7a8fbbf132
Merge branch 'master' into zookeeper-add-extra-list-argument
2022-06-29 08:31:03 +00:00
Antonio Andelic
1d26446f84
Define new list request type
2022-06-29 08:30:39 +00:00
Robert Schulze
bb441faa42
Merge pull request #38491 from ClickHouse/clang-tidy-in-branches
...
Fix some clang-tidy warnings in headers
2022-06-29 10:22:04 +02:00
Alexey Milovidov
dea3b5bfce
Revert "Non Negative Derivative window function"
2022-06-29 08:56:15 +03:00
HeenaBansal2009
608bfb8453
Fixed {..} regex parsing as shell does
2022-06-28 12:49:31 -07:00
Robert Schulze
f692ead6ad
Don't use std::unique_lock unless we have to
...
Replace where possible by std::lock_guard which is more light-weight.
2022-06-28 19:19:06 +00:00
Robert Schulze
c22038d48b
More clang-tidy fixes
2022-06-28 11:50:05 +00:00
HeenaBansal2009
6a5819a405
Fixed bug in parsing{..} regex
2022-06-27 22:51:31 -07:00
Robert Schulze
5e28580f11
Fix some clang-tidy warnings in headers
2022-06-27 23:49:07 +02:00
Dmitry Novik
b629d557ce
Merge pull request #38246 from ClickHouse/overcommit-deadlock-fix
...
Fix deadlock in OvercommitTracker logging
2022-06-27 21:57:31 +02:00
Nikita Taranov
986ead7358
use old HashTableGrower with *WithStackMemory data structures
2022-06-27 20:34:18 +02:00
Robert Schulze
53cd8820d3
Merge pull request #38434 from ClickHouse/multi-match-with-nonconst-patterns
...
Refactoring to enable multi-match functions with non-const needles
2022-06-27 19:35:48 +02:00
kssenii
5c26f99bc5
Merge master
2022-06-27 13:36:41 +02:00
Antonio Andelic
c06776ce0d
Merge branch 'master' into zookeeper-add-extra-list-argument
2022-06-27 06:53:29 +00:00
Antonio Andelic
0d906e311d
PR review fixes
2022-06-27 06:53:09 +00:00
Sergey Skvortsov
b7bfb6abb0
Fix WeakHash32 for floating point types
2022-06-26 21:24:49 +03:00
Robert Schulze
bb7c627964
Cosmetics: Pass patterns around as std::string_view instead of StringRef
...
- The patterns are not used in hashing, there should not be a performance
impact when we use stuff from the standard library instead.
- added forgotten .reserve() in FunctionsMultiStringPosition.h
2022-06-26 15:32:19 +00:00
mergify[bot]
f63c959679
Merge branch 'master' into cleanup_garbage_in_store_dir
2022-06-26 13:35:10 +00:00
Nikita Taranov
95d413d7ec
put the thing into its own cache line
2022-06-26 01:38:45 +02:00
Alexey Milovidov
25cc406201
Update src/Common/ThreadStatus.cpp
...
Co-authored-by: Dmitry Novik <n0vik@clickhouse.com>
2022-06-26 01:29:06 +03:00
Nikita Taranov
abcefeeb41
cleanup
2022-06-25 23:15:59 +02:00
mergify[bot]
469f24a12c
Merge branch 'master' into zookeeper-add-extra-list-argument
2022-06-25 12:01:06 +00:00
Alexey Milovidov
e33f236d50
Slight improvement
2022-06-25 03:59:01 +02:00
Alexey Milovidov
b89f01438e
Lower mutex scope
2022-06-25 03:05:55 +02:00
Nikita Taranov
6639d94125
stash
2022-06-25 01:32:21 +02:00
Nikita Taranov
c476427422
stash
2022-06-25 01:27:24 +02:00
Nikita Taranov
f6ef78c0f1
stash
2022-06-25 01:26:46 +02:00
kssenii
708b93a03b
Merge master
2022-06-25 00:08:24 +02:00
kssenii
082c306ee8
Fix test, fix style
2022-06-25 00:04:21 +02:00
Kruglov Pavel
86e8f31ad4
Merge branch 'master' into schema-inference-cache
2022-06-24 16:10:25 +02:00
mergify[bot]
92eff431be
Merge branch 'master' into overcommit-deadlock-fix
2022-06-24 13:54:11 +00:00
Alexander Tokmakov
cfe0e434e5
Revert "Add support for io_uring read method"
2022-06-24 12:19:41 +03:00
mergify[bot]
a0eb831cd1
Merge branch 'master' into overcommit-deadlock-fix
2022-06-23 23:02:59 +00:00
Alexey Milovidov
812ab9bd6b
Merge pull request #36103 from sauliusvl/uring
...
Add support for io_uring read method
2022-06-24 00:34:29 +03:00
Alexander Tokmakov
74f38710a8
Merge branch 'master' into cleanup_garbage_in_store_dir
2022-06-23 21:43:28 +02:00
kssenii
6fbd49f554
Merge master
2022-06-23 21:40:01 +02:00
kssenii
468c98ff42
Better
2022-06-23 17:46:27 +02:00
kssenii
f7b329ee57
Merge master
2022-06-23 14:56:48 +02:00
Antonio Andelic
ae3d9fd962
Expose list request type in internal client
2022-06-23 10:28:12 +00:00
Antonio Andelic
568c957eb2
Fix TestKeeper
2022-06-23 10:28:12 +00:00
Antonio Andelic
3a71b63b5d
Add list request type
2022-06-23 10:28:12 +00:00
Antonio Andelic
a5ee918bd2
Merge pull request #38047 from ClickHouse/keeper-sequential-consistency-reads
...
Add `SYNC` command to internal ZooKeeper client
2022-06-23 08:43:24 +02:00
kssenii
e40d9bcf55
Merge master
2022-06-22 23:28:52 +02:00
mergify[bot]
9688388be2
Merge branch 'master' into concurrency-control
2022-06-22 15:07:56 +00:00
Dmitry Novik
3544fbe5c4
cleanup
2022-06-22 14:05:20 +00:00
kssenii
4178abc0a5
Merge master
2022-06-21 22:38:51 +02:00
kssenii
90ce0b44f0
Fixes
2022-06-21 21:03:18 +02:00
Robert Schulze
0d80874d40
Merge pull request #38068 from ClickHouse/clang-tsa
...
Support for Clang Thread Safety Analysis (TSA)
2022-06-21 20:19:33 +02:00
Sergei Trifonov
dc59d208de
unittest style/perf minor fixes
2022-06-21 18:38:51 +02:00
kssenii
481644939a
Add describe cache command
2022-06-21 16:07:39 +02:00
avogar
d37ad2e6de
Implement cache for schema inference for file/s3/hdfs/url
2022-06-21 13:02:48 +00:00
Dmitry Novik
099055c183
Explicitly forbid allocations in OvercommitTracker
2022-06-21 12:26:13 +00:00
Alexander Tokmakov
ba0fcec993
add background cleanup of store/ subdirs
2022-06-21 12:35:47 +02:00
Saulius Valatka
160c95a6b8
unpoisson memory read by io_uring, handle interrupted syscalls, do not throw from monitor thread
2022-06-21 13:20:21 +03:00
Saulius Valatka
7b5e13a9eb
implement pending request queue to prevent CQ overflows, more error checking, reduce size of io_uring
2022-06-21 13:17:56 +03:00
Dmitry Novik
e10f079bd3
Get rid of allocations in OvercommitTracker
2022-06-21 10:15:33 +00:00
Kseniia Sumarokova
71ee5dbbb2
Merge pull request #38227 from kssenii/diff-reduce
...
buffer's getFileSize small changes
2022-06-21 12:12:22 +02:00
mergify[bot]
bdd5b94192
Merge branch 'master' into keeper-sequential-consistency-reads
2022-06-21 08:13:04 +00:00
Saulius Valatka
0dc7854af1
add initial io_uring support
2022-06-21 09:59:46 +03:00
lingpeng0314
c18dd55400
Resolve comments
...
- refine metric description
2022-06-21 10:30:19 +08:00
Dmitry Novik
9ca368ac20
Use do while(false) in macro
2022-06-20 23:10:40 +00:00
mergify[bot]
9bdd9e14a6
Merge branch 'master' into fix_flaky_tests_with_transactions
2022-06-20 18:11:30 +00:00
Dmitry Novik
53d656d89f
Fix deadlock in OvercommitTracker logging
2022-06-20 17:35:24 +00:00
Robert Schulze
55b39e709d
Merge remote-tracking branch 'origin/master' into clang-tsa
2022-06-20 16:39:32 +02:00
Antonio Andelic
0c76fc1121
Fix style
2022-06-20 14:21:59 +00:00
Robert Schulze
5a4f21c50f
Support for Clang Thread Safety Analysis (TSA)
...
- TSA is a static analyzer build by Google which finds race conditions
and deadlocks at compile time.
- It works by associating a shared member variable with a
synchronization primitive that protects it. The compiler can then
check at each access if proper locking happened before. A good
introduction are [0] and [1].
- TSA requires some help by the programmer via annotations. Luckily,
LLVM's libcxx already has annotations for std::mutex, std::lock_guard,
std::shared_mutex and std::scoped_lock. This commit enables them
(--> contrib/libcxx-cmake/CMakeLists.txt).
- Further, this commit adds convenience macros for the low-level
annotations for use in ClickHouse (--> base/defines.h). For
demonstration, they are leveraged in a few places.
- As we compile with "-Wall -Wextra -Weverything", the required compiler
flag "-Wthread-safety-analysis" was already enabled. Negative checks
are an experimental feature of TSA and disabled
(--> cmake/warnings.cmake). Compile times did not increase noticeably.
- TSA is used in a few places with simple locking. I tried TSA also
where locking is more complex. The problem was usually that it is
unclear which data is protected by which lock :-(. But there was
definitely some weird code where locking looked broken. So there is
some potential to find bugs.
*** Limitations of TSA besides the ones listed in [1]:
- The programmer needs to know which lock protects which piece of shared
data. This is not always easy for large classes.
- Two synchronization primitives used in ClickHouse are not annotated in
libcxx:
(1) std::unique_lock: A releaseable lock handle often together with
std::condition_variable, e.g. in solve producer-consumer problems.
(2) std::recursive_mutex: A re-entrant mutex variant. Its usage can be
considered a design flaw + typically it is slower than a standard
mutex. In this commit, one std::recursive_mutex was converted to
std::mutex and annotated with TSA.
- For free-standing functions (e.g. helper functions) which are passed
shared data members, it can be tricky to specify the associated lock.
This is because the annotations use the normal C++ rules for symbol
resolution.
[0] https://clang.llvm.org/docs/ThreadSafetyAnalysis.html
[1] https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/42958.pdf
2022-06-20 16:13:25 +02:00
Antonio Andelic
777ae72259
Merge branch 'master' into keeper-sequential-consistency-reads
2022-06-20 14:06:45 +00:00
kssenii
5dd1bb2fd8
improvements for getFileSize
2022-06-20 15:22:56 +02:00
Antonio Andelic
6c225bb04d
Update src/Common/ZooKeeper/ZooKeeperImpl.cpp
...
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-06-20 14:55:59 +02:00
kssenii
90be49faa4
Merge master
2022-06-20 14:26:56 +02:00
Vitaly Baranov
06c4082a7c
Merge pull request #37358 from vitlibar/backup-improvements-6
...
Backup Improvements 6
2022-06-20 14:13:30 +02:00
kssenii
84a2bb031c
Fix
2022-06-20 14:02:06 +02:00
mergify[bot]
4ed606a275
Merge branch 'master' into fix_flaky_tests_with_transactions
2022-06-20 10:17:51 +00:00
Kseniia Sumarokova
a756b4be27
Merge pull request #37391 from azat/insert-profile-events-fix
...
Send profile events for INSERT queries (previously only SELECT was supported)
2022-06-20 12:16:29 +02:00
lingpeng0314
f06b19bdbf
Add keeper monitoring data
2022-06-20 11:32:18 +08:00
Sergey Skvortsov
466a5d04c5
fix: Use LIMIT_EXCEEDED
2022-06-19 22:18:37 +03:00
Sergey Skvortsov
ca85baea48
feat: Use non-default initial value for CRC32, a lot of perf
2022-06-19 16:41:03 +03:00
Sergey Skvortsov
7463dc5664
style: Apply some fixes
2022-06-18 03:25:26 +03:00
Sergey Skvortsov
f77f8201aa
refactor: Move isPowerOf2 to Common/BitHelpers.h
2022-06-18 02:31:56 +03:00
Sergey Skvortsov
3386386a22
feat: Support grace hash join
2022-06-18 02:31:56 +03:00
Vitaly Baranov
a0c558a17e
Implement backup/restore for ACL system tables (system.users, system.roles, etc.)
2022-06-17 18:14:31 +02:00
Alexander Tokmakov
e9c2157f01
Merge branch 'master' into fix_flaky_tests_with_transactions
2022-06-17 15:57:30 +02:00
alesapin
1c7a7da487
Merge pull request #38088 from kssenii/diff-with-cache
...
Extract some diff from pr #36171
2022-06-17 12:07:31 +02:00
Alexander Tokmakov
39c0219c11
fixes
2022-06-16 19:41:32 +02:00
alesapin
ca33ff93cb
Merge pull request #37555 from ClickHouse/revert-37534-revert-37036-keeper-preprocess-operations
...
Add support for preprocessing ZooKeeper operations and real-time digest in `clickhouse-keeper`
2022-06-16 17:29:00 +02:00
kssenii
797482f132
Better
2022-06-16 16:40:29 +02:00
Azat Khuzhin
b3bf7589ef
Fix possible concurrent access in ProgressIndication
...
In case of all of the above:
- clickhouse-local
- input_format_parallel_parsing=true
- write_progress_on_update=true
It is possible concurrent access to the following:
- writeProgress() (class properties) (guarded with progress_mutex)
- thread_data/host_cpu_usage (guarded with profile_events_mutex)
v2: decrease number of rows for INSERT ProfileEvents test (10 times)
CI: https://s3.amazonaws.com/clickhouse-test-reports/37391/4bd5c335182279dcc5020aa081b13c3044135951/stateless_tests__debug__actions__[1/3].html
v3: decrease number of rows for INSERT ProfileEvents test (10 times) and add a comment
CI: https://s3.amazonaws.com/clickhouse-test-reports/37391/026d7f732cb166c90d6c287b02824b6c7fdebf0c/stateless_tests_flaky_check__address__actions_/runlog.log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
f
2022-06-16 11:59:01 +03:00
Antonio Andelic
0b843d316f
Merge branch 'master' into keeper-sequential-consistency-reads
2022-06-16 07:52:56 +00:00
Alexey Milovidov
c26abbfdc5
Merge pull request #38093 from danlark1/master
...
Optimize most important parts with NEON SIMD
2022-06-16 08:26:56 +03:00
Robert Schulze
b39b963733
Merge pull request #37993 from ClickHouse/stripping
...
Strip less aggressively to make the embedded hash survive
2022-06-16 00:08:36 +02:00
Vitaly Baranov
21f3bed435
Simplify path calculations in backup.
2022-06-15 20:32:34 +02:00
Vitaly Baranov
592f568f83
Move backup/restore code to storages and databases - part 2.
2022-06-15 20:32:31 +02:00
kssenii
416c6008ee
Merge master
2022-06-15 16:50:25 +02:00
Danila Kutenin
048f56bf4d
Fix some tests and comments
2022-06-15 14:40:21 +00:00
kssenii
500f49972b
Extract diff from PR 36171
2022-06-15 16:40:18 +02:00
Danila Kutenin
08e3f77a9c
Optimize most important parts with NEON SIMD
...
First part, updated most UTF8, hashing, memory and codecs. Except
utf8lower and upper, maybe a little later.
That includes huge amount of research with movemask dealing. Exact
details and blog post TBD.
2022-06-15 13:19:29 +00:00
mergify[bot]
d148299c20
Merge branch 'master' into revert-37534-revert-37036-keeper-preprocess-operations
2022-06-15 07:11:31 +00:00
Alexey Milovidov
0957c885e2
Remove -0. from CPU usage in the client
2022-06-14 23:36:16 +02:00
mergify[bot]
4bd61950db
Merge branch 'master' into stripping
2022-06-14 20:48:52 +00:00
alesapin
af1cd745e1
Merge pull request #37975 from kssenii/clean-up-broken-detached
...
Clean up broken detached parts after timeout
2022-06-14 20:53:31 +02:00
Antonio Andelic
b7bd5a8eb1
Merge branch 'master' into revert-37534-revert-37036-keeper-preprocess-operations
2022-06-14 12:51:35 +00:00
Antonio Andelic
c98c6566bf
Use std::pair
2022-06-14 12:49:42 +00:00
Maksim Kita
da8b1b1eba
Merge pull request #38025 from kitaisreal/use-base-sort-instead-of-standard
...
Use pdqsort instead of standard sort
2022-06-14 12:13:35 +02:00
Antonio Andelic
367df12626
Add sync support to client
2022-06-14 09:50:30 +00:00
Robert Schulze
bc46cef63c
Minor follow-up
...
- change ELF section name to ".clickhouse.hash" (lowercase seems
standard)
- more expressive/concise integrity check messages at startup
2022-06-14 08:52:13 +00:00
kssenii
74cffaf186
Merge master
2022-06-14 00:45:19 +02:00
kssenii
4813b90281
Merge master
2022-06-13 21:32:00 +02:00
Antonio Andelic
e5504f1b33
Merge branch 'master' into revert-37534-revert-37036-keeper-preprocess-operations
2022-06-13 15:43:10 +00:00
Maksim Kita
98a89b50ff
Use pdqsort instead of standard sort
2022-06-13 15:31:08 +02:00
Kseniia Sumarokova
7fd1140e96
Merge pull request #38004 from xiedeyantu/optimize_max_cache
...
fix when open enable_filesystem_query_cache_limit, throw LOGICAL_ERROR
2022-06-13 11:54:09 +02:00
Robert Schulze
9ec56fa362
Merge pull request #37628 from zvonand/non-neg-deriv
...
Non Negative Derivative window function
2022-06-13 11:21:16 +02:00
Robert Schulze
bc6f30fd40
Move binary hash to ELF section ".ClickHouse.hash"
2022-06-13 08:46:23 +00:00
xiedeyantu
c93ef2b033
fix when open enable_filesystem_query_cache_limit, throw Reserved cache size exceeds the remaining cache size
2022-06-12 15:03:06 +08:00
kssenii
4859e11c27
Review fixes
2022-06-12 01:15:10 +02:00
kssenii
aaf9a46f07
Merge master
2022-06-11 15:56:05 +02:00
Alexander Tokmakov
a1ca690afb
Merge pull request #37976 from ClickHouse/tavplubix-patch-1
...
Try fix `test_consistent_parts_after_clone_replica`
2022-06-10 21:04:56 +03:00
Alexander Tokmakov
2319ef7647
fix test
2022-06-10 17:48:14 +02:00
zvonand
5beb6e0c3b
Merge branch 'master' of github.com:ClickHouse/ClickHouse into non-neg-deriv
2022-06-10 17:40:16 +03:00
Kseniia Sumarokova
580a30c6ae
Merge pull request #37859 from KinderRiven/support_max_request_cache_size
...
Support to set max cache size for per query in local cache
2022-06-10 16:17:18 +02:00
zvonand
794dbe6b60
new stateless queries + minor fixes
2022-06-10 17:01:49 +03:00
Robert Schulze
5f5732a2c4
Merge pull request #37969 from ClickHouse/consistent-macro-usage
...
More consistent use of platform macros
2022-06-10 14:10:01 +02:00
kssenii
498f389c21
Merge master
2022-06-10 12:49:10 +02:00
kssenii
0fd2c4b2c0
Continuation
2022-06-10 12:33:29 +02:00
kssenii
7a2676c7ab
Clean up broken detached parts with timeout
2022-06-10 12:27:57 +02:00
Kseniia Sumarokova
508676ab4e
Merge pull request #37804 from ClickHouse/metadata_storage
...
Metadata storage abstraction for Disks
2022-06-10 11:43:28 +02:00
Robert Schulze
1a0b5f33b3
More consistent use of platform macros
...
cmake/target.cmake defines macros for the supported platforms, this
commit changes predefined system macros to our own macros.
__linux__ --> OS_LINUX
__APPLE__ --> OS_DARWIN
__FreeBSD__ --> OS_FREEBSD
2022-06-10 10:22:31 +02:00
KinderRiven
360730bafe
fix
2022-06-10 12:28:22 +08:00
Alexander Tokmakov
780f7c87c7
Merge pull request #36113 from ClickHouse/remove-useless-code-2
...
Remove useless code in ReplicatedMergeTreeRestartingThread
2022-06-09 17:56:28 +03:00
KinderRiven
5c27244eb3
fix unit_test
2022-06-09 21:50:09 +08:00
alesapin
84ab147155
Merge branch 'master' into metadata_storage
2022-06-08 22:33:12 +02:00
Maksim Kita
a38c527e32
ProcfsMetricsProvider fix typo
2022-06-08 16:30:16 +02:00
KinderRiven
d5da970129
fix
2022-06-08 20:42:16 +08:00
KinderRiven
16ae349751
fix
2022-06-08 20:15:58 +08:00
KinderRiven
cec810ad29
fix
2022-06-08 20:13:20 +08:00
KinderRiven
6883ecda96
fix
2022-06-08 14:19:50 +08:00
KinderRiven
ff16d5555c
fix build
2022-06-08 03:23:40 +08:00
KinderRiven
1e47ae1026
fix build
2022-06-08 03:22:58 +08:00
KinderRiven
5e8a3c6352
fix build
2022-06-08 03:19:07 +08:00
KinderRiven
55c390c86f
fix
2022-06-08 01:42:46 +08:00
KinderRiven
6f8abd0328
fix
2022-06-07 19:53:24 +08:00
KinderRiven
de45f0a38c
fix unit_test
2022-06-07 19:30:39 +08:00
KinderRiven
f00914430d
fix holder
2022-06-07 19:10:57 +08:00
Vladimir C
1c184a7e18
Merge pull request #37840 from azat/join-query-fatal-errors
2022-06-07 12:07:37 +02:00
KinderRiven
3b2a427002
fix
2022-06-07 11:50:56 +08:00
alesapin
5a213c2396
Followup
2022-06-06 20:52:53 +02:00
alesapin
a459f2e43d
Fix bug
2022-06-06 20:51:58 +02:00
Antonio Andelic
2c37fe3d7b
Merge branch 'master' into revert-37534-revert-37036-keeper-preprocess-operations
2022-06-06 12:39:55 +00:00
alesapin
daf49dca77
Remove logical error (legal case)
2022-06-06 13:32:58 +02:00
KinderRiven
bfe5150154
better
2022-06-06 16:48:30 +08:00
KinderRiven
4e78bbd414
fix
2022-06-06 03:21:56 +08:00
KinderRiven
13e74bef5e
support skip_download_if_exceeds_query_cache
2022-06-06 02:36:23 +08:00
KinderRiven
882104ab77
fix
2022-06-06 01:46:27 +08:00
KinderRiven
d9684daa6f
fix better
2022-06-06 01:29:49 +08:00
KinderRiven
ae86f7ceaa
fix
2022-06-06 00:00:59 +08:00
KinderRiven
c5fc826fc3
fix style
2022-06-05 17:45:45 +08:00
Amos Bird
a5afb73c52
Remove duplicated peak mem log
...
Also log "Processed in {} sec" a little bit earlier so that it's also
sent to client and have the log entry related to the query_id.
2022-06-05 17:02:58 +08:00
KinderRiven
cb9927cd00
fix
2022-06-05 16:52:01 +08:00
KinderRiven
3ffb0b3549
support_max_query_cache_size
2022-06-05 16:21:36 +08:00
Alexey Milovidov
f860407af5
Merge pull request #37777 from ClickHouse/avx512_tail_zero
...
Use multitarget framework for numZerosInTail implementation
2022-06-04 01:46:56 +03:00
Azat Khuzhin
c29768325c
Print query in one line on fatal errors
...
executeQuery() logging query without new lines in SQL, and it is useful,
since you can grep and see the whole query (usually).
So let's use the same in fatal error handler to make CI reports more
informative.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-06-03 18:55:53 +03:00
kssenii
f41621736d
Fixes
2022-06-03 17:03:05 +02:00
mergify[bot]
ddf7210ecc
Merge branch 'master' into remove-useless-code-2
2022-06-03 13:58:45 +00:00
alesapin
ac03e3af3e
Merge branch 'master' into metadata_storage
2022-06-03 14:42:21 +02:00
zvonand
5e4e349495
small fixes
2022-06-03 14:14:20 +03:00
Alexey Milovidov
1529d47207
Merge pull request #34754 from ClickHouse/llvm-14
...
Switch to clang/llvm 14
2022-06-03 14:07:34 +03:00
alesapin
46bccae078
Trying to create metadata layer
2022-06-02 18:09:40 +02:00
kssenii
3d85391195
Better
2022-06-02 18:00:13 +02:00
Antonio Andelic
7ee47fc5bb
Merge branch 'master' into revert-37534-revert-37036-keeper-preprocess-operations
2022-06-02 13:38:52 +00:00
Nikolai Kochetov
edac3d6714
Merge branch 'master' into refactor-read-metrics-and-callbacks
2022-06-02 09:36:20 +00:00
Alexander Gololobov
6433fd6113
Added macros for AVX512BW target
2022-06-02 11:19:46 +02:00
Sergei Trifonov
db2cf73b52
perf/safety/docs improvements
2022-06-02 11:17:13 +02:00
Alexey Milovidov
cb8b0219ac
Merge branch 'master' of github.com:ClickHouse/ClickHouse into llvm-14
2022-06-02 08:46:31 +02:00
Alexander Gololobov
a0cf902d49
Merge pull request #37588 from yaqi-zhao/avx512_tail_zero
...
add avx512 support for mergetree reader
2022-06-02 08:51:52 +03:00
Alexander Gololobov
ec6e413f0b
Fixed runtime check for AVX512F
2022-06-01 23:00:49 +02:00
Alexey Milovidov
b5f48a7d3f
Merge branch 'master' of github.com:ClickHouse/ClickHouse into llvm-14
2022-06-01 22:09:58 +02:00
kssenii
e3647585aa
Fix tests
2022-06-01 19:58:28 +02:00
Alexey Milovidov
89638de521
Merge pull request #37738 from ClickHouse/fix-intersect-with-const
...
Fix `Intersect` with constant strings
2022-06-01 19:31:55 +03:00
Antonio Andelic
ded1398565
Fix intersect with const string
2022-06-01 11:13:33 +00:00
mergify[bot]
4aefcf29e3
Merge branch 'revert-37534-revert-37036-keeper-preprocess-operations' into keeper-real-time-digest
2022-06-01 10:17:49 +00:00
Alexander Gololobov
26609a1875
Style fixes
2022-05-31 21:41:10 +02:00
Nikolai Kochetov
86fbb74703
Merge branch 'master' into refactor-read-metrics-and-callbacks
2022-05-31 18:07:47 +00:00
mergify[bot]
ba49c6bb46
Merge branch 'master' into memory-overcommit-improvement
2022-05-31 13:17:06 +00:00
Sergei Trifonov
9884ea1945
Merge branch 'concurrency-control' of github.com:ClickHouse/ClickHouse into concurrency-control
2022-05-31 08:17:30 +02:00
Sergei Trifonov
1914f9fed7
fix typos
2022-05-31 08:17:09 +02:00
yaqi-zhao
a2857491c4
add avx512 support for mergetreereader
2022-05-30 20:53:00 -04:00
mergify[bot]
93fd3e4772
Merge branch 'master' into concurrency-control
2022-05-30 20:24:58 +00:00
kssenii
bdfd166eb1
Merge master
2022-05-30 21:31:47 +02:00
kssenii
bfbc0e3184
Better, important fixes
2022-05-30 20:35:31 +02:00
Sergei Trifonov
6bd874df48
add tests; fix bugs; make Allocation and ConcurrencyControl classes less tighly bounded
2022-05-30 17:43:25 +02:00
Kseniia Sumarokova
b1ba7b7027
Fix build
2022-05-30 17:30:59 +02:00
Kseniia Sumarokova
1869adfd7d
Update FileCache.cpp
2022-05-30 16:06:58 +02:00
Nikolai Kochetov
5b4658aa5e
Merge branch 'master' into refactor-read-metrics-and-callbacks
2022-05-30 09:47:35 +00:00
Andrey Zvonov
c79d87e629
fix style
2022-05-30 02:26:02 +03:00
Alexey Milovidov
5fda199dcf
Update src/Common/ErrorCodes.cpp
...
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2022-05-30 00:20:49 +03:00
Andrey Zvonov
2dbbf14de5
Merge branch 'master' into non-neg-deriv
2022-05-29 10:09:51 +03:00
Alexey Milovidov
c1169019d2
Merge branch 'master' into llvm-14
2022-05-29 02:29:02 +02:00
Alexey Milovidov
11788c8129
Fix clang-tidy-14
2022-05-29 02:28:46 +02:00
zvonand
032e54abbf
works now
2022-05-29 03:21:07 +03:00
Alexey Milovidov
73e2e63414
Merge pull request #37612 from ClickHouse/clang-tidy-14
...
Fix clang-tidy-14, part 1
2022-05-29 03:16:32 +03:00
Anton Popov
1d9b3be7da
Merge pull request #37536 from CurtizJ/profile-events-for-part-types
...
Add profile events for introspection of part types
2022-05-28 14:25:21 +02:00
kssenii
2d3714f6c4
Merge master
2022-05-28 14:07:04 +02:00
Alexey Milovidov
eff285e24a
Update ThreadFuzzer.cpp
2022-05-28 05:13:16 +03:00
Alexey Milovidov
c50791dd3b
Fix clang-tidy-14, part 1
2022-05-27 22:52:14 +02:00
Alexey Milovidov
d2c6fd90cb
Fix clang-tidy-14, part 1
2022-05-27 22:51:37 +02:00
Kseniia Sumarokova
10c9716467
Fix clang-tidy
2022-05-27 22:48:07 +02:00
Dmitry Novik
60b9d81773
Remove global_memory_usage_overcommit_max_wait_microseconds
2022-05-27 16:30:29 +00:00
kssenii
a4e8fd59e1
Correct merge
2022-05-27 18:24:17 +02:00
Kseniia Sumarokova
8099361cbc
Update FileCache.cpp
2022-05-27 17:48:14 +02:00
kssenii
25b1ed526d
Merge master
2022-05-27 16:50:45 +02:00
kssenii
b78455168e
Continuation
2022-05-27 16:25:33 +02:00
tchepavel
42cd854688
Merge branch 'master' into nats-integration
2022-05-27 16:05:08 +03:00
zvonand
5c558d0be9
old work upload
2022-05-27 15:07:22 +03:00
alesapin
6d6779f17a
Merge pull request #37139 from ClickHouse/i_object_storage
...
Separate object storage operations from disks
2022-05-27 13:59:50 +02:00
Kseniia Sumarokova
f5d69506b4
Merge pull request #37516 from KinderRiven/improve_local_cache
...
Control cache downloads to avoid negative optimization of local caches
2022-05-27 11:53:17 +02:00
Sergei Trifonov
4c021b8d80
fix comments
2022-05-26 13:25:50 +02:00
Nikolai Kochetov
84f97b53de
Merge branch 'master' into refactor-read-metrics-and-callbacks
2022-05-26 11:07:45 +00:00
Sergei Trifonov
27fca17421
add concurrency control in pipeline executor
2022-05-26 11:05:34 +02:00
KinderRiven
822ecd982f
better & support clean stash
2022-05-26 16:36:05 +08:00
alesapin
1db9cf480b
Merge remote-tracking branch 'origin/master' into i_object_storage
2022-05-25 22:50:22 +02:00
kssenii
50cd358c0e
Merge master
2022-05-25 22:21:28 +02:00
alesapin
c7b16065e1
Merge with master
2022-05-25 21:47:05 +02:00
kssenii
b89a4edc04
Merge master
2022-05-25 20:55:04 +02:00
alesapin
6f5c86e55e
Merge branch 'master' into i_object_storage
2022-05-25 20:49:01 +02:00
kssenii
0dbc09ef17
Continuation
2022-05-25 20:28:46 +02:00
KinderRiven
a33c7ce648
fix
2022-05-25 22:58:47 +08:00
Anton Popov
16e839ac71
add profile events for introspection of part types
2022-05-25 14:54:49 +00:00
kssenii
0556237b68
Continuation
2022-05-25 16:49:40 +02:00
Nikolai Kochetov
1b85f2c1d6
Merge branch 'master' into refactor-read-metrics-and-callbacks
2022-05-25 16:27:40 +02:00
KinderRiven
875557abc2
fix
2022-05-25 21:53:28 +08:00
KinderRiven
adbb821176
fix
2022-05-25 21:05:15 +08:00
KinderRiven
2211c1ddb8
fix
2022-05-25 20:15:43 +08:00
KinderRiven
d0fcffec66
fix style
2022-05-25 17:51:03 +08:00
KinderRiven
1ce219bae2
fix
2022-05-25 17:24:38 +08:00
KinderRiven
e3f76cab55
impl improve remote fs cache
2022-05-25 16:54:28 +08:00
Robert Schulze
01ab7b9bad
Pass strings in some places as string_view
...
The original goal was to get change
const auto & needle = String(
reinterpret_cast<const char *>(cur_needle_data),
cur_needle_length);
in Functions/MatchImpl.h into a std::string_view to save an allocation +
copy. The needle is eventually passed as search pattern into the re2
library. Re2 has an alternative constructor taking a const char * i.e. a
NULL-terminated string. Here, the needle is NULL-terminated but
1. this is only because it is passed inside a ColumnString yet this is
not always the case (e.g. fixed string columns has a dense layout w/o
NULL terminator).
2. assuming NULL termination for users != MatchImpl of the regex code is
too dangerous.
So, for now we'll stay with copying to be on the safe side. One fine day
when re2 has a ptr/size ctor, we can use std::string_view.
Just changing a few other places from std::string to std::string_view
but this will not help with performance.
2022-05-25 10:05:51 +02:00
Robert Schulze
e8c96777f6
Make OptimizedRegularExpression::analyze() private
2022-05-25 10:05:45 +02:00
Kseniia Sumarokova
02d162c25d
Merge branch 'master' into nats-integration
2022-05-25 10:04:39 +02:00
Antonio Andelic
fe72cd7478
Merge branch 'master' into keeper-real-time-digest
2022-05-25 07:41:31 +00:00
Robert Schulze
7348a0eb28
Merge pull request #37251 from ClickHouse/non_const_like
...
Support non-constant SQL functions (NOT) (I)LIKE and MATCH
2022-05-24 20:28:31 +02:00
Maksim Kita
3c0c322d7c
Merge pull request #37480 from kitaisreal/dynamic-dispatch-infrastructure-improvements
...
Dynamic dispatch infrastructure style fixes
2022-05-24 18:13:53 +02:00
tchepavel
43226a57fc
Merge branch 'master' into nats-integration
2022-05-24 18:15:11 +03:00
kssenii
35d2dec8d5
Fix
2022-05-24 16:15:55 +02:00
Maksim Kita
e6e4b2826d
Dynamic dispatch infrastructure style fixes
2022-05-24 14:25:29 +02:00
Alexander Tokmakov
6bc68c0cbc
Merge branch 'master' into fixes_for_transactions
2022-05-23 18:49:21 +02:00
Dmitry Novik
e9187ec4b7
Overcommit: update defaults, exception message and add ProfileEvent
2022-05-23 14:35:09 +00:00
tchepavel
d9436ec7dd
Merge branch 'master' into nats-integration
2022-05-23 14:30:09 +03:00
Antonio Andelic
8cb6101a3c
Merge branch 'master' into keeper-real-time-digest
2022-05-23 10:34:20 +00:00
mergify[bot]
747aa5575c
Merge branch 'master' into remove-useless-code-2
2022-05-22 17:41:57 +00:00
Robert Schulze
0299cc87e4
Improve naming consistency of string search code
...
Just renamings, nothing major ...
2022-05-22 17:50:38 +02:00
alesapin
c8d92b87c8
Merge branch 'master' into i_object_storage
2022-05-22 12:16:10 +02:00
Robert Schulze
19d53c14fa
Merge pull request #37382 from ClickHouse/wc++98-compat-extra-semi
...
Enable -Wc++98-compat-extra-semi
2022-05-22 09:40:45 +02:00
kssenii
9aa20193d5
Merge master
2022-05-22 00:56:20 +02:00
kssenii
ffd8d9723a
Continuation
2022-05-22 00:21:40 +02:00
Nikolai Kochetov
56feef01e7
Move some resources
2022-05-20 19:49:31 +00:00
Alexander Tokmakov
1027798517
handle connection loss on commit
2022-05-20 17:35:29 +02:00
Anton Popov
cb0e6c2718
mark all operators bool() as explicit
2022-05-20 15:29:54 +00:00
Robert Schulze
0f6715bd91
Follow-up to PR #37300 : semicolon warnings
...
In PR #37300 , Alexej asked why we the compiler does not warn about
unnecessary semicolons, e.g.
f()
{
}; // <-- here
The answer is surprising: In C++98, above syntax was disallowed but by
most compilers accepted it regardless. C++>11 introduced "empty
declarations" which made the syntax legal.
The previous behavior can be restored using flag
-Wc++98-compat-extra-semi. This finds many useless semicolons which were
removed in this change. Unfortunately, there are also false positives
which would require #pragma-s and HAS_* logic (--> check_flags.cmake) to
suppress. In the end, -Wc++98-compat-extra-semi comes with extra effort
for little benefit. Therefore, this change only fixes some semicolons
but does not enable the flag.
2022-05-20 15:06:34 +02:00
Alexander Tokmakov
12bbb7de87
fix race on TID allocation
2022-05-20 12:41:44 +02:00
alesapin
654b27e307
Merge branch 'master' into i_object_storage
2022-05-20 11:56:13 +02:00
Antonio Andelic
fc9beb2933
Merge branch 'master' into keeper-real-time-digest
2022-05-20 09:54:44 +00:00
Robert Schulze
b475fbc9a7
Merge pull request #37300 from ClickHouse/cmake-cleanup-pt3
...
Various cmake cleanups
2022-05-20 10:02:36 +02:00
Antonio Andelic
c133f815bd
Merge branch 'keeper-preprocess-operations' into keeper-real-time-digest
2022-05-20 07:57:47 +00:00
kssenii
e501a5a106
Update tests config
2022-05-19 15:55:07 +02:00
Antonio Andelic
f5759e2d7e
Cache nodes latest state
2022-05-19 12:30:57 +00:00
Yakov Olkhovskiy
cd2ae72aac
Merge pull request #37273 from ClickHouse/client-dns-list
...
Multiple client connection attempts if hostname resolves to multiple addresses
2022-05-19 01:50:39 -04:00
Maksim Kita
df0cb06209
Merge pull request #37289 from kitaisreal/unary-arithmetic-functions-improve-performance-dynamic-dispatch
...
Improve performance of unary arithmetic functions
2022-05-18 19:16:30 +02:00
mergify[bot]
d5f870eac8
Merge branch 'master' into client-dns-list
2022-05-18 12:40:02 +00:00
alesapin
2bdc718923
Merge branch 'i_object_storage' of github.com:ClickHouse/ClickHouse into i_object_storage
2022-05-18 12:37:00 +02:00
Dmitry Novik
20c537addd
Make noncopyable
2022-05-18 01:42:13 +00:00
Dmitry Novik
a97ba9741e
Fix possible deadlock in OvercommitTracker during logging
2022-05-17 18:07:52 +00:00
Maksim Kita
31a29d8315
Fixed dynamic dispatch macro
2022-05-17 16:59:11 +02:00
tchepavel
2692d88a42
Merge branch 'master' into nats-integration
2022-05-17 16:59:57 +03:00
Antonio Andelic
a29286ce09
Remove data from request string
2022-05-17 13:54:44 +00:00
Antonio Andelic
6fba1c96ed
Define small test for digest check
2022-05-17 13:53:12 +00:00
alesapin
5872781ac6
Merge with master
2022-05-17 15:50:30 +02:00
alesapin
824176f61d
Merge branch 'master' into i_object_storage
2022-05-17 15:49:15 +02:00
kssenii
e4e6e44e86
Merge master
2022-05-17 15:47:33 +02:00
alesapin
f9cd820854
Fix style
2022-05-17 15:39:46 +02:00
Yakov Olkhovskiy
c8a4be4c64
refactoring
2022-05-17 08:31:31 -04:00
Antonio Andelic
fc5a79f186
Polishing changes
2022-05-17 08:16:55 +00:00
Yakov Olkhovskiy
fc26505111
multiple client connection attempts if hostname resolves to multiple addresses
2022-05-16 17:47:07 -04:00
Kseniia Sumarokova
94683786dc
Merge branch 'master' into MeiliSearch
2022-05-16 22:42:09 +02:00
Maksim Kita
20380fa87b
Merge pull request #37257 from kitaisreal/dynamic-dispatch-infrastructure-for-class-members
...
Dynamic dispatch infrastructure for class member functions
2022-05-16 22:15:10 +02:00
kssenii
6a51dea791
Merge master
2022-05-16 22:13:22 +02:00
kssenii
5e3410f60a
Better
2022-05-16 22:09:11 +02:00
Vitaly Baranov
72bff5242a
Merge pull request #37168 from vitlibar/backup-improvements-5
...
Backups Improvements 5
2022-05-16 21:25:54 +02:00
Robert Schulze
43945cea1b
Fixing some warnings
2022-05-16 20:59:27 +02:00
tchepavel
270c01bcb7
Merge branch 'master' of github.com:ClickHouse/ClickHouse into nats-integration
2022-05-16 19:18:51 +03:00
Maksim Kita
032b5d3fc3
Dynamic dispatch infrastructure for class member functions
2022-05-16 17:05:16 +02:00
kssenii
f3c1f3796b
Some fixes
2022-05-16 16:16:38 +02:00
Antonio Andelic
2ec61a8d7f
Initial implementation of digest
2022-05-16 13:36:31 +00:00
Kseniia Sumarokova
ff37d7d5c3
Update ErrorCodes.cpp
2022-05-16 15:30:07 +02:00
Mikhail Artemenko
535b3ea686
refactor code & change exception numbers
2022-05-16 16:13:05 +03:00
tchepavel
58d8bc40aa
Merge branch 'master' of github.com:ClickHouse/ClickHouse into nats-integration
2022-05-16 13:01:45 +03:00
Robert Schulze
e3cfec5b09
Merge remote-tracking branch 'origin/master' into clangtidies
2022-05-16 10:12:50 +02:00
Dmitry Novik
2259add1fa
Merge pull request #37197 from ClickHouse/overcommit-ratio-overflow
...
Fix possible overflow in OvercommitRatio
2022-05-15 15:09:19 +02:00
tchepavel
7317c76d3c
Merge branch 'master' into nats-integration
2022-05-15 14:41:22 +03:00
kssenii
646cf4cc95
Better
2022-05-14 14:26:04 +02:00
Kseniia Sumarokova
f4a8a0cefe
Merge pull request #37200 from kssenii/add-s3-requests-metric
...
Add S3Requests metric
2022-05-14 10:08:21 +02:00
kssenii
47ff7b6132
Fixes after merge
2022-05-13 19:22:22 +02:00
kssenii
58faaf0ea3
Merge master
2022-05-13 18:51:07 +02:00
kssenii
5dd3ad08a1
Add S3Requests metric
2022-05-13 18:12:46 +02:00
Dmitry Novik
45585f0e7f
Fix possible overflow in OvercommitRatio
2022-05-13 15:39:05 +00:00
Kseniia Sumarokova
6e0a910fcd
Merge branch 'master' into better-read-from-cache
2022-05-12 19:44:18 +02:00
alesapin
e7296a2b28
Merge pull request #36825 from kssenii/cache-fix-1
...
Removed forceful drop cache command, fix detached status state
2022-05-12 17:18:21 +02:00
kssenii
7700d51ae4
Update profile events descriptions
2022-05-12 15:02:07 +02:00
kssenii
ef044a5df7
Merge
2022-05-12 14:59:27 +02:00
kssenii
483e056bcc
Merge master
2022-05-12 14:58:24 +02:00
Vitaly Baranov
30005a1eff
BACKUP ON CLUSTER correctly collects data of a replicated table from all replicas now,
...
and if some part doesn't exist on either replica it's no problem anymore.
2022-05-12 13:33:42 +02:00
tchepavel
5f8fcb748f
Select, MV, Insert working
2022-05-12 13:58:50 +03:00
Kseniia Sumarokova
5ae28f6fd8
Update ProfileEvents.cpp
2022-05-12 12:28:48 +02:00
Kseniia Sumarokova
d636a02e7a
Update FileSegment.cpp
2022-05-12 12:16:12 +02:00
Kseniia Sumarokova
2a4f763a5e
Merge pull request #37075 from kssenii/fix-progress-for-insert-select
...
Fix progress indication for `INSERT SELECT` in clickhouse-local and for file progress in client
2022-05-12 12:05:53 +02:00
Robert Schulze
f8c24c5fe8
Merge pull request #37117 from ClickHouse/bug-37114
...
Fix Bug 37114 - ilike on FixedString(N)s produces wrong results
2022-05-12 09:39:36 +02:00
Kseniia Sumarokova
4483e5783a
Update FileSegment.h
2022-05-11 23:33:38 +02:00
Kseniia Sumarokova
2d15520ddb
Update FileSegment.cpp
2022-05-11 23:33:15 +02:00
Alexander Tokmakov
5daf1b81a0
Update ZooKeeperImpl.cpp
2022-05-11 22:25:09 +03:00
Alexander Tokmakov
c23bc01196
Merge branch 'master' into zookeeper_client_fault_injection
2022-05-11 17:20:42 +02:00
kssenii
c5e84950d6
Update test, add descriptions to profile events
2022-05-11 14:57:51 +02:00
Robert Schulze
7232f47c68
Fix Bug 37114 - ilike on FixedString(N) columns produces wrong results
...
The main fix is in MatchImpl.h where the "case_insensitive" parameter is
added to Regexps::get().
Also made "case_insensitive" a non-default template parameter to reduce
the risk of future bugs.
The remainder of this commit are minor random code improvements.
resoves #37114
2022-05-11 14:30:21 +02:00
Kseniia Sumarokova
a440e1376a
Update FileSegment.cpp
2022-05-11 12:05:50 +02:00
mergify[bot]
0e2a86dcee
Merge branch 'master' into MeiliSearch
2022-05-11 08:49:19 +00:00
kssenii
5385a4da8a
Fix review comments
2022-05-11 10:45:20 +02:00
kssenii
18dd74be0c
Remove unneede changes
2022-05-11 10:26:30 +02:00
alesapin
0f276a0956
Merge pull request #36947 from ClickHouse/dump_ordered_sessions_map
...
Force keeper snapshot equality on different replicas
2022-05-10 23:36:09 +02:00
kssenii
ccab49e3cf
Merge master
2022-05-10 19:33:34 +02:00
kssenii
61f2737e17
Merge master
2022-05-10 19:31:22 +02:00
kssenii
f4b45a5805
Better profile events
2022-05-10 16:00:53 +02:00
kssenii
0feda67ec4
Fix progress for insert select
2022-05-10 15:04:08 +02:00
Alexander Tokmakov
897a0393b2
Merge pull request #37072 from jiahui-97/fix_comment_num
...
just fix a number
2022-05-10 15:39:50 +03:00
jiahui-97
4c1244d06d
just fix a number
...
Find a number wrong when reading SAHA paper and related code.
2022-05-10 20:33:25 +08:00
kssenii
2f0f76369a
Better
2022-05-09 21:25:26 +02:00
Anton Popov
e911900054
remove last mentions of data streams
2022-05-09 19:15:24 +00:00
Robert Schulze
1b81bb49b4
Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
...
Official docs:
Some headers from C library were deprecated in C++ and are no longer
welcome in C++ codebases. Some have no effect in C++. For more details
refer to the C++ 14 Standard [depr.c.headers] section. This check
replaces C standard library headers with their C++ alternatives and
removes redundant ones.
2022-05-09 08:23:33 +02:00
kssenii
f43c09b53c
Fix incorrect assetion
2022-05-08 14:18:43 +02:00
kssenii
50d229651f
Fix exception message
2022-05-07 23:33:28 +02:00
kssenii
0e9e1dd000
Fix assert in case cache forcefully dropped
2022-05-07 23:19:44 +02:00
mergify[bot]
ac5e69d940
Merge branch 'master' into dump_ordered_sessions_map
2022-05-07 21:17:23 +00:00
alesapin
e54e33a6df
I'm not ready for 3-way comparison
2022-05-07 15:33:34 +02:00
Alexey Milovidov
4eac661588
Merge branch 'master' into master
2022-05-07 13:21:59 +03:00
kssenii
0db83d7002
Merge master
2022-05-07 11:52:25 +02:00
kssenii
7e9913509f
Fix build
2022-05-06 14:22:01 +02:00
kssenii
35ed60f5f6
Merge master
2022-05-06 13:56:14 +02:00
kssenii
c0248d4250
Merge master
2022-05-06 13:50:09 +02:00
Kruglov Pavel
80df398bfc
Merge pull request #36883 from kssenii/add-asynchronous-metrics-for-filesystem-cache
...
Add some asynchronous metrics for fs cache
2022-05-06 13:39:55 +02:00
kssenii
23d9230acd
Do not throw logical error for detached file segment
2022-05-06 12:48:16 +02:00
alesapin
931a5f11f1
Update src/Common/ZooKeeper/IKeeper.h
...
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2022-05-06 12:13:51 +02:00
kssenii
2275196ef0
Merge master
2022-05-06 11:21:10 +02:00
Kseniia Sumarokova
83a4b94970
Merge pull request #36952 from ClickHouse/remove-nested-exception
...
Remove nested exception
2022-05-06 11:14:16 +02:00
Alexey Milovidov
996d838ca3
Merge pull request #36817 from DevTeamBK/Clang-tidy-Fixes
...
Clang -Tidy Fixes
2022-05-06 02:01:00 +03:00
kssenii
3aef08b887
Fix style
2022-05-06 00:25:13 +02:00
kssenii
b26098735f
Merge
2022-05-06 00:08:14 +02:00
kssenii
3a3a756d18
Fix failed checks
2022-05-06 00:07:22 +02:00
Alexey Milovidov
7841f02cf0
Remove nested exception
2022-05-05 23:05:52 +02:00
mergify[bot]
9ce436733f
Merge branch 'master' into fix-current-size-count-in-cache
2022-05-05 17:33:56 +00:00
alesapin
f4cdd86ae8
Force keeper snapshot equality on different replicas
2022-05-05 19:23:01 +02:00
mergify[bot]
2a8aad42dc
Merge branch 'master' into add-asynchronous-metrics-for-filesystem-cache
2022-05-05 15:43:38 +00:00
kssenii
78d3fd505f
Merge master
2022-05-05 17:41:13 +02:00
kssenii
0117fd40a6
Review fixes
2022-05-05 17:39:36 +02:00
Vitaly Baranov
dd51265218
Merge pull request #36864 from vitlibar/backup-improvements-4
...
Backup improvements
2022-05-05 15:37:51 +02:00
Anton Popov
fa1feb238e
Merge pull request #36853 from qoega/add-other-time-microsecons
...
Add Other Query Time Microseconds Profile Event
2022-05-05 13:58:13 +02:00
Alexander Gololobov
7e3a805ae3
Merge pull request #36572 from ClickHouse/fix-trash-s3-metrics
...
Everything related to S3 metrics was not good
2022-05-05 11:44:02 +02:00
alesapin
aba78e5ed0
Merge pull request #36859 from ClickHouse/revert-36858-revert-35637-memory-overcommit-free
...
Revert "Revert "Memory overcommit: continue query execution if memory is available""
2022-05-04 23:43:00 +02:00
kssenii
e604677c85
Better
2022-05-04 22:52:01 +02:00
Alexander Tokmakov
e30365a531
Merge pull request #36872 from ClickHouse/fix_exception_message
...
Add extra info when sending exception
2022-05-04 23:24:47 +03:00
Robert Schulze
c48d9a4174
Merge pull request #36844 from rschu1ze/shared_ptr_helper3
...
Remove inherited create() method + disallow copying of storages
2022-05-04 19:16:30 +02:00
mergify[bot]
e0fa563092
Merge branch 'master' into fix_exception_message
2022-05-04 15:56:03 +00:00
Robert Schulze
78cdb3ec64
Merge pull request #36862 from rschu1ze/new-clangtidies
...
Activated a bunch of LLVM 12/13/14 clang-tidy warnings
2022-05-04 15:26:57 +02:00
kssenii
c8b5decf29
Fix lock inversion
2022-05-04 14:28:55 +02:00
mergify[bot]
6ecddf4077
Merge branch 'master' into fix-trash-s3-metrics
2022-05-04 10:14:29 +00:00
Robert Schulze
590a01d39d
Linux build fix
2022-05-04 11:42:23 +02:00
Dmitry Novik
9087ab0e11
Use free_continue_and_alloc_3_test
2022-05-04 00:41:15 +00:00
kssenii
ef7d5b2a65
Fix
2022-05-04 00:19:36 +02:00
Vitaly Baranov
160bc288d3
Fix implementation of totalBytes() & totalRows() for Log family.
2022-05-04 00:15:21 +02:00
mergify[bot]
64084b5e32
Merge branch 'master' into shared_ptr_helper3
2022-05-03 20:46:16 +00:00
kssenii
8f99046100
Add come asynchronous metrics
2022-05-03 20:02:19 +02:00
kssenii
ab65e163fa
Add current metrics
2022-05-03 19:35:04 +02:00
mergify[bot]
ddd1c3e1b3
Merge branch 'master' into add-other-time-microsecons
2022-05-03 15:45:40 +00:00
Vitaly Baranov
828f45f078
Add new restore setting 'allow_non_empty_tables'.
2022-05-03 16:18:45 +02:00
Dmitry Novik
455742ec7a
Make unit tests stable
2022-05-03 13:20:57 +00:00
Alexander Tokmakov
94af11dd74
add extra info when sending exception
2022-05-03 15:13:47 +02:00
kssenii
025e632a66
Merge master
2022-05-03 14:46:59 +02:00
kssenii
b0d43e3f40
Better
2022-05-03 14:20:23 +02:00
kssenii
a3c9ff7fe8
Tiny changes
2022-05-03 11:46:22 +02:00
Vitaly Baranov
409edfd3fa
Rework RestoreCoordination: make restore deterministic.
2022-05-03 11:01:44 +02:00
Vitaly Baranov
2c754f44fc
Make calculation of shard_num & replica_num not dependant on match of the cluster's definitions on nodes.
2022-05-03 11:01:44 +02:00
Larry Luo
ee131eefd8
Removed move for trivially-copyable type and added noexcept for move constructor
2022-05-02 18:46:34 -07:00
Dmitry Novik
2815f22152
Remove incorrect assert
2022-05-02 23:02:43 +00:00
Dmitry Novik
2ed5a4013a
Revert "Revert "Memory overcommit: continue query execution if memory is available""
2022-05-03 00:45:13 +02:00
alesapin
f0b7af0aa2
Revert "Memory overcommit: continue query execution if memory is available"
2022-05-03 00:36:50 +02:00
alesapin
73f3334d80
Better fix for cache
2022-05-03 00:28:53 +02:00
Dmitry Novik
71b6f89166
Merge pull request #35637 from ClickHouse/memory-overcommit-free
...
Memory overcommit: continue query execution if memory is available
2022-05-02 19:00:18 +02:00
kssenii
70e2bb6264
Reimplement write-through cache
2022-05-02 18:55:11 +02:00
Ilya Yatsishin
6c3bbb4933
Add Other Time Microseconds Profile Event
2022-05-02 17:13:57 +02:00
Vladimir C
7293a69e5e
Merge pull request #36656 from amosbird/timefunctionunderflow
...
Saturate date/datetime to zero (part 2)
2022-05-02 17:10:48 +02:00
Maksim Kita
9bea207680
Merge pull request #36839 from rschu1ze/concepts
...
Replace uses of SFINAE by C++20 concepts
2022-05-02 14:20:12 +02:00
Robert Schulze
ad0b3be79d
Replace uses of SFINAE by C++20 concepts
...
- enable_if is usually regarded as fragile and unreadable
- C++20 concepts are much easier to read and produce more expressive
error messages
2022-05-02 09:23:53 +02:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying
...
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
previously allowed.
Hence, this change
- removes shared_ptr_helper and as a result all inherited create() methods,
- instead, Storage objects are now created using make_shared<>() by the
caller (for that to work, many constructors had to be made public), and
- all Storage classes were marked as noncopyable using boost::noncopyable.
In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
2022-05-02 08:46:52 +02:00
Alexey Milovidov
ef9633499c
Merge branch 'master' into fix-trash-s3-metrics
2022-05-02 03:55:10 +02:00
Mikhail Artemenko
cf48390cb9
Merge branch 'master' into MeiliSearch
2022-05-02 00:28:42 +03:00
KinderRiven
7d0789472c
fix
2022-05-01 19:45:16 +08:00
KinderRiven
e1acacf831
fix
2022-05-01 19:45:16 +08:00
KinderRiven
d80aa0fd17
impl system.filesystem_cache_log
2022-05-01 19:45:16 +08:00
KinderRiven
d595df1604
fix
2022-05-01 19:45:16 +08:00
KinderRiven
6a2e4559c8
impl system.cache_log
2022-05-01 19:45:16 +08:00
KinderRiven
ce9a6965d0
impl system.log_table
2022-05-01 19:45:16 +08:00
KinderRiven
a4b8f9e9cf
impl system.cache_log
2022-05-01 19:45:16 +08:00
KinderRiven
9c9870f021
build cache_log table
2022-05-01 19:45:16 +08:00
KinderRiven
5a361a0db5
impl cache_log in filecache
2022-05-01 19:45:16 +08:00
KinderRiven
5b7b2d26ea
fix add miss header
2022-05-01 19:45:16 +08:00
KinderRiven
df81496ba1
fix bug for cache log table
2022-05-01 19:45:16 +08:00
KinderRiven
de7e89661d
resubmit
2022-05-01 19:45:16 +08:00
Mikhail Artemenko
41f657d8ed
Merge branch 'master' into MeiliSearch
2022-05-01 10:01:56 +03:00
kssenii
8cf83a2daf
Fix
2022-04-30 22:02:44 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
...
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"
About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.
About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.
Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Kseniia Sumarokova
66f62b2ba6
Merge pull request #36632 from DevTeamBK/Fix-Coverity-Issues
...
Minor Coverity defects fixes
2022-04-30 15:11:40 +02:00
kssenii
eea0a009dc
Debug
2022-04-30 15:02:21 +02:00
mergify[bot]
cc08ccb420
Merge branch 'master' into remove-useless-code-2
2022-04-30 12:48:15 +00:00
Alexey Milovidov
1ddb04b992
Merge pull request #36715 from amosbird/refactorbase
...
Reorganize source files so that base won't depend on Common
2022-04-30 09:40:58 +03:00
HeenaBansal2009
042157efca
Clang -Tidy Fixes
2022-04-29 20:17:45 -07:00
mergify[bot]
e9fde5d067
Merge branch 'master' into memory-overcommit-free
2022-04-29 19:31:59 +00:00
Nikolai Kochetov
5807ca47b0
Merge pull request #36425 from ClickHouse/pool-size-hot-reload
...
Allow to increase number of threads and tasks for background executors
2022-04-29 17:24:12 +02:00
Kseniia Sumarokova
ca994e0861
Merge pull request #36660 from kssenii/fix-stress-test
...
Fix stress test after 36639
2022-04-29 12:56:25 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
Amos Bird
e81929a8b5
Saturate date/datetime to zero (part 2)
...
For partial hours/minutes timezones.
2022-04-29 10:24:18 +08:00
Kseniia Sumarokova
ace3fe253d
Merge pull request #36737 from KinderRiven/fix_bug_for_local_cache
...
fix bug for local cache
2022-04-29 02:54:33 +02:00
mergify[bot]
41aa85fd4c
Merge branch 'master' into fix-stress-test
2022-04-29 00:54:09 +00:00
kssenii
1cbf672237
Another fix
2022-04-28 22:51:57 +02:00
Alexey Milovidov
d8fa806fca
Merge pull request #36360 from ClickHouse/optimize-asynchronous-metric-log
...
Optimize `system.asynchronous_metric_log`
2022-04-28 20:16:17 +03:00
Dmitry Novik
8fb7e2dbab
Cleanup
2022-04-28 15:31:13 +00:00
HeenaBansal2009
3ac9434c57
Merge branch 'master' into Fix-Coverity-Issues
2022-04-28 08:14:50 -07:00
kssenii
9b38c9f7eb
Fix
2022-04-28 13:06:43 +02:00
Kseniia Sumarokova
0c2f074c60
Update FileCache.cpp
2022-04-28 12:47:02 +02:00
Kseniia Sumarokova
2039e0e974
Update FileCache.h
2022-04-28 12:46:45 +02:00
KinderRiven
63804fd425
fix
2022-04-28 18:45:01 +08:00
KinderRiven
1fbaddf559
fix bug for local_cache
2022-04-28 17:11:25 +08:00
Vitaly Baranov
641a5f5e35
Merge pull request #36198 from vitlibar/backup-improvements-3
...
Backup for replicated tables and other improvements
2022-04-28 09:23:53 +02:00
Alexey Milovidov
de3a47c67a
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-28 05:03:57 +02:00
kssenii
37d11cfb1c
Merge master
2022-04-28 00:44:15 +02:00
mergify[bot]
b7e63154df
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-27 18:27:27 +00:00
kssenii
da1392877a
Better
2022-04-27 20:01:59 +02:00
mergify[bot]
9410e2813f
Merge branch 'master' into fix-stress-test
2022-04-27 14:51:55 +00:00
HeenaBansal2009
4961caec13
Merge branch 'master' into Fix-Coverity-Issues
2022-04-26 11:43:44 -07:00
kssenii
64168faf0a
Fix
2022-04-26 20:31:42 +02:00
HeenaBansal2009
a34fca27d5
Incorporated review comments
2022-04-26 11:12:14 -07:00
HeenaBansal2009
13a9a8fd5e
Style check fix
2022-04-26 07:13:09 -07:00
HeenaBansal2009
267f426605
Minor Coverity defetcs fixes
2022-04-26 07:13:09 -07:00
kssenii
0c43b7b08a
Merge master
2022-04-26 16:10:47 +02:00
kssenii
8d3dfc62ae
Revert
2022-04-26 12:57:58 +02:00
kssenii
8d741f173a
Save changes
2022-04-26 12:57:06 +02:00
kssenii
a395532d54
Add support for exact right bounded reads for some other buffers
2022-04-26 12:56:40 +02:00
mergify[bot]
7571387a6e
Merge branch 'master' into memory-overcommit-free
2022-04-26 10:15:18 +00:00
kssenii
b874750807
Better
2022-04-26 12:13:21 +02:00
kssenii
41bba15e20
Fix
2022-04-26 12:09:58 +02:00
Vladimir C
1aa9d77246
Merge pull request #36453 from zombee0/master
2022-04-26 11:47:42 +02:00
Kseniia Sumarokova
81db081b88
Merge pull request #36639 from kssenii/better-drop-cache
...
Improve drop cache query
2022-04-26 11:25:46 +02:00
Vitaly Baranov
1c0b731ea6
Fix compilation.
2022-04-26 10:13:08 +02:00
mergify[bot]
4e82b56a8d
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-26 05:40:49 +00:00
Alexey Milovidov
86bf67c93c
Merge pull request #36526 from Joeywzr/to_start_of_five_minutes
...
Replace toStartOfFiveMinute to toStartOfFiveMinutes
2022-04-26 05:52:02 +03:00
alesapin
92296484e7
Merge pull request #36348 from rschu1ze/erase_if3
...
Replace remove-erase idiom by C++20 erase()/erase_if()
2022-04-25 23:34:18 +02:00
alesapin
7a901c0826
Merge pull request #36602 from azat/netlink-strict-resubmit
...
Strict taskstats parser (resubmit)
2022-04-25 23:28:08 +02:00
alesapin
04afe552f8
Trying to avoid segfaults
2022-04-25 22:51:09 +02:00
kssenii
35b8d302da
Fix
2022-04-25 21:57:13 +02:00
alesapin
1fffa56f63
Merge branch 'master' into memory-overcommit-free
2022-04-25 20:21:08 +02:00
mergify[bot]
d2ac9b2223
Merge branch 'master' into to_start_of_five_minutes
2022-04-25 17:36:38 +00:00
mergify[bot]
e79de5a577
Merge branch 'master' into optimize-asynchronous-metric-log
2022-04-25 17:29:11 +00:00
mergify[bot]
fdc895462e
Merge branch 'master' into fix-trash-s3-metrics
2022-04-25 17:28:06 +00:00
kssenii
a76a35d3ce
Better drop cache
2022-04-25 19:20:25 +02:00
Vitaly Baranov
d20b3d78c5
Rename some restore settings.
2022-04-25 16:34:17 +02:00
Sergei Trifonov
ad9d57807f
fix typo
2022-04-25 16:06:14 +02:00
Kruglov Pavel
34c342fdd3
Merge pull request #36205 from Avogar/improve-globs
...
Some refactoring around schema inference with globs
2022-04-25 13:14:46 +02:00
Nikolai Kochetov
d5b2d28f7b
Merge pull request #36579 from amosbird/refactor-executor1
...
Small refactoring of Processors and QueryPipeline
2022-04-25 12:47:59 +02:00
Antonio Andelic
d60384d336
Merge pull request #36469 from bigo-sg/fix_ranger_generator
...
Fix bug of range generator
2022-04-25 10:52:34 +02:00
Azat Khuzhin
278101fc0c
Add a comment for taskstruct netlink interface rounding to KiB
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-25 08:49:17 +03:00
Azat Khuzhin
d161b798a8
Strict taskstats parser
...
This will unhide possible issues (since sometimes statistics is
inaccurate).
Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit bfa65b651a
)
2022-04-25 07:56:54 +03:00
Azat Khuzhin
6df54611a9
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
(cherry picked from commit 2be022cb56
)
2022-04-25 07:56:54 +03:00
mergify[bot]
705d5af3a0
Merge branch 'master' into to_start_of_five_minutes
2022-04-24 22:24:24 +00:00
Alexey Milovidov
74bb6349c2
Revert "Strict taskstats parser"
2022-04-25 01:15:08 +03:00
Amos Bird
a25bb50096
Refactor many exception messages
...
1. Always use fmt variant
2. Remove redundant period at the end of message
3. Remove useless parenthesis
2022-04-24 19:44:00 +08:00
taiyang-li
6716aa9d95
Merge remote-tracking branch 'ck/master' into fix_ranger_generator
2022-04-24 11:31:19 +08:00
Alexey Milovidov
8af3159916
Merge pull request #36351 from azat/netlink-strict
...
Strict taskstats parser
2022-04-24 05:14:06 +03:00
Alexey Milovidov
d08da0f63c
Everything related to S3 metrics was a trash
2022-04-24 03:46:35 +02:00
Alexey Milovidov
6de4f2bbff
Everything related to S3 metrics was a trash
2022-04-24 03:42:18 +02:00
zombee0
c02de61086
fixed the cow_compositions.cpp clone inner column when there is no need
...
Signed-off-by: zombee0 <flylucas_10@163.com>
2022-04-23 18:42:04 +08:00
alesapin
7380a71333
Merge pull request #31833 from ClickHouse/musl-check
...
Build clickhouse-keeper with Musl
2022-04-22 22:41:16 +02:00
Nikita Mikhaylov
36bdee0499
Deleted settings
2022-04-22 13:56:16 +00:00
Alexander Tokmakov
b16faab477
fix configs
2022-04-22 15:37:14 +02:00
Kseniia Sumarokova
33bb48106f
Merge pull request #36314 from CurtizJ/print-bad-filenames
...
Show names of erroneous files in case of parsing errors while executing table functions
2022-04-22 13:24:55 +02:00
taiyang-li
3751c69aaa
fix code style
2022-04-22 15:38:19 +08:00
taiyang-li
6bcf24ae36
add test for range generator
2022-04-22 12:33:16 +08:00
Memo
956d525840
fix conflict
2022-04-22 11:22:50 +08:00
Memo
39aadf0975
replaced toStartOfFiveMinute to toStartOfFiveMinutes
2022-04-22 10:49:59 +08:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes
...
Clang tidy fixes
2022-04-21 16:11:27 +02:00
kssenii
1b008b0014
Fix test
2022-04-21 14:48:07 +02:00
mergify[bot]
1ba1cad5cf
Merge branch 'master' into improve-globs
2022-04-21 11:52:13 +00:00
kssenii
24e376337d
Merge with master
2022-04-21 12:33:56 +02:00
taiyang-li
adb1288e10
fix bug of range generator
2022-04-21 11:33:15 +08:00
Azat Khuzhin
2be022cb56
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
2022-04-20 21:39:26 +03:00
Azat Khuzhin
bfa65b651a
Strict taskstats parser
...
This will unhide possible issues (since sometimes statistics is
inaccurate).
Also before this patch TASKSTATS_TYPE_AGGR_TGID had been handled, while
it not correct to take into account, but it was not requested anyway.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-20 21:39:25 +03:00
Alexander Tokmakov
09daa23bd7
fix
2022-04-20 18:15:21 +02:00
Kruglov Pavel
813e228fcc
Merge branch 'master' into improve-globs
2022-04-20 16:31:47 +02:00
Anton Popov
d4df38a0e6
fix tests
2022-04-20 14:13:04 +00:00
KinderRiven
137a1a3392
fix bug for local cache
2022-04-20 20:22:33 +08:00
KinderRiven
59d56b6391
resubmit
2022-04-20 20:10:31 +08:00
KinderRiven
910c4a6660
fix bug for local cache
2022-04-20 19:49:04 +08:00
KinderRiven
b91f18033c
fix bug for local cache
2022-04-20 19:43:07 +08:00
Alexander Tokmakov
1d30a97fd2
Merge branch 'master' into remove-useless-code-2
2022-04-20 11:45:56 +02:00
mergify[bot]
0df5fda6ed
Merge branch 'master' into musl-check
2022-04-20 09:28:40 +00:00
tavplubix
2c54381520
Merge pull request #36200 from ClickHouse/fix_create_as_replicated_default_args
...
Fix CREATE AS for ReplicatedMergeTree with default arguments
2022-04-20 12:01:13 +03:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
...
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Robert Schulze
b6d7367538
Merge remote-tracking branch 'origin/master' into erase_if3
...
Conflicts:
- Interpreters/ActionsDAG.cpp
2022-04-20 10:02:59 +02:00
Anton Popov
bee4ca9b62
add more tests for error diagnostics in files
2022-04-19 15:56:34 +00:00
Alexey Milovidov
93229133e2
Return two changes
2022-04-19 17:44:27 +02:00
Alexey Milovidov
79be0aa75b
Remove Arcadia
2022-04-19 17:44:27 +02:00
Alexey Milovidov
3c1e05eb53
Remove Arcadia
2022-04-19 17:44:27 +02:00
Alexey Milovidov
7629016f66
Fix clang-tidy-14 (part 1)
2022-04-19 17:44:27 +02:00
Alexey Milovidov
b6c06268eb
Simplification #36313
2022-04-19 17:44:27 +02:00
Alexey Milovidov
767b2eecff
Remove trash
2022-04-19 17:44:27 +02:00
Alexey Milovidov
fb9545e0b4
Remove trash
2022-04-19 17:44:27 +02:00
Alexey Milovidov
611ea86d60
Remove abbreviation
2022-04-19 17:44:26 +02:00
Alexey Milovidov
c46715db82
Remove abbreviation
2022-04-19 17:44:26 +02:00
Anton Popov
3e361c9759
Merge remote-tracking branch 'upstream/master' into HEAD
2022-04-19 14:18:04 +00:00
kssenii
7cfc0ac433
Merge with master
2022-04-19 15:13:45 +02:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
...
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Alexey Milovidov
f6ab2bd523
Merge pull request #36312 from ClickHouse/remove-arcadia
...
Remove remaining parts of Arcadia
2022-04-18 07:02:54 +03:00
Alexey Milovidov
36595e4206
Merge pull request #36320 from ClickHouse/fix-clang-tidy-14
...
Fix clang-tidy-14 (part 1)
2022-04-18 07:02:10 +03:00
Alexey Milovidov
48fd09c7db
Merge pull request #36310 from ClickHouse/cpuid-remove-trash
...
Remove trash from CPUID
2022-04-18 07:01:23 +03:00
Alexey Milovidov
543e5d7242
Merge branch 'master' into musl-check
2022-04-18 02:40:13 +02:00
Alexey Milovidov
c7bca13a03
Remove abbreviation
2022-04-18 01:03:58 +02:00
Alexey Milovidov
242919eddd
Remove abbreviation
2022-04-18 01:02:49 +02:00
Alexey Milovidov
a64765bc6f
Allow custom default ORDER BY for system logs
2022-04-17 21:56:36 +02:00
Alexey Milovidov
27afc08d8f
Merge branch 'master' into cpuid-remove-trash
2022-04-17 16:30:30 +02:00
Alexey Milovidov
7de4f2b6c1
Merge branch 'master' into remove-arcadia
2022-04-17 16:30:09 +02:00
Robert Schulze
1e1df8e101
Replace remove-erase idiom by C++20 erase()/erase_if()
...
- makes the code less verbose while being as efficient
2022-04-17 12:04:47 +02:00
Alexey Milovidov
294efeccfe
Fix clang-tidy-14 (part 1)
2022-04-16 04:54:04 +02:00
Alexey Milovidov
33ffdcaa4f
Return two changes
2022-04-16 02:18:22 +02:00
Anton Popov
2de6668b3f
show names of erroneous files
2022-04-16 00:10:47 +00:00
Alexey Milovidov
69b91c5410
Simplification #36313
2022-04-16 02:08:06 +02:00
Alexey Milovidov
40357637ec
Remove Arcadia
2022-04-16 00:33:32 +02:00
Alexey Milovidov
cbeeb7ec4f
Remove Arcadia
2022-04-16 00:20:47 +02:00
Alexey Milovidov
364f10aff5
Remove trash
2022-04-15 22:56:51 +02:00
Alexey Milovidov
58fc4e033a
Remove trash
2022-04-15 22:54:08 +02:00
alesapin
40e5ba21a4
Update src/Common/FileSegment.cpp
2022-04-15 11:55:05 +02:00
Alexander Tokmakov
4ce0b280e6
wait for node to disappear instead of removing
2022-04-14 15:31:05 +02:00
kssenii
3e42a1711d
Fix
2022-04-14 13:50:13 +02:00
Kseniia Sumarokova
4d667301cc
Merge pull request #36135 from kssenii/cache-fix
...
Fix after #35475
2022-04-14 11:11:13 +02:00