Commit Graph

53473 Commits

Author SHA1 Message Date
Alexey Milovidov
47d8248b9d
Merge pull request #60005 from ClickHouse/non-significant-changes-3
Fix obviously wrong (but non significant) error in dictionaries
2024-02-15 05:59:07 +01:00
Alexey Milovidov
009d08561d
Merge pull request #59946 from kitaisreal/replicated-merge-tree-alter-update-metadata-version-in-single-transaction
ReplicatedMergeTree invalid metadata_version fix
2024-02-15 04:38:06 +01:00
Alexey Milovidov
0b58f16938
Merge pull request #59964 from ClickHouse/cleanups
Cleanups
2024-02-15 02:59:54 +01:00
Alexey Milovidov
5e5528a890
Merge pull request #59972 from jrdi/fix-max-num-to-warn
Fix max num to warn message
2024-02-15 02:59:29 +01:00
Alexey Milovidov
b73c9ce9f5
Merge pull request #59981 from ClickHouse/analyzer-fix-test_storage_rabbitmq
Analyzer: Fix test_storage_rabbitmq
2024-02-15 02:58:09 +01:00
Alexey Milovidov
feb8020448
Merge pull request #59983 from ClickHouse/analyzer-fix-test_shard_level_const_function
Analyzer: Fix test_shard_level_const_function
2024-02-15 02:57:39 +01:00
Alexey Milovidov
681351fe1e
Merge pull request #59987 from nickitat/fix_data_race_storage_distributed
Fix data race in `StorageDistributed`
2024-02-15 02:55:08 +01:00
Alexey Milovidov
46fb01c4f6 Fix trash 2024-02-15 02:31:46 +01:00
Alexey Milovidov
bbd7acd7f9
Merge branch 'master' into exponent-floats-inference 2024-02-15 01:46:51 +01:00
Alexey Milovidov
2688a6268c Fix obviously wrong (but non significant) error in dictionaries 2024-02-15 01:42:14 +01:00
Vitaly Baranov
5591d74076 Add new config setting "backups.remove_backup_files_after_failure". 2024-02-14 23:19:21 +01:00
Alexey Milovidov
7a5e152d9e
Merge pull request #59967 from ClickHouse/dashboards-to-use-merge-tables
Use merge table in the dashboard; add Cloud overview to the system table
2024-02-14 21:56:37 +01:00
Julia Kartseva
b1b58ef9a3
Revert "Insert synchronously if dependent MV deduplication is enabled" 2024-02-14 12:54:42 -08:00
Vitaly Baranov
d842c497e6 Change code to pass test 02963_remote_read_small_buffer_size_bug. 2024-02-14 20:47:34 +01:00
Nikolai Kochetov
ab8738ffe5
Merge pull request #59985 from ClickHouse/remove-context-from-comparison-functions
Remove context from comparison functions.
2024-02-14 19:32:28 +01:00
Nikolai Kochetov
9c626f9c36
Merge pull request #59899 from ClickHouse/refactor-squashing-for-inserts
Refactor Squashing for inserts.
2024-02-14 19:29:11 +01:00
Nikolai Kochetov
5833f30deb
Merge pull request #59984 from ClickHouse/update-settings-change-history
Add newlines to SettingsChangesHistory to maybe have less conflicts
2024-02-14 17:45:19 +01:00
Nikolai Kochetov
70d456dc28
Update greater.cpp 2024-02-14 17:44:06 +01:00
Nikolai Kochetov
078ec9a97f
Update notEquals.cpp 2024-02-14 17:43:49 +01:00
Dmitry Novik
433d835df6
Merge pull request #59920 from azat/http-retries-logs
Decrease logging level for http retriable errors to Warning (and fix 00157_cache_dictionary flakiness)
2024-02-14 17:11:28 +01:00
Nikita Taranov
5f87956fc8 impl 2024-02-14 16:22:14 +01:00
Maksim Kita
d4778d858d Fixed tests 2024-02-14 18:05:29 +03:00
Maksim Kita
0cce386207 Added documentation 2024-02-14 18:05:29 +03:00
Maksim Kita
f6d211b44d StorageSystemTables add metadata_version 2024-02-14 18:05:29 +03:00
Maksim Kita
be490291af Updated implementation 2024-02-14 18:05:06 +03:00
Maksim Kita
dca627026c ReplicatedMergeTree ALTER update metadata_version in single transaction 2024-02-14 18:05:06 +03:00
Raúl Marín
11519f949b
Merge pull request #59731 from kitaisreal/asof-join-try-sort-with-radix-sort
ASOF JOIN use trySort with RadixSort
2024-02-14 15:54:22 +01:00
kssenii
8fe9ede207 Add a test 2024-02-14 15:25:43 +01:00
yariks5s
c1897e74a8 fix 2024-02-14 14:04:25 +00:00
Nikolai Kochetov
c54a1d1d97 Add newlines to SettingsChangesHistory to maybe have less conflicts 2024-02-14 13:54:26 +00:00
Antonio Andelic
40d4fc1c24 More resilient Disk related operations 2024-02-14 14:53:22 +01:00
Dmitry Novik
e95726f57c Analyzer: Fix test_shard_level_const_function 2024-02-14 13:21:23 +00:00
Igor Nikonov
d5ab7d8df0 Keep header the same as before 2024-02-14 13:19:34 +00:00
Igor Nikonov
eafa4219d9 Remove unnecessary include 2024-02-14 13:17:55 +00:00
Antonio Andelic
0bee591a0c Fix build 2024-02-14 14:10:58 +01:00
Yarik Briukhovetskyi
41304c3e11
Update src/Functions/FunctionBinaryArithmetic.h
Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com>
2024-02-14 14:08:20 +01:00
Igor Nikonov
fd5b572225 Fix 2024-02-14 13:00:22 +00:00
Vitaly Baranov
8919e3b011 Add test. 2024-02-14 13:41:23 +01:00
Vitaly Baranov
eb3836ac5a Fix error "Read beyond last offset" for AsynchronousBoundedReadBuffer. 2024-02-14 13:41:18 +01:00
Nikolai Kochetov
32a23244c9 Remove context from comparison functions.
(cherry picked from commit 57608cc6f9)
2024-02-14 12:38:13 +00:00
Nikolai Kochetov
ebf47dd7c2
Merge pull request #58916 from ClickHouse/allow-parallel-replicas-for-join-with-analyzer-2
Allow parallel replicas for JOIN with analyzer [part 2]
2024-02-14 13:30:35 +01:00
Kruglov Pavel
c8c9adbd8b
Merge pull request #59088 from Blargian/#31363_format_template_configure_in_settings
#31363 format template configure in settings
2024-02-14 13:29:13 +01:00
Nikolai Kochetov
3d86e87f7f Fixing tests. 2024-02-14 12:28:54 +00:00
Dmitry Novik
12963ce53e Analyzer: Fix test_storage_rabbitmq 2024-02-14 12:20:37 +00:00
avogar
2c34a98426 Apply suggestions from the review 2024-02-14 12:20:09 +00:00
Yarik Briukhovetskyi
941e179be2
Merge branch 'ClickHouse:master' into div_int_with_decimal 2024-02-14 13:16:13 +01:00
Nikolai Kochetov
03720d558e
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-14 12:54:29 +01:00
Konstantin Bogdanov
83f28b8537
Move definition to cpp 2024-02-14 12:51:14 +01:00
Kruglov Pavel
db2c15c0a6
Apply suggestions from code review
Co-authored-by: Sergei Trifonov <svtrifonov@gmail.com>
2024-02-14 12:24:10 +01:00
Kruglov Pavel
0263826c15
Merge pull request #59925 from Avogar/fix-json-http-crash
Fix crash in JSONColumnsWithMetadata format over http
2024-02-14 11:58:18 +01:00
Konstantin Bogdanov
e6450f8af2
More missing headers 2024-02-14 11:48:03 +01:00
Alexander Gololobov
dda7c5d2b7 Add comment with motivation 2024-02-14 11:41:07 +01:00
李扬
90d07ba82c
Trivial optimize of function coalesce. (#59627)
* reuse result of functionfactory::get

* add perf test

* Update src/Functions/coalesce.cpp

Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>

* change as requested

---------

Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
2024-02-14 11:29:45 +01:00
Konstantin Bogdanov
5f2358b014
Add missing header 2024-02-14 11:22:47 +01:00
Konstantin Bogdanov
f678bdc546
Update tests 2024-02-14 10:51:42 +01:00
Konstantin Bogdanov
914fd27d5b
Add PlacementInfo 2024-02-14 10:19:36 +01:00
Jordi Villar
83a184d928 Fix max num to warn message 2024-02-14 10:11:21 +01:00
Robert Schulze
25667d9c9a
Attempt II at fixing the Fuzzer issue 2024-02-14 08:49:14 +00:00
Alexey Milovidov
653c6ba49f
Merge pull request #59931 from pamarcos/patch-1
Fix description for allow_prefetched_read_pool_for_local_filesystem
2024-02-14 07:47:47 +01:00
Alexey Milovidov
a76d4bbb56
Merge pull request #59968 from ClickHouse/less-conflicts
Less conflicts
2024-02-14 07:45:51 +01:00
Alexey Milovidov
9823966e13
Merge pull request #59845 from vitlibar/add-check-for-recursive-remove-low-cardinality
Add check for recursiveRemoveLowCardinality()
2024-02-14 05:57:37 +01:00
Alexey Milovidov
af2dfe0e35
Merge pull request #59537 from nickitat/fix_aggr
Fix data race with `AggregatedDataVariants`
2024-02-14 05:46:30 +01:00
Alexey Milovidov
40ac23e958 Even less conflicts 2024-02-14 04:12:50 +01:00
Alexey Milovidov
0ccad74810 Even less conflicts 2024-02-14 03:44:52 +01:00
Alexey Milovidov
98f7602ea1 Less conflicts 2024-02-14 03:01:03 +01:00
Alexey Milovidov
7b3e57e2d2 Use merge table in the dashboard 2024-02-14 02:37:42 +01:00
Alexey Milovidov
b713a8dffe
Merge pull request #59960 from jsc0218/Better_name_extract_key_value_pairs_max_pairs_per_row
rename a setting v2
2024-02-14 02:21:45 +01:00
Alexey Milovidov
102e64cf1d Merge branch 'master' of github.com:ClickHouse/ClickHouse into dashboards-to-use-merge-tables 2024-02-14 02:20:20 +01:00
Alexey Milovidov
27f115f581 Use merge table in the dashboard 2024-02-14 02:17:23 +01:00
Alexey Milovidov
7ee6b0bd87
Merge pull request #59941 from kitaisreal/register-storage-merge-tree-exception-message-fix
Register StorageMergeTree exception message fix
2024-02-14 01:31:00 +01:00
Alexey Milovidov
2b4949bd18 Cleanups 2024-02-14 00:21:13 +01:00
yariks5s
ac601a0cb9 fix build 2024-02-13 23:12:21 +00:00
Alexey Milovidov
8b59977639
Merge pull request #59909 from azat/rmt-macros-cleanup
Petite cleanup around macros and ReplicatedMergeTree
2024-02-14 00:09:34 +01:00
Alexey Milovidov
b9d3ae3b0a
Merge pull request #58195 from Unalian/feat-58127
Add InitialQuery event
2024-02-13 23:51:03 +01:00
Igor Nikonov
3d91b12a2f Fix typo 2024-02-13 22:34:10 +00:00
Igor Nikonov
e9dcc751ac Merge remote-tracking branch 'origin/master' into query-log-on-insert-exception-over-http 2024-02-13 22:08:44 +00:00
Igor Nikonov
a27639a7f9 Fix: call first exception callback on exception
it'll update query_log
2024-02-13 22:06:00 +00:00
jsc0218
84e8755aae rename a setting 2024-02-13 19:27:29 +00:00
Nikolai Kochetov
68f72de6f0
Merge pull request #59928 from kitaisreal/uniq-exact-set-read-crash-fix
UniqExactSet read crash fix
2024-02-13 19:45:52 +01:00
yariks5s
4125070791 Merge branch 'div_int_with_decimal' of https://github.com/yariks5s/ClickHouse into div_int_with_decimal 2024-02-13 18:38:36 +00:00
yariks5s
ed5591e68c changes due to review 2024-02-13 18:20:57 +00:00
Kruglov Pavel
1dbfeafb42
Merge branch 'master' into auto-format-detection 2024-02-13 19:08:33 +01:00
Kruglov Pavel
61983a7ec8
Merge branch 'master' into exponent-floats-inference 2024-02-13 19:04:07 +01:00
Nikolai Kochetov
d697c12a44 Fixing build. 2024-02-13 17:57:35 +00:00
Nikolai Kochetov
72bcadb7d5 Trying to fix settings change 2024-02-13 17:37:25 +00:00
Kruglov Pavel
48a3b8e675
Merge pull request #58292 from ucasfl/negtive-position
Resubmit: Support negtive position arguments
2024-02-13 18:35:28 +01:00
Nikolai Kochetov
c2ad7693db Review fixes. 2024-02-13 17:32:24 +00:00
Kruglov Pavel
42628fdd38
Merge branch 'master' into #31363_format_template_configure_in_settings 2024-02-13 17:24:54 +01:00
Kruglov Pavel
39f091bffb
Merge pull request #59487 from azat/dist/fix-uncaught-exception
Fix possible uncaught exception during distributed query cancellation
2024-02-13 17:22:09 +01:00
Nikolai Kochetov
476bec4baf Fixing tests. 2024-02-13 16:16:53 +00:00
Nikolai Kochetov
134837d6fb Fixing tests. 2024-02-13 16:16:53 +00:00
Nikolai Kochetov
431aee4de3 Rename back. 2024-02-13 16:16:53 +00:00
Nikolai Kochetov
253abd1643 Refactor Squashing for inserts. 2024-02-13 16:16:53 +00:00
Antonio Andelic
0d151e3f0d Send only specific events/metrics for Keeper prometheus 2024-02-13 16:01:50 +01:00
Alexander Gololobov
037bc043e6 Removed lambdas 2024-02-13 16:01:17 +01:00
Maksim Kita
4dc6ed3a39 Register StorageMergeTree exception message fix 2024-02-13 17:53:35 +03:00
Smita Kulkarni
8f71d7817c Fix clang build 2024-02-13 14:57:45 +01:00
Smita Kulkarni
d7056d642d Addressed review comments 2024-02-13 13:53:40 +01:00
Maksim Kita
4577975923 Fixed code review issues 2024-02-13 15:41:17 +03:00
Maksim Kita
bfa7938df9 Fixed tests 2024-02-13 15:41:17 +03:00
Maksim Kita
a359ceecb5 ASOF JOIN use trySort with RadixSort 2024-02-13 15:41:17 +03:00
Smita Kulkarni
3526d7982c Merge branch 'master' into Support_parameterized_view_with_analyzer 2024-02-13 13:08:35 +01:00
Pablo Marcos
a4562ea013
Fix description for allow_prefetched_read_pool_for_local_filesystem
allow_prefetched_read_pool_for_local_filesystem wrongly used the same description as allow_prefetched_read_pool_for_remote_filesystem
2024-02-13 12:56:32 +01:00
alesapin
f48c5973cc
Merge pull request #59901 from ClickHouse/fix-partition-expression-parsing-with-parens
Fix parsing of partition expressions surrounded by parens
2024-02-13 12:52:24 +01:00
Maksim Kita
ddf0f22819 UniqExactSet read crash fix 2024-02-13 14:36:46 +03:00
Kseniia Sumarokova
bb12fb45c4
Merge pull request #59873 from azat/file-log-shutdown-fix
Fix long shutdown of FileLog storage
2024-02-13 12:08:12 +01:00
Nikita Mikhaylov
4b85f6b39a
Revert "Less error prone interface of read buffers" (#59911) 2024-02-13 12:02:46 +01:00
Nikolai Kochetov
666b3d6664
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-13 11:11:03 +01:00
avogar
743f2410c1 Fix crash in JSONColumnsWithMetadata format over http 2024-02-13 09:54:36 +00:00
Azat Khuzhin
7c01705231 Run ValidationChecker for sanitizers build as well
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 10:50:45 +01:00
Azat Khuzhin
4228eaf44a Decrease logging level for http retriable errors to Warning
Messages like this:

    2024-02-12 21:25:24 [5c66f008cd40] 2024.02.12 14:25:01.596769 [ 2530 ] {e71fcb6d-356d-4962-95bd-ef8b8c504e11} <Error> ReadWriteBufferFromHTTP: HTTP request to `https://clickhouse-datasets-web.s3.us-east-1.amazonaws.com/store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin` failed at try 1/10 with bytes read: 311149/378695. Error: DB::HTTPException: Received error from remote server /store/78e/78ebf6a1-d987-4579-b3ec-00c1a087b1f3/201403_1_1_2/UserAgent.bin. HTTP status code: 500 Internal Server Error, body: <?xml version="1.0" encoding="UTF-8"?>

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:31:28 +01:00
Azat Khuzhin
58e5d7876b Allow uuid in replica_path if CREATE TABLE explicitly has it
Right now the query with {uuid} macro without ON CLUSTER fails:

    CREATE TABLE x UUID 'aaaaaaaa-1111-2222-3333-aaaaaaaaaaaa' (key Int) ENGINE = ReplicatedMergeTree('/tables/{database}/{uuid}', 'r1') ORDER BY tuple();

There is a workaround right now to use ATTACH instead of CREATE, but
ATTACH is not CREATE.

CREATE still useful for proper RESTORE without ON CLUSTER.

So this patch allows this syntax, but only if UUID had been explicitly
passed in the query. This looks safe.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:01:09 +01:00
Alexey Milovidov
4dc59051a1
Merge pull request #59897 from ClickHouse/s3queue-fix-uninitialized-value
s3queue: fix uninitialized value
2024-02-13 02:44:45 +01:00
Igor Nikonov
d1167d0b04 Fix: corrupted source + fail point 2024-02-12 20:56:13 +00:00
Igor Nikonov
eb44faf867 Test to reproduce absence of closing record in query_log 2024-02-12 20:41:46 +00:00
Azat Khuzhin
c61ac1d3bc Convert default_replica_path/default_replica_name into server settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
Azat Khuzhin
5868cdc708 Remove one unused implementation of Macros::expand()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
Nikolai Kochetov
105308ee54
Merge pull request #59889 from ClickHouse/follow-up-58554
Follow up for #58554. Cleanup.
2024-02-12 20:46:36 +01:00
kssenii
d008ee725f Add a test 2024-02-12 20:23:21 +01:00
János Benjamin Antal
310b0773b2 Fix include used for debugging 2024-02-12 17:25:17 +00:00
János Benjamin Antal
69273b4645 Fix parsing of partition expressions surrounded by parens 2024-02-12 17:10:10 +00:00
kssenii
0628ae6268 S3 queue fix uninitialized value 2024-02-12 17:13:30 +01:00
Azat Khuzhin
c7c05c9881 Do not pull mutations if pulling replication log had been stopped
Right now, mutations can be pulled even after:

    SYSTEM STOP PULLING REPLICATION LOG

Since they pulled from two places:
- StorageReplicatedMergeTree::mutationsUpdatingTask()
- ReplicatedMergeTreeQueue::pullLogsToQueue()

And only the last one checks action blocker.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 16:28:08 +01:00
Raúl Marín
407b7a4651
Merge pull request #59737 from Algunenano/more_asserts_memory
Add assertions around FixedString code
2024-02-12 16:01:02 +01:00
Antonio Andelic
5872ca520c
Merge pull request #59592 from ClickHouse/keeper-more-reduce
Reduce size of node in Keeper even more
2024-02-12 15:59:39 +01:00
Dmitry Novik
00136b8f65
Merge pull request #59121 from ClickHouse/analyzer-fix-const-fold
Analyzer: Add cast for ConstantNode from constant folding
2024-02-12 15:01:15 +01:00
Nikolai Kochetov
87b6d65b9b Remove outdated comment. 2024-02-12 13:46:30 +00:00
Nikolai Kochetov
fd2ee19f65 Follow up for #58554. Cleanup. 2024-02-12 13:37:25 +00:00
Nikolai Kochetov
09d3b3c0d0
Merge pull request #58554 from ClickHouse/try-to-always-push-down-prewhere-from-query-plan
Simplify optimize-push-to-prewhere from query plan
2024-02-12 12:52:39 +01:00
Azat Khuzhin
67b73c3e49 Fix long shutdown of FileLog storage
Previously it was possible to wait up to
poll_directory_watch_events_backoff_max (default is 32000) on shutdown,
because it was not possible to stop poll of inotify.

Before (takes 3 seconds):

    2024.02.12 11:27:55.058192 [ 10134 ] {} <Trace> StorageFileLog (file_log): Waiting for cleanup
    2024.02.12 11:27:58.178021 [ 10271 ] {} <Trace> directory_watch: Execution took 7519 ms.

After:

    2024.02.12 11:33:29.722403 [ 15866 ] {} <Trace> StorageFileLog (file_log): Waiting for cleanup
    2024.02.12 11:33:29.722473 [ 15956 ] {} <Trace> directory_watch: Execution took 6399 ms.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:52:09 +01:00
Igor Nikonov
0c35492ed3
Merge pull request #59858 from ClickHouse/std-exception-during-exception-handling
Fix: check if std::function is set before calling it
2024-02-12 11:36:14 +01:00
Antonio Andelic
a0507c2044 Whitespace 2024-02-12 10:36:35 +01:00
Alexander Gololobov
67bb3994ce
Merge pull request #59854 from ClickHouse/system_zk_init
Do not reinitialize ZooKeeperWithFaultInjection on each chunk
2024-02-12 10:14:54 +01:00
Antonio Andelic
36b966967b Merge branch 'master' into keeper-more-reduce 2024-02-12 10:03:07 +01:00
Antonio Andelic
c9c0e12b4c Address PR reviews 2024-02-12 09:15:40 +01:00
Alexey Milovidov
61a5696ce9
Merge pull request #59735 from ClickHouse/tavplubix-patch-13
Make ZooKeeper actually sequentialy consistent
2024-02-12 04:41:35 +01:00
Igor Nikonov
cb812d84cf Fix: check if std::function is set before calling it 2024-02-11 22:31:33 +00:00
Robert Schulze
06dc9ed074
Merge remote-tracking branch 'ClickHouse/master' into materialize_non_override_past_values 2024-02-11 15:48:55 +00:00
Alexander Gololobov
309db427e7 Do not reinitialize ZooKeeperWithFaultInjection on each chunk 2024-02-11 13:13:49 +01:00
Robert Schulze
b1099e181d
Add check for NULL pattern argument 2024-02-11 11:38:33 +00:00
Michael Kolupaev
5424f235a9 Fix StorageURL doing some of the query execution in one thread instead of max_threads 2024-02-11 02:44:18 +00:00
Vitaly Baranov
40ea04faf5 Add check that recursiveRemoveLowCardinality() doesn't change the size of a column. 2024-02-10 21:07:31 +01:00
Nikolai Kochetov
306f504781 Fixing test. 2024-02-10 19:53:03 +00:00
Alexey Milovidov
61227acdc4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-10 19:30:22 +01:00
Nikolai Kochetov
8b25d868e2
Update optimizePrewhere.cpp 2024-02-10 17:04:27 +01:00
Robert Schulze
a6337fb6b0
Incorporate review feedback 2024-02-10 13:42:14 +00:00
Robert Schulze
4e2d0e8bf6
Merge remote-tracking branch 'rschu1ze/master' into countMatches-fuzzed 2024-02-10 13:22:30 +00:00
Nikolai Kochetov
cd4e304db0
Merge pull request #59564 from kitaisreal/revert-59509-revert-59375-poco-logger-small-refactoring
Revert "Revert "Poco Logger small refactoring""
2024-02-10 12:53:29 +01:00
Nikolai Kochetov
bcae537810 Remove commented code. 2024-02-10 11:50:06 +00:00
Nikolai Kochetov
43d8a879fe Fixing tests. 2024-02-10 11:38:21 +00:00
SmitaRKulkarni
f2f4422783
Merge pull request #59819 from ClickHouse/Fix_settings_azure
Fix settings history azure_max_single_part_copy_size
2024-02-10 07:58:26 +01:00
Alexey Milovidov
c36397100b
Merge pull request #59662 from Algunenano/shard_query_start_time
Fix query start time on non initial queries
2024-02-10 03:09:06 +01:00
robot-clickhouse
e86f1f45d7
Merge pull request #59787 from ClickHouse/hide
Hide URL/S3 'headers' argument in SHOW CREATE
2024-02-09 23:03:00 +01:00
Alexey Milovidov
a7c30098b6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-09 22:52:49 +01:00
Nikolai Kochetov
769078e2d8 Another attempt. 2024-02-09 19:32:53 +00:00
Anton Popov
b4449535c2
Merge pull request #59733 from CurtizJ/check-minmax-index-types
Validate types of arguments for `minmax` skipping index
2024-02-09 19:39:59 +01:00
Maksim Kita
9c3b363c81 Fixed tests 2024-02-09 21:39:36 +03:00
Maksim Kita
2fc8895ae8 Fixed tests 2024-02-09 21:39:36 +03:00
Maksim Kita
dc52def9eb Revert "Revert "Poco Logger small refactoring"" 2024-02-09 21:39:35 +03:00
Nikita Mikhaylov
69e118e587
Fix potential endless loop during merge (#59812) 2024-02-09 19:34:21 +01:00
Nikolai Kochetov
1d0a86ccdf Try to fix tests. 2024-02-09 18:31:51 +00:00
Smita Kulkarni
a76e07207a Add new setting azure_max_single_part_copy_size to SettingsChangesHistory.h 2024-02-09 18:58:15 +01:00
Nikolai Kochetov
16f3dbea71 Update optimizePrewjere 2024-02-09 16:43:48 +00:00
Raúl Marín
ca2f514931 Fix msan unpoison 2024-02-09 17:36:44 +01:00
Nikolai Kochetov
d3cccf8561 Fixing tests. 2024-02-09 15:44:51 +00:00
Nikolai Kochetov
862c6cd79c
Merge pull request #57430 from ClickHouse/non-ready-set-ttl
Non ready set in TTL WHERE.
2024-02-09 16:31:26 +01:00
Igor Nikonov
effaaceb26
Merge pull request #59501 from ClickHouse/pr-better-replicas-failover-2
Parallel replicas: better initial replicas failover (2)
2024-02-09 15:50:56 +01:00
Nikolai Kochetov
1063d9ca50 Use opd prewhere optimizaer for old analyzer. 2024-02-09 14:47:24 +00:00
Nikolai Kochetov
3cca665f66 Attempt to fix more tests. 2024-02-09 14:06:41 +00:00
Dmitry Novik
2e6ca6200e
Merge pull request #59774 from ClickHouse/analyzer-merge-follow-up
Followup #50894
2024-02-09 15:05:19 +01:00
Nikita Mikhaylov
50828dade2
Fix stacktraces on MacOS (#59690) 2024-02-09 14:53:03 +01:00
Vitaly Baranov
09e727d48b
Merge pull request #56988 from ClickHouse/Azure_backup
Backup & Restore support for AzureBlobStorage
2024-02-09 14:45:35 +01:00
Antonio Andelic
d2eac53c86 Fix 2024-02-09 12:06:01 +01:00
Dmitry Novik
1dfecd5e6c Merge remote-tracking branch 'origin' into analyzer-fix-const-fold 2024-02-09 11:57:23 +01:00
Dmitry Novik
8655c11280
Fix typo 2024-02-09 11:45:15 +01:00
Antonio Andelic
35303603b6 Merge branch 'master' into keeper-more-reduce 2024-02-09 11:28:03 +01:00
Raúl Marín
3efbde8492 Merge remote-tracking branch 'blessed/master' into more_asserts_memory 2024-02-09 11:09:10 +01:00
Raúl Marín
1ff0a5430e Fix unpoison call 2024-02-09 11:08:54 +01:00
Antonio Andelic
42f2fefeab Fix data race and leak 2024-02-09 10:40:43 +01:00
Antonio Andelic
8c765a3713
Merge pull request #59766 from ClickHouse/logical-optimizer-lowcardinality
Fix logical optimizer with LowCardinality in new analyzer
2024-02-09 09:04:44 +01:00
Michael Kolupaev
359dda5693
Fix DB type check - now it'll refuse to create in Replicated databases (#59743)
Fix DB type check - now it'll refuse to create in Replicated databases
2024-02-08 22:38:53 -08:00
Julia Kartseva
93bcf0b09c
Merge pull request #59781 from jkartseva/adaptive-async-timeout-better-logging
Better logging for adaptive async timeouts
2024-02-08 20:32:42 -08:00
Michael Kolupaev
2dfd310cf2 Hide URL/S3 'headers' argument in SHOW CREATE 2024-02-09 03:31:30 +00:00
Julia Kartseva
2286184885
Merge pull request #59699 from jkartseva/disable_async_inserts_for_dependent_mv_dedup
Insert synchronously if dependent MV deduplication is enabled
2024-02-08 19:23:51 -08:00
Alexey Milovidov
a6fcd63159
Merge pull request #58866 from rschu1ze/distance-with-cpu-dispatch
AVX vectorization of distance functions
2024-02-09 03:32:26 +01:00
Alexey Milovidov
3e546ecdf1 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-09 02:00:33 +01:00
Alexey Milovidov
aa004cabff Fix tests 2024-02-09 02:00:05 +01:00
Alexey Milovidov
497d78703b Merge branch 'master' of github.com:ClickHouse/ClickHouse into check-stack-size-in-parser 2024-02-09 01:58:34 +01:00
Ilya Yatsishin
1c58cafcf3
Merge pull request #59741 from vitlibar/fix-skipping-unused-shards-with_analyzer
Fix skipping unused shards with analyzer
2024-02-09 02:44:59 +04:00
Julia Kartseva
e598ad9157 Better logging for adaptive async timeouts
Log the adaptive async timeout value after normalization.
2024-02-08 21:42:44 +00:00
Alexey Milovidov
91c607f249 Fix a test 2024-02-08 22:11:37 +01:00
Alexey Milovidov
cd0acc512d Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-08 22:08:15 +01:00
Raúl Marín
74dbb06d3f Merge remote-tracking branch 'blessed/master' into shard_query_start_time 2024-02-08 19:43:20 +01:00
Raúl Marín
16e2b275c2 Fix unpoison 2024-02-08 19:08:46 +01:00
Igor Nikonov
84d64a6ed8 Merge remote-tracking branch 'origin/master' into pr-better-replicas-failover-2 2024-02-08 18:03:16 +00:00
Raúl Marín
d97c5496f5 Fix unpoison 2024-02-08 18:37:07 +01:00
kssenii
e55b60e05c Fix 2024-02-08 17:43:16 +01:00
Antonio Andelic
dfb3a8f7be Another fix 2024-02-08 17:17:12 +01:00
Robert Schulze
ccafc523a9
Fix style 2024-02-08 15:51:27 +00:00
Dmitry Novik
5f75087178 Add comments 2024-02-08 15:48:20 +00:00
Vitaly Baranov
1b9620001b Move ColumnArray-specific code out of the ActionsDAG. 2024-02-08 15:31:32 +01:00
Antonio Andelic
160f1b7fd8 Fix logical optimizer with LowCardinality 2024-02-08 15:01:56 +01:00
Nikolai Kochetov
73d2ff3933
Update MergeTask.cpp 2024-02-08 14:55:35 +01:00
Nikolai Kochetov
fafd8005a0 Fixing style. 2024-02-08 13:51:29 +00:00
Nikolai Kochetov
57ddf196cf
Merge pull request #59705 from kitaisreal/revert-59702-revert-59650-merge-tree-final-optimization-diagnostics-and-settings
Revert "Revert "MergeTree FINAL optimization diagnostics and settings""
2024-02-08 14:48:29 +01:00
Nikolai Kochetov
9560eabfe8
Merge pull request #59720 from ClickHouse/try-remove-source-with-key-condition
Remove SourceWithKeyCondition from ReadFromStorageStep
2024-02-08 14:44:13 +01:00
Raúl Marín
5b16d6b958
Merge pull request #59754 from ClickHouse/revert-59683-rename-setting
Revert "Rename a setting"
2024-02-08 13:19:48 +01:00
Raúl Marín
697f7b28a7
Merge pull request #59739 from Algunenano/padstring_fix
Fix leftPad / rightPad function with FixedString input
2024-02-08 13:15:26 +01:00
Raúl Marín
284ed191ab
Revert "Rename a setting" 2024-02-08 13:13:22 +01:00
Robert Schulze
fc003497bb
Fix bug 59749 2024-02-08 11:50:20 +00:00
Robert Schulze
f7bb000b51
Refactorings, pt. II: disallow FixedString patterns 2024-02-08 11:38:04 +00:00
Robert Schulze
cfa1a452e1
Refactorings, pt. I 2024-02-08 11:33:34 +00:00
Dmitry Novik
b8f74b5b05
Merge pull request #50894 from ClickHouse/storage-merge-aliases-analyzer
Analyzer: support aliases and distributed JOINs in StorageMerge
2024-02-08 11:22:00 +01:00
Antonio Andelic
33f12c9f35 Merge branch 'master' into keeper-more-reduce 2024-02-08 10:54:26 +01:00
Igor Nikonov
3fb30a23d9 Merge remote-tracking branch 'origin/master' into pr-better-replicas-failover-2 2024-02-08 09:09:11 +00:00
Julia Kartseva
ece4febe32 Insert synchronously if dependent MV deduplication is enabled 2024-02-08 08:42:04 +00:00
Alexander Tokmakov
510f90edf8
Merge pull request #59688 from ClickHouse/revert_39507_again
Temporarily remove a feature that doesn't work
2024-02-08 02:27:55 +01:00
Vitaly Baranov
12a71375b8 Fix skipping unused shards with analyzer. 2024-02-08 00:44:59 +01:00
Alexey Milovidov
02c0b4c67f Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-07 22:45:50 +01:00
Alexey Milovidov
393abebf64
Merge pull request #59683 from ClickHouse/rename-setting
Rename a setting
2024-02-07 22:43:14 +01:00
Raúl Marín
48a48be135 Fix leftPad / rightPad function with FixedString input 2024-02-07 22:31:21 +01:00
Igor Nikonov
620bf09a75
Merge pull request #59706 from ClickHouse/cleanup-connection-establisher
ConnectionEstablisher: remove unused is_finished
2024-02-07 22:17:41 +01:00
Nikolai Kochetov
1c71a27527 Remove some comments 2024-02-07 20:05:39 +00:00
Raúl Marín
10c09b5817 Enable MSAN in mem*Overflow15 functions 2024-02-07 20:23:52 +01:00
Nikolai Kochetov
39da54cd50 Fixing more tests. 2024-02-07 19:15:59 +00:00
Konstantin Bogdanov
38373b989a
Merge pull request #59659 from ClickHouse/create-tables-in-threadpool-followup
Follow up for #59277
2024-02-07 21:12:43 +03:00
Raúl Marín
7f8449f6d8 FixedString: Assert columns are of the same size 2024-02-07 18:52:41 +01:00
Anton Popov
9a4dbc843a validate type of arguments for minmax secondary index 2024-02-07 17:52:17 +00:00
Alexander Tokmakov
328359dcd3
Update ZooKeeperImpl.cpp 2024-02-07 18:51:19 +01:00
Ilya Yatsishin
4a2912d791
Update src/Core/Settings.h
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2024-02-07 21:47:54 +04:00
Maksim Kita
8f774f358f Fixed tests 2024-02-07 20:16:54 +03:00
Maksim Kita
65db507317 Fixed tests 2024-02-07 20:16:54 +03:00
Maksim Kita
a9624786f2 Revert "Revert "MergeTree FINAL optimization diagnostics and settings"" 2024-02-07 20:16:54 +03:00
Nikolai Kochetov
a547116821
Update SettingsChangesHistory.h 2024-02-07 17:58:15 +01:00
Nikolai Kochetov
01d0ca315e
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-07 17:56:57 +01:00
vdimir
82cb09cab3
Merge pull request #59528 from ClickHouse/vdimir/analyzer/fix_test_select_access_rights
Analyzer fix test_select_access_rights/test_main.py::test_select_count
2024-02-07 17:00:46 +01:00
Dmitry Novik
813020a1a6 remove redundant logging 2024-02-07 16:44:09 +01:00
Dmitry Novik
ff4729ccc4 Improve replaceTableExpressionAndRemoveJoin function 2024-02-07 16:40:23 +01:00
Antonio Andelic
99be5b5cb1 Fix 2024-02-07 15:57:52 +01:00
Nikolai Kochetov
c391cb5f56 Remove SourceWithKeyCondition from ReadFromStorageStep 2024-02-07 14:53:55 +00:00
Alexey Milovidov
7016e1d397 Maybe better 2024-02-07 15:43:58 +01:00
Raúl Marín
74b37ea5b0
Revert "Use MergeTree as a default table engine" 2024-02-07 14:23:43 +01:00
Antonio Andelic
15c89bdd66 Merge branch 'master' into keeper-more-reduce 2024-02-07 14:21:31 +01:00
Nikita Taranov
e8c0637fe2 fix 2024-02-07 14:18:11 +01:00
Antonio Andelic
2b316d51ea Merge branch 'master' into keeper-logs-cache 2024-02-07 13:52:53 +01:00
Smita Kulkarni
e594608c42 Merge branch 'master' into Azure_backup 2024-02-07 13:48:46 +01:00
Nikolai Kochetov
41d6243170 Fix PreparedSets 2024-02-07 12:43:26 +00:00
Robert Schulze
7edcb86c08
Merge pull request #58632 from ClibMouse/series_outlier
Added function `seriesOutliersTukey` for outlier detetion in series data
2024-02-07 13:08:53 +01:00
Raúl Marín
05e33bdf6a
Merge pull request #59605 from Algunenano/more_sanity_checks
Add another sanity check for function return types
2024-02-07 13:08:11 +01:00
Nikolai Kochetov
df0c30878e Fixing style 2024-02-07 12:38:52 +01:00
Nikolai Kochetov
d1902cdba0 Fix some tests. 2024-02-07 12:36:24 +01:00
Nikolai Kochetov
fbd71ee15e Fixing style. 2024-02-07 12:36:24 +01:00
Nikolai Kochetov
06d112135e Simplify prewhere push down from query plan. Try to always use it. 2024-02-07 12:36:20 +01:00
Nikolai Kochetov
a3d1b3f502 Merge branch 'master' into non-ready-set-ttl 2024-02-07 11:29:04 +00:00
Nikolai Kochetov
c434748fc1
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-07 12:25:11 +01:00
Raúl Marín
01a459c9b6
Merge pull request #59702 from ClickHouse/revert-59650-merge-tree-final-optimization-diagnostics-and-settings
Revert "MergeTree FINAL optimization diagnostics and settings"
2024-02-07 11:52:39 +01:00
Raúl Marín
38c8e1b8cc
Merge pull request #59485 from Algunenano/strict_int8
Strict aliasing for Int8
2024-02-07 11:33:06 +01:00
Raúl Marín
b5b7847036
Revert "MergeTree FINAL optimization diagnostics and settings" 2024-02-07 10:59:32 +01:00
Alexander Gololobov
4dcd806dfc
Merge pull request #59545 from ClickHouse/system_zookeeper_stream
Produce stream of chunks from system.zookeeper instead of accumulating the whole result
2024-02-07 10:17:38 +01:00
Alexey Milovidov
d65a56d967
Merge branch 'master' into enable-coverage-for-debug-build 2024-02-07 04:58:21 +01:00
Alexey Milovidov
5b791ddec8 Check stack size in Parser 2024-02-07 04:23:43 +01:00
Alexey Milovidov
88b6b38a74 Check stack size in Parser 2024-02-07 04:21:57 +01:00
Alexey Milovidov
40e10d1f97
Merge pull request #59316 from ClickHouse/merge-tree-as-a-default-table-engine
Use `MergeTree` as a default table engine
2024-02-07 03:59:37 +01:00
Alexey Milovidov
575bf1e060
Merge pull request #59658 from Algunenano/rewrite_sum_plus_fix
Maintain function alias in RewriteSumFunctionWithSumAndCountVisitor
2024-02-07 03:38:46 +01:00
Alexander Tokmakov
77e4b0c8d9 Revert "Merge pull request #59122 from arthurpassos/bring_back_attach_partition_pr"
This reverts commit ac90637170, reversing
changes made to fe2b5cde05.
2024-02-07 02:52:43 +01:00
Igor Nikonov
4f153b59c0 Minor fix 2024-02-07 01:30:48 +00:00
Igor Nikonov
755298838f Preserve replicas order for data locality 2024-02-07 01:28:27 +00:00
Igor Nikonov
0c00435cea Merge remote-tracking branch 'origin/master' into pr-better-replicas-failover-2 2024-02-07 00:52:50 +00:00
Igor Nikonov
10082399d5 Minor review fixes 2024-02-07 00:52:25 +00:00
Alexey Milovidov
5991ea4dc3 Rename the setting 2024-02-07 00:00:34 +01:00
Alexey Milovidov
23c9b32282 Fix the documentation 2024-02-06 23:54:12 +01:00
Alexey Milovidov
8d08d60bf1 Rename a setting 2024-02-06 23:49:54 +01:00
Alexey Milovidov
01c8542462
Merge pull request #59606 from vitlibar/fix-distributed-table-with-const-sharding-key
Fix distributed table with a constant sharding key
2024-02-06 22:10:34 +01:00
Konstantin Bogdanov
d64db12f72
Fix for empty sorted_nodes 2024-02-06 21:44:45 +01:00
Konstantin Bogdanov
942addfa8c
Learning how std::vector works 2024-02-06 21:22:55 +01:00
Raúl Marín
25738c8313 Remove no longer needed specialization 2024-02-06 20:34:12 +01:00
Raúl Marín
ff63a1cf9f Fix tidy 2024-02-06 20:34:12 +01:00
Raúl Marín
0a4e73a98d Strict aliasing for Int8 2024-02-06 20:33:32 +01:00
Dmitry Novik
d558728281
Merge branch 'master' into storage-merge-aliases-analyzer 2024-02-06 20:24:20 +01:00
robot-ch-test-poll4
3af96c6970
Merge pull request #59435 from rschu1ze/nested-memory-cgroups
Consider nested cgroup memory limits for the total memory tracker
2024-02-06 20:18:00 +01:00
Nikolai Kochetov
f311f2ed45
Merge pull request #59650 from kitaisreal/merge-tree-final-optimization-diagnostics-and-settings
MergeTree FINAL optimization diagnostics and settings
2024-02-06 20:14:14 +01:00
Raúl Marín
b43f90fce2 Fix query start time on non initial queries 2024-02-06 19:55:50 +01:00
Konstantin Bogdanov
0f515e7759
Reserve space in vector 2024-02-06 19:37:22 +01:00
Anton Popov
3b22c3849f
Merge pull request #59621 from bigo-sg/opt_if_not_null
Trivial optimize on ifNotNull with intel AVX2
2024-02-06 19:13:06 +01:00
Konstantin Bogdanov
3b03aea16b
Use vector instead of a map 2024-02-06 19:10:45 +01:00
Konstantin Bogdanov
5894fa9860
0 means number of cores 2024-02-06 19:10:34 +01:00
Raúl Marín
5c68f9cabd Maintain function alias in RewriteSumFunctionWithSumAndCountVisitor 2024-02-06 19:09:28 +01:00
Raúl Marín
e10e105ec1 Merge remote-tracking branch 'blessed/master' into more_sanity_checks 2024-02-06 17:42:36 +01:00
Raúl Marín
5d042dc815 Check pointer 2024-02-06 17:42:24 +01:00
vdimir
9438118745
fix test_select_access_rights/test_main.py::test_select_join 2024-02-06 16:15:04 +00:00
vdimir
aad9f49626
analyzer fix test_select_access_rights/test_main.py::test_select_count 2024-02-06 16:01:26 +00:00
Nikolai Kochetov
29908ddd09 Remove commented code. Add more comments. 2024-02-06 15:59:13 +00:00
Dmitry Novik
1abcf26df6 Fix filter expressions 2024-02-06 15:39:52 +00:00
Igor Nikonov
b9848dbd2c Remove unused is_finished 2024-02-06 14:30:19 +00:00
Anton Popov
addbd78341
Merge pull request #59436 from nickitat/perf_introspection_for_inserts
More perf introspection for `INSERT`-s
2024-02-06 14:59:32 +01:00
Alexander Gololobov
ca4f46ab41 Check block size in bytes instead of rows 2024-02-06 14:27:15 +01:00
Maksim Kita
c4846b6613 MergeTree FINAL optimization diagnostics and settings 2024-02-06 15:55:16 +03:00
Raúl Marín
c858e2e173 Merge remote-tracking branch 'blessed/master' into fix_map_memory 2024-02-06 11:48:13 +01:00
Raúl Marín
b247440b7d
Merge pull request #59603 from Algunenano/crash_topk
Fix crash in topK when merging empty states
2024-02-06 11:40:52 +01:00
Antonio Andelic
1279964866
fix build 2024-02-06 10:18:02 +01:00