Commit Graph

378 Commits

Author SHA1 Message Date
Azat Khuzhin
b7ba0b64dc Reset signal handlers just before closing signal pipe to avoid EBADF after
stack trace:

    (gdb) bt
    0  0x00007ffff7dda355 in raise () from /usr/lib/libc.so.6
    1  0x00007ffff7dc3853 in abort () from /usr/lib/libc.so.6
    2  0x0000000013a78180 in abort_message (format=format@entry=0x5781e10 "terminate_handler unexpectedly threw an exception") at abort_message.cpp:76
    3  0x0000000013a899ff in std::__terminate (func=<optimized out>) at cxa_handlers.cpp:67
    4  0x0000000013a771a1 in __cxxabiv1::call_terminate (native_exception=native_exception@entry=true, unwind_exception=unwind_exception@entry=0x7ffff70e9060) at cxa_personality.cpp:323
    5  0x0000000013a77669 in __cxxabiv1::scan_eh_tab (results=..., actions=<optimized out>, native_exception=native_exception@entry=true, unwind_exception=0x7ffff70e9060, context=context@entry=0x7fffffffc3a0) at cxa_personality.cpp:887
    6  0x0000000013a77bde in __cxxabiv1::__gxx_personality_v0 (version=<optimized out>, actions=<optimized out>, exceptionClass=<optimized out>, unwind_exception=0x7ffff70e9060, context=0x7fffffffc3a0) at cxa_personality.cpp:969
    7  0x0000000013a962d7 in unwind_phase1 (exception_object=0x7ffff70e9060, cursor=0x7fffffffc3a0, uc=0x7fffffffc2f0) at UnwindLevel1.c:98
    8  _Unwind_RaiseException (exception_object=exception_object@entry=0x7ffff70e9060) at UnwindLevel1.c:363
    9  0x0000000013a8929b in __cxxabiv1::__cxa_rethrow () at cxa_exception.cpp:607
    10 0x000000000f170ad2 in DB::WriteBuffer::next (this=0x7fffffffc510) at WriteBuffer.h:52
    11 writeSignalIDtoSignalPipe (sig=<optimized out>) at BaseDaemon.cpp:111
    12 <signal handler called>
    13 0x00007ffff7e9895b in munmap () from /usr/lib/libc.so.6
    14 0x00007ffff7f7e255 in free_stacks () from /usr/lib/libpthread.so.0
    15 0x00007ffff7f7e6aa in __deallocate_stack () from /usr/lib/libpthread.so.0
    16 0x00007ffff7f80898 in __pthread_clockjoin_ex () from /usr/lib/libpthread.so.0
    17 0x0000000013a759f7 in std::__1::__libcpp_thread_join (__t=0x7fff0aa2b090) at __threading_support:409
    18 std::__1:🧵:join (this=this@entry=0x7fff0aa2b090) at thread.cpp:56
    19 0x000000000a4c9399 in ThreadPoolImpl<std::__1::thread>::finalize (this=this@entry=0x7ffff7053900) at list:355
    20 0x000000000a4c9426 in ThreadPoolImpl<std::__1::thread>::~ThreadPoolImpl (this=0x7ffff7053900, __in_chrg=<optimized out>) at ThreadPool.cpp:172
    21 0x000000000a4c8a9c in GlobalThreadPool::~GlobalThreadPool (this=0x7ffff7053900, __in_chrg=<optimized out>) at ThreadPool.h:132
    22 std::__1::default_delete<GlobalThreadPool>::operator() (__ptr=0x7ffff7053900, this=<optimized out>) at memory:2363
    23 std::__1::unique_ptr<GlobalThreadPool, std::__1::default_delete<GlobalThreadPool> >::reset (__p=0x0, this=<optimized out>) at memory:2618
    24 std::__1::unique_ptr<GlobalThreadPool, std::__1::default_delete<GlobalThreadPool> >::~unique_ptr (this=<optimized out>, __in_chrg=<optimized out>) at memory:2572
    25 0x00007ffff7ddcc57 in __run_exit_handlers () from /usr/lib/libc.so.6
    26 0x00007ffff7ddcdfe in exit () from /usr/lib/libc.so.6
    27 0x00007ffff7dc5009 in __libc_start_main () from /usr/lib/libc.so.6
    28 0x000000000a48702e in _start () at new:340
2020-08-13 23:12:36 +03:00
myrrc
e2e38e30d0 Merge remote-tracking branch 'upstream/master' into bug/low-cardinality-arrays-optimisations 2020-08-12 19:12:08 +03:00
myrrc
82206e89dd fixed perftest long test and StringRef assert 2020-08-12 17:07:56 +03:00
myrrc
67d716b5cc revert accidental changes 2020-08-11 16:36:28 +03:00
Alexander Kazakov
6e0d536327
Merge branch 'master' into bug/low-cardinality-arrays-optimisations 2020-08-11 16:25:20 +03:00
Amos Bird
1eda00d27d
Readline fix 2020-08-11 17:49:39 +08:00
Alexey Milovidov
16b9d77ebf Merge branch 'master' of github.com:yandex/ClickHouse into clickhouse-install 2020-08-11 00:41:35 +03:00
Ivan
c8d3999693
Enable Poco::NetSSL support in ya.make 2020-08-10 14:18:57 +03:00
Alexey Milovidov
6716e442f9 Merge branch 'master' of github.com:yandex/ClickHouse into clickhouse-install 2020-08-10 02:20:37 +03:00
Vitaly Baranov
2e6ba2a05d
Merge pull request #13496 from vitlibar/compound-identifiers-for-custom-settings
Support compound identifiers for custom settings.
2020-08-10 01:03:02 +03:00
Alexey Milovidov
0eac2d4054 Merge branch 'embed-configs' into clickhouse-install 2020-08-09 02:42:06 +03:00
Alexey Milovidov
182e2929f3 Merge branch 'master' into embed-configs 2020-08-09 02:41:44 +03:00
Alexey Milovidov
b4ac900462 Fix "Arcadia" build 2020-08-09 02:38:53 +03:00
alexey-milovidov
ba5988dcf6
Merge pull request #13446 from ClickHouse/fix-netloc
Function "netloc": fix wrong code.
2020-08-09 01:39:46 +03:00
Alexey Milovidov
d9db0a3442 Add simple "clickhouse-install" tool 2020-08-08 21:38:34 +03:00
Vitaly Baranov
5401694138 splitInto() now can put result into a vector of std::string_view. 2020-08-08 19:35:53 +03:00
Alexey Milovidov
0d70393bac Fix build 2020-08-08 07:55:33 +03:00
Alexey Milovidov
0f79eb3cc5 Embed configs into binary 2020-08-08 06:42:42 +03:00
Alexey Milovidov
0cbbe153cd Fix typos, the last 1% 2020-08-08 04:21:04 +03:00
Alexey Milovidov
d1ed1fb83a Fix error 2020-08-07 04:04:37 +03:00
alesapin
aa7d5adf11
Merge pull request #13379 from ClickHouse/remove-recursive-submodules
Remove recursive submodules
2020-08-06 11:50:40 +03:00
Nikita Mikhaylov
fa51f15f00
fix style 2020-08-05 19:23:14 +03:00
Nikita Mikhaylov
b80677fdb3
Update OwnSplitChannel.cpp 2020-08-05 18:12:06 +03:00
Alexey Milovidov
2cd811975a Update Sentry 2020-08-05 17:41:27 +03:00
nikitamikhaylov
4e3c7c60b7 fix build 2020-08-05 16:39:14 +03:00
nikitamikhaylov
264320a82c done 2020-08-05 16:33:04 +03:00
Alexander Kuzmenkov
0eaab3d095
Merge pull request #13191 from ClickHouse/aku/semicolon-cleanup
Cleanup for #12999. NFC
2020-08-05 14:53:27 +03:00
myrrc
98119af9de Merge remote-tracking branch 'upstream/master' into bug/low-cardinality-arrays-optimisations 2020-08-04 15:01:27 +03:00
Alexander Kuzmenkov
e7744cc15c Merge remote-tracking branch 'origin/master' into HEAD 2020-08-03 16:35:42 +03:00
Alexey Milovidov
d3c0635fc0 Merge branch 'master' into stack-frams-size-limit 2020-08-02 04:35:09 +03:00
Alexey Milovidov
64d91d0f90 Fix build; fix errors 2020-08-01 18:54:44 +03:00
Alexey Milovidov
9ef9d31f03 Crash log: development 2020-07-31 23:16:31 +03:00
Alexander Kuzmenkov
efb09d7ff5 Cleanup for #12999. NFC. 2020-07-31 17:53:41 +03:00
Alexey Milovidov
c202691319 Merge branch 'master' into stack-frams-size-limit 2020-07-30 23:53:52 +03:00
Azat Khuzhin
b7eee3afe0 Add a comment of explicit flock() in ReplxxLineReader::addToHistory() 2020-07-29 21:00:46 +03:00
Azat Khuzhin
d6102869e5 Avoid re-loading completion from the history file after each query
By default replxx reload history from the file in
replxx::Replxx::history_save(), and this will overlaps current session
history with the history from other sessions, and this does not looks a
great idea (bash and other interpreters don't do this).

So to avoid this, use separate replxx::Replxx instance.
2020-07-29 21:00:46 +03:00
myrrc
0f5b089270 fix: ubsan, EMPTY_STRING_REF constant 2020-07-29 01:08:09 +03:00
myrrc
da9502e496 Merge remote-tracking branch 'upstream/master' into bug/low-cardinality-arrays-optimisations 2020-07-28 15:06:39 +03:00
alexey-milovidov
da32e62daa
Fix comment (tnx Pavel Belikov) (#12957) 2020-07-28 11:58:26 +03:00
myrrc
61ef8852a1 reverting explicit fix 2020-07-22 23:13:57 +03:00
myrrc
586ecf0a0b fixed 2 explicit constructors 2020-07-22 23:10:12 +03:00
myrrc
1d0bf93444 added perftest, fixed style check and PVS bugs 2020-07-22 22:44:11 +03:00
myrrc
222eb7fba3 fixed result column overwriting 2020-07-22 16:18:21 +03:00
Alexey Milovidov
50bbfc848d Merge branch 'master' into stack-frams-size-limit 2020-07-21 14:45:15 +03:00
Vitaly Baranov
0b17595a91
Merge pull request #12423 from vitlibar/update-simdjson
Update simdjson
2020-07-20 10:15:38 +03:00
Vitaly Baranov
61e43c3ef9 Make conversion std::string_view => StringRef explicit. 2020-07-19 12:50:24 +03:00
Alexander Kuzmenkov
f785837b1d
Merge pull request #12518 from ClickHouse/aku/android
Some provisions for Android build
2020-07-15 22:05:41 +03:00
Alexander Kuzmenkov
3e6b9f297f Some provisions for Android build 2020-07-15 14:16:00 +03:00
Alexey Milovidov
360bf61639 Fix error 2020-07-13 03:45:18 +03:00
Alexey Milovidov
f2fe419ca9 Saturate negative unix timestamp to zero instead of overflow 2020-07-13 01:48:22 +03:00
Alexey Milovidov
d07af62370 Log sanitizer trap messages from separate thread 2020-07-09 05:00:48 +03:00
alexey-milovidov
4f63af957d
Merge pull request #12145 from ClickHouse/fix-suggest-word-break-chars
Remove underscore as word-break character.
2020-07-06 08:51:35 +03:00
alexey-milovidov
1719ab1ec5
Merge pull request #12041 from azat/curl-proper-cmake
Rewrite curl dependency in a more ch compatible way
2020-07-06 06:31:51 +03:00
Alexey Milovidov
5eb60d5bd3 Remove underscore as word-break character. This partially reverts #11975 2020-07-06 01:16:32 +03:00
Alexey Milovidov
10c40f4b11 Attempt to fix "Arcadia" build 2020-07-05 03:48:00 +03:00
Alexey Milovidov
96e8e93c64 Fix warnings from CodeQL 2020-07-05 02:16:16 +03:00
Alexey Milovidov
176a7f2f72 Normalize "pid" file handling #3501 2020-07-04 16:54:24 +03:00
Azat Khuzhin
0700a705bc Rewrite curl dependency in a more ch compatible way
- add support of unbundled curl
- add CURL::libcurl libraries
- avoid explicit linkage of daemon with curl (added with sentry)
- set CACHE variables for non-direct users:
  - mariadb-connector-c
  - aws-s3-cmake
  - sentry-native

Cc: @alexey-milovidov
Cc: @alesapin (requires docker image update)
Cc: @abyss7

Refs: #11300
Refs: #8011
Refs: #8905

v2: replace cmake/find/curl.cmake with proper contrib/curl-cmake (as
pointed by @abyss7, cmake/find/*.cmake is deprecated)
2020-07-03 00:57:08 +03:00
alexey-milovidov
77c4861430
Merge pull request #11975 from oandrew/fix-word-breaks
Extend word break config to all non-alphanumeric chars
2020-06-27 19:13:44 +03:00
Andrew Onyshchuk
80c0676031 Extend word break config to all non-alphanumeric chars 2020-06-25 20:36:09 -05:00
Ivan Blinkov
db568b477e lost unused 2020-06-24 11:12:47 +03:00
Ivan Blinkov
3ed76a388e send build_id to sentry as well + fix some minor issues 2020-06-24 00:27:04 +03:00
Ivan Blinkov
45d1ca2567 merge master 2020-06-24 00:18:16 +03:00
Ivan Blinkov
87d56d700f restore old toStringImpl signature 2020-06-24 00:15:54 +03:00
Alexey Milovidov
b50b4b14de Merge branch 'master' into send-logs-on-fatal-errors 2020-06-22 15:48:46 +03:00
Ivan Blinkov
2c0ff29c48 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-22 10:06:36 +03:00
Alexey Milovidov
fe71a8eb8c Merge branch 'master' into send-logs-on-fatal-errors 2020-06-21 13:55:11 +03:00
Alexey Milovidov
ea35829481 Fix build 2020-06-21 13:46:41 +03:00
Alexey Milovidov
7f05d2bac0 Merge branch 'master' into print-build-id 2020-06-21 13:44:32 +03:00
alexey-milovidov
45fbc96f19
Merge pull request #11827 from ClickHouse/remove-tzdata-dependency
Remove dependency on tzdata
2020-06-21 00:20:01 +03:00
Alexey Milovidov
581d1a4470 Fix build 2020-06-20 21:05:44 +03:00
Alexey Milovidov
6eda152726 Remove dependency on tzdata 2020-06-20 15:26:44 +03:00
Alexey Milovidov
b2d1e08dd6 Fix build 2020-06-20 14:31:38 +03:00
Alexey Milovidov
7ba25bd799 Make it work 2020-06-20 14:17:15 +03:00
Alexey Milovidov
beae4d5db1 Fix sleep in signal handler 2020-06-20 13:15:53 +03:00
Alexey Milovidov
9f42e81ef9 Send logs on fatal errors (development) 2020-06-20 13:10:18 +03:00
Alexey Milovidov
2897a54072 Fix build 2020-06-20 12:17:31 +03:00
Alexey Milovidov
7fcdfa1f88 Print build id on startup 2020-06-20 12:13:11 +03:00
Alexey Milovidov
ead4a2cfd9 Print build id in crash messages 2020-06-20 12:07:05 +03:00
Ivan Blinkov
102628ff09 remove extra line 2020-06-17 10:54:06 +03:00
Ivan Blinkov
8b50e3450b move the default endpoint to config 2020-06-16 23:01:15 +03:00
Ivan Blinkov
1fd0f0ff07 Merge branch 'sentry' of github.com:blinkov/ClickHouse into sentry 2020-06-16 16:02:44 +03:00
Ivan Blinkov
0e77692a27 improvements after review comments 2020-06-16 15:56:28 +03:00
alexey-milovidov
92c7760c6e
Update CMakeLists.txt 2020-06-16 02:51:33 +03:00
alexey-milovidov
977fd3e44f
Update CMakeLists.txt 2020-06-16 02:45:05 +03:00
Ivan Blinkov
395ef1ecaf experiment 2020-06-12 09:35:31 +03:00
Ivan Blinkov
e92641858e fixes 2020-06-12 01:00:35 +03:00
Ivan Blinkov
bbeb768a19 use the sentry logger hook 2020-06-11 21:12:48 +03:00
Ivan Blinkov
fa47fc3f30 fix address formatting 2020-06-11 15:34:02 +03:00
Ivan Blinkov
5fa4401991 fix 2020-06-10 21:18:34 +03:00
Ivan Blinkov
0a74c9373e less confusing 2020-06-10 19:48:08 +03:00
Ivan Blinkov
60b40f0403 Lost part of refactoring 2020-06-10 17:51:25 +03:00
Ivan Blinkov
6191d33bd9 Do not cache frames inside StackTrace 2020-06-10 16:30:12 +03:00
Ivan Blinkov
6f7064928f Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-09 19:07:57 +03:00
Ivan
47ad338cb2
Refactor CMake build files (#11390)
* Get rid of lib_name.cmake
* Refactor Boost and HyperScan libraries
* Refactor lz4
* Fix build with xxHash
2020-06-09 13:54:49 +03:00
Ivan Blinkov
5b3fef526e Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-09 11:51:29 +03:00
Alexey Milovidov
9b53cb052f Limit stack frame size in tests 2020-06-09 01:45:38 +03:00
Matwey V. Kornilov
269bf6f5ef Fix missed #include <functional>
<functional> is required for std::hash
2020-06-08 19:25:21 +03:00
Matwey V. Kornilov
339703d1b8 Fix missed #include <utility>
<utility> is required for std::move
2020-06-08 18:03:54 +03:00
alexey-milovidov
ce4f528b73
Merge branch 'master' into kuskarov-add_syntax_highlighting 2020-06-08 02:14:09 +03:00
Alexey Milovidov
df19db1509 Added a test for history in clickhouse-client 2020-06-07 20:29:34 +03:00
alexey-milovidov
6b97fd6378
Update ReplxxLineReader.cpp 2020-06-06 12:51:42 +03:00
alexey-milovidov
7003fe8258
Update ReplxxLineReader.cpp 2020-06-06 12:49:15 +03:00
Ivan Blinkov
653a9afda0 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-05 22:51:28 +03:00
Alexey Milovidov
e1b5ee51c1 Better way to plug in the code 2020-06-05 01:45:04 +03:00
Alexey Milovidov
275075b6f7 Revert all changes but save commit history from @kuskarov 2020-06-05 01:44:29 +03:00
Tagir Kuskarov
d0312bf1fe Fix 2020-06-05 02:36:40 +04:00
Alexey Milovidov
fcd7fd8e7c Updates for #11422 2020-06-05 01:31:19 +03:00
Tagir Kuskarov
d916d0849d Add diagnostic messages 2020-06-05 02:10:22 +04:00
Tagir Kuskarov
83ba86c5f6 Fix history bug 2020-06-05 01:31:51 +04:00
Tagir Kuskarov
fed90652c9 Move files 2020-06-04 05:04:57 +04:00
Ivan Blinkov
921b7c7480 partial revert 2020-06-02 22:25:34 +03:00
Ivan Blinkov
711e7d101d experiment 2020-06-02 21:50:55 +03:00
Tagir Kuskarov
643c3cd153 Add syntax highlighting first version 2020-06-02 16:08:09 +04:00
Ivan Blinkov
280eea1e12 fix compiling when disabled 2020-06-02 10:33:11 +03:00
Ivan Blinkov
40f6e559e2 fix compiling when disabled 2020-06-02 08:29:29 +03:00
alexey-milovidov
73a05d9b6d
Update LineReader.h 2020-06-02 06:30:00 +03:00
Alexey Milovidov
38829beb1c Minor updates 2020-06-02 06:28:59 +03:00
Alexey Milovidov
1bbbfc6e1b Fix \G in clickhouse-client multiline mode #9933 2020-06-02 06:25:19 +03:00
Ivan Blinkov
e9a04f7741 more build fixes 2020-06-01 23:48:42 +03:00
Ivan Blinkov
6bd4282727 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-01 21:49:56 +03:00
Ivan Blinkov
1797a47a9f fix clang warnings 2020-06-01 21:25:25 +03:00
Alexey Milovidov
7fcfcf201d Fix unit tests under MSan 2020-06-01 20:07:27 +03:00
Ivan Blinkov
acf22bfb19 fix sanitizers build 2020-06-01 19:42:59 +03:00
Ivan Blinkov
3e0811f297 Adapt to recent logging changes 2020-06-01 17:15:14 +03:00
Ivan Blinkov
fcc7ff0ef9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-01 08:42:03 +03:00
alexey-milovidov
9984e989c1
Merge pull request #11317 from ClickHouse/logger-fmt-2
Preparation for structured logging
2020-06-01 00:11:29 +03:00
Alexey Milovidov
d2eb58142e Fix build 2020-05-31 16:51:37 +03:00
Alexey Milovidov
e3dc1d6734 Fix build 2020-05-31 16:50:40 +03:00
Alexey Milovidov
669a15b943 Whitespaces 2020-05-31 16:48:43 +03:00
Alexey Milovidov
b444615404 Compatibility with Arcadia build 2020-05-31 16:47:58 +03:00
Alexey Milovidov
25f941020b Remove namespace pollution 2020-05-31 00:57:37 +03:00
Ivan Blinkov
be94d8454d fix Arcadia build 2020-05-30 13:54:57 +03:00
Ivan Blinkov
52f7b9545b Add http_proxy option 2020-05-30 11:24:21 +03:00
Ivan Blinkov
77d8c9baca Add anonymize option and version tag 2020-05-30 11:02:13 +03:00
Ivan Blinkov
f88b85625a style 2020-05-30 00:36:47 +03:00
Ivan Blinkov
69dedcbe21 Move sending crash reports below logging 2020-05-30 00:28:55 +03:00
Ivan Blinkov
a84123195b adjust comments 2020-05-29 23:08:05 +03:00
Ivan Blinkov
95ee742ee7 merge master 2020-05-29 22:56:10 +03:00
Ivan Blinkov
d9bb3ef91b Add logging and adjust initialization 2020-05-29 22:48:32 +03:00
Alexey Milovidov
e8f52337aa Fix incorrect usage of fmtlib 2020-05-29 03:09:12 +03:00
Ivan Blinkov
52e4a0293d Keep sentry-native in debug mode only under setting 2020-05-27 23:21:53 +03:00
Ivan Blinkov
31123236cb Settings for crash report opt-in 2020-05-27 23:15:33 +03:00
Ivan Blinkov
709b4f42c8 Prototype sending crash reports on segfaults 2020-05-27 22:11:04 +03:00
Alexey Milovidov
2fd48696dc Fix build 2020-05-24 12:50:30 +03:00
Alexey Milovidov
5388693343 Fix Arcadia build 2020-05-24 01:33:29 +03:00
Alexey Milovidov
7e1813825b Return old names of macros 2020-05-24 01:24:01 +03:00
Alexey Milovidov
61cc605ee7 Remove old method 2020-05-24 01:21:29 +03:00
Alexey Milovidov
cd6d3c7509 Progress on task 2020-05-23 22:55:06 +03:00
Alexey Milovidov
f13ccfc8e8 Progress on task 2020-05-23 22:43:13 +03:00