thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
81,955 Commits 8,938 Branches 1,766 Tags 2 GiB
af9910b518
Commit Graph

81955 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
af9910b518 Fix leak of demangle result (for opentelementry) 
LSan found [1]:

    Direct leak of 5170176 byte(s) in 5049 object(s) allocated from:
        0 0xc598edd in malloc (/usr/bin/clickhouse+0xc598edd)
        1 0x39679739 in (anonymous namespace)::itanium_demangle::initializeOutputStream(char*, unsigned long*, (anonymous namespace)::itanium_demangle::OutputStream&, unsigned long) obj-x86_64-linux-gnu/../contrib/libcxxabi/src/demangle/Utility.h:178:31
        2 0x39679739 in __cxa_demangle obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_demangle.cpp:351:13
        3 0x28f6f3ed in DB::executeQueryImpl(char const*, char const*, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:662:44

  [1]:
https://s3.amazonaws.com/clickhouse-test-reports/33957/08f4f45fd9da923ae3e3fdd8a527c297d35247eb/stress_test__address__actions_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-27 13:46:37 +03:00
Azat Khuzhin
08f4f45fd9 Fix Context leak (recursive context reference) in StorageSQLite 
CI founds after LSan had been fixed [1]:

    01889_sqlite_read_write:                                                [ FAIL ] 8.32 sec. - return code: 1

    =================================================================
    ==20649==ERROR: LeakSanitizer: detected memory leaks

    Indirect leak of 1968 byte(s) in 1 object(s) allocated from:
        0 0xc5c1ffd in operator new(unsigned long) (/usr/bin/clickhouse+0xc5c1ffd)
        1 0x25e32d0d in std::__1::__unique_if<DB::StorageInMemoryMetadata>::__unique_single std::__1::make_unique<DB::StorageInMemoryMetadata, DB::StorageInMemoryMetadata const&>(DB::StorageInMemoryMetadata c>
        2 0x25e32d0d in DB::IStorage::setInMemoryMetadata(DB::StorageInMemoryMetadata const&) obj-x86_64-linux-gnu/../src/Storages/IStorage.h:194:22
        3 0x29bdee98 in DB::StorageSQLite::StorageSQLite(DB::StorageID const&, std::__1::shared_ptr<sqlite3>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std:>
        4 0x25ee61d6 in std::__1::shared_ptr<DB::StorageSQLite> shared_ptr_helper<DB::StorageSQLite>::create<DB::StorageID, std::__1::shared_ptr<sqlite3> const&, std::__1::basic_string<char, std::__1::char_tr>
        5 0x25ee61d6 in DB::TableFunctionSQLite::executeImpl(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1:>

    SUMMARY: AddressSanitizer: 171256 byte(s) leaked in 130 allocation(s).

  [1]: https://github.com/ClickHouse/ClickHouse/runs/4929706698?check_suite_focus=true

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-26 12:56:27 +03:00
Azat Khuzhin
0fe1f070fa Fix getauxval() in glibc-compatibility 
getauxval() from glibc-compatibility did not work always correctly:

- it does not work after setenv(), and this breaks vsyscalls,
  like sched_getcpu() [1] (and BaseDaemon.cpp always set TZ if timezone
  is defined, which is true for CI [2]).

  [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1163404
  [2]: https://github.com/ClickHouse/ClickHouse/pull/32928#issuecomment-1015762717

- another think that is definitely broken is LSan (Leak Sanitizer), it
  relies on worked getauxval() but it does not work if __environ is not
  initialized yet (there is even a commit about this).

  And because of, at least, one leak had been introduced [3]:

    [3]: https://github.com/ClickHouse/ClickHouse/pull/33840

Fix this by using /proc/self/auxv.

And let's see how many issues will LSan find...

I've verified this patch manually by printing AT_BASE and compared it
with output of LD_SHOW_AUXV.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-26 12:56:27 +03:00
tavplubix
9e91a9dfd1
Merge pull request #33429 from zzsmdfj/MaterializeMySQL_support_set_and_other_dataType 
MaterializeMySQL support SET YEAR TIME GEOMETRY dataType
 2022-01-26 11:29:46 +03:00
alesapin
677a7f1133
Merge pull request #33990 from ClickHouse/cancel-lambda 
Cancel lambda
 2022-01-26 10:51:21 +03:00
Maksim Kita
bf768a94e8
Merge pull request #33971 from Avogar/fix-ipv6 
Fix parsing IPv6 from query parameter and fix IPv6 to string conversion
 2022-01-25 22:45:11 +01:00
Maksim Kita
2c7a5e4d4e
Merge pull request #33967 from cnmade/PF202201250933 
Translate to zh: use-case/time-serial: remove bak file
 2022-01-25 22:24:23 +01:00
alesapin
0105f7e0bc
Merge pull request #33988 from ClickHouse/keeper_and_access 
Fix clickhouse server start when replicated access storage depend on keeper
 2022-01-25 22:54:43 +03:00
alexey-milovidov
0d6032f0fe
Merge pull request #33962 from ClickHouse/cpp-expr-script 
add c++expr script for C++ one-liners
 2022-01-25 22:50:18 +03:00
mergify[bot]
00d728a9d2
Merge branch 'master' into PF202201250933 2022-01-25 18:56:50 +00:00
Mikhail f. Shiryaev
62ddfbe4ab
Use workflow names instead of ID 2022-01-25 18:32:13 +01:00
Mikhail f. Shiryaev
604af8d3b8
Apply black to cancel lambda 2022-01-25 18:28:17 +01:00
Maksim Kita
0cc8b9462b
Merge pull request #33977 from vitlibar/fix-checking-access-for-system-command 
Fix checking access for the SYSTEM command.
 2022-01-25 17:07:36 +01:00
tavplubix
9f1da9b8b8
Update MaterializedMySQLSyncThread.cpp 2022-01-25 17:25:34 +03:00
Maksim Kita
4507f883e6
Merge pull request #33976 from azat/fix-00985_merge_stack_overflow 
Disable parallel run for 00985_merge_stack_overflow
 2022-01-25 15:12:47 +01:00
tavplubix
35534a4b92
Update Types.h 2022-01-25 16:42:55 +03:00
alesapin
b8c6481d4c Fix clickhouse server start when replicated access storage depend on keeper 2022-01-25 16:40:12 +03:00
Vitaly Baranov
cc38fe3fb6 Fix checking access for the SYSTEM command. 2022-01-25 18:54:59 +07:00
Ilya Yatsishin
fe84167c99
Merge pull request #33983 from ClickHouse/docker-green-on-retry 
Fix dependencies tree for docker image check
 2022-01-25 14:43:00 +03:00
Kruglov Pavel
1b19139f74
Merge pull request #31862 from Avogar/fix-lz4 
Try to fix lz4 compression
 2022-01-25 14:34:45 +03:00
Maksim Kita
702ad6e2c8
Merge pull request #33966 from battle-test/patch-2 
Removed line break for correct table display
 2022-01-25 12:20:14 +01:00
Mikhail f. Shiryaev
fb908a31e2
Fix dependencies tree for docker image check 2022-01-25 12:09:10 +01:00
Filatenkov Artur
a30c3d1772
Merge pull request #31645 from karnevil13/karnevil-DOCSUP-18631 
* DOCSUP-18631: Edit and translate
 2022-01-25 14:02:51 +03:00
Azat Khuzhin
7111f411df check-style: ignore comments for currentDatabase() check 
Inaccurate, but should OK for check-style scripts.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-25 13:16:45 +03:00
Azat Khuzhin
922b758298 Disable parallel run for 00985_merge_stack_overflow 
Since parallel queries to system.columns may fail with
TOO_DEEP_RECURSION too.

CI: https://s3.amazonaws.com/clickhouse-test-reports/33201/0013a2fdee26fc11a34ebffaf10f69d7cfff9b3a/fast_test__actions_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-25 12:54:43 +03:00
Kruglov Pavel
ed43abbaeb
Update FunctionsConversion.h 2022-01-25 12:32:21 +03:00
Kruglov Pavel
9f12f4af13
Merge pull request #33302 from Avogar/formats-with-suffixes 
Allow to create new files on insert for File/S3/HDFS engines
 2022-01-25 10:56:15 +03:00
avogar
ab49472155 Add comment 2022-01-25 10:10:04 +03:00
avogar
ad01d68f36 Fix parsing IPv6 from query parameter and fix IPv6 to string conversion 2022-01-25 10:09:17 +03:00
cnmade
06f22dda6e Translate to zh: use-case/time-serial: remove bak file 2022-01-25 09:41:37 +08:00
cnmade
405715374d Translate to zh: use-case/time-serial: translate to zh 2022-01-25 09:40:47 +08:00
cnmade
fadd2a3750 Translate to zh: use-case/time-serial: import old document 2022-01-25 09:38:56 +08:00
cnmade
a9290e6768 Translate to zh: use-case/time-serial: move old time-series.md to bak 2022-01-25 09:38:05 +08:00
Maksim Kita
b9fb741c79
Merge pull request #33930 from cnmade/PF202201240930 
Translate zh/faq/general/columnar-database: translate to zh
 2022-01-24 23:53:43 +01:00
Maksim Kita
c1db61b4ed
Merge pull request #33946 from azat/build-cleanup 
Remove MAKE_STATIC_LIBRARIES (in favor of USE_STATIC_LIBRARIES)
 2022-01-24 23:42:04 +01:00
Nikita
d6147f7105
Removed line break for correct table display 
https://clickhouse.com/docs/en/sql-reference/dictionaries/external-dictionaries/external-dicts-dict-structure/#ext_dict_structure-attributes
 2022-01-25 01:29:39 +03:00
Sergei Trifonov
990fd2b0aa add c++expr script for C++ one-liners 2022-01-24 22:16:47 +03:00
alexey-milovidov
189ff60f32
Merge pull request #33950 from azat/remove-glibc-compat 
Revert glibc compatibility (via .symver) in favor of hermetic build (bundled libc)
 2022-01-24 21:10:19 +03:00
Mikhail f. Shiryaev
0eaeabd9d3
Merge pull request #33954 from ClickHouse/style-checker-aarch64 
Add on-demand style-checker-aarch64 hosts
 2022-01-24 17:04:57 +01:00
Mikhail f. Shiryaev
57b4655fa2
Fix style for pr_info 2022-01-24 16:34:01 +01:00
Mikhail f. Shiryaev
fc1c80f1be
Launch docker images building on on-demand hosts 2022-01-24 15:56:18 +01:00
Mikhail f. Shiryaev
8e8ee8f8d1
Add style-checker-aarch64 to metrics lambda 2022-01-24 15:50:34 +01:00
Filatenkov Artur
852b5fe4b2
Correct paths 2022-01-24 17:37:23 +03:00
Azat Khuzhin
4a0facd341 Remove MAKE_STATIC_LIBRARIES (in favor of USE_STATIC_LIBRARIES) 
There is no more MAKE_*, so remove this alias.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-01-24 17:28:33 +03:00
Mikhail f. Shiryaev
3c5bdc0054
Merge pull request #33751 from ClickHouse/fix-docker-dependencies 
Fix docker dependencies
 2022-01-24 15:03:32 +01:00
Mikhail f. Shiryaev
7a1f471d6f
Add tests for process_image_with_parrents 2022-01-24 14:55:57 +01:00
Mikhail f. Shiryaev
d38b4f5440
Add unit tests for python to CI 2022-01-24 14:54:55 +01:00
Mikhail f. Shiryaev
70d997cbda
Fix pylint issues 2022-01-24 14:54:37 +01:00
Mikhail f. Shiryaev
18ef029ed3
Fix issue with building from non-existing tags 2022-01-24 14:54:29 +01:00
Mikhail f. Shiryaev
3531318388
Add tests for get_changed_docker_images 2022-01-24 14:52:07 +01:00