Commit Graph

84358 Commits

Author SHA1 Message Date
Saad Ur Rahman
c7402c2a39
[IO] Version ID provided during buffer read
The Version ID, if provided, is to be set in the request to read the buffer from S3. If not provided the latest version of the object must be retrieved.

Version ID set to last parameter to allow defaulting and backward compatibility with calls.
2022-03-14 20:10:14 -04:00
alesapin
fbb1ebd9b8
Merge pull request #35274 from CurtizJ/fix-check-table-sparse-columns
Fix check table in case when there exist sparse columns
2022-03-14 21:56:04 +01:00
alesapin
4e2ec66b92
Merge pull request #35282 from kssenii/fix-test
Fix test
2022-03-14 21:52:48 +01:00
kssenii
887414296b Fix 2022-03-14 20:19:53 +01:00
alesapin
54dd2583d2
Merge pull request #35280 from vitlibar/remove-github-hook
Remove utils/github-hook/hook.py
2022-03-14 20:06:53 +01:00
Kseniia Sumarokova
8c3caf3805
Merge pull request #35277 from den-crane/Docs/named-collections
Doc. named connections. Сontinuation.
2022-03-14 19:48:12 +01:00
Vitaly Baranov
3a45166ff1 Remove utils/github-hook/hook.py 2022-03-14 19:31:42 +01:00
Maksim Kita
fe1bed0b40
Merge pull request #35248 from kitaisreal/enable-clang-tidy-for-header-files
Enable clang tidy for header files
2022-03-14 19:20:58 +01:00
Maksim Kita
282dd98779 Fix build 2022-03-14 18:17:36 +00:00
Maksim Kita
3ca40d5d2e Fixed style check 2022-03-14 18:17:35 +00:00
Maksim Kita
5cf0e0c0f3 Fixed build 2022-03-14 18:17:35 +00:00
Maksim Kita
2fdcf53a76 Fix clang-tidy warnings in Server, Storages folders 2022-03-14 18:17:35 +00:00
Maksim Kita
2665724301 Fix clang-tidy warnings in Parsers, Processors, QueryPipeline folders 2022-03-14 18:17:35 +00:00
Maksim Kita
e30117a3d6 Fix clang-tidy warnings in Interpreters, IO folders 2022-03-14 18:17:35 +00:00
Maksim Kita
538f8cbaad Fix clang-tidy warnings in Disks, Formats, Functions folders 2022-03-14 18:17:35 +00:00
Maksim Kita
1d674123a9 Fix clang-tidy warnings in Databases, DataTypes, Dictionaries folders 2022-03-14 18:17:35 +00:00
Maksim Kita
65c52298b6 Fix clang-tidy warnings in Compression, Coordination, Core folders 2022-03-14 18:17:35 +00:00
Maksim Kita
e7772ed434 Fix clang-tidy warnings in Common folder 2022-03-14 18:17:35 +00:00
Maksim Kita
07b0845110 Fix clang-tidy warnings in Backups, Client, Columns folders 2022-03-14 18:17:35 +00:00
Maksim Kita
5147da3355 Fix clang-tidy warnings in AggregateFunction folder 2022-03-14 18:17:35 +00:00
Maksim Kita
e14cfd5dcd Fix clang-tidy warnings in Access folder 2022-03-14 18:17:35 +00:00
alesapin
b143aefd3f
Merge pull request #35261 from ClickHouse/tavplubix-patch-1
Fix flaky test
2022-03-14 18:21:03 +01:00
Denny Crane
cb6e2c84cb
Update named-collections.md 2022-03-14 13:53:39 -03:00
Denny Crane
70a3e7febb
Update named-collections.md 2022-03-14 13:51:51 -03:00
Denny Crane
8337a4ee5e Doc. named connections 2022-03-14 13:48:12 -03:00
Vitaly Baranov
4af61fb9d3
Merge pull request #34738 from DevTeamBK/Issue-33953
New setting in Server Configuration to on/off AuthType Plaintext_password and No_password
2022-03-14 17:09:46 +01:00
Mikhail f. Shiryaev
23afbbaeeb
Merge pull request #35260 from azat/fix-build-check
Mark build action as failed if it was retried and there was no succeeded builds
2022-03-14 16:45:34 +01:00
Anton Popov
428bbd6377 fix check table in case when there exist sparse columns 2022-03-14 15:22:23 +00:00
alesapin
b13b415d3f
Merge pull request #35257 from azat/fix-s3-pool-shutdown
Wait for IDiskRemote thread pool properly
2022-03-14 13:56:37 +01:00
Antonio Andelic
ed3d71d83f
Merge pull request #35072 from azat/buffer-memory-tracker-leak
Avoid MEMORY_LIMIT_EXCEEDED during INSERT into Buffer with AggregateFunction
2022-03-14 12:31:04 +01:00
alesapin
98144bc1f5
Merge pull request #35031 from ClickHouse/standalone_keeper_build
Building small keeper binary
2022-03-14 11:27:25 +01:00
Antonio Andelic
ebf72bf61d
Merge pull request #35145 from bigo-sg/lower-column-name
add setting to lower column case when reading parquet/orc file
2022-03-14 11:25:03 +01:00
Azat Khuzhin
4b770343e1 Mark build action as failed if it was retried and there was no succeeded builds
Builder actions does not shows errors after retries, for example [1]
failed, but the check is green:

    Dump json report {
      'log_url': 'https://s3.amazonaws.com/clickhouse-builds/35204/c5a71a7f10e9d20b116b3e1db02bb444b203c32a/binary_gcc/build_log.log',
      'build_urls': [], <-- empty
      'build_config': {...},
      'elapsed_seconds': 0, 'status': False
    } to build_urls_binary_gcc.json with env build_urls_{build_name}

  [1]: https://github.com/ClickHouse/ClickHouse/runs/5510262456?check_suite_focus=true#logs

And previous build indeed failed [2]:

    Mar 11 08:19:45 ninja: build stopped: subcommand failed.

  [2]: https://s3.amazonaws.com/clickhouse-builds/35204/c5a71a7f10e9d20b116b3e1db02bb444b203c32a/binary_gcc/build_log.log

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-14 13:23:51 +03:00
alesapin
f1b812bdc1
Merge pull request #35229 from ClickHouse/change-timezone-in-stateful-tests
Change timezone in stateful tests.
2022-03-14 11:13:12 +01:00
alesapin
b149f28cd3
Merge pull request #35209 from kssenii/cache-fix
Cache fix
2022-03-14 11:07:40 +01:00
tavplubix
17e803ea37
Update 01162_strange_mutations.sh 2022-03-14 13:02:56 +03:00
Maksim Kita
ad6b3693e1
Merge pull request #35123 from zhanghuajieHIT/fix_build_fail_with_gcc
fix build fail with gcc
2022-03-14 10:36:15 +01:00
Maksim Kita
25c994c10c
Merge pull request #35255 from ClickHouse/rfraposa-patch-4
Update internal-dicts.md
2022-03-14 10:34:49 +01:00
Kseniia Sumarokova
58a2d2b458
Merge pull request #35118 from zzsmdfj/issue/#31469_MaterializedMysql_mysqlDate2CkDate32
to #31469_MaterializedMysql_mysqlDate2CkDate32
2022-03-14 10:32:33 +01:00
Kseniia Sumarokova
5359e0430d
Merge pull request #35251 from den-crane/Docs/named-collections
Doc. named connections
2022-03-14 10:25:13 +01:00
Azat Khuzhin
d13fc9ec44 Wait for IDiskRemote thread pool properly
ASan report [1]:

    WARNING: ThreadSanitizer: heap-use-after-free (pid=611)
      Read of size 4 at 0x7b48006f0250 by thread T273:
        0 MemoryTracker::allocImpl() obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:105:49 (clickhouse+0xa05d0ef)
        1 MemoryTracker::allocImpl() obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:239:22 (clickhouse+0xa05d580)
        2 MemoryTracker::alloc(long) obj-x86_64-linux-gnu/../src/Common/MemoryTracker.cpp:246:5 (clickhouse+0xa05dea7)
        3 DB::ThreadStatus::~ThreadStatus() obj-x86_64-linux-gnu/../src/Common/ThreadStatus.cpp:154:28 (clickhouse+0xa059b01)
        4 ThreadFromGlobalPool::ThreadFromGlobalPool<>()::'lambda'()::operator()() obj-x86_64-linux-gnu/../s>

      Previous write of size 8 at 0x7b48006f0250 by main thread:
        8 std::__1::unordered_map<std::__1::basic_string<>, DB::ProcessListForUser, std::__1::hash<>, std::__1>
        9 DB::ProcessList::~ProcessList() obj-x86_64-linux-gnu/../src/Interpreters/ProcessList.h:275:7 (clickhouse+0x17b71c9c)
        10 DB::ContextSharedPart::~ContextSharedPart() obj-x86_64-linux-gnu/../src/Interpreters/Context.cpp:304:5 (clickhouse+0x17b70712)
        13 DB::SharedContextHolder::reset() obj-x86_64-linux-gnu/../src/Interpreters/Context.cpp:453:44 (clickhouse+0x17b3daf9)
        14 DB::Server::main()::$_8::o>

      Thread T273 (tid=946, running) created by thread T223 at:
        0 pthread_create <null> (clickhouse+0x9f7d49d)
        15 DB::WriteBufferFromS3::makeSinglepartUpload() obj-x86_64-linux-gnu/../src/IO/WriteBufferFromS3.cpp:332:9 (clickhouse+0x17a81b6a)

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/35072/19be9c8c6433ffd1bbf8eb08975d8afbaebf3d43/stress_test__thread__actions_.html

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-14 12:07:47 +03:00
Azat Khuzhin
9f7fae56b0 WriteBufferFromS3: remove unused headers
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-03-14 12:07:47 +03:00
Maksim Kita
2211e016cb
Merge pull request #35254 from ClickHouse/rfraposa-patch-3
Update rounding-functions.md
2022-03-14 09:31:58 +01:00
Maksim Kita
6e230d4335
Merge pull request #35253 from ClickHouse/rfraposa-patch-2
Update json-functions.md
2022-03-14 09:31:23 +01:00
Maksim Kita
2f5c35516a
Merge pull request #35256 from ClickHouse/rfraposa-patch-5
Update quotas.md
2022-03-14 09:30:34 +01:00
Denny Crane
39c6428636 Doc. named connections 2022-03-14 00:35:02 -03:00
Rich Raposa
928538f04b
Update quotas.md
Missed this comment from Alexey earlier
2022-03-13 21:34:43 -06:00
Rich Raposa
6fbb63b30c
Update internal-dicts.md
The mentioned functions have already been removed
2022-03-13 21:31:48 -06:00
Denny Crane
0b4c3e5be9 Doc. named connections 2022-03-14 00:31:20 -03:00
Rich Raposa
fa3c3f9179
Update rounding-functions.md
Adding a clarification about the use case of `roundDuration`
2022-03-13 21:27:02 -06:00