thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
45,219 Commits 8,926 Branches 1,765 Tags 2 GiB
d93f0c7548
Commit Graph

1270 Commits

Author SHA1 Message Date
Pervakov Grigorii
bc9381406f Add default credentials and custom headers for s3 table functions. 2020-06-02 20:48:49 +03:00
Ivan Blinkov
862693d78d change sentry-native commit 2020-06-02 16:59:45 +03:00
Ivan Blinkov
5036ad7c6a back to upstream 2020-06-02 13:13:29 +03:00
Denis Glazachev
c61cbe8e98 Merge branch 'master' into ldap-per-user-authentication 
* master: (114 commits)
  Update PushingToViewsBlockOutputStream.cpp
  Update PushingToViewsBlockOutputStream.cpp
  make clang-10 happy
  Fix sync_async test (remove timeout)
  CLICKHOUSEDOCS-631: temporary_files_codec, join_on_disk_max_files_to_merge settings. (#11242)
  Suppress output of cancelled queries in clickhouse-client #9473
  Better log messages in ConfigReloader
  fix select from StorageJoin
  Fix unit tests under MSan
  Added test.
  Fix build.
  Fix arguments for AggregateFunctionQuantile/
  Update style.md
  Add a guide on error messages.
  Report dictionary name on dictionary load errors.
  more types in ASOF JOIN (#11301)
  Fix part_log test
  Update test.
  Add perftest.
  Parallel processing for PushingToViewsBlockOutputStream::writeSuffix
  ...
 2020-06-02 12:42:29 +04:00
Ivan Blinkov
9c1ac2f1c1 experiment 2020-06-02 09:46:36 +03:00
Ivan Blinkov
965204dfb1 Try to fix the msan build 2020-06-01 21:48:34 +03:00
kssenii
d3b069e37b Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into add-storage-rabbitmq-read-only 2020-06-01 18:25:36 +00:00
Alexander Tokmakov
62761eddcc Merge branch 'master' into merging_external_source_cassandra 2020-06-01 14:44:46 +03:00
Ivan Blinkov
fcc7ff0ef9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-01 08:42:03 +03:00
kssenii
e80b405359 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into add-storage-rabbitmq-read-only 2020-05-31 10:30:53 +00:00
Ivan Blinkov
b6e4a2ec61 one more merge issue 2020-05-29 23:21:53 +03:00
Ivan Blinkov
d033941399 try to fix merge issues 2020-05-29 23:20:28 +03:00
Ivan Blinkov
95ee742ee7 merge master 2020-05-29 22:56:10 +03:00
Alexander Tokmakov
8921041706 Merge branch 'master' into merging_external_source_cassandra 2020-05-29 18:20:39 +03:00
Denis Glazachev
d9ca9cd9b2 Compilation fix 
Typo fix
 2020-05-29 14:00:12 +04:00
Mikhail Filimonov
34a93197f7 Update librdkafka to version 1.4.2 2020-05-28 16:52:03 +02:00
alexey-milovidov
cbac07f5eb
Merge pull request #11163 from azat/bump-jemalloc 
[WIP] Bump jemalloc to 5.2.1
 2020-05-28 01:17:26 +03:00
Alexander Tokmakov
905bce4aeb fix 2020-05-27 23:53:35 +03:00
Ivan Blinkov
709b4f42c8 Prototype sending crash reports on segfaults 2020-05-27 22:11:04 +03:00
alesapin
abc6dbcf7a
Merge pull request #11213 from ClickHouse/make_cmake_worse 
Fix cctz linking with dirty hack
 2020-05-27 18:26:46 +03:00
Alexander Tokmakov
415c8469a3 comaptibility with glibc 2.4 2020-05-27 16:51:23 +03:00
alesapin
9355240965 Better path detection 2020-05-27 15:43:25 +03:00
alesapin
d04962808e Actually it's INTERFACE linking 2020-05-27 12:14:40 +03:00
alesapin
f452c50d86 Replace private with public 2020-05-27 12:00:33 +03:00
alesapin
f29d3b8cc9 Fix cmake one more time 2020-05-27 11:58:11 +03:00
Azat Khuzhin
210e67d831 jemalloc: allow changing default malloc_conf without purging cmake cache 2020-05-27 02:19:13 +03:00
Azat Khuzhin
b694d6ed8c jemalloc: disable oversize_threshold (slower) 2020-05-27 02:19:13 +03:00
Azat Khuzhin
a8749c5d5c jemalloc: aarch64 does not have pause 2020-05-27 02:19:13 +03:00
Azat Khuzhin
bc572dc5f2 jemalloc: sync common (non per-arch) pre-generated headers 
$ for f in include/jemalloc/jemalloc_*.h; do cp /src/oss/jemalloc/$f $f; done
 2020-05-27 02:19:13 +03:00
Azat Khuzhin
5cd31dbf0d jemalloc: add _GNU_SOURCE for RTLD_NEXT 2020-05-27 02:19:13 +03:00
Azat Khuzhin
9f1cefd8df jemalloc: disable secure_getenv() 2020-05-27 02:19:13 +03:00
Azat Khuzhin
82f2b1a986 jemalloc: merge jemalloc_internal_defs.h.in for aarch64 
- keep LG_PAGE/LG_HUGEPAGE
- use upstream JEMALLOC_PURGE_MADVISE_FREE
 2020-05-27 02:19:13 +03:00
Azat Khuzhin
2f256b0d2d jemalloc: merge jemalloc_internal_defs.h.in for x86_64 
- Use upstream JEMALLOC_PURGE_MADVISE_FREE
 2020-05-27 02:19:13 +03:00
Azat Khuzhin
2590ee64d9 jemalloc: merge jemalloc_preamble.h for aarch64 2020-05-27 02:19:13 +03:00
Azat Khuzhin
b2ff1b3f20 jemalloc: merge jemalloc_preamble.h for x86_64 2020-05-27 02:19:13 +03:00
Azat Khuzhin
bbb38664c1 jemalloc: add missing safety_check.c 2020-05-27 02:19:13 +03:00
Azat Khuzhin
b53c6ddfd9 jemalloc: bump to 5.2.1 2020-05-27 02:19:13 +03:00
Azat Khuzhin
734cc78e58 jemalloc: make include_linux_*/jemalloc/*.h common for aarch64 and x86_64 
This patch can go upstream, regardless of the jemalloc update
eventually.

Also I noticed that header with jemalloc version differs (someone forgot
to update?)
 2020-05-27 02:19:13 +03:00
Alexander Tokmakov
940132adc4 Merge branch 'master' into merging_external_source_cassandra 2020-05-27 00:13:57 +03:00
Alexander Tokmakov
310d522528 minimal implementation 2020-05-26 22:21:18 +03:00
alesapin
15e7c618bb Fix cctz linking with dirty hack 2020-05-26 22:21:07 +03:00
kssenii
ad1c0de8db Merge 2020-05-26 17:45:39 +00:00
Vitaly Baranov
e27ded8798
Merge pull request #11172 from vitlibar/grpc-improve-build-scripts 
Improve build scripts for protobuf & gRPC
 2020-05-26 13:27:54 +03:00
filimonov
73a0ef6c0e
Fix for the hang during deletion of engine=Kafka (one more time) (#11145) 
* Added flag for safer rdkafka destruction, but more testing detected another hang case, which has no straigt solutions and can be workarounded currenly only by draining the consumer queue, so destructor is back

* After review fixes

* After review fixes2

* After review fixes3
 2020-05-26 00:13:10 +03:00
Vitaly Baranov
58a2172154 Improve build scripts related to protobuf and gRPC. 2020-05-25 18:46:57 +03:00
Vitaly Baranov
aac48e0274 Update grpc to a new version. 2020-05-25 09:09:15 +03:00
Alexey Milovidov
35d79e1252 fmt-style logging, part 1 2020-05-23 19:33:07 +03:00
Alexander Tokmakov
ac54d470da Merge branch 'master' into merging_external_source_cassandra 2020-05-22 17:27:40 +03:00
Alexander Tokmakov
e6ca09e134 fix build 2020-05-22 17:19:33 +03:00
Alexey Milovidov
14b61cfa9e Fix JEMalloc conf after #11084 2020-05-22 16:08:08 +03:00
Azat Khuzhin
111fa49df5 Add comment for enabling jemalloc percpu_arena 2020-05-21 11:43:29 +03:00
Azat Khuzhin
5da41d5cd6 Configure jemalloc options via cmake 2020-05-21 11:43:29 +03:00
Azat Khuzhin
58ffa4c59c Enable percpu_arena:percpu for jemalloc 
This will reduce memory fragmentation due to thread pool.
 2020-05-21 01:01:28 +03:00
Alexander Tokmakov
4b30b3168c try fix build 2020-05-20 23:26:39 +03:00
kssenii
fe8d285e11 Fix libevent build 2020-05-20 12:52:16 +00:00
kssenii
a055e33087 Add libevent & AMQP-CPP libraries 2020-05-20 09:08:27 +03:00
Alexander Tokmakov
175b7aedf3 Merge branch 'master' into merging_external_source_cassandra 2020-05-19 05:21:27 +03:00
alexey-milovidov
5898f611da Merge pull request #10861 from traceon/contrib-openldap 
Add OpenLDAP third-party library integration (system or contrib/build)
 2020-05-15 23:13:23 +03:00
Denis Glazachev
bad61a659c Allow Linux aarch64 2020-05-15 15:15:13 +04:00
Denis Glazachev
b68664d332 Normalize CMAKE_SYSTEM_NAME and platform dependent folder names 2020-05-15 00:40:27 +04:00
Denis Glazachev
38320e6444 Normalize CMAKE_SYSTEM_PROCESSOR and platform dependent folder names 2020-05-15 00:25:27 +04:00
Denis Glazachev
3586fb1dc0 Clean and adjust the generated files 
Add FreeBSD amd64 generated files/support
 2020-05-14 23:53:11 +04:00
Nikolai Kochetov
757b0ecabb Update boost submodule. 2020-05-14 12:26:40 +03:00
alexey-milovidov
f8195a577c
Merge pull request #10744 from Jokser/s3-proxy-resolver 
S3 with proxy resolver
 2020-05-14 02:19:10 +03:00
Denis Glazachev
7b1399795d Merge commit '1a4ce6b3c806f77e548dacf4207e06542231fa19' into contrib-openldap 
* commit '1a4ce6b3c806f77e548dacf4207e06542231fa19':
  DOCS-628: Stable versions of statistical functions (#10848)
  Allow expected number of failures in performance test
  Fix test
  Fix LIVE VIEW tests
  Fix bad test
  Fix exception message after server shutdown (#10841)
  Preparation for MSan UBSan stress tests
  Improve tests for ALTER MOVE
  Fix bad tests
  Fix data rot @blinkov
  Documentation: fix broken link
  Fix infinite loop in test
 2020-05-14 01:39:12 +04:00
alesapin
612385d703 Revert "DOCS-628: Stable versions of statistical functions (#10848)" 
This reverts commit 1a4ce6b3c8.
 2020-05-13 16:32:36 +03:00
Denis Glazachev
1db8f3367a Link ldap[_r] with lber 2020-05-13 15:16:59 +04:00
BayoNet
1a4ce6b3c8
DOCS-628: Stable versions of statistical functions (#10848) 
* CLICKHOUSEDOCS-628: Mentioned Stable versions of staticsical functions.

* CLICKHOUSEDOCS-628: Sync from EN to RU.

* Update docs/ru/sql-reference/aggregate-functions/reference.md

Co-authored-by: Ivan Blinkov <github@blinkov.ru>

* Update docs/en/sql-reference/aggregate-functions/reference.md

Co-authored-by: Ivan Blinkov <github@blinkov.ru>

* CLICKHOUSEDOCS-628: Updated formatting.

Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
Co-authored-by: Ivan Blinkov <github@blinkov.ru>
 2020-05-13 09:08:35 +03:00
Denis Glazachev
36cb24377b Merge branch 'master' into contrib-openldap 
* master: (204 commits)
  DOCS-289: randConstant (#10838)
  Update performance_comparison.md
  fix docs build
  Adjust ld+json images, remove feather icons (#10843)
  [docs] faster local/debug build (#10840)
  CLICKHOUSE-4862: some markdown fixes @ ru mergetree.md (#10835)
  CLICKHOUSE-4862: fix link (#10836)
  Some fixes at ru merge-tree-settings.md (#10837)
  Fix MSan failure in cache dictionary
  Fix double whitespace
  Additional assert in ColumnVector
  Fix paths in compiler error messages #10434
  Fix "Arcadia" build
  Fix style check in Block::sortColumns() (sigh)
  Sort iterators to avoid extra std::string creation in Block::sortColumns()
  Optimize Block::sortColumns()
  Better DNS exception message
  Fix logical error in convertFieldToType
  Make order of columns strict in Block::sortColumns()
  Add a test for INSERT into Buffer() with different order of columns (via MV)
  ...
 2020-05-13 00:29:09 +04:00
Denis Glazachev
acd8cfc5d2 Added contrib/openldap submodule 
Added OpenLDAP find/detection cmake scripts
Added integration for OpenLDAP Linux and Darwin x86_64 platforms (following OpenSSL integration approach)
 2020-05-12 23:19:15 +04:00
Alexey Milovidov
b56e62ddf6 Better DNS exception message 2020-05-12 03:11:58 +03:00
alexey-milovidov
caced89773
Merge pull request #10794 from mnkonkova/grpc-cmake 
grpc protobuf
 2020-05-11 20:44:04 +03:00
mnkonkova
41d2e9d52d test 2020-05-11 12:12:54 +00:00
Alexey Milovidov
222f15a35a Update CPUID after changes were integrated to upstream 2020-05-11 09:21:26 +03:00
alexey-milovidov
aa70cc1d80
Merge pull request #10663 from ClickHouse/update-zstd 
Update zstd to 1.4.4
 2020-05-11 06:12:40 +03:00
mnkonkova
da004fba02 grpc protobuf 2020-05-11 01:38:46 +00:00
Alexey Milovidov
e8c646ebf5 Fix style 2020-05-10 03:49:05 +03:00
alexey-milovidov
4353d19e87
Merge pull request #10776 from ClickHouse/remove-unnecessarily-warning-suppressions 
Remove unnecessary warning suppressions
 2020-05-10 03:44:28 +03:00
Alexey Milovidov
c0e68df0ff Fix build 2020-05-10 02:06:03 +03:00
Alexey Milovidov
f0c517e4d1 Fix build 2020-05-10 02:05:35 +03:00
Alexey Milovidov
a576a4fbcd Enable extra warnings for base, utils, programs 2020-05-10 01:59:34 +03:00
Alexey Milovidov
99ceb12b19 Remove unnecessary warning suppressions #10396 2020-05-09 23:30:28 +03:00
Alexey Milovidov
f884306dbc Update zstd to 1.4.4 2020-05-09 21:31:01 +03:00
Alexey Milovidov
91ab871c11 Fix TSan report in CPUID 2020-05-09 21:10:50 +03:00
Amos Bird
e33fb54686
Fix libunwind 2020-05-09 05:44:57 +08:00
Ivan
85d783c247
Poco contrib refactoring (#10396) 
* Remove config_common.h
* Refactor libcpuid contrib
* Remove support for libcpuinfo
* Define USE_CPUID in Arcadia
* Refactor Poco libraries
 2020-05-08 17:11:19 +03:00
Pavel Kovalenko
215c9c617d Update AWS module. 2020-05-07 17:01:58 +03:00
Andrew Onyshchuk
5e0cccab15 Update contrib/poco 2020-05-05 20:41:04 -05:00
alexey-milovidov
443c64abc0
Merge pull request #10638 from ClickHouse/fix-ubsan-hashtable 
Fix UBSan report in HashTable
 2020-05-04 04:50:25 +03:00
Alexey Milovidov
80d5db2b8f Avoid UBSan reports from zstd 2020-05-03 22:27:12 +03:00
alexey-milovidov
add569364b
Merge branch 'master' into get_rid_of_external_linker 2020-05-03 18:49:43 +03:00
alexey-milovidov
8af997f3df
Merge pull request #10632 from ClickHouse/use-cmake-linker-for-blobs 
Allow to use lld to link blobs
 2020-05-03 18:34:02 +03:00
alesapin
6866601e2d Get rid of external linker call 2020-05-03 16:57:18 +03:00
alexey-milovidov
410f77dfce
Merge pull request #10631 from ClickHouse/fix-ubsan-report-lz4 
Fix UBSan report in LZ4 library
 2020-05-03 14:45:18 +03:00
alexey-milovidov
aeb5487261
Merge branch 'master' into xcode-build-fix 2020-05-03 05:03:49 +03:00
Alexey Milovidov
5bfadc6e90 Allow to use lld to link blobs 2020-05-03 05:01:57 +03:00
Alexey Milovidov
a1f55729be Fix UBSan report in LZ4 library 2020-05-03 04:37:30 +03:00
alexey-milovidov
071ccaaa62
Merge pull request #10630 from ClickHouse/update-lz4 
Update LZ4 to the latest dev
 2020-05-03 03:40:21 +03:00
alexey-milovidov
a235533d5f
Merge pull request #10576 from Jokser/s3-with-dynamic-proxies 
S3 with dynamic proxy configuration
 2020-05-03 01:25:13 +03:00
Alexey Milovidov
68f94e4ae7 Update LZ4 to the latest dev 2020-05-03 00:07:18 +03:00
Alexey Milovidov
81adcc9058 Remove obsolete records from system.build_options 2020-05-02 17:00:03 +03:00
Denis Glazachev
66adf60e1b Proper handling of CMAKE_BUILD_TYPE vs CMAKE_BUILD_TYPE_UC 2020-04-30 18:41:22 +04:00
Pavel Kovalenko
bd9a0792b5 Update AWS module 2020-04-29 11:40:29 +03:00
Denis Glazachev
f5600bb8ab Add comments for USE_FOLDERS and CMAKE_FOLDER 2020-04-27 22:34:36 +04:00
Denis Glazachev
22a00bd5a3 Enable organazing targets into folders for GUI-based IDEs 
Put all targets of contrib/ into contib/ folder in GUI IDE
 2020-04-27 21:50:26 +04:00
Denis Glazachev
bc11e05260 Link an empty dummy.c into base64 target, for Xcode to generate a library 2020-04-27 21:48:01 +04:00
Denis Glazachev
6b02bfadaf Use deduced paths to target executables 2020-04-27 21:46:41 +04:00
Alexey Milovidov
b46cb9be52 Update CCTZ 2020-04-26 19:27:34 +03:00
Alexey Milovidov
340ae71a41 Added missing modification for tzdata library 2020-04-23 03:42:49 +03:00
Alexey Milovidov
91f966610e Do not embed timezones on alien platforms 2020-04-22 20:11:36 +03:00
Alexey Milovidov
04cdb1a4b9 Remove duplicate symbols 2020-04-22 11:59:49 +03:00
Alexey Milovidov
5cf94cd7b9 Merge branch 'master' into embedded-time-zones 2020-04-22 11:52:24 +03:00
Alexey Milovidov
b205d7cdb2 Remove accidential dependency on Z3 2020-04-22 06:54:11 +03:00
Alexey Milovidov
45b5afa131 Avoid dependency on system tzdata 2020-04-22 06:17:29 +03:00
Amos Bird
2d08c8e4ab
clang-10 fix 2020-04-20 15:45:37 +08:00
Vitaly Baranov
d62345bbaa Show information about not loaded dictionaries in system.columns, system.tables 
and in "SHOW TABLES" executed in any database with the "Dictionary" engine.
 2020-04-18 12:50:54 +03:00
alexey-milovidov
17e7d4d88a
Merge pull request #10307 from abyss7/arcadia-4 
Changes for auto-sync with Arcadia
 2020-04-17 05:08:34 +03:00
Alexey Milovidov
f3fe13a794 Update submodule 2020-04-15 01:53:12 +03:00
Ivan Lezhankin
871d3f2aa0 Move contrib/widecharwidth → base/widechar_width 2020-04-13 18:55:48 +03:00
Ivan Lezhankin
910ab8a265 Move contrib/libpcg-random → base/pcg-random 2020-04-13 18:42:58 +03:00
Alexey Milovidov
ceb5c1964a Update cctz just in case #10211 2020-04-12 23:48:51 +03:00
Ivan
19bb2976b9
Update pdqsort to recent version (#10171) 2020-04-11 14:16:14 +03:00
Ivan
67235834b3
Update libdivide to v3.0 (#10169) 2020-04-11 14:14:01 +03:00
Vitaly Baranov
9208847a85 Update submodule libc-headers to a new version. 2020-04-11 00:07:08 +03:00
Avogar
7a96984dd8 Merge branch 'master' of github.com:ClickHouse/ClickHouse into msgpack_format 2020-04-04 16:44:44 +03:00
Alexander Tokmakov
cb933a3d19 fix races in 01108_restart_replicas_rename_deadlock 2020-04-03 03:08:51 +03:00
Ivan Lezhankin
26e81a2bbf Add dl library dependency 2020-03-31 21:58:00 +03:00
Ivan Lezhankin
db6e374d39 Fix build for ancient CMake 2020-03-30 15:06:30 +03:00
Kruglov Pavel
18daaf6de5
Merge branch 'master' into msgpack_format 2020-03-26 20:11:49 +03:00
Avogar
b02636f916 Add MsgPackRowInputFormat, msgpack-c contrib and tests. 2020-03-26 19:46:13 +03:00
Ivan Lezhankin
03d3332d43 Fix cmake for unbundled build 2020-03-22 13:51:58 +03:00
Ivan Lezhankin
362aca365f Merge branch 'master' into jemalloc 2020-03-21 22:50:48 +03:00
Ivan Lezhankin
86cb4811b5 Build shared jemalloc in splitted mode 2020-03-21 22:49:26 +03:00
Amos Bird
cf9ca33c88
using double width space to display newline ch 2020-03-21 21:46:32 +08:00
alexey-milovidov
5645c202e6
Merge pull request #9790 from amosbird/cg 
Better cli client
 2020-03-21 16:05:20 +03:00
Amos Bird
6fe1839f9e
Better cli client 2020-03-21 13:17:12 +08:00
Alexey Milovidov
e4192a0937 Update submodule 2020-03-21 05:02:19 +03:00
Alexey Milovidov
b8a66ec59d Update Poco 2020-03-20 21:55:03 +03:00
Alexander Kuzmenkov
d5822e7ebe
Merge pull request #6892 from ClickHouse/aku/poco-1.9.3 
Update Poco to 1.9.3.
 2020-03-20 06:03:48 +03:00
alexey-milovidov
fd81507a9b
Merge pull request #9753 from amosbird/ce 
correct highlighting for completion prefix
 2020-03-19 21:57:52 +03:00
Alexander Kuzmenkov
b3a4e4e58f Update Poco to 1.9.3 2020-03-19 19:05:41 +03:00
Amos Bird
412c9b6de0
correct highlighting for completion prefix 2020-03-19 19:16:05 +08:00
Ivan
571d0d541c
Improve CCTZ contrib (#9687) 
* common/Types.h → common/types.h
  Also split Core/Defines.h and merge with common/likely.h
* Improve cctz contrib
* Fix ALWAYS_INLINE and unbundled build
* Update Dockerfile from master
* Fix test for unbundled library
 2020-03-19 13:38:34 +03:00
Alexey Milovidov
c0f7e5c908 Revert "Removed always built target" 
This reverts commit 5983cf03a6.
 2020-03-19 01:22:04 +03:00
Alexey Milovidov
5983cf03a6 Removed always built target 2020-03-18 21:27:33 +03:00
Ivan Lezhankin
5a2e829489 Some fixes 2020-03-18 15:29:51 +03:00
Ivan Lezhankin
528e42bc4c Improve jemalloc contrib 2020-03-18 15:29:51 +03:00
Artem Zuikov
d7d9078183 fix build with dynamic libs 2020-03-13 20:19:28 +03:00
Ivan
b7ef5a699c
Move FastMemcpy to contribs (#9219) 
* Get rid of non-existent vectorclass
* Move FastMemcpy to contribs
* Restore comments
* Disable FastMemcpy on non-Linux
* Fix cmake file
* Don't build FastMemcpy for ARM64
* Replace FastMemcpy submodule with its contents
* Fix cmake file
* Move widechar_width to contrib/
* Move sumbur to contrib/
* Move consistent-hashing to contrib/
* Fix UBSan tests
 2020-03-13 01:26:16 +03:00
alexey-milovidov
beed841441
Merge branch 'master' into clang-tidy 2020-03-11 10:16:13 +03:00