Commit Graph

680 Commits

Author SHA1 Message Date
Alexey Milovidov
64e76a4a8d Minor changes in Decimal 2021-02-20 21:13:36 +03:00
kssenii
21ee685ef0 Fix brotly 2021-02-19 22:18:14 +00:00
Ivan
414f470c79
Make Poco HTTP Server zero-copy again (#19516)
* Refactoring: part 1

* Refactoring: part 2

* Handle request using ReadBuffer interface

* Struggles with ReadBuffer's

* Fix URI parsing

* Implement parsing of multipart/form-data

* Check HTTP_LENGTH_REQUIRED before eof() or will hang

* Fix HTTPChunkedReadBuffer

* Fix build and style

* Fix test

* Resist double-eof

* Fix arcadian build
2021-02-19 15:51:26 +03:00
Kruglov Pavel
794c3449ca
Merge branch 'master' into hedged-requests 2021-02-17 20:36:36 +03:00
Pavel Kruglov
1b78de2142 Use fibers in HedgedRequests 2021-02-17 20:34:52 +03:00
Nikita Mikhailov
6ee98ead05 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keen-wolf-filefuncwithreadbuf 2021-02-16 15:38:03 +03:00
Nikita Mikhailov
7c5d845866 refactor function 2021-02-16 15:37:49 +03:00
Nikita Mikhaylov
cb2beb475e
Merge pull request #20516 from nikitamikhaylov/more-checks-filesegmentation-engine
More checks in fileSegmentationEngine
2021-02-16 12:39:27 +03:00
Kruglov Pavel
598576ce70
Merge branch 'master' into hedged-requests 2021-02-15 16:51:45 +03:00
Nikita Mikhailov
d615b8e516 more checks
(cherry picked from commit b45168ecaf37d0061edfd12c67a8c5300d45d2e3)
2021-02-15 16:11:16 +03:00
alexey-milovidov
a299790522
Merge pull request #19748 from excitoon-favorites/s3ssec
Added Server Side Encryption Customer Keys support in S3 client
2021-02-15 15:23:14 +03:00
Nikita Mikhaylov
a77b740a7c
Merge pull request #20286 from nikitamikhaylov/json-import-bugfix
Error from allocator on JSON import
2021-02-15 12:40:09 +03:00
alesapin
9557bca4af
Merge pull request #20464 from azat/abnormal-server-termination-fix
Fix abnormal server termination when http client goes away
2021-02-15 11:10:29 +03:00
Azat Khuzhin
33f54cdb3c Fix abnormal server termination when http client goes away
In [1] stress tests found:

    2021.02.12 14:20:58.800988 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Debug> executeQuery: (from [::1]:45792, using production parser) (comment: /usr/share/clickhouse-test/queries/0_stateless/01520_client_print_query_id.expect) SELECT * FROM numbers(34599)
    2021.02.12 14:20:58.916484 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Trace> ContextAccess (default): Access granted: CREATE TEMPORARY TABLE ON *.*
    2021.02.12 14:20:59.071980 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Trace> InterpreterSelectQuery: FetchColumns -> Complete
    2021.02.12 14:21:10.708202 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Information> executeQuery: Read 34599 rows, 270.30 KiB in 11.876294055 sec., 2913 rows/sec., 22.76 KiB/sec.
    2021.02.12 14:22:10.506261 [ 17728 ] {de3e7894-b401-4f7d-8530-90cd5ab06682} <Debug> DynamicQueryHandler: Done processing query
    2021.02.12 14:22:18.238037 [ 375 ] {} <Fatal> BaseDaemon: (version 21.3.1.5996, build id: 8DBCED54529C989F7AD4D991F51410774D55DE6C) (from thread 17728) Terminate called for uncaught exception:
    Code: 24, e.displayText() = DB::Exception: Cannot write to ostream at offset 262994, Stack trace (when copying this message, always include the lines below):

    0. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/exception:0: Poco::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x15c976cb in /usr/bin/clickhouse
    1. ./obj-x86_64-linux-gnu/../src/Common/Exception.cpp:56: DB::Exception::Exception(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, bool) @ 0x8c9320e in /usr/bin/clickhouse
    2. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::nextImpl() @ 0x8d54da5 in /usr/bin/clickhouse
    3. ./obj-x86_64-linux-gnu/../src/IO/BufferBase.h:39: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x8d551d7 in /usr/bin/clickhouse
    4. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromOStream.cpp:44: DB::Write

    2021.02.12 14:22:18.811071 [ 18134 ] {} <Fatal> BaseDaemon: ########################################
    2021.02.12 14:22:18.878935 [ 18134 ] {} <Fatal> BaseDaemon: (version 21.3.1.5996, build id: 8DBCED54529C989F7AD4D991F51410774D55DE6C) (from thread 17728) (query_id: de3e7894-b401-4f7d-8530-90cd5ab06682) Received signal Aborted (6)
    2021.02.12 14:22:18.943148 [ 18134 ] {} <Fatal> BaseDaemon:
    2021.02.12 14:22:19.007073 [ 18134 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f109932018b 0x7f10992ff859 0x8bb33ae 0x8e301dd 0x17dac8c4 0x17dac7c7 0x8c3fe0b 0x8d552c5 0x8d552ea 0x11a29914 0x11a2a2ca 0x12f96092 0x12f8c65e 0x12f84300 0x15b84110 0x15bc0913 0x15bc103f 0x15d29a12 0x15d27fb0 0x15d267b8 0x8badbad 0x7f10994d5609 0x7f10993fc293
    2021.02.12 14:22:19.255998 [ 18134 ] {} <Fatal> BaseDaemon: 5. raise @ 0x4618b in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.02.12 14:22:19.270203 [ 18134 ] {} <Fatal> BaseDaemon: 6. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.02.12 14:22:50.108918 [ 370 ] {} <Fatal> Application: Child process was terminated by signal 6.

  [1]: https://clickhouse-test-reports.s3.yandex.net/19580/6aecb62416ece880cbb8ee3a803e14d841388dde/stress_test_(thread).html#fail1

Verified locally by commenting out->next() call in
WriteBufferFromHTTPServerResponse::nextImpl(), adding a sleep(1) and
canceling HTTP request before it finished, the stacktrace as follow:

    [ 6351 ] {} <Fatal> BaseDaemon: (version 21.3.1.1, build id: 9B40466BF3D2F5AED78A52A995A4A2FD3116787C) (from thread 6677) Terminate called for uncaught exception:
    Code: 24, e.displayText() = DB::Exception: Cannot write to ostream at offset 4, Stack trace (when copying this message, always include the lines below):

    0. /src/ch/clickhouse/.cmake/../src/Common/StackTrace.cpp:298: StackTrace::tryCapture() @ 0x30a52a in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    1. /src/ch/clickhouse/.cmake/../src/Common/StackTrace.cpp:260: StackTrace::StackTrace() @ 0x30a4e5 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    2. /src/ch/clickhouse/.cmake/../src/Common/Exception.cpp:53: DB::Exception::Exception(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, int, bool) @ 0x2a61ae in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    3. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromOStream.cpp:22: DB::WriteBufferFromOStream::nextImpl() @ 0x3b468a in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    4. /src/ch/clickhouse/.cmake/../src/IO/WriteBuffer.h:47

    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 7. __cxxabiv1::__terminate(void (*)()) @ 0x1784ca in /src/ch/clickhouse/.cmake/contrib/replxx-cmake/libreplxxd.so
    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 10. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromOStream.cpp:0: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x3b48c1 in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    [ 8966 ] {} <Fatal> BaseDaemon: 11. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromOStream.cpp:44: DB::WriteBufferFromOStream::~WriteBufferFromOStream() @ 0x3b48ec in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 14. /src/ch/clickhouse/.cmake/../src/IO/WriteBufferFromHTTPServerResponse.cpp:218: DB::WriteBufferFromHTTPServerResponse::~WriteBufferFromHTTPServerResponse() @ 0x3b33cd in /src/ch/clickhouse/.cmake/src/libclickhouse_common_iod.so
    <snip>
    [ 8966 ] {} <Fatal> BaseDaemon: 22. /src/ch/clickhouse/.cmake/../src/Server/HTTPHandler.h:43: DB::HTTPHandler::Output::~Output() @ 0x260421 in /src/ch/clickhouse/.cmake/src/libclickhouse_serverd.so
    [ 8966 ] {} <Fatal> BaseDaemon: 23. /src/ch/clickhouse/.cmake/../src/Server/HTTPHandler.cpp:778: DB::HTTPHandler::handleRequest(Poco::Net::HTTPServerRequest&, Poco::Net::HTTPServerResponse&) @ 0x253fd4 in /src/ch/clickhouse/.cmake/src/libclickhouse_serverd.so
2021-02-13 13:23:03 +03:00
Azat Khuzhin
fa329808e5 Call next() from sync()/finalize() in WriteBuffer 2021-02-13 13:14:11 +03:00
alexey-milovidov
dc3ffd3fe2
Merge pull request #19451 from azat/safe-writes
Do not silently ignore write errors
2021-02-11 21:19:11 +03:00
Nikita Mikhailov
6c9f5e4991 try 2021-02-10 17:16:27 +03:00
alesapin
cb1194d37a Add final to some classes 2021-02-09 12:05:54 +03:00
alexey-milovidov
ed5a81ab59
Merge pull request #20078 from abyss7/better-read-buffers-4
LimitReadBuffer: check that position always advances
2021-02-07 07:33:08 +03:00
alexey-milovidov
f2ab4f2ce9
Merge pull request #20037 from abyss7/better-read-buffers-2
ReadBuffer: check for unread data on next()
2021-02-07 01:33:06 +03:00
alexey-milovidov
417cfcd698
Update ReadBuffer.h 2021-02-07 01:31:20 +03:00
Ivan Lezhankin
8953fe1eb2 Fix seekable buffer 2021-02-06 19:30:46 +03:00
Pavel Kruglov
f946aab759 Merge branch 'master' of github.com:ClickHouse/ClickHouse into hedged-requests 2021-02-06 17:38:56 +03:00
Pavel Kruglov
0704d3cf27 Refactor 2021-02-06 03:54:27 +03:00
alesapin
011109c82a
Merge pull request #17348 from xjewer/alex/CLICKHOUSE-606_deduplication_UUID
CLICKHOUSE-606: query deduplication based on parts' UUID
2021-02-05 22:47:34 +03:00
Ivan Lezhankin
16d399aa35 Another build fix 2021-02-05 13:31:18 +03:00
Ivan
d135a727e2
Merge branch 'master' into better-read-buffers-2 2021-02-05 02:17:05 +03:00
Ivan Lezhankin
d59b45e496 Fix build 2021-02-05 02:14:17 +03:00
Azat Khuzhin
98e3a99a88 Do not catch exceptions during final flush in writers destructors
Since this hides real problems, since destructor does final flush and if
it fails, then data will be lost.

One of such examples if MEMORY_LIMIT_EXCEEDED exception, so lock
exceptions from destructors, by using
MemoryTracker::LockExceptionInThread to block these exception, and allow
others (so std::terminate will be called, since this is c++11 with
noexcept for destructors by default).

Here is an example, that leads to empty block in the distributed batch:

    2021.01.21 12:43:18.619739 [ 46468 ] {7bd60d75-ebcb-45d2-874d-260df9a4ddac} <Error> virtual DB::CompressedWriteBuffer::~CompressedWriteBuffer(): Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 332.07 GiB (attempt to allocate chunk of 4355342 bytes), maximum: 256.00 GiB, Stack trace (when copying this message, always include the lines below):

    0. DB::Exception::Exception<>() @ 0x86f7b88 in /usr/bin/clickhouse
    ...
    4. void DB::PODArrayBase<>::resize<>(unsigned long) @ 0xe9e878d in /usr/bin/clickhouse
    5. DB::CompressedWriteBuffer::nextImpl() @ 0xe9f0296 in /usr/bin/clickhouse
    6. DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0xe9f0415 in /usr/bin/clickhouse
    7. DB::DistributedBlockOutputStream::writeToShard() @ 0xf6bed4a in /usr/bin/clickhouse
2021-02-05 01:31:45 +03:00
Ivan
0db2aa3c2e
Check that position doesn't go beyond end (#20039) 2021-02-05 01:21:24 +03:00
Ivan Lezhankin
84b88c6802 CC 2021-02-04 22:06:43 +03:00
Ivan Lezhankin
2b9909d396 Merge remote-tracking branch 'upstream/master' into better-read-buffers-2 2021-02-04 21:51:23 +03:00
Ivan Lezhankin
bcbe6f209c Merge branch 'better-read-buffers-1' into better-read-buffers-2 2021-02-04 21:50:31 +03:00
Ivan Lezhankin
610d7b755b Don't forget to update position of inner buffer 2021-02-04 21:50:15 +03:00
Ivan Lezhankin
ee0ff755e2 Check that position always advances 2021-02-04 17:46:46 +03:00
Azat Khuzhin
ca071381e1 Merge remote-tracking branch 'upstream/master' into writer-partial-buffer 2021-02-03 23:46:39 +03:00
Ivan Lezhankin
72b0a18503 Check for unread data on next() 2021-02-03 15:37:32 +03:00
Ivan Lezhankin
b0f400ca1b Reset internal buffer position on next() 2021-02-03 15:31:45 +03:00
tavplubix
b24f73fd88
remove outdated comment 2021-02-03 13:27:41 +03:00
Aleksei Semiglazov
921518db0a CLICKHOUSE-606: query deduplication based on parts' UUID
* add the query data deduplication excluding duplicated parts in MergeTree family engines.

query deduplication is based on parts' UUID which should be enabled first with merge_tree setting
assign_part_uuids=1

allow_experimental_query_deduplication setting is to enable part deduplication, default ot false.

data part UUID is a mechanism of giving a data part a unique identifier.
Having UUID and deduplication mechanism provides a potential of moving parts
between shards preserving data consistency on a read path:
duplicated UUIDs will cause root executor to retry query against on of the replica explicitly
asking to exclude encountered duplicated fingerprints during a distributed query execution.

NOTE: this implementation don't provide any knobs to lock part and hence its UUID. Any mutations/merge will
update part's UUID.

* add _part_uuid virtual column, allowing to use UUIDs in predicates.

Signed-off-by: Aleksei Semiglazov <asemiglazov@cloudflare.com>

address comments
2021-02-02 16:53:39 +00:00
Azat Khuzhin
f3a56b965c Add deebug assertion for empty working buffer in WriteBuffer 2021-02-02 01:56:00 +03:00
Azat Khuzhin
63a8f463f9 Allow writing partial buffer
In #6012 the behavior of the WriteBuffer has been changed.

Before, WriteBuffer write the data when next() is called.
After, WriteBuffer will write the data if, and only if, the buffer is
full.

See the discussion here [1].

  [1]: https://github.com/ClickHouse/ClickHouse/pull/6012#discussion_r567320267
2021-02-02 00:23:55 +03:00
Alexey Milovidov
49979afbc1 Fix bad translation 2021-02-01 10:12:14 +03:00
Alexander Kuzmenkov
f42aefc4a4
Merge pull request #19750 from excitoon-favorites/s3betterglobs
Used global region for accessing S3 if can't determine exactly
2021-01-29 23:44:14 +03:00
Pavel Kruglov
25e85d71ee Merge branch 'master' of github.com:ClickHouse/ClickHouse into hedged-requests 2021-01-29 21:08:47 +03:00
Maksim Kita
03eec39719
Merge pull request #19712 from kitaisreal/added-functions-parse-date-time-best-effort-us-or-zero-or-null
Added functions parseDateTimeBestEffortUSOrZero, parseDateTimeBestEffortUSOrNull
2021-01-28 11:13:45 +03:00
Vladimir Chebotarev
579f8da573 Added SSE-C support in S3 client. 2021-01-28 09:32:41 +03:00
alexey-milovidov
7c240d0ca7
Merge pull request #17870 from excitoon-favorites/s3testiostream
Update of AWS C++ SDK
2021-01-28 07:12:52 +03:00
Vladimir Chebotarev
76e62739ed Fixed build. 2021-01-27 23:05:41 +03:00
Maksim Kita
9db9ce11dc Added functions parseDateTimeBestEffortUSOrZero, parseDateTimeBestEffortUSOrNull 2021-01-27 17:10:06 +03:00
Vladimir Chebotarev
afdea5eff0 Changed handling of PocoHTTPClientConfiguration in order to ensure AWS SDK is initialized. 2021-01-27 09:38:35 +03:00
Alexey Milovidov
093108bf81 Normalize BigInt implementation 2021-01-27 03:54:57 +03:00
Alexey Milovidov
d296424dfa Remove even more code 2021-01-26 22:39:03 +03:00
Alexey Milovidov
877be11398 Remove useless code, part 2 2021-01-26 21:32:46 +03:00
Vladimir Chebotarev
3322cc812d Updated AWS C++ SDK. 2021-01-26 20:58:02 +03:00
alexey-milovidov
3fffa16aab
Update src/IO/HTTPCommon.cpp
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
2021-01-23 00:43:02 +03:00
Azat Khuzhin
d1d82bc897 Fix build with unbundled poco
Refs: #13405
Cc: @excitoon
2021-01-22 21:35:48 +03:00
tavplubix
49e1321df4
Merge pull request #19072 from ClickHouse/fix_19021
Fix checkpoint in PeekableReadBuffer over ConcatReadBuffer
2021-01-22 21:00:04 +03:00
Azat Khuzhin
e4350e078c Add ability to distinguish remote exceptions from local 2021-01-20 01:10:17 +03:00
Pavel Kruglov
97b5179e55 Implement HedgedRequests 2021-01-19 22:41:05 +03:00
Alexander Kuzmenkov
c153268da7 Make -- { echo } hint preserve leading comments. 2021-01-18 15:15:46 +03:00
Alexander Kuzmenkov
d22c04568d
Merge pull request #13405 from excitoon-favorites/s3keepalive
Connection pools for S3
2021-01-18 12:52:37 +03:00
alexey-milovidov
141b5e23b2
Merge pull request #19136 from amosbird/removeuseless
Remove useless code
2021-01-16 11:04:55 +03:00
Amos Bird
8b079674a9
Remove useless code 2021-01-16 00:37:41 +08:00
tavplubix
fb6d1dc18e
Merge pull request #18979 from ClickHouse/fix_18690
Remove unread data limit from PeekableReadBuffer
2021-01-15 13:43:50 +03:00
alexey-milovidov
2760006415
Update gtest_peekable_read_buffer.cpp 2021-01-14 22:29:34 +03:00
Alexander Tokmakov
547c7af1b1 fix checkpoint in PeekableReadBuffer over ConcatReadBuffer 2021-01-14 17:38:59 +03:00
Alexander Tokmakov
f9ee3f8178 update test 2021-01-14 14:09:13 +03:00
alesapin
2683bbc0f7 Disable lint for test 2021-01-13 18:35:35 +03:00
Alexander Tokmakov
6c4be506fd add test 2021-01-13 16:43:42 +03:00
alesapin
c84a8c4b16 Fix manipulators for common string types 2021-01-13 15:47:34 +03:00
Alexander Tokmakov
111f4d49e3 remove unread data limit from PeekableReadBuffer 2021-01-12 21:55:12 +03:00
Alexey Milovidov
c38dca155c Fix clang-tidy 2021-01-10 05:51:54 +03:00
Alexey Milovidov
6eb5a5f4d9 Remove useless code 2021-01-10 03:28:59 +03:00
Azat Khuzhin
53268d9f05 Fix fsync_after_insert by not closing fd from finalize()
But this may cause troubles, another option will be to split finalize()
into finalize(bool sync) and finalizeImpl()

This was introduced in #8356
2021-01-07 19:30:10 +03:00
Vladimir Chebotarev
ad6fe2a8b1 Build fix. 2021-01-05 13:34:55 +03:00
Vladimir Chebotarev
59fb76e8bc Fix. 2021-01-05 13:34:55 +03:00
Vladimir Chebotarev
5cbc25c647 Added global setting s3_max_connections. 2021-01-05 13:34:55 +03:00
Alexey Milovidov
12a0ef907e Slightly better 2021-01-04 21:07:52 +03:00
Alexey Milovidov
d88d3de0d1 Fix UBSan report: applying non-zero offset to nullptr 2021-01-04 02:31:47 +03:00
Nikita Mikhailov
ffd73082ba fix memory and add comment 2020-12-30 01:34:26 +03:00
Nikita Mikhailov
c3288c3fbf Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel-parsing-input-format 2020-12-28 15:09:37 +03:00
alexey-milovidov
230f9b6ad4
Merge pull request #18449 from vladimir-golovchenko/fix-AM-abbreviation-handling-for-parseDateTimeBestEffort
Bug fix '#18402 parseDateTimeBestEffort should not ignore AM abbreviation for 12th hour'
2020-12-25 22:32:43 +03:00
Yatsishin Ilya
ce1e2b18a3 Fix codespell warnings. Split style checks. Update style checks docker 2020-12-24 13:17:52 +03:00
vladimir golovchenko
ed4fe206aa Fixed the parseDateTimeBestEffort*-functions to correctly handle '12 am' time. 2020-12-23 18:10:00 -08:00
Nikita Mikhaylov
c005dcdd26
Merge pull request #17641 from nikitamikhaylov/parallel_row_numbers
Added an offset to exception message for parallel parsing
2020-12-23 17:24:35 +03:00
Nikolai Kochetov
af7f5c9518
Merge pull request #17868 from ClickHouse/async-read-from-socket
Async read from socket
2020-12-23 12:20:42 +03:00
Nikita Mikhailov
dcfbe782c6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel-parsing-input-format 2020-12-23 05:20:22 +03:00
Nikita Mikhailov
138b74aa3b better 2020-12-23 01:04:02 +03:00
nikitamikhaylov
c60c161168 add ParsingException 2020-12-23 01:02:01 +03:00
Denis Glazachev
0c39539c76 Apply path workaround on actual uri_ argument
Print out actual uri_ argument being used
2020-12-21 03:29:11 +04:00
Nikolai Kochetov
01c8d5dccc Use replace fiber to callback in ReadBufferFromPocoSocket 2020-12-18 17:24:44 +03:00
Nikita Mikhailov
6a55e018e4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel-parsing-input-format 2020-12-18 02:25:32 +03:00
Nikita Mikhaylov
aa7793e38f
Merge pull request #18084 from nikitamikhaylov/fix-arcadia-third
Try to fix Arcadia
2020-12-18 01:54:42 +03:00
alesapin
799997db35
Merge pull request #16621 from arenadata/ADQM-148
HDFS configuration and Kerberos Authenticaiton
2020-12-17 23:16:58 +03:00
nikitamikhaylov
d198f03301 suppress warnings 2020-12-17 18:46:26 +03:00
nikitamikhaylov
d70f58a98f remove ryu 2020-12-17 00:52:04 +03:00
Maksim Kita
685099af7f Move getPageSize in common 2020-12-17 00:23:41 +03:00
nikitamikhaylov
50c29d9ed0 better 2020-12-16 18:34:29 +03:00
nikitamikhaylov
18d52dbc63 better 2020-12-16 14:55:33 +03:00
nikitamikhaylov
20aaf48e38 pragmas 2020-12-16 14:55:33 +03:00
nikitamikhaylov
5c4e1d1db5 better 2020-12-16 14:55:33 +03:00
nikitamikhaylov
3288f1fd0c ya make 2020-12-16 14:55:33 +03:00
nikitamikhaylov
c3a6499f6d fix ya.make 2020-12-16 14:55:33 +03:00
Ilya Golshtein
7e97814859 cleanup, fixes, new submodules, ShellCommand, WriteBufferFromString 2020-12-16 14:48:33 +03:00
Ilya Golshtein
d1d657335b USE_INTERNAL_HDFS3_LIBRARY + bash lint 2020-12-16 14:48:33 +03:00
Ilya Golshtein
d9166a0645 HADOOP_SECURE_DN_USER way, kinit thread, docker capabilities 2020-12-16 14:48:33 +03:00
Ilya Golshtein
185ac744b1 kerberized hdfs compiled 2020-12-16 14:48:33 +03:00
Maksim Kita
7d23451e81 Replaced usages of 4096 constant with getPageSize 2020-12-16 13:46:28 +03:00
Maksim Kita
dbb2fbcdd5 Unified usages of getPageSize
1. Introduced getPageSize function.
2. Replaced usages of getpagesize with getPageSize function.
3. Replaced usages of sysconf(_SG_PAGESIZE) with getPageSize function.
2020-12-16 13:42:23 +03:00
Maksim Kita
058fbd5222 MMapReadBufferFromFileDescriptor use getpagesize 2020-12-16 13:42:23 +03:00
Nikolai Kochetov
4905201985 Merge branch 'master' into async-read-from-socket 2020-12-15 21:04:47 +03:00
nikitamikhaylov
4ff1be6e25 better 2020-12-15 00:56:47 +03:00
nikitamikhaylov
5b7af8aa9c add extremes and totals 2020-12-15 00:56:47 +03:00
Nikita Mikhaylov
da43504654 better 2020-12-15 00:56:47 +03:00
Nikita Mikhaylov
9922324787 it works 2020-12-15 00:56:47 +03:00
Nikita Mikhaylov
9f127a46c7 first try 2020-12-15 00:56:47 +03:00
Nikita Mikhaylov
0a508c7b8a save 2020-12-15 00:56:46 +03:00
alexey-milovidov
91be7a6f27
Merge pull request #16809 from kitaisreal/read-float-8digits-unroll-performance-improvement
ReadFloat 8digits unroll performance improvement
2020-12-14 23:03:21 +03:00
alexey-milovidov
363ff79cca
Merge pull request #17934 from Jokser/s3-adaptive-single-part-upload
Adaptive choose of single/multi part upload in WriteBufferFromS3
2020-12-14 23:00:43 +03:00
Nikolai Kochetov
8de5cd5bc7 Merge branch 'master' into async-read-from-socket 2020-12-14 17:45:38 +03:00
Nikolai Kochetov
e295dfe6e3 Use ucontext for asan 2020-12-14 17:42:08 +03:00
Nikolai Kochetov
116bed2cfd Fixing build. 2020-12-14 17:42:00 +03:00
alexey-milovidov
60efab623d
Update S3Common.cpp 2020-12-14 13:53:40 +03:00
Vladimir Chebotarev
418c974eaf
Fixed std::out_of_range: basic_string in S3 URL parsing. 2020-12-14 11:17:29 +03:00
Pavel Kovalenko
346c241c20 Merge remote-tracking branch 'origin/master' into s3-adaptive-single-part-upload
# Conflicts:
#	src/Disks/S3/DiskS3.cpp
2020-12-14 11:00:30 +03:00
alexey-milovidov
5da9315ceb
Update readFloatText.h 2020-12-14 05:22:17 +03:00
alexey-milovidov
66b2424e33
Update readFloatText.h 2020-12-14 05:20:00 +03:00
alexey-milovidov
04e222f6f3
Merge pull request #17986 from azat/fwd-decl
More forward declaration for generic headers
2020-12-13 01:12:05 +03:00
alexey-milovidov
2eabd41749
Merge pull request #17659 from nautaa/master
add function to escape charaters for XML
2020-12-12 23:43:41 +03:00
Azat Khuzhin
5b3ab48861 More forward declaration for generic headers
The following headers are pretty generic, so use forward declaration as
much as possible:
- Context.h
- Settings.h
- ConnectionTimeouts.h
(Also this shows that some missing some includes -- this has been fixed)

And split ConnectionTimeouts.h into ConnectionTimeoutsContext.h (since
module part cannot be added for it, due to recursive build dependencies
that will be introduced)

Also remove Settings from the RemoteBlockInputStream/RemoteQueryExecutor
and just pass the context, since settings was passed only in speicifc
places, that can allow making a copy of Context (i.e. Copier).

Approx results (How much units will be recompiled after changing file X?):

- ConnectionTimeouts.h
  - mainline: 100

- Context.h:
  - mainline: ~800
  - patched:  415

- Settings.h:
  - mainline: 900-1K
  - patched:  440 (most of them because of the Context.h)
2020-12-12 17:43:10 +03:00
Pavel Kovalenko
59a5e63417 Merge remote-tracking branch 'origin/master' into s3-adaptive-single-part-upload
# Conflicts:
#	src/Disks/S3/DiskS3.cpp
#	src/Disks/S3/DiskS3.h
#	src/Disks/S3/registerDiskS3.cpp
#	src/IO/WriteBufferFromS3.cpp
#	src/IO/WriteBufferFromS3.h
2020-12-11 18:28:41 +03:00
Kruglov Pavel
6300cd285f
Merge pull request #17909 from Jokser/disk-s3-send-metadata
Ability to set metadata when put S3 object
2020-12-11 17:01:14 +03:00
nauta
00dc104025 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse 2020-12-11 16:15:40 +08:00
alexey-milovidov
f7d1441858
Update WriteHelpers.h 2020-12-11 00:09:52 +03:00
nikitamikhaylov
17310c6c50 fix-arcadia 2020-12-10 21:08:16 +03:00
Kruglov Pavel
9a785dbbf5
Merge branch 'master' into disk-s3-send-metadata 2020-12-10 20:17:41 +03:00
nikitamikhaylov
955033d6a1 done 2020-12-10 16:18:37 +03:00
Vladimir Chebotarev
39d867e56d
Added proper authentication for S3 client (#16856) 2020-12-10 12:19:42 +03:00
Nikolai Kochetov
0e44a22f43 Fixing build. 2020-12-09 19:17:59 +03:00
Nikolai Kochetov
32b38f389e Merge branch 'master' into async-read-from-socket 2020-12-09 17:15:36 +03:00
Nikolai Kochetov
156f44808f Fixing crash. 2020-12-09 17:11:45 +03:00
Pavel Kovalenko
db7a87089b Adaptive choose of single/multi part upload in WriteBufferFromS3. 2020-12-09 17:09:04 +03:00
alexey-milovidov
e127636a4b
Merge pull request #16787 from kitaisreal/fast-float-integration
FastFloat library integration
2020-12-08 21:34:34 +03:00
Pavel Kovalenko
dfbb31174e Ability to set metadata when put S3 object 2020-12-08 21:31:57 +03:00
alexey-milovidov
ab10cb4bf9
Merge pull request #17707 from ClickHouse/quota-by-x-forwarded-for
Allow quotas to be keyed by proxy-forwarded IP address; add support for PROXY protocol
2020-12-08 14:48:05 +03:00
Nikolai Kochetov
7d77a7ba24
Merge pull request #16952 from Enmk/DateTime64_fixes_comparison
Fixed comparison of DateTime64 with different scales
2020-12-08 12:40:41 +03:00
Maksim Kita
a9a6517291 Fixed style 2020-12-07 19:26:38 +03:00
Alexey Milovidov
1ed329017b Merge branch 'master' into quota-by-x-forwarded-for 2020-12-07 18:22:19 +03:00
Maksim Kita
b0afa8488d Updated parse float precise implementation 2020-12-07 17:23:02 +03:00
Maksim Kita
c3864d2fbf Updated contrib CMakeLists 2020-12-07 14:08:19 +03:00
Maksim Kita
b6bfb1cf20 Use fast_float by default 2020-12-06 23:37:36 +03:00
Maksim Kita
5f410718ca Fix marker check 2020-12-06 23:37:35 +03:00
Maksim Kita
ccbfd52315 Fixed compile issues 2020-12-06 23:37:35 +03:00
Maksim Kita
095137b9f7 FastFloat conditional replace precise parsing 2020-12-06 23:37:35 +03:00
Maksim Kita
87c50602bc Fast float updated implementation 2020-12-06 23:37:35 +03:00
Maksim Kita
7d97f23db4 Fixed point 2020-12-06 23:37:35 +03:00
Maksim Kita
80d66b8868 FastFloat library integration 2020-12-06 23:37:35 +03:00
alexey-milovidov
878864602c
Merge pull request #17831 from kitaisreal/dragonbox-integration
DragonBox integration
2020-12-06 22:58:56 +03:00
alexey-milovidov
614420feb9
Merge pull request #17794 from excitoon-favorites/s3testiostream
Attempt to use IOStream in AWS SDK
2020-12-06 16:42:12 +03:00
nauta
8e615a1d8d Merge remote-tracking branch 'upstream/master' 2020-12-06 20:48:47 +08:00
Maksim Kita
977da3d052 Removed ryu 2020-12-06 15:39:39 +03:00
Maksim Kita
64549702a2 DragonBox integration 2020-12-06 00:32:03 +03:00
Vladimir Chebotarev
a5e3d89649 Attempt to use IOStream in AWS SDK. 2020-12-04 13:37:08 +03:00
Ivan
6a48d25b74
Fix arcadian build (#17781) 2020-12-04 02:32:17 +03:00
alexey-milovidov
9d7667dada
Update ReadHelpers.h 2020-12-03 16:24:32 +03:00
Nikolai Kochetov
082a496364 Add async read to RemoteQueryExecutor 2020-12-03 15:21:10 +03:00
Alexey Milovidov
3e2447391b Support for PROXY protocol 2020-12-03 00:05:51 +03:00
alexey-milovidov
85f4045160
Merge pull request #17144 from fibersel/issue-16791
introduce zstd compression (for data import/export)
2020-12-02 22:41:07 +03:00
Nikolai Kochetov
e3946bc2b5 Add async read to RemoteQueryExecutor. 2020-12-02 20:02:14 +03:00
nautaa
4cc56c2501 rename function name 2020-12-02 17:00:27 +08:00
nautaa
eb0c442763 add function to escape charaters for HTML 2020-12-01 16:32:09 +08:00
Vasily Nemkov
87945fb68b Merge branch 'master' into HEAD 2020-11-30 23:25:57 +03:00
tavplubix
db3918d88d
Merge pull request #16861 from Jokser/disk-s3-proxy-tunnel-mode
Support HTTP proxy and HTTPS S3 endpoint configuration
2020-11-30 16:05:12 +03:00
a.palagashvili
1e71725143 fix typo 2020-11-29 16:02:04 +03:00
a.palagashvili
9c5640f443 merged 2020-11-29 15:19:19 +03:00
a.palagashvili
7a20fad305 added errors checking, removed redundant variables 2020-11-29 15:17:19 +03:00
a.palagashvili
502355922d added errors checking, removed redundant variables 2020-11-29 15:14:42 +03:00
a.palagashvili
7b886252ac added errors checking, removed redundant variables 2020-11-29 15:08:28 +03:00
Alexander Kuzmenkov
edce1e636e
Merge pull request #16535 from ClickHouse/aku/opentelemetry
OpenTelemetry improvements
2020-11-25 14:10:17 +03:00
Vitaly Baranov
08b3707842
Merge pull request #15111 from vitlibar/grpc-protocol
Implement GRPC protocol.
2020-11-25 09:00:32 +03:00
Alexander Kuzmenkov
1d7dcef4a0 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-24 21:45:10 +03:00
Alexander Kuzmenkov
8de415861f
Merge pull request #17206 from ClickHouse/aku/noescape
Remove escaping from toString(std::string)
2020-11-24 21:23:39 +03:00
Vitaly Baranov
93459d854b Fix WriteBufferFromVector: restart() now resize empty container to initial_size
because WriteBufferFromVector can't operate with empty container.
2020-11-24 17:53:34 +03:00
alesapin
45f09fe293
Merge pull request #17220 from ianton-ru/s3_max_redirects
S3 max redirects
2020-11-24 12:13:10 +03:00
Alexander Kuzmenkov
951a59eff7 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-23 21:00:22 +03:00
Anton Ivashkin
aa208a9d9f Use only 's3_max_redirect' in params instead of all settings 2020-11-23 14:02:17 +03:00
Vladimir Chebotarev
b3e2ebbaa5 Used global region for accessing S3 if can't determine exactly. 2020-11-23 08:19:38 +03:00
alexey-milovidov
203db68250
Update ZstdDeflatingWriteBuffer.cpp 2020-11-23 07:14:41 +03:00
alexey-milovidov
945aa009ad
Update ZstdDeflatingWriteBuffer.h 2020-11-23 07:13:02 +03:00
alexey-milovidov
d47cf8c919
Update ZstdInflatingReadBuffer.cpp 2020-11-23 07:11:52 +03:00
Alexey Milovidov
fbbf439338 Merge branch 'master' into Enmk-DateTime64_fixes_comparison 2020-11-23 05:46:17 +03:00
tavplubix
3e335c1e95
Merge pull request #17091 from zhang2014/fix/binlog_checksum
Fix MaterializeMySQL SYNC failure when modify binlog_checksum
2020-11-20 13:25:14 +03:00
Anton Ivashkin
a7d4f4be65 Add 's3_max_redirects' test 2020-11-20 11:18:44 +03:00
Alexander Kuzmenkov
7fa779c2ef Remove escaping from toString(std::string)
This is just confusing, I'd expect it to be an identity. It looks
especially weird when you do something like `toString(Field("don't escape
me"))`. Let's see which tests are going to fail.
2020-11-19 18:26:44 +03:00
zhang2014
bed93ef713 Try fix review comment 2020-11-19 12:02:43 +08:00
Alexander Kuzmenkov
f2b3f5f8b6 Allow formatting named tuples as JSON objects 2020-11-18 13:38:30 +03:00
a.palagashvili
22f147ab0f added newline, fixed initialization in constructor 2020-11-17 23:14:22 +03:00
Alexander Kuzmenkov
b16c5a1748 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-17 22:54:54 +03:00
a.palagashvili
b737a5ea9f added newlines, fixed formatting 2020-11-17 21:36:18 +03:00
a.palagashvili
6f5390cc70 introduce zstd compression 2020-11-17 19:02:10 +03:00
zhang2014
cc0134f361 Try fix asan build 2020-11-17 23:29:02 +08:00
Alexey Milovidov
24f4fa6edf Follow Arcadia ya.make rules 2020-11-17 00:16:50 +03:00
Alexey Milovidov
3df04ce0c2 Follow Arcadia ya.make rules 2020-11-16 21:24:58 +03:00
zhang2014
6ef93ac73c Try fix MaterializeMySQL SYNC with modify binlog_checksum 2020-11-16 21:46:36 +08:00
Maksim Kita
437bbef5b9 Fix marker check 2020-11-15 13:07:23 +03:00
Maksim Kita
1b9c20a5df ReadFloat 8digits unroll performance improvement 2020-11-15 13:07:23 +03:00
Anton Ivashkin
15b5d3a55a Merge master 2020-11-13 19:32:35 +03:00
Anton Ivashkin
026f7e0a27 Add 's3_max_redirects' setting 2020-11-13 19:31:51 +03:00
Vasily Nemkov
eb9604ecd0 Fixed comparison of DateTime4 with different scales
Made DateTime64 a stand-alone type rather than typedef to allow function resolution/deduction based on type.
Added tests.
2020-11-12 23:32:16 +03:00
Nikolai Kochetov
75e78026de Fty to fix ci 2020-11-12 13:03:10 +03:00
Nikolai Kochetov
85a4849756 Fty to fix ci 2020-11-12 12:21:33 +03:00
alexey-milovidov
34b2a460ba
Merge pull request #16578 from fibersel/issue-8828
add compression method for files: Xz
2020-11-12 02:58:52 +03:00
a.palagashvili
fe5800a27e remove commented code 2020-11-12 02:12:51 +03:00
tavplubix
058aa8f85e
Merge pull request #16824 from ClickHouse/replace_stringstreams_with_buffers
Replace std::*stringstreams with DB::*Buffers
2020-11-12 01:11:44 +03:00
Alexander Tokmakov
dbac7860b1 review suggestions 2020-11-11 16:27:54 +03:00
a.palagashvili
1b06fd9373 regenerated ya.make 2020-11-11 15:57:35 +03:00
Pavel Kovalenko
e311759c5d
Abort multipart upload if no data was written to WriteBufferFromS3. (#16840) 2020-11-11 15:15:16 +03:00
Pavel Kovalenko
adfe966c46 Support HTTP proxy and HTTPS S3 endpoint configuration. 2020-11-11 12:30:32 +03:00
a.palagashvili
124ef2f5fa added and successfully passed tests for content encoding and file() function, formatted code 2020-11-11 04:50:56 +03:00
Alexander Tokmakov
b94cc5c4e5 remove more stringstreams 2020-11-10 21:22:26 +03:00
Alexander Tokmakov
55631e442b fix bug in WriteBufferFromVector 2020-11-10 14:43:22 +03:00
Alexander Kuzmenkov
55c7051330 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-10 08:50:54 +03:00
a.palagashvili
f999ea2a6f renamed files, added new library, changed error codes, added tests for file() function 2020-11-10 01:52:22 +03:00
Alexander Tokmakov
5cdfcfb307 remove other stringstreams 2020-11-09 22:12:44 +03:00
a.palagashvili
6286775031 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into issue-8828 2020-11-09 19:53:20 +03:00
Alexander Tokmakov
62ff00ee8b use WriteBuffer in formatAST(...) 2020-11-09 19:05:40 +03:00
Alexander Tokmakov
a06be511df pcg serialization 2020-11-09 16:07:38 +03:00
Maksim Kita
240bbd2cd7 Removed fast path for parsing DateTime in Date format 2020-11-09 11:29:08 +03:00
Maksim Kita
02da9af32d DateTime comparison with date string literal 2020-11-09 11:29:08 +03:00
Alexander Kuzmenkov
2fe9c76728 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-09 09:37:50 +03:00
Alexey Milovidov
dba57529f8 Merge branch 'master' of github.com:yandex/ClickHouse into fix-stringstream 2020-11-07 22:03:38 +03:00
a.palagashvili
268f289bd1 resolved conflict 2020-11-07 16:36:38 +03:00
a.palagashvili
73e5d283aa regenerated ya.make 2020-11-07 16:24:21 +03:00
Alexey Milovidov
fd84d16387 Fix "server failed to start" error 2020-11-07 03:14:53 +03:00
Alexey Milovidov
7b72894363 Simplified code 2020-11-06 23:23:08 +03:00
Alexey Milovidov
c35e7ec74e Merge branch 'master' into https-sni 2020-11-06 21:44:26 +03:00
Alexey Milovidov
b56486510f Improve Arcadia 2020-11-05 12:55:01 +03:00
a.palagashvili
87cc3546ca fix codestyle 2020-11-04 19:39:26 +03:00
a.palagashvili
53a064b6e3 added eof initializing in constuctor 2020-11-04 15:45:37 +03:00
a.palagashvili
986d13df3a replaced null with nullptr 2020-11-04 03:35:16 +03:00
a.palagashvili
f9cebbfa81 added newline for files 2020-11-04 02:47:39 +03:00
a.palagashvili
ba6fa5d828 fixed whitespaces, added hidden submodule file 2020-11-02 23:04:49 +03:00
a.palagashvili
2ad01c59da fixed codestyle, added record to changelog 2020-11-02 16:17:25 +03:00
a.palagashvili
805bfd286c resolved git modules 2020-11-02 15:16:49 +03:00
Alexey Milovidov
8a68ee2547 Whitespaces 2020-11-02 13:45:48 +03:00
a.palagashvili
495cd47fd8 fixed compressor testing, added base logic for compressor and decompressor, tests passing 2020-11-02 02:52:34 +03:00
a.palagashvili
be2b002ff4 fixed cmake for building, added test for compression method, added basic code for encoding 2020-11-01 21:40:05 +03:00
a.palagashvili
731e274cd0 changed moment of stream object initialization 2020-11-01 03:14:40 +03:00
a.palagashvili
c1abf5d13c *added adapters' boilerplate for Lzma buffers, *added submodule to gitmodules, *added cmake for xz 2020-11-01 02:56:41 +03:00