v2: Add a note that top_level_domains_lists aren not applied w/o restart
v3: Remove ExtractFirstSignificantSubdomain{Default,Custom}Lookup.h headers
v4: TLDListsHolder: remove FIXME for dense_hash_map (this is not significant)
* master: (207 commits)
Update RadixSort.h
rerun tests to be sure
Update date_time_short perf test for toUnixTimestamp(Date())
update test
remove comments
better
fix tests
style
update copy pasted test
better
comments
better merge
new interface for the function
better
Fix comments
Add missing file
Make the code less bad
initial
test added
style
...
* master: (70 commits)
Update documentation-issue.md
Add an option to use existing tables to perf.py
DOCSUP-4280: Update the SELECT query (#17231)
DOCSUP-3584 edit and translate (#17176)
Fixed flaky test_storage_s3::test_custom_auth_headers
Update 01560_merge_distributed_join.sql
Minor improvements
Slightly more correct
Auto version update to [20.13.1.1] [54444]
Auto version update to [20.12.1.5236] [54443]
Update roadmap
Add favicon; add loading indicator
Fix race condition; history and sharing capabilities
Update bitmap-functions.md
Fix exception message
Use default value for read-only flag in metadata for Disk3.
ISSUES-16605 try fix review comment
trigger CI
ISSUES-16605 try fix integration failure
ISSUES-16605 try fix integration test failure
...
* master: (50 commits)
Update documentation-issue.md
Add an option to use existing tables to perf.py
DOCSUP-4280: Update the SELECT query (#17231)
DOCSUP-3584 edit and translate (#17176)
Fixed flaky test_storage_s3::test_custom_auth_headers
Update 01560_merge_distributed_join.sql
Minor improvements
Slightly more correct
Auto version update to [20.13.1.1] [54444]
Auto version update to [20.12.1.5236] [54443]
Update roadmap
Add favicon; add loading indicator
Fix race condition; history and sharing capabilities
Update bitmap-functions.md
Fix exception message
Use default value for read-only flag in metadata for Disk3.
ISSUES-16605 try fix review comment
trigger CI
ISSUES-16605 try fix integration failure
ISSUES-16605 try fix integration test failure
...
* master: (159 commits)
Review fix.
Update version_date.tsv after release 20.8.7.15
wrong translation
Update version_date.tsv after release 20.9.6.14
Update version_date.tsv after release 20.10.5.10
Update version_date.tsv after release 20.11.4.13
Improvements in coverage images
Fixed a problem with the translation of the document
final_parallel
final_parallel
DOCSUP-4162: Document the system.replicated_fetches system table (#16900)
Update settings.md
Update settings.md
Less verbose logging when fetch is impossible
Don't add tons of client coverage files in stateful tests with coverage
More compatible watches in TestKeeper
Trying to make read_in_order_many_parts more stable
trigger CI
Update version_date.tsv after release 20.6.10.2
Update visibleWidth.cpp
...
* Fix test "max_memory_usage_for_user"
* Update test
* Update annoying boilerplate
* Support symlinks in tarballs
* Fix Fuzzer
* Remove "secondary" user
* Remove "secondary" user
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).
TL;DR;
To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.
Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.
NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
