Commit Graph

862 Commits

Author SHA1 Message Date
Azat Khuzhin
5b3ab48861 More forward declaration for generic headers
The following headers are pretty generic, so use forward declaration as
much as possible:
- Context.h
- Settings.h
- ConnectionTimeouts.h
(Also this shows that some missing some includes -- this has been fixed)

And split ConnectionTimeouts.h into ConnectionTimeoutsContext.h (since
module part cannot be added for it, due to recursive build dependencies
that will be introduced)

Also remove Settings from the RemoteBlockInputStream/RemoteQueryExecutor
and just pass the context, since settings was passed only in speicifc
places, that can allow making a copy of Context (i.e. Copier).

Approx results (How much units will be recompiled after changing file X?):

- ConnectionTimeouts.h
  - mainline: 100

- Context.h:
  - mainline: ~800
  - patched:  415

- Settings.h:
  - mainline: 900-1K
  - patched:  440 (most of them because of the Context.h)
2020-12-12 17:43:10 +03:00
Alexander Kuzmenkov
fb1221148d
Merge pull request #17748 from azat/custom-TLD
Add ability to use custom TLD list
2020-12-11 12:42:19 +03:00
Azat Khuzhin
352a1eea34 Use new top_level_domains_path 2020-12-09 21:08:31 +03:00
Azat Khuzhin
840a21d073 Add top_level_domains_path for easier overriding 2020-12-09 21:08:31 +03:00
Azat Khuzhin
916cbd6610 Add ability to use custom TLD list
v2: Add a note that top_level_domains_lists aren not applied w/o restart
v3: Remove ExtractFirstSignificantSubdomain{Default,Custom}Lookup.h headers
v4: TLDListsHolder: remove FIXME for dense_hash_map (this is not significant)
2020-12-09 21:08:22 +03:00
alesapin
850f903d40 Merge branch 'master' into complete_zk_api 2020-12-09 18:18:38 +03:00
alesapin
0dd9c720f4 Better server 2020-12-09 11:58:41 +03:00
alesapin
758dcd1972 Separate factory for test keeper handlers 2020-12-09 11:45:36 +03:00
alexey-milovidov
8ff30b87a6
Merge pull request #15930 from kitaisreal/clickhouse-client-and-local-added-queries-file-parameter
Clickhouse client and clickhouse local added queries-file parameter
2020-12-08 21:44:19 +03:00
Vitaly Baranov
f6f336ac78
Merge pull request #17888 from vitlibar/retrieve-logs-from-grpc
Retrieve logs from grpc
2020-12-08 20:54:02 +03:00
alesapin
3d0dbbe411 Fix build 2020-12-08 17:49:18 +03:00
alexey-milovidov
ab10cb4bf9
Merge pull request #17707 from ClickHouse/quota-by-x-forwarded-for
Allow quotas to be keyed by proxy-forwarded IP address; add support for PROXY protocol
2020-12-08 14:48:05 +03:00
Vitaly Baranov
559afe028f Retrieve logs from grpc library and pass them to our logging system. 2020-12-07 23:39:55 +03:00
Vitaly Baranov
76afe58bbf Fix commenting in the server config. 2020-12-07 21:50:55 +03:00
Maksim Kita
963ee5211b Added queries-file parameter. Fixed code review issues 2020-12-07 19:29:17 +03:00
Maksim Kita
f5d1a9e59a Clickhouse client and local added queries-file parameter 2020-12-07 19:29:17 +03:00
Alexey Milovidov
1ed329017b Merge branch 'master' into quota-by-x-forwarded-for 2020-12-07 18:22:19 +03:00
Maksim Kita
ee33323d1e Added tests 2020-12-07 11:35:44 +03:00
spongedc
5914e6e451 Refine documents for system log table, and fix a link error in config.xml 2020-12-07 16:04:29 +08:00
alesapin
0c43246216 Merge branch 'master' into complete_zk_api 2020-12-07 10:24:55 +03:00
Maksim Kita
97cfaea182 Clickhouse-benchmark added query parameter 2020-12-06 11:53:02 +03:00
Alexey Milovidov
1e943babcc Do not add empty query to browser history 2020-12-03 23:20:09 +03:00
Alexey Milovidov
3e2447391b Support for PROXY protocol 2020-12-03 00:05:51 +03:00
alesapin
93ea2f5b1f Merge branch 'master' into complete_zk_api 2020-12-02 11:30:09 +03:00
Alexander Kuzmenkov
6e1512304c
no TTL by default, as before 2020-12-01 15:59:31 +03:00
spongedc
9e995d9756 1.make ttl option more generic 2. add check if engine specified for system log 2020-12-01 00:29:36 +08:00
spongedc
d96600678d Merge remote-tracking branch 'origin/master' into add_ttl_option_for_syslog 2020-11-30 22:53:52 +08:00
alesapin
6d2a007b79 Merge branch 'master' into complete_zk_api 2020-11-30 10:58:25 +03:00
alexey-milovidov
0c831e1204
Merge pull request #17301 from ClickHouse/odbc-minor-changes
Minor changes for ODBC storage
2020-11-29 21:23:20 +03:00
Alexey Milovidov
24bd2e8e8e GRPC: better config 2020-11-28 08:44:16 +03:00
Nikita Mikhaylov
0b6f5c75b9
Merge pull request #17435 from vitlibar/grpc-protocol-2
Implement GRPC protocol (corrections)
2020-11-27 15:19:50 +03:00
alesapin
d199a2bf76 Merge branch 'master' into complete_zk_api 2020-11-27 14:55:55 +03:00
felixxdu
17e83cbb8d Merge remote-tracking branch 'origin/master' into add_ttl_option_for_syslog 2020-11-27 10:02:57 +08:00
alexey-milovidov
77b5fa9468
Merge pull request #17421 from ClickHouse/clickhouse-install-improvements
ClickHouse install script improvements
2020-11-26 23:12:57 +03:00
alexey-milovidov
f086f56379
Merge pull request #17428 from ClickHouse/simplify-init-script-2
Simplify init script (part 2)
2020-11-26 23:06:01 +03:00
Nikolai Kochetov
9291bbb04b
Merge pull request #16804 from vdimir/ip-dict-no-trie
sorted-array based ip_dict
2020-11-26 19:26:06 +03:00
felixxdu
4cc6594cb8 Support configure Ssystem log table's ttl in config.xml 2020-11-26 17:37:42 +08:00
Vitaly Baranov
1fc43b3c93 Remove trailing whitespaces in config.xml 2020-11-26 10:27:04 +03:00
Vitaly Baranov
2063cbae0e Remove old and broken C++ grpc-client. 2020-11-26 10:23:01 +03:00
Vitaly Baranov
49cf980761 Use port 9100 for grpc by default. 2020-11-26 10:14:27 +03:00
Alexey Milovidov
36151b9e54 Simplify init script (part 2) 2020-11-26 07:54:18 +03:00
alexey-milovidov
8eccf680d8
Update ODBCBlockInputStream.cpp 2020-11-26 07:11:34 +03:00
alexey-milovidov
aca4da7a2b
Update Install.cpp 2020-11-26 07:07:48 +03:00
Alexey Milovidov
2ff3e96e95 Many fixes in Install script 2020-11-26 05:11:55 +03:00
Alexey Milovidov
e89d1632a1 Improvements of Install script 2020-11-26 04:44:26 +03:00
Alexander Kuzmenkov
394b81ac46 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-25 23:38:55 +03:00
Nikolai Kochetov
729272391f
Merge branch 'master' into ip-dict-no-trie 2020-11-25 23:07:19 +03:00
alesapin
fb86eaf6fc Better errors and better config 2020-11-25 16:19:09 +03:00
Nikita Mikhaylov
d6dd133bee
Merge pull request #17363 from nikitamikhaylov/copier-uninitialized-var
Initialize unitialized variable
2020-11-25 15:12:42 +03:00
Nikita Mikhaylov
27acf6462f
Merge pull request #17248 from kaka11chen/15235
Fix #15235. When clickhouse-copier handle non-partitioned table, throws segfault error.
2020-11-25 14:31:59 +03:00
Alexander Kuzmenkov
edce1e636e
Merge pull request #16535 from ClickHouse/aku/opentelemetry
OpenTelemetry improvements
2020-11-25 14:10:17 +03:00
alesapin
310307fa72 Replace eventfd with pipes 2020-11-25 11:18:15 +03:00
alesapin
4d40d9be3f Merge branch 'master' into complete_zk_api 2020-11-25 10:31:16 +03:00
chenqi
302cd55f45 Fix #15235. When clickhouse-copier handle non-partitioned table, throw segfault error. 2020-11-25 11:52:00 +08:00
Alexander Kuzmenkov
1d7dcef4a0 Merge remote-tracking branch 'origin/master' into HEAD 2020-11-24 21:45:10 +03:00
nikitamikhaylov
ebd51db987 better 2020-11-24 21:22:50 +03:00
Vitaly Baranov
3c85165e60 Redirect stderr, stdout for clickhouse-odbc-bridge to files. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
eab3006a4d Support SSL and compression when using gRPC protocol. 2020-11-24 17:55:02 +03:00
Vitaly Baranov
c2edd9f8ce Rework async server: switch to coroutine-like approach, no using statuses anymore for control flow. 2020-11-24 17:53:34 +03:00
Vitaly Baranov
ff62fd4967 Add an adapter for protocol servers. 2020-11-24 17:53:34 +03:00
Vitaly Baranov
44717797c9 Fix code style and compilation. 2020-11-24 17:53:34 +03:00
Vitaly Baranov
13f2352c57 Move files to right places. 2020-11-24 17:53:34 +03:00
mnkonkova
6cd1557d67 Implement GRPC protocol. 2020-11-24 17:53:34 +03:00
nikitamikhaylov
31505fb279 done 2020-11-24 17:40:38 +03:00
myrrc
fbb0e6e6aa Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-24 16:04:17 +03:00
alesapin
c1a7e4f5fa Merge branch 'master' into complete_zk_api 2020-11-24 13:37:51 +03:00
Denis Glazachev
a367abb88f Merge branch 'master' into ldap-cache-login
* master: (70 commits)
  Update documentation-issue.md
  Add an option to use existing tables to perf.py
  DOCSUP-4280: Update the SELECT query (#17231)
  DOCSUP-3584 edit and translate (#17176)
  Fixed flaky test_storage_s3::test_custom_auth_headers
  Update 01560_merge_distributed_join.sql
  Minor improvements
  Slightly more correct
  Auto version update to [20.13.1.1] [54444]
  Auto version update to [20.12.1.5236] [54443]
  Update roadmap
  Add favicon; add loading indicator
  Fix race condition; history and sharing capabilities
  Update bitmap-functions.md
  Fix exception message
  Use default value for read-only flag in metadata for Disk3.
  ISSUES-16605 try fix review comment
  trigger CI
  ISSUES-16605 try fix integration failure
  ISSUES-16605 try fix integration test failure
  ...
2020-11-24 02:55:20 +04:00
alesapin
1de175257b More const 2020-11-23 23:22:04 +03:00
alesapin
5a48076802 Trying to get rid of leak 2020-11-23 13:55:00 +03:00
Alexey Milovidov
77c963dec5 Minor changed for ODBC storage 2020-11-23 13:32:56 +03:00
alesapin
b8fb44a7b9 Merge with master 2020-11-23 11:05:50 +03:00
Alexey Milovidov
fdc11cb739 Minor improvements 2020-11-23 11:05:13 +03:00
Alexey Milovidov
56651a94c4 Slightly more correct 2020-11-23 10:52:33 +03:00
Alexey Milovidov
f3e567b4b4 Update roadmap 2020-11-23 10:15:52 +03:00
Alexey Milovidov
5058c56ecf Add favicon; add loading indicator 2020-11-23 10:15:33 +03:00
Alexey Milovidov
2c982b4ccf Fix race condition; history and sharing capabilities 2020-11-23 09:35:08 +03:00
Tai White
43fce34eec Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into ldap-cache-login 2020-11-20 20:56:36 +01:00
alesapin
0208751a7d Add dirty hack for connections close 2020-11-20 15:46:05 +03:00
vdimir
36544a45b7
Merge remote-tracking branch 'upstream/master' into ip-dict-no-trie 2020-11-19 18:56:24 +03:00
alesapin
991386e37b Fix stupid error 2020-11-19 13:56:36 +03:00
Azat Khuzhin
dd0fccae47 Disable rotation of the logs in tests (on CI)
Right now due to rotation the archive with the clickhouse-server.log
maybe not full, for example:
- not full - https://clickhouse-test-reports.s3.yandex.net/16947/caf5f98db2ae39dd911f7d1fc0a7c2cc382b1c53/functional_stateless_tests_(ubsan)/clickhouse-server.log (no messages about server start)
- full     - https://clickhouse-test-reports.s3.yandex.net/16993/d1f52dc72d417580c4088cf3880593176416bea2/functional_stateless_tests_(thread).html

And sometimes rotated part may include relative part of the log, so it
is better to disable it.
2020-11-19 01:08:47 +03:00
Azat Khuzhin
8a7376247b Add a comment about rotation policy into server config 2020-11-19 01:07:09 +03:00
Alexander Kuzmenkov
1570320e20 fixes for context hierarchy 2020-11-18 20:43:18 +03:00
alesapin
2cd66f23a3 Merge branch 'master' into complete_zk_api 2020-11-18 17:50:50 +03:00
Alexey Milovidov
3df04ce0c2 Follow Arcadia ya.make rules 2020-11-16 21:24:58 +03:00
myrrc
862c8a428c Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-16 14:40:49 +03:00
alexey-milovidov
3940babab5
Merge pull request #16936 from ClickHouse/filimonov-install-always-create-missing-dirs
Install script should always create subdirs in config folders.
2020-11-14 17:22:57 +03:00
myrrc
b1c0089b78 Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-14 16:50:04 +03:00
filimonov
0e4cbf7508
Update programs/install/Install.cpp 2020-11-13 12:31:37 +01:00
Alexey Milovidov
7d1c0f5b28 Fixed bug in git-import tool 2020-11-13 04:36:34 +03:00
filimonov
8a20133373
style 2020-11-12 18:28:24 +01:00
alexey-milovidov
385e8f5ee0
Update Install.cpp 2020-11-12 19:52:58 +03:00
filimonov
26f6ce3fb5
Update Install.cpp 2020-11-12 17:48:17 +01:00
alesapin
4aad6a597c Merge branch 'correctly_send_close_request' into complete_zk_api 2020-11-12 17:46:02 +03:00
myrrc
a8d8dd7d3e Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-12 14:50:59 +03:00
alexey-milovidov
8dd81410de
Merge pull request #16843 from azat/clickhouse-client-stage
Add --stage option for clickhouse-client
2020-11-12 13:09:40 +03:00
tavplubix
058aa8f85e
Merge pull request #16824 from ClickHouse/replace_stringstreams_with_buffers
Replace std::*stringstreams with DB::*Buffers
2020-11-12 01:11:44 +03:00
alesapin
6398271432 Merge branch 'master' into complete_zk_api 2020-11-11 16:57:24 +03:00
alesapin
d83c68fca8 Fix timeouts 2020-11-11 16:55:28 +03:00
Alexander Tokmakov
dbac7860b1 review suggestions 2020-11-11 16:27:54 +03:00
alesapin
66236d6ebb Refactored a little 2020-11-11 16:07:06 +03:00
Azat Khuzhin
ab8f13b885 Add --stage option for clickhouse-client
It is sometimes useful to process queries not up to the Complete stage
but intermediate some (i.e. for Distributed queries debugging and
similar).
2020-11-11 00:54:51 +03:00
Alexander Tokmakov
b94cc5c4e5 remove more stringstreams 2020-11-10 21:22:26 +03:00
myrrc
e460248624 Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-10 14:54:24 +03:00
alesapin
932ea0ef8b Merge branch 'master' into complete_zk_api 2020-11-10 13:56:11 +03:00
Amos Bird
aa8e6db786
reload auxiliary zookeepers configuration 2020-11-10 15:56:37 +08:00
Denis Glazachev
0e704ec278
Merge branch 'master' into ldap-cache-login 2020-11-10 00:10:22 +04:00
Alexander Tokmakov
5cdfcfb307 remove other stringstreams 2020-11-09 22:12:44 +03:00
Alexander Tokmakov
62ff00ee8b use WriteBuffer in formatAST(...) 2020-11-09 19:05:40 +03:00
Alexander Kuzmenkov
24e57c659a
Merge pull request #15960 from kitaisreal/clickhouse-client-added-history-file-parameter
Clickhouse client added history file parameter
2020-11-09 08:19:00 +03:00
vdimir
a67f5b780f
Use sorted ip array instead of trie in TrieDictionary 2020-11-08 19:19:04 +03:00
alexey-milovidov
2d427eb1e8
Merge pull request #16496 from ClickHouse/register-formats
Fix inconsistency in FormatFactory
2020-11-08 14:27:33 +03:00
alexey-milovidov
4e03daac76
Update CMakeLists.txt 2020-11-08 01:19:50 +03:00
Maksim Kita
05ba70c91f Clickhouse client added history file parameter 2020-11-06 17:05:59 +03:00
Azat Khuzhin
b2e17916e4 Mask password in data_path in the system.distribution_queue 2020-11-06 00:10:25 +03:00
myrrc
9788065786 Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-05 08:44:37 +03:00
Alexey Milovidov
6757fb6996 Add development roadmap for web UI 2020-11-05 01:17:30 +03:00
alexey-milovidov
fa929b0312
Replace duplicate development config files with symlinks. (#16486)
* Fix test "max_memory_usage_for_user"

* Update test

* Update annoying boilerplate

* Support symlinks in tarballs

* Fix Fuzzer

* Remove "secondary" user

* Remove "secondary" user
2020-11-04 23:45:06 +03:00
alexey-milovidov
d5a51ddbbf
Update CMakeLists.txt 2020-11-04 23:44:43 +03:00
myrrc
3d70ab7f3b Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-11-04 14:29:59 +03:00
Alexey Milovidov
5cfd84249b Merge branch 'master' into register-formats 2020-11-04 12:41:59 +03:00
Vitaliy Zakaznikov
e6d04b4780 Merge branch 'master' of https://github.com/traceon/ClickHouse into ldap-cache-login 2020-11-03 16:53:23 -05:00
alesapin
a02b4322b6 Merge branch 'master' into complete_zk_api 2020-11-03 13:13:07 +03:00
Ivan
281bf351d2
Remove ANALYZE and AST queries (#16536) 2020-11-02 15:47:12 +03:00
myrrc
9ca35c0b44 Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-10-30 17:22:24 +03:00
alesapin
c2525ef211 Server and client pinging each other 2020-10-30 17:16:47 +03:00
alexey-milovidov
ae4d66ac9d
Merge pull request #16047 from ClickHouse/suggest-destruction-order
Fix destruction order of Suggest #16035
2020-10-29 09:10:23 +03:00
Alexey Milovidov
1520b6aa2a Take out odbc-bridge from clickhouse bundle 2020-10-29 08:27:55 +03:00
Alexey Milovidov
f2bdfcef41 Add missing modification 2020-10-29 08:18:42 +03:00
Alexey Milovidov
0440958c3e Add missing modification 2020-10-29 07:27:12 +03:00
Alexey Milovidov
a7b5db912c odbc-bridge: two libraries less 2020-10-29 06:42:49 +03:00
Alexey Milovidov
2e0a979e3a Fix inconsistency in FormatFactory 2020-10-29 06:39:43 +03:00
Alexey Milovidov
c703c052b4 Merge branch 'master' into suggest-destruction-order 2020-10-28 04:21:43 +03:00
Alexander Kuzmenkov
6509f1eb39
Merge branch 'master' into minumum 2020-10-27 21:38:23 +03:00
Mikhail Filimonov
41971e073a
Fix typos reported by codespell 2020-10-27 12:04:03 +01:00
Alexey Milovidov
2e232bad74 Merge branch 'master' into sigaltstack 2020-10-26 22:51:58 +03:00
Alexander Kuzmenkov
5a70e26c70 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-26 19:21:13 +03:00
Alexander Kuzmenkov
6552613118
Merge pull request #16280 from filimonov/clickhouse-local-tmp-folder
clickhouse-local can work without tmp directory
2020-10-26 19:10:15 +03:00
Alexander Kuzmenkov
44162c28c0
Update LocalServer.cpp 2020-10-26 19:09:43 +03:00
myrrc
4d11bd036b Merge remote-tracking branch 'upstream/master' into improvement/diff-types-in-avg-weighted 2020-10-26 17:42:47 +03:00
Denis Glazachev
f2a6696362 Implement verification_cooldown LDAP server connection param 2020-10-26 16:44:36 +04:00
filimonov
79895130b7
Better grammar in comments, CI rerun 2020-10-26 08:59:15 +01:00
Alexey Milovidov
b472bd35b7 Merge branch 'master' into sigaltstack 2020-10-26 07:42:33 +03:00
Alexey Milovidov
068235c2d7 Disable alt stack for sanitizers 2020-10-26 05:18:36 +03:00
alexey-milovidov
bfe17d7dca
Merge pull request #16358 from azat/dist-insert-fix
Fix async Distributed INSERT w/ prefer_localhost_replica=0 and internal_replication
2020-10-26 05:07:35 +03:00
Azat Khuzhin
edc8d6e5e7 Fix async Distributed INSERT w/ prefer_localhost_replica=0 and internal_replication 2020-10-25 14:27:06 +03:00
Alexey Milovidov
4bf32cb15b Fix destruction order of Suggest #16035 2020-10-25 05:07:52 +03:00
Ivan
1d170f5745
ASTTableIdentifier Part #1: improve internal representation of ASTIdentifier name (#16149)
* Use only |name_parts| as primary name source

* Restore legacy logic for table restoration

* Fix build

* Fix tests

* Add pytest server config

* Fix tests

* Fixes due to review
2020-10-24 21:46:10 +03:00
alexey-milovidov
2bbb663fdd
Update programs/local/LocalServer.cpp
Co-authored-by: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com>
2020-10-24 07:30:39 +03:00
Azat Khuzhin
72d7b6117e Use total_memory_tracker when there is no other MemoryTracker object.
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).

TL;DR;

To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.

Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.

NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
2020-10-23 21:07:52 +03:00