Commit Graph

63105 Commits

Author SHA1 Message Date
Azat Khuzhin
eefd67fce5 Disable optimize_distributed_group_by_sharding_key with window functions 2021-05-06 00:44:22 +03:00
Azat Khuzhin
6ac50ab9c5 Extend 01568_window_functions_distributed for distributed_group_by_no_merge 2021-05-06 00:24:39 +03:00
Azat Khuzhin
e5cff95cc8 Avoid deadlock due to Log usage in 01568_window_functions_distributed 2021-05-06 00:24:39 +03:00
Azat Khuzhin
8703b7863d Fix distributed_group_by_no_merge=2 with GROUP BY
Before this patch the following query:

  SELECT assumeNotNull(argMax(dummy, 1))
  FROM remote('127.1', system.one)
  SETTINGS distributed_group_by_no_merge = 2

Leads to:

  Code: 10. DB::Exception: Received from localhost:9000. DB::Exception: Not found column argMax(dummy, 1) in block: while executing 'INPUT : 0 -> argMax(dummy, 1) UInt8 : 0'.

Since it tries to execute function one more time, but shards will not
send this column when the query processed with
distributed_group_by_no_merge=2 (i.e. up to
WithMergeableStateAfterAggregation).

v0: no exception
v2: execut window functions
v3: throw exception, since executing window function in this case will
lead to messy output
2021-05-06 00:21:47 +03:00
alexey-milovidov
7ae8938b69
Merge pull request #23896 from ClickHouse/implement-todo
Minor code simplification (implemented TODO)
2021-05-05 19:31:52 +03:00
Maksim Kita
1a38b2ed9a
Merge pull request #23898 from ice1x/master
Add run options with default config path according to issues/23875
2021-05-05 18:41:02 +03:00
ice1x
577613b6ae
Merge pull request #2 from ice1x/feature/add-osx-build-run-item
Update build-osx.md
2021-05-05 19:57:47 +05:00
ice1x
d748560991
Update build-osx.md 2021-05-05 19:56:20 +05:00
ice1x
d6164d389d
Merge pull request #1 from ice1x/feature/add-osx-build-run-item
Add run options with default config path
2021-05-05 19:36:31 +05:00
ice1x
dc595f391e
Add run options with default config path
Add run options with default config path.
Checked on Catalina 10.15.7
2021-05-05 19:35:28 +05:00
Maksim Kita
6105a19357
Merge pull request #23869 from kirillikoff/kirillikoff-DOCSUP-8495
DOCSUP-8495: Documented http-max-uri-size
2021-05-05 15:27:42 +03:00
Alexey Milovidov
79beaae056 Shave off some lines of code 2021-05-05 15:01:01 +03:00
Alexey Milovidov
6473e956bb Implement TODO 2021-05-05 14:58:17 +03:00
alexey-milovidov
542c940941
Merge pull request #23874 from filimonov/librdkafka161
Update librdkafka 1.6.0-RC3 to 1.6.1
2021-05-05 13:48:14 +03:00
alexey-milovidov
2e22cceffa
Merge pull request #23884 from azat/bash-completion
bash completion improvements
2021-05-05 13:43:44 +03:00
alexey-milovidov
bf8c28a17f
Merge pull request #23885 from azat/dist-broken-metrics
Add metrics for broken files during async distributed sends
2021-05-05 13:41:15 +03:00
alexey-milovidov
86e6ad17dc
Merge pull request #23893 from zifter/bugfix/fix-doc-link
Doc. Fix title link for send_crash_reports for en and ru
2021-05-05 13:39:21 +03:00
alexey-milovidov
3a5e95359a
Merge pull request #23883 from ClickHouse/delete-bad-test-in-memory-parts
@CurtizJ convinced me that this test has to be deleted
2021-05-05 13:27:57 +03:00
Oleg Strokachuk
04e3fa1834 Doc. Fix title link for send_crash_reports for en and ru 2021-05-05 11:33:38 +03:00
alexey-milovidov
c607291042
Merge pull request #23877 from ClickHouse/pvs-studio-fixes-5
Fix some warnings by PVS-Studio
2021-05-04 22:57:19 +03:00
Azat Khuzhin
9c6e8e1462 Add BrokenDistributedFilesToInsert new metric
Number of files for asynchronous insertion into Distributed tables that
has been marked as broken. This metric will starts from 0 on start.
Number of files for every shard is summed.
2021-05-04 22:48:07 +03:00
Azat Khuzhin
74269882f7 Add broken_data_files/broken_data_compressed_bytes into distribution_queue 2021-05-04 22:48:07 +03:00
Azat Khuzhin
1639cc598d bash-completion: add completion for --host 2021-05-04 22:23:08 +03:00
Azat Khuzhin
3e72d4186c bash-completion: add completion for --stage 2021-05-04 22:23:08 +03:00
Azat Khuzhin
61e4c5af07 bash-completion: make some code more generic 2021-05-04 22:23:08 +03:00
Alexey Milovidov
af41344cf5 @CurtizJ convinced me that this test has to be deleted 2021-05-04 20:59:42 +03:00
Vladimir
164cad403c
Merge pull request #23879 from vdimir/fix-disks3-arcadia
Add Read/WriteBufferFromFileDecorator.cpp to ya.make
2021-05-04 16:12:07 +03:00
vdimir
657eda9288
Add Read/WriteBufferFromFileDecorator.cpp to ya.make 2021-05-04 16:07:56 +03:00
Tatiana Kirillova
cba158037e Merge branch 'kirillikoff-DOCSUP-8495' of https://github.com/kirillikoff/ClickHouse into kirillikoff-DOCSUP-8495 2021-05-04 15:58:10 +03:00
Tatiana Kirillova
5bc025ecae translation to ru 2021-05-04 15:54:13 +03:00
Alexey Milovidov
2b118f11b4 PVS-Studio 2021-05-04 15:14:55 +03:00
Alexey Milovidov
9cbdcc1ab5 PVS-Studio 2021-05-04 15:14:47 +03:00
Alexey Milovidov
eea47a65d2 PVS-Studio 2021-05-04 15:13:47 +03:00
kirillikoff
0e92cc06df
Update docs/en/operations/settings/settings.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-05-04 15:09:15 +03:00
alexey-milovidov
4ebc0b79fc
Merge pull request #23868 from ClickHouse/fix-disks3-arcadia
Add DiskRestartProxy.cpp to ya.make
2021-05-04 14:57:18 +03:00
Maksim Kita
5fa3701540
Merge pull request #23873 from elevankoff/patch-1
Fix typo in the comment
2021-05-04 13:48:46 +03:00
Mikhail Filimonov
80065b08f8
Revert "avoid race in librdkafka"
This reverts commit bd8c3eb117.
2021-05-04 10:06:33 +02:00
Mikhail Filimonov
ba7945367e
Update to librdkafka 1.6.1 2021-05-04 10:05:12 +02:00
Yegor Levankov
3c02a998c2
Fix typo in comment 2021-05-04 10:54:13 +03:00
Maksim Kita
ea7ea99512
Merge pull request #23856 from azat/dist-send-improve-logging
Add file paths into logs on failed distributed async sends
2021-05-03 22:18:14 +03:00
vdimir
465341eafd
Add DiskRestartProxy.cpp to ya.make 2021-05-03 20:50:17 +03:00
Tatiana Kirillova
c763a5c33f max-uri-size 2021-05-03 20:16:44 +03:00
alexey-milovidov
1f23d95d81
Merge pull request #23855 from azat/replxx-bindings
replxx readline compatibility
2021-05-03 19:19:24 +03:00
alexey-milovidov
b868cabfa9
Update functions-for-nulls.md 2021-05-03 13:40:54 +03:00
alexey-milovidov
41a6fd677e
Update functions-for-nulls.md 2021-05-03 13:39:10 +03:00
Azat Khuzhin
5e33604c4d Add file paths into logs on failed distributed async sends 2021-05-03 08:55:38 +03:00
Azat Khuzhin
5ff78fb297 replxx readline compatibility
- By default M-BACKSPACE is KILL_TO_WHITESPACE_ON_LEFT, while in
  readline it is backward-kill-word, so use KILL_TO_BEGINING_OF_WORD
  instead.
- By default C-w is KILL_TO_BEGINING_OF_WORD, while in readline it is
  unix-word-rubout, so use KILL_TO_WHITESPACE_ON_LEFT instead.
2021-05-02 23:26:42 +03:00
Nikolai Kochetov
08f10dced0
Merge pull request #23743 from ClickHouse/refactor-join-step
Refactor join step
2021-05-02 21:17:23 +03:00
Maksim Kita
6f08f945e8
Merge pull request #21105 from eaxdev/fix_doc
Actualize OnTime example
2021-05-02 14:23:04 +03:00
Alexey Milovidov
b22032b97d Whitespace 2021-05-02 14:19:47 +03:00