thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 07:01:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
97,745 Commits 9,141 Branches 1,778 Tags 2 GiB
64b44be513
Commit Graph

97745 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Azat Khuzhin
64b44be513 Account any IO that is done from ThreadPoolReader 
In case of some issues with the disk it is possible that
preadv2(RWF_NOWAIT)==EAGAIN can take a lot of time, so let's measure
even this case.

I've verified with a simple (almost) loop of preadv2(RWF_NOWAIT), and
got this:

    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    EAGAIN: 8565670 (out of 17148317)
    too long at offset=8691694, ret=18446744073709551615 (14.5016)
    too long at offset=8694766, ret=18446744073709551615 (14.4338)
    too long at offset=8694766, ret=18446744073709551615 (16.2144)

So here you can see that preadv2(RWF_NOWAIT) took 14-16 seconds in case
of failure.

Complete code can be found here [1].

  [1]: https://gist.github.com/azat/f4a6b0750316c42bec021064e0a7627c

I came up with this patch because I saw some stranginess in
ProfileEvents, that does not show all the time that was spend in IO when
pread_threadpool method was used.
Also there was some stranginess with trace_log too.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-09-18 10:05:21 +02:00
Alexey Milovidov
76aaecf1aa
Merge pull request #41450 from ClickHouse/remove-s3-sample-block-cache 
Remove too long test from the test suite with S3
 2022-09-18 09:44:07 +03:00
Alexey Milovidov
6607bf0f5c
Merge pull request #41384 from Algunenano/insert_stats 
Check the behaviour of query_log read/write stats in INSERT queries
 2022-09-18 07:57:05 +03:00
Alexey Milovidov
7e93dbfcd6
Merge pull request #41094 from HarryLeeIBM/hlee-s390x-zlib-ng 
Fix zlib-ng build issue for s390x
 2022-09-18 07:55:20 +03:00
Alexey Milovidov
26965818c2
Merge pull request #41163 from azat/bump-replxx 
Bump replxx to fix possible uncaught exception
 2022-09-18 07:53:50 +03:00
Alexey Milovidov
a958751c98
Merge pull request #40219 from den-crane/test/zvonand-monotonic 
test for datetime64 monotonic #39864
 2022-09-18 07:48:49 +03:00
Alexey Milovidov
32efe6952e
Merge pull request #41429 from ClickHouse/forbid-dlopen-2 
Forbid invocations of `dlopen`
 2022-09-18 07:05:56 +03:00
Alexey Milovidov
00ba819611
Update 00632_get_sample_block_cache.sql 2022-09-18 06:18:22 +03:00
Alexey Milovidov
c8c728e740
Merge pull request #41449 from ClickHouse/fix-categorial-information 
Fix incorrect properties of `categorialInformationValue` function
 2022-09-18 05:26:26 +03:00
Alexey Milovidov
25dfbba8dd Merge branch 'forbid-dlopen-2' of github.com:ClickHouse/ClickHouse into forbid-dlopen-2 2022-09-18 02:25:12 +02:00
Alexey Milovidov
15e5fc96a1 Add a trap 2022-09-18 02:24:56 +02:00
Alexey Milovidov
515972f459 Merge branch 'master' into forbid-dlopen-2 2022-09-18 02:20:22 +02:00
Alexey Milovidov
f7edbeba22 Remove too long test from the test suite with S3 2022-09-18 02:19:12 +02:00
Alexey Milovidov
45dc3faeca
Merge pull request #41438 from ClickHouse/integration-tests-remove-trash 
Remove trash from integration tests
 2022-09-18 03:16:44 +03:00
Alexey Milovidov
dc76677eb2
Merge pull request #41440 from ClickHouse/remove-cruft 
Remove cruft about gcc
 2022-09-18 03:15:26 +03:00
Alexey Milovidov
416b5c701b Add a test 2022-09-18 01:21:33 +02:00
Alexey Milovidov
6f1878b12a Fix error 2022-09-18 01:17:22 +02:00
Alexey Milovidov
c424ad12aa Simplification 2022-09-18 00:09:21 +02:00
Alexey Milovidov
e2d434ea18 Start with code removal 2022-09-17 23:37:57 +02:00
Alexey Milovidov
88577747e5
Merge branch 'master' into forbid-dlopen-2 2022-09-18 00:25:25 +03:00
Alexey Milovidov
bac578b23a
Merge pull request #41428 from ClickHouse/remove-dlopen 
Remove `dlopen`
 2022-09-18 00:09:57 +03:00
Alexey Milovidov
f4a48cd4d6 Remove cruft 2022-09-17 22:16:31 +02:00
Alexey Milovidov
59d05b949b
Merge branch 'master' into bump-replxx 2022-09-17 22:49:34 +03:00
robot-clickhouse
838bc678cc Automatic style fix 2022-09-17 18:38:12 +00:00
Alexey Milovidov
c480531423 Remove trash error message from integration tests 2022-09-17 20:27:19 +02:00
Alexey Milovidov
ecfd8cb5a6 Remove trash error message from integration tests 2022-09-17 20:24:56 +02:00
Alexander Tokmakov
49a9c9e5fa
Merge pull request #41436 from ClickHouse/revert_38200 
Revert "Keeper faster linearizable reads"
 2022-09-17 20:25:43 +03:00
Robert Schulze
38aecc15a2
Merge pull request #41214 from arenadata/ADQM-528-B 
Add enable_extended_results_for_datetime_functions option to return results of type Date32
 2022-09-17 19:25:11 +02:00
Alexander Tokmakov
42dab6dc02 Revert "Merge pull request #38200 from ClickHouse/keeper-linearizable-reads" 
This reverts commit 222b964070, reversing
changes made to da01982652.
 2022-09-17 19:22:58 +02:00
alesapin
33216dedf9
Merge pull request #41323 from ClickHouse/remove_bad_exception 
Fix parts removal in case of connection loss
 2022-09-17 19:14:53 +02:00
Anton Popov
6f7aaef5ee
Merge pull request #41336 from CurtizJ/dynamic-columns-21 
Fix writing of empty columns of type `Object`
 2022-09-17 19:05:11 +02:00
Anton Popov
07cfb0cba4
Merge branch 'master' into dynamic-columns-21 2022-09-17 19:02:58 +02:00
Alexey Milovidov
9ce0c5f738
Merge pull request #41431 from ClickHouse/remove-method-simplification 
Remove `-WithTerminatingZero` methods
 2022-09-17 19:48:35 +03:00
Alexey Milovidov
d9d1b558e9 Fix clang-tidy 2022-09-17 18:40:22 +02:00
Igor Nikonov
475443c10c
Merge pull request #41257 from ClickHouse/igor/mixed_improvements_along_the_way 
Tiny improvements along the code
 2022-09-17 10:43:46 +02:00
Alexey Milovidov
ada7a44ae4 Remove -WithTerminatingZero methods 2022-09-17 05:34:18 +02:00
Alexey Milovidov
0c3835240b Fix error with multidimensional arrays 2022-09-17 04:16:24 +02:00
Alexey Milovidov
b60a5a5bc5 Merge branch 'master' into fix-getdataat-multidimensional-arrays 2022-09-17 04:07:12 +02:00
Alexey Milovidov
ecd4c29c2a Forbid invocations of dlopen 2022-09-17 03:55:39 +02:00
Alexey Milovidov
35cce03125 Remove dlopen 2022-09-17 03:02:34 +02:00
Alexey Milovidov
cb45f51e51
Merge branch 'master' into bump-replxx 2022-09-17 03:22:10 +03:00
Alexey Milovidov
31ebd34f5b
Merge pull request #41193 from azat/DWARF-5-parser-v3 
Add support for DWARF-5 (without emitting them in binaries)
 2022-09-17 02:58:02 +03:00
Dan Roscigno
7e6fee46d1
Merge pull request #41422 from DanRoscigno/add-formats-link 
add link to formats from SQL reference
 2022-09-16 17:38:17 -04:00
DanRoscigno
149970447a add link to formats 2022-09-16 17:21:03 -04:00
Alexey Milovidov
c09604bef2
Merge pull request #41363 from kitaisreal/small-style-fixes 
Small style fixes
 2022-09-17 00:19:00 +03:00
Denny Crane
6540d55d42
Merge branch 'master' into test/zvonand-monotonic 2022-09-16 17:02:09 -03:00
Nikita Taranov
6f186d3dd2
Do not return empty blocks from ConvertingAggregatedToChunksTransform (#41152) 
* impl

* add test

* update test
 2022-09-16 21:54:36 +02:00
Dmitry Novik
6e77751581
Merge pull request #41060 from ClickHouse/fix-odr-vialation 
Try to fix ODR for Loggers class
 2022-09-16 18:47:20 +02:00
Dmitry Novik
eacc790050
Merge branch 'master' into fix-odr-vialation 2022-09-16 18:44:53 +02:00
vvbufetov
fb94e43a60
Fix the link on the original article about MaterializedView (#41339) 
Fix the link on the original article about MaterializedView

Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
 2022-09-16 17:52:32 +02:00