Commit Graph

41283 Commits

Author SHA1 Message Date
Nikolay Degterinsky
7a727bbbe3
Merge pull request #49520 from IvanTakarlikov-st/it-grammar-fixes
Fix some grammar mistakes in documentation, code and tests
2023-05-05 15:45:58 +02:00
kssenii
6bc302959b Better 2023-05-05 14:55:52 +02:00
Han Fei
9c19bd8179
Merge branch 'master' into patch-1 2023-05-05 14:41:40 +02:00
kssenii
1050754432 Fix 2023-05-05 14:41:35 +02:00
Robert Schulze
d35ff02b8b
Fix writeAnyEscapedString if quote_character is a meta character
Function writeAnyEscapedString() escapes
- quote_character with itself or with a backslash, depending on template
  parameter escape_quote_with_quote
- some metacharacters with backslash.

If quote_character is a metacharacter, the code previously always quoted
with backslash, independently of escape_quote_with_quote. I didn't find
places which do this but better be on the safe side.
2023-05-05 12:40:48 +00:00
Kseniia Sumarokova
478542c6d7
Update ErrorCodes.cpp 2023-05-05 13:56:10 +02:00
Kseniia Sumarokova
221796e053
Merge branch 'master' into allow-to-get-current-az 2023-05-05 13:55:14 +02:00
wangxiaobo
f704c0dfec
Implement SYSTEM DROP REPLICA from auxillary ZooKeeper clusters (#48932)
* multiple zookeeper drop replica bug fix.

* add an integration test.

* format code.

* set stay_alive=True for test.

* style check bug fix.

* add check for is_active

* format code

* remove table_settings and has_metadata_out param.
2023-05-05 14:11:11 +03:00
Kseniia Sumarokova
7c203dbcd2
Merge pull request #49481 from snikch/master
Fix postgres database setting
2023-05-05 12:53:51 +02:00
Kuba Kaflik
8a6084abd4 Fix syntax error for TableFunctionS3 2023-05-05 12:41:30 +02:00
Anton Popov
c87a6e8e7d
Merge pull request #49117 from CurtizJ/limit-mutations
Add settings to delay or throw in case of too many mutations
2023-05-05 12:18:57 +02:00
Ilya Yatsishin
2414dd9a06
Merge pull request #49534 from ClickHouse/remove-garbage-pretty
Remove garbage from Pretty format
2023-05-05 12:15:38 +02:00
Bulat Gaifullin
8556493c9e
Update LRUFileCachePriority.cpp 2023-05-05 12:00:24 +03:00
Bulat Gaifullin
a222c4c5a1
Update LRUFileCachePriority.h 2023-05-05 11:59:59 +03:00
Bulat Gaifullin
82e6ce22fa
Update IFileCachePriority.h
remove extra semicolumn
2023-05-05 11:59:37 +03:00
Bulat Gaifullin
3fe8c9e6ed
Remove extra semicolumns 2023-05-05 11:54:11 +03:00
Kuba Kaflik
ec30b0f2be Add function inline documentation 2023-05-05 10:14:06 +02:00
Antonio Andelic
1dacd5b526 Merge branch 'master' into fix-cnf-new-analyzer 2023-05-05 07:44:22 +00:00
Sergei Trifonov
f6c433cdd2
Merge pull request #49521 from ClickHouse/serxa-patch-3 2023-05-05 08:28:55 +02:00
Alexey Milovidov
f77d087404 Merge branch 'master' into low-cardinality-fix-progress 2023-05-05 06:43:37 +02:00
Alexey Milovidov
09f171822e Merge branch 'master' into deprecate-in-memory-parts 2023-05-05 06:43:23 +02:00
Alexey Milovidov
efa66521de Allow to run in Linux without PRCTL support 2023-05-05 06:40:12 +02:00
Alexey Milovidov
90b0de5677 Make Pretty prettier 2023-05-05 06:36:53 +02:00
Michael Kolupaev
3bd1489f18 Propagate input_format_parquet_preserve_order to parallelizeOutputAfterReading() 2023-05-05 04:20:27 +00:00
Alexey Milovidov
dfbba48510
Merge pull request #49282 from loneylee/49280
Fix all key value is null and group use rollup return wrong answer
2023-05-05 06:43:41 +03:00
Alexey Milovidov
179eddee01 Remove garbage from Pretty format 2023-05-05 04:44:47 +02:00
Alexey Milovidov
ab1a1ea5b7
Merge pull request #49490 from ClickHouse/fix-s3cluster-with-headers
Correctly handle s3Cluster arguments
2023-05-05 05:31:23 +03:00
Alexey Milovidov
38b2f94bfa
Merge pull request #49476 from ClickHouse/minor-changes
Minor changes for setThreadName
2023-05-05 04:02:30 +03:00
Michael Kolupaev
0fa311ee38 Make INSERT do more things in parallel to avoid getting bottlenecked on one thread 2023-05-05 00:49:27 +00:00
Alexey Milovidov
c5184ed329 Optimize the system.query_log and system.query_thread_log tables by applying LowCardinality when appropriate 2023-05-05 01:36:01 +02:00
Dmitry Novik
4ba7530c23 Fix thread MemoryTracker parent after detach 2023-05-05 00:21:13 +02:00
Kseniia Sumarokova
3cbe9be22d
Merge pull request #49491 from kssenii/fix-assertions-2
Fix logical error in stress test, add some logging
2023-05-05 00:00:57 +02:00
Michael Kolupaev
eb3b774ad0 Better control over Parquet row group size 2023-05-04 14:59:55 -07:00
Ivan Takarlikov
339fb0c2c1
Merge branch 'master' into it-grammar-fixes 2023-05-04 15:57:09 -03:00
pufit
309032fb67 Check if grantees are empty 2023-05-04 13:42:14 -04:00
Sergei Trifonov
f4b3f1eb28
Fix UserTimeMicroseconds and SystemTimeMicroseconds descriptions 2023-05-04 19:40:41 +02:00
Sema Checherinda
9a0bc891e4 fix can_remove_callback for Temporary parts 2023-05-04 19:39:16 +02:00
alesapin
9456eb59fd
Merge pull request #48466 from ClickHouse/keeper-correctly-handle-snapshots
Correctly handle concurrent snapshots in Keeper
2023-05-04 19:16:00 +02:00
Kseniia Sumarokova
322b5a4da0
Update ReadBufferFromRemoteFSGather.cpp 2023-05-04 18:59:08 +02:00
Ivan Takarlikov
8873856ce5 Fix some grammar mistakes in documentation, code and tests 2023-05-04 13:35:18 -03:00
kssenii
a7c60aa282 Merge remote-tracking branch 'upstream/master' into allow-zero-objects-in-remote-fs-buffer 2023-05-04 17:39:39 +02:00
kssenii
6d3eb75a54 Allow zero objects in ReadBufferFromRemoteFSGather 2023-05-04 17:35:24 +02:00
Dmitry Novik
befcdbcc6d
Merge pull request #47630 from ClickHouse/revert-47476-revert_46622
Fix user MemoryTracker counter in async inserts
2023-05-04 16:57:41 +02:00
Anton Popov
e61d7baa54 Merge remote-tracking branch 'upstream/master' into HEAD 2023-05-04 14:03:53 +00:00
Kuba Kaflik
0672d75f72
Merge branch 'master' into add-gcs-table-function 2023-05-04 16:00:33 +02:00
Antonio Andelic
9825531cb1 Better 2023-05-04 13:38:28 +00:00
Alexander Tokmakov
b5a57da4ce
Merge pull request #49316 from ClickHouse/rs/48385
Unpoison stack frame ptrs from libunwind for msan
2023-05-04 16:17:30 +03:00
Antonio Andelic
e8e99065c2 Merge branch 'master' into fix-gcs-headers 2023-05-04 13:09:00 +00:00
vdimir
6d3559e817
Merge pull request #49093 from ClickHouse/vdimir/ntile-default-frame 2023-05-04 14:01:53 +02:00
Alexander Tokmakov
36f8fcdfaf
Merge pull request #49458 from ClickHouse/tavplubix-patch-6
Follow-up to #48792
2023-05-04 14:32:18 +03:00
kssenii
9bb681c104 Fix build 2023-05-04 13:31:07 +02:00
kssenii
1433f5ffc9 Merge remote-tracking branch 'upstream/master' into remove-dependency-from-context 2023-05-04 13:24:02 +02:00
Antonio Andelic
a68a023ca7
Merge pull request #48724 from johanngan/sse-kms
Support SSE-KMS configuration with S3 client
2023-05-04 13:20:54 +02:00
kssenii
9ddd4aa7f7 Merge remote-tracking branch 'origin/allow-to-get-current-az' into allow-to-get-current-az 2023-05-04 13:10:32 +02:00
kssenii
08772e1da7 Review fixes 2023-05-04 13:09:03 +02:00
Nikolai Kochetov
df9f00e87c
Merge pull request #49417 from ClickHouse/respect-PR-for-agg-projection
Respect PK for aggregate projection.
2023-05-04 12:52:27 +02:00
kssenii
cf3a8e9b93 One more fix 2023-05-04 12:49:23 +02:00
kssenii
663a007fa6 Add assertion 2023-05-04 12:11:44 +02:00
Nikolay Degterinsky
f58ec4fbd7
Apply suggestions from code review
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2023-05-04 12:07:53 +02:00
Alexander Gololobov
f77cc89464
Merge pull request #49470 from ClickHouse/remove_no_delay_flag
Replace `NO DELAY` with `SYNC` in tests
2023-05-04 11:57:01 +02:00
alesapin
412b161104
Merge pull request #48791 from kssenii/better-local-object-storage
Make local object storage work consistently with s3 object storage, fix problem with append, make it configurable as independent storage
2023-05-04 11:47:43 +02:00
kssenii
7ad4330c14 Fix logical error in stress test 2023-05-04 11:37:19 +02:00
alesapin
ba0d9c8b93
Merge branch 'master' into whitespaces-3 2023-05-04 11:32:02 +02:00
alesapin
89caf40840
Merge pull request #46528 from myrrc/feature/show-secrets-option
Show secrets in `SHOW` and `SELECT` queries
2023-05-04 11:21:30 +02:00
Antonio Andelic
8769ac2187 Correctly append arguments 2023-05-04 08:30:45 +00:00
xmy
c8cccb393e fix 2023-05-04 16:05:10 +08:00
Li Shuai
279970337a Fix all key value is null and group use rollup return wrong answer 2023-05-04 11:07:17 +08:00
Nikolay Degterinsky
ed9a9ecd57 Fixes 2023-05-04 02:45:25 +00:00
johanngan
731823b873 Add support for SSE-KMS configuration with S3
https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingKMSEncryption.html

Similar to the server_side_encryption_customer_key_base64 option for
configuring SSE-C with S3, add the following settings to configure
SSE-KMS on a per-endpoint/disk basis:
  - server_side_encryption_kms_key_id
  - server_side_encryption_kms_encryption_context
  - server_side_encryption_kms_bucket_key_enabled
2023-05-03 21:35:38 -05:00
johanngan
1bc52977a7 Support "header" setting in S3 disk config
The S3 table engine supports specifying extra HTTP headers in S3
requests to certain endpoints, via the "headers" setting. This commit
adds the same setting to S3 disk config.
2023-05-03 21:32:58 -05:00
alekar
af81f056b4
Merge branch 'master' into 48716 2023-05-03 18:35:54 -07:00
Mal Curtis
5727585d95 s/use_tables_cache/use_table_cache 2023-05-03 23:40:12 +00:00
Alexey Milovidov
261907c143 Merge branch 'master' into deprecate-in-memory-parts 2023-05-04 01:07:38 +02:00
Alexey Milovidov
50202c1b0a Minor changes 2023-05-03 22:51:56 +02:00
Alexander Gololobov
a90c2ec90d
Merge pull request #49425 from ClickHouse/fix_build_set_with_remote
Fix fuzz bug when subquery set is not built when reading from remote()
2023-05-03 21:47:29 +02:00
wangxiaobo
2924837c7e
Fix Attaching a table with non-existent ZK path does not increase the ReadonlyReplica metric (#48954)
* Attaching a table with non-existent ZK path does not increase the ReadonlyReplica metric bug fix.

* add integration test.

* add integration test.

* Update test.py

* format code

* format code
2023-05-03 22:41:20 +03:00
Alexander Tokmakov
83b12ec5ca replace NO DELAY with SYNC in tests 2023-05-03 20:08:49 +02:00
Kseniia Sumarokova
48fab80dd7
Update Credentials.cpp 2023-05-03 19:39:43 +02:00
Anton Popov
c9705d6bf1
Merging #49066 (Better error handling during loading of parts) (#49430)
* catch filesystem error when loading parts

* better exception handling during part loading

---------

Co-authored-by: cangyin <excangyin@gmail.com>
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-05-03 19:10:06 +02:00
Nikita Mikhaylov
954e3b724c
Speedup outdated parts loading (#49317) 2023-05-03 18:56:45 +02:00
Alexander Tokmakov
ff70d26c23
Update StorageMergeTree.cpp 2023-05-03 19:30:44 +03:00
kssenii
0a18a87ad3 Fix style check 2023-05-03 18:28:33 +02:00
Kruglov Pavel
01ed70a660
Fix possible logical error "Cannot cancel. Either no query sent or already cancelled" (#49106)
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-05-03 19:16:23 +03:00
kssenii
cb6e5fedc5 Throw on error 2023-05-03 18:02:04 +02:00
flynn
236a0d9da0 add alias str_to_map and mapFromString for extractKeyValuePairs 2023-05-03 15:46:17 +00:00
kssenii
64bc03fefd Allow to get availability zone 2023-05-03 17:40:39 +02:00
Alexander Tokmakov
e399903030
Merge pull request #48548 from ClickHouse/clusters_is_active_column
Add some columns to system.clusters
2023-05-03 17:42:40 +03:00
Alexander Tokmakov
f3f6cfdcbb
Update StorageMergeTree.cpp 2023-05-03 17:39:31 +03:00
Nikolay Degterinsky
11d4ce8b4e
Merge pull request #44905 from evillique/bcrypt
Add bcrypt authentication type
2023-05-03 16:39:27 +02:00
Dmitry Novik
b921476a3b
Merge pull request #49419 from ClickHouse/fix-function-parameter-exception
Throw an exception for non-parametric functions in new analyzer
2023-05-03 16:34:28 +02:00
Nikolay Degterinsky
048b4ec738
Merge branch 'master' into bcrypt 2023-05-03 16:14:57 +02:00
Anton Popov
7896d30737
Merge pull request #49122 from CurtizJ/add-async-insert-mt-setting
Add `MergeTree` setting `async_insert`
2023-05-03 16:01:13 +02:00
Mike Kot
3d6240b982 fix 2023-05-03 13:59:45 +00:00
kssenii
35f437ac9c Address review comments 2023-05-03 14:37:18 +02:00
Antonio Andelic
b8b7a362b2
Merge branch 'master' into keeper-correctly-handle-snapshots 2023-05-03 13:51:09 +02:00
Azat Khuzhin
ad69fbb972
Fix compiling average example (suppress -Wframe-larger-than) (#49358) 2023-05-03 13:32:34 +02:00
Nikolai Kochetov
2395e52247
Merge branch 'master' into safer-cut-and-concat 2023-05-03 13:21:08 +02:00
kssenii
189f276ff5 Fix 2023-05-03 13:16:08 +02:00
vdimir
ef9c3a3ca1
Merge branch 'master' into vdimir/ntile-default-frame 2023-05-03 12:59:57 +02:00
alesapin
6f3f202f7c
Merge branch 'master' into fix_zero_copy_not_atomic 2023-05-03 12:53:35 +02:00
Nikolai Kochetov
6388be2062
Merge pull request #49326 from k-morozov/refactoring/pipe-into-step
move pipe compute into initializePipeline
2023-05-03 12:43:21 +02:00
Alexander Tokmakov
1ec3040d0c
Merge pull request #49420 from ClickHouse/fix_00002
Fix some bad error messages
2023-05-03 13:33:53 +03:00
Vladimir C
887ab23487
Merge pull request #49319 from azat/dict/fix-hashed-load_factor 2023-05-03 12:28:40 +02:00
Vladimir C
65ab64a77f
Merge pull request #49418 from ClickHouse/vdimir/keeper_fault_inject_sequential_cleanup 2023-05-03 12:27:10 +02:00
Kseniia Sumarokova
59401ce93c
Merge pull request #49411 from ClickHouse/kssenii-patch-7
Update FileSegment.cpp
2023-05-03 11:50:13 +02:00
Kseniia Sumarokova
f5b6aa0fc5
Merge pull request #49415 from kssenii/fix-assertions
Fix some assertions failing in stress test
2023-05-03 11:45:33 +02:00
Antonio Andelic
ae62b227f0 More fixes 2023-05-03 08:30:22 +00:00
Antonio Andelic
2a28efbfac Merge branch 'master' into fix-cnf-new-analyzer 2023-05-03 07:25:33 +00:00
Alexey Milovidov
ee9fae6aa2
Merge pull request #49363 from tsolodov/master
Disallow configuring compression CODECs for alias columns
2023-05-03 03:37:48 +03:00
Alexey Milovidov
f449df85b6 Deprecate in-memory parts 2023-05-03 00:31:09 +02:00
Kseniia Sumarokova
d4a921bd7c
Merge branch 'master' into fix-assertions 2023-05-03 00:10:32 +02:00
kssenii
d8d0d78db8 Fix build 2023-05-03 00:09:52 +02:00
Nikolay Degterinsky
4c038ef538
Merge branch 'master' into bcrypt 2023-05-02 21:52:21 +02:00
kssenii
ecfbf1e304 Remove dependency from DB::Context in readers 2023-05-02 21:45:27 +02:00
kssenii
ac9ef077ad Fix 2023-05-02 21:41:17 +02:00
Alexander Gololobov
2e20f2a14d Do not skip building set even when reading from remote 2023-05-02 21:31:56 +02:00
Nikolai Kochetov
6beff3bd44
Merge pull request #48603 from ilejn/sequence_state_fix
sequence state fix
2023-05-02 21:25:27 +02:00
Azat Khuzhin
2b21b83979 Reduce inter-header dependencies
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-02 21:15:18 +02:00
Dmitry Novik
bab112a1bc
Merge branch 'master' into revert-47476-revert_46622 2023-05-02 20:54:25 +02:00
Dmitry Novik
0c521eb10b Another atempt to fix test 2023-05-02 18:51:36 +00:00
Alexey Milovidov
eb27c58bc0 Whitespaces 2023-05-02 19:27:23 +02:00
Alexander Tokmakov
495325f664 fix some bad error messages, suppress others 2023-05-02 17:55:42 +02:00
Dmitry Novik
3d76c92f30 Throw exception for non-parametric functions in new analyzer 2023-05-02 15:40:19 +00:00
vdimir
33cf697028
Correctly cleanup sequential node in ZooKeeperWithFaultInjection 2023-05-02 15:01:59 +00:00
Nikolai Kochetov
75597efeb6 Respect PK for aggregate projection. 2023-05-02 14:58:44 +00:00
Nikolay Degterinsky
2aa8619534
Merge pull request #48851 from mauidude/date-trunc-return-date-time
date_trunc function to always return DateTime type
2023-05-02 16:43:20 +02:00
Nikolay Degterinsky
46c86dce93 Fix bcrypt enum value 2023-05-02 14:36:48 +00:00
kssenii
22487de34a Fix 2023-05-02 16:09:33 +02:00
Nikolay Degterinsky
f6704205ff
Update WithFileName.cpp 2023-05-02 16:05:18 +02:00
Robert Schulze
cf884d29a1
Merge remote-tracking branch 'origin/master' into rs/48385 2023-05-02 13:43:36 +00:00
Kseniia Sumarokova
bccc4d3b7e
Update FileSegment.cpp 2023-05-02 15:43:03 +02:00
Robert Schulze
ee49f8f0fa
Fix clang-tidy build 2023-05-02 13:41:38 +00:00
alesapin
a08225d9ea Fix typo 2023-05-02 15:34:57 +02:00
Robert Schulze
7e5fded3cf
A little less clutter 2023-05-02 13:16:15 +00:00
SmitaRKulkarni
997210c782
Merge pull request #48515 from ClickHouse/Clear_marks_cache_for_outdated_parts
MergeTreeMarksLoader holds DataPart instead of DataPartStorage
2023-05-02 15:11:14 +02:00
Nikolay Degterinsky
f87c418fc8
Merge pull request #49360 from evillique/alias-restricted-keywords
Allow restricted keywords if alias is quoted
2023-05-02 15:02:05 +02:00
Konstantin Morozov
046949a6d3 fix names 2023-05-02 14:59:41 +02:00
Konstantin Morozov
e4394debd4 forgot about query_plan 2023-05-02 14:59:41 +02:00
Konstantin Morozov
397a1700c7 apply comments 2023-05-02 14:59:41 +02:00
kst-morozov
f0619910d4 move pipe compute into initializePipeline 2023-05-02 14:59:41 +02:00
alesapin
24a744db4c Merge branch 'master' into fix_zero_copy_not_atomic 2023-05-02 14:57:55 +02:00
alesapin
619b6f2071 Fix typo 2023-05-02 14:57:52 +02:00
Robert Schulze
6bdbee33ee
Incorporate review feedback 2023-05-02 12:29:56 +00:00
Antonio Andelic
13739cd26b Correctly stop CNF convert for too many atomics 2023-05-02 12:29:15 +00:00
Nikita Mikhaylov
aa4c5fe958
Enhancements for background merges (#49313) 2023-05-02 13:43:59 +02:00
Anton Popov
bcdd2307fb add comments 2023-05-02 11:30:50 +00:00
Antonio Andelic
f695040a19
Merge pull request #48897 from ClickHouse/keeper-check-not-exists
Add `CheckNotExists` request to Keeper
2023-05-02 13:14:22 +02:00
Antonio Andelic
468ed32b23 Fix whitespace 2023-05-02 11:08:26 +00:00
Antonio Andelic
8c91dbdfc6 Properly fix GCS with keys 2023-05-02 10:49:31 +00:00
Kseniia Sumarokova
3ec53152e5
Update Metadata.cpp 2023-05-02 12:02:54 +02:00
kssenii
4fc1f644bc Simplify 2023-05-02 11:57:02 +02:00
Kseniia Sumarokova
1590ba3326
Merge pull request #49376 from ClickHouse/kssenii-patch-7
Remove wrong assertion in cache
2023-05-02 11:47:11 +02:00
Vladimir C
96d109c3db
Merge pull request #49137 from ClickHouse/vdimir/mutliple_storage_join 2023-05-02 11:40:16 +02:00
alesapin
96d2482bff
Merge pull request #49365 from ClickHouse/ttl_on_insert
Fix bug in removal of existing part directory
2023-05-02 11:32:01 +02:00
pufit
2964ca5c84 Specify grants for users in users.xml 2023-05-01 20:24:02 -04:00
Alexey Milovidov
1267fbca1c
Merge pull request #48998 from ongkong/fix-join-clause-create-column
Fix incorrect createColumn call on join clause
2023-05-02 02:23:07 +03:00
Alexey Milovidov
6f2ccd88b3
Merge pull request #49241 from evillique/decompress-filename
Add file name to exception raised during decompression
2023-05-02 02:16:49 +03:00
Timur Solodovnikov
e58a63b451 addressing PR comments 2023-05-01 16:13:45 -07:00
Alexey Milovidov
51847fbf10
Merge pull request #49321 from nickitat/rand_exp
Presumably better buffer size for reading from fs
2023-05-02 02:06:25 +03:00
Han Fei
d608ba41e7 try to fix 2023-05-02 00:05:36 +02:00
Timur Solodovnikov
c7295db43e nit 2023-05-01 13:59:38 -07:00
Robert Schulze
3d467febe0
Fix build 2023-05-01 20:58:10 +00:00
Timur Solodovnikov
6566ed7863 removed loop & added tests 2023-05-01 13:51:46 -07:00
Kseniia Sumarokova
044cfe5a22
Remove wrong assertion 2023-05-01 22:32:31 +02:00
kssenii
fbdccbd25f Merge remote-tracking branch 'origin/better-local-object-storage' into better-local-object-storage 2023-05-01 22:25:28 +02:00
kssenii
f325ba1794 Better 2023-05-01 21:10:37 +02:00
alesapin
0f6a4b973e
Merge branch 'master' into ttl_on_insert 2023-05-01 21:02:04 +02:00
alesapin
a3f9a8b87b Fix bug in removal of existing part directory 2023-05-01 20:32:01 +02:00
Nikita Mikhaylov
503f099afe
Merge branch 'master' into master 2023-05-01 18:50:44 +02:00
Timur Solodovnikov
fc5b0783fd fix for linter 2023-05-01 09:40:56 -07:00
Nikolay Degterinsky
65e743735a Merge remote-tracking branch 'upstream/master' into mongodb-array-type 2023-05-01 16:33:01 +00:00
Timur Solodovnikov
e49842ff6c block setting codec for alias columns 2023-05-01 09:25:08 -07:00
Han Fei
4d18a4f8d3
Merge branch 'master' into hanfei/fiu 2023-05-01 17:51:41 +02:00
Han Fei
b701293d46 support named fault injection and add a simple test 2023-05-01 17:44:37 +02:00
Nikolay Degterinsky
76a591fa5e Allow restricted keywords if alias is quoted 2023-05-01 15:16:12 +00:00
alesapin
66847386df
Merge pull request #49146 from ClickHouse/don_t_write_version_file_on_start
Don't add metadata_version file if it doesn't exist
2023-05-01 17:04:47 +02:00
Anton Popov
36d53e0d6c
Merge branch 'master' into add-async-insert-mt-setting 2023-05-01 16:13:23 +02:00
Nikita Taranov
266c9d403a review fixes 2023-05-01 13:09:55 +00:00
Nikolay Degterinsky
1be9371fb5 Better 2023-05-01 13:01:23 +00:00
larryluogit
e18395b265
Merge branch 'master' into saveIntervals 2023-05-01 08:15:47 -04:00
Duc Canh Le
abe0cfd10f
fix wrong query result when using nullable primary key (#49172) 2023-05-01 12:51:22 +02:00
Azat Khuzhin
2fd1a73812 Fix element_count for HASHED/SPARSE_HASHED with multiple attributes
Previosly element_count was multplied by the number of attributes.

Fixes: #5440
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-01 12:44:41 +02:00
Azat Khuzhin
93201f21d9 Fix load_factor for HASHED/SPARSE_HASHED dictionaries with SHARDS
Previously, bucket_count was set only for the one shard, and hence
load_factor was > 1.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-05-01 12:44:41 +02:00
ongkong
1bffb28adc add comment, change check location 2023-05-01 12:14:44 +02:00
ongkong
35a736f811 use sanitizeBlock 2023-05-01 12:14:44 +02:00
Nikolay Degterinsky
f64ef88197 Merge remote-tracking branch 'upstream/master' into bcrypt 2023-04-30 21:39:16 +00:00
alesapin
f03e75971a Remove on detach 2023-04-30 19:06:31 +02:00
alesapin
a098298c0f Remove file for empty parts 2023-04-30 19:06:23 +02:00
alesapin
a95a5f6fb6 Fix two bugs and add test 2023-04-30 16:33:23 +02:00
alesapin
ec2c860a39 Merge branch 'fix_zero_copy_not_atomic' of github.com:ClickHouse/ClickHouse into fix_zero_copy_not_atomic 2023-04-30 15:02:27 +02:00
Smita Kulkarni
408db4a25b Updated to store IMergeTreeDataPartInfoForReader instead of DataPart in MergeTreeMarksLoader 2023-04-30 10:56:43 +02:00
Nikolay Degterinsky
ea8c8ef559 Fix test 2023-04-29 21:53:47 +00:00
alesapin
daa0b095ed Merge branch 'master' into fix_zero_copy_not_atomic 2023-04-29 21:26:26 +02:00
Alexey Milovidov
15d0379e2c
Merge pull request #48792 from ClickHouse/fix_some_tests3
Fix some tests
2023-04-29 22:04:11 +03:00
Nikita Taranov
f1ff2c0135
Fix oss-fuzz build errors (#49236) 2023-04-29 18:44:50 +02:00
Nikita Taranov
0be9c0751e
Merge branch 'master' into rand_exp 2023-04-29 15:22:08 +02:00
Kseniia Sumarokova
7d867d7632
Merge pull request #49225 from MikhailBurdukov/mongo_dict_tls
Connection options for MongoDB dictionaries
2023-04-29 11:37:45 +02:00
Alexey Milovidov
7bab39105f Fix progress bar for LowCardinality fields with shared dictionaries 2023-04-29 00:14:10 +02:00
alekar
29d96afae8
Merge branch 'master' into 48716 2023-04-28 14:24:46 -07:00
Nikita Taranov
af558e282c impl 2023-04-28 20:48:37 +00:00
Alexey Milovidov
5bd4fc9e90
Merge pull request #48492 from azat/s3-multipart-strict-size
Add ability to use strict parts size for S3 (compatibility with R2)
2023-04-28 23:34:45 +03:00
Kseniia Sumarokova
d4aa96e262
Merge branch 'master' into better-local-object-storage 2023-04-28 21:05:05 +02:00
Kseniia Sumarokova
47b77acb34
Merge pull request #49309 from ClickHouse/kssenii-patch-7
Fix stress test
2023-04-28 21:02:54 +02:00
Robert Schulze
7609832606
Unpoison stack frame ptrs from libunwind for msan
Turned out that in msan builds, stack frame pointers explicitly returned
by unw_backtrace() in Common/StackTrace.cpp were unpoisened, but stack
frame pointers returned from the same function under the
STD_EXCEPTION_HAS_STACK_TRACE define in std::exception (see (*)) were
not. I tried unpoisoning directly in libcxx. Since this didn't work,
this PR unpoisons where get_stack_trace_frames() is called.

I don't know why this issue never occurred in CI but it fixes #48385 for
me (where msan complains about reads of uninitialized data when query
cache squashes and compresses chunks produced from SELECT last_error_trace
FROM system.errors).

Fixes: #48385

(*) https://github.com/ClickHouse/llvm-project/pull/7/files#diff-8c81d74ef72967be2fa27a31275000aa18532a583490f9673c62d7b981a5b39c
2023-04-28 17:43:12 +00:00
Alexey Milovidov
cd171bef7d
Merge pull request #45999 from sichenzhao/cgroup_v2
Updates AsyncMetrics cgroup-memory to support cgroupv2
2023-04-28 20:39:53 +03:00
Mike Kot
2d20658885
Merge branch 'master' into feature/show-secrets-option 2023-04-28 20:19:35 +03:00
Shane Andrade
a60ee304b3
Merge branch 'master' into date-trunc-return-date-time 2023-04-28 09:16:40 -07:00
Nikolai Kochetov
8465b6cdf0
Merge pull request #49139 from ClickHouse/remove-upgradable-mutex
Use `SharedMutex` instead of `UpgradableMutex`
2023-04-28 17:40:08 +02:00
alesapin
70ee02a3eb Add node holder 2023-04-28 17:39:32 +02:00
Nikolay Degterinsky
54c8f63a33 Fixes 2023-04-28 15:12:06 +00:00
Kseniia Sumarokova
a04025623c
Update FileCache.cpp 2023-04-28 16:47:15 +02:00
Kseniia Sumarokova
b2aa2aa244
Fix 2023-04-28 16:45:00 +02:00
Alexey Milovidov
911d4e9977
Merge branch 'master' into fix_some_tests3 2023-04-28 17:23:46 +03:00
Alexander Tokmakov
691fdbf6a6
Update StorageReplicatedMergeTree.cpp (#49302) 2023-04-28 17:21:03 +03:00
Dmitry Novik
0520342cd5
Merge pull request #49116 from ClickHouse/fix-analyzer-tests
Fix tests with enabled analyzer
2023-04-28 16:07:25 +02:00
Mike Kot
f1d0ed367d separate name for format setting 2023-04-28 13:39:38 +00:00
Mike Kot
7bffa89e96 add all 3 settings 2023-04-28 13:22:36 +00:00
Alexey Milovidov
c86d3daee5
Update AsynchronousMetrics.cpp 2023-04-28 16:21:37 +03:00
Alexey Milovidov
6dcfdbfaf2
Merge branch 'master' into clusters_is_active_column 2023-04-28 16:16:25 +03:00
Alexey Milovidov
85d78a6265
Merge pull request #49286 from ClickHouse/added-documentation-for-kolmogorov-smirnov-test-2
Added an alias `asymptotic` for `asymp` computational method for `kolmogorovSmirnovTest`.
2023-04-28 16:15:24 +03:00
Anton Popov
bbdfb9dcd2
Merge pull request #48300 from aiven-sal/aiven-sal/case2
Allow NULLs in CASE and transform
2023-04-28 14:58:47 +02:00
alesapin
ef49603432 Merge branch 'master' into fix_zero_copy_not_atomic 2023-04-28 14:42:30 +02:00
MikhailBurdukov
5c9959af49 Resolve conservation 2023-04-28 12:40:47 +00:00
kssenii
e603adfd4c Merge remote-tracking branch 'upstream/master' into better-local-object-storage 2023-04-28 13:26:57 +02:00
kssenii
298ed454ce Merge remote-tracking branch 'upstream/master' into better-local-object-storage 2023-04-28 13:26:55 +02:00
Raúl Marín
bb4a7f65de
Slight improvements to coordinator logging (#49204) 2023-04-28 13:25:53 +02:00
Kseniia Sumarokova
107474a42f
Merge pull request #44985 from kssenii/cache-better-locks
Rework locking in fs cache
2023-04-28 12:24:55 +02:00
Robert Schulze
c583a4f8cd
Merge pull request #49222 from DanRoscigno/add-examples-to-functions
Extend system.functions with in-source documentation
2023-04-28 11:56:35 +02:00
Azat Khuzhin
c8ec152f57 Add ability to use strict parts size for S3 (compatibility with R2)
The are some implementations that does not allow to use parts of
different size for multi-part upload:

- CouldFlare R2 [1] and also got help on discord
- AWS S3 Glacier [2]
- and I also know of one bug in Google Cloud Storage (GCS), but it
  should be fixed in a couple of months.

  [1]: https://developers.cloudflare.com/r2/reference/changelog/#2022-10-28
       > Multipart upload part sizes are always expected to be of the
       > same size, but this enforcement is now done when you complete
       > an upload instead of being done very time you upload a part

  [2]: https://docs.aws.amazon.com/amazonglacier/latest/dev/api-multipart-initiate-upload.html

On top of this I'm going to add auto detection of this issue for disks,
but not for S3 function, since those checks are quite costly, and they
need to write at least 5MB*3, which may be questionable.

v2: mark test as long [1]
    [1]: https://s3.amazonaws.com/clickhouse-test-reports/48492/d4a90880e947ab3a17b3eddeea274afed8ebceb4/stateless_tests_flaky_check__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-28 11:01:56 +02:00
xmy
2da33b96eb Allow Int* type argument for groupBitAnd/GroupBitOr/groupBitXor 2023-04-28 11:03:50 +08:00
Mike Kot
e428af0b63 replace format settings with server setting 2023-04-27 21:27:18 +00:00
Mike Kot
b24de29c70 reverting mr changes 2023-04-27 20:37:12 +00:00
Alexey Milovidov
5367206057
Update TableFunctionS3.h 2023-04-27 23:24:36 +03:00
Alexey Milovidov
4dccd5f9b0
Update AsynchronousMetrics.cpp 2023-04-27 23:20:38 +03:00
Mike Kot
357cde95e9 Merge branch 'master' into feature/show-secrets-option 2023-04-27 20:19:40 +00:00
kssenii
f7404d7e72 Fix 2023-04-27 21:40:55 +02:00
Nikolay Degterinsky
df1e56b985 Merge remote-tracking branch 'upstream/master' into bcrypt 2023-04-27 17:01:58 +00:00
Nikita Mikhaylov
da72eb630e Done 2023-04-27 18:14:46 +02:00
Alexey Milovidov
96826cfca6
Merge pull request #49161 from ClickHouse/nickitat-patch-11
Align connect timeout with aws sdk default
2023-04-27 18:33:47 +03:00
Robert Schulze
b6e65ddeff
Merge branch 'master' into add-examples-to-functions 2023-04-27 16:11:32 +02:00
Alexey Milovidov
064dea4483
Merge branch 'master' into add-gcs-table-function 2023-04-27 16:59:09 +03:00
Alexey Milovidov
aec8f17614
Update TableFunctionS3.cpp 2023-04-27 16:58:18 +03:00
Alexey Milovidov
30f1bef6e8
Update TableFunctionS3.h 2023-04-27 16:57:42 +03:00
Alexey Milovidov
fd3c588c68
Merge pull request #49200 from CurtizJ/better-map-concat
Allow using function `concat` with `Map` type
2023-04-27 16:40:42 +03:00
Kseniia Sumarokova
45e2d296f9
Merge branch 'master' into better-local-object-storage 2023-04-27 14:54:04 +02:00
Alexey Milovidov
3fa19c5ee2
Merge branch 'master' into fix_some_tests3 2023-04-27 15:04:15 +03:00
Alexey Milovidov
c5793f9684
Fix build 2023-04-27 14:56:51 +03:00
Alexey Milovidov
aac037f51c
Merge pull request #46765 from zk-kiger/improve_cluster_table_funcion_skip_unavailable_shards
add skip_unavailable_shards setting for table function cluster
2023-04-27 14:54:18 +03:00
Alexey Milovidov
30113cd137
Merge pull request #49083 from ClickHouse/fix-jit-aggregation
Try to fix JIT for aggregation functions
2023-04-27 14:53:06 +03:00
Alexander Tokmakov
fc9b2fbac8
Fix race on Outdated parts loading (#49223) 2023-04-27 13:52:09 +02:00
kssenii
641b64c4e8 Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-27 13:31:41 +02:00
Kseniia Sumarokova
c72bd3eeef
Merge pull request #49260 from ClickHouse/kssenii-patch-7
Add a comment in FileCache.cpp
2023-04-27 13:29:19 +02:00
Nikolay Degterinsky
ea55222131
Merge pull request #44674 from evillique/add_default_password_type
Add default password type
2023-04-27 13:25:58 +02:00
Raúl Marín
0a192d1160
Fix GCS s3 compat disks (#49194) 2023-04-27 13:24:20 +02:00
kssenii
fab84345fd Corrections after merge with master 2023-04-27 13:18:32 +02:00
kssenii
3d4413183f Merge remote-tracking branch 'upstream/master' into cache-better-locks 2023-04-27 13:16:36 +02:00
Kseniia Sumarokova
9325787884
Update FileCache.cpp 2023-04-27 13:03:41 +02:00
Kseniia Sumarokova
28dee371e0
Merge pull request #49203 from kssenii/fix-system-error-from-cache
Catch exceptions from create_directories in fs cache
2023-04-27 12:29:38 +02:00
Robert Schulze
096667be45
More fixes 2023-04-27 09:33:52 +00:00
Nikolay Degterinsky
111fb4b8a9 Add file name to exception raised during decompression 2023-04-27 02:52:23 +00:00
Alexey Milovidov
ed97e46d41
Merge pull request #49221 from Algunenano/conversion_typos
Fix some typos in conversion functions
2023-04-27 03:00:40 +03:00
Alexey Milovidov
0da0592f86
Merge pull request #49237 from ClickHouse/23.5-prepare
Update version after release
2023-04-27 02:47:22 +03:00
Alexey Milovidov
7333e964bc Update autogenerated version to 23.5.1.1 and contributors 2023-04-27 01:40:57 +02:00
Nikolay Degterinsky
527b136ddf
Merge pull request #48806 from ucasfl/in-operator
IN operator support compare Date and Date32
2023-04-27 01:17:05 +02:00
Alexey Milovidov
1bb685a081
Fix error. 2023-04-27 01:32:54 +03:00
Alexey Milovidov
354cf09892
Merge pull request #48549 from cangyin/add_zookeeper_name
add zookeeper name in system.replicas
2023-04-27 01:22:22 +03:00
Alexey Milovidov
3920eb987f
Merge pull request #49101 from ClickHouse/parallelize-output-setting
Setting parallelize_output_from_storages
2023-04-27 00:51:24 +03:00
Alexey Milovidov
a34f94833c
Merge branch 'master' into fix-jit-aggregation 2023-04-27 00:46:45 +03:00
Robert Schulze
af7730d285
Merge pull request #49126 from jinjunzh/iaadeflate_upgrade_qpl_v1.1.0
Upgrade QPL to v1.1.0 + get maximum jobs from libaccel_config
2023-04-26 23:31:21 +02:00
Robert Schulze
739bfc9b8d
Fix categories 2023-04-26 21:23:26 +00:00
MikhailBurdukov
40ad8499a0 fix 2023-04-26 21:03:27 +00:00
Robert Schulze
ca62b3d177
Merge pull request #49183 from ClickHouse/rs/doc-makedate
Document makeDateTime() and its variants
2023-04-26 22:45:24 +02:00
MikhailBurdukov
b229a28e94
Merge branch 'master' into mongo_dict_tls 2023-04-26 23:39:27 +03:00
Robert Schulze
d72030b876
Various fixes 2023-04-26 20:38:41 +00:00
Kseniia Sumarokova
5a01673118
Merge branch 'master' into fix-after-49110 2023-04-26 22:19:13 +02:00
Nikolai Kochetov
b86de85901
Merge branch 'master' into safer-cut-and-concat 2023-04-26 21:51:46 +02:00
MikhailBurdukov
389c0af922 Fix style 2023-04-26 19:36:34 +00:00
MikhailBurdukov
baaee66e85 Missing files 2023-04-26 19:29:29 +00:00
MikhailBurdukov
d76430fe90 Added options handling for mongoo dict 2023-04-26 19:19:10 +00:00
Raúl Marín
7bdc5fa88f Fix some typos in conversion functions 2023-04-26 20:45:11 +02:00
Robert Schulze
249dc4ff6d
Merge pull request #49220 from ClickHouse/rs/replace-with-const-haystack
Fix replace[Regexp]{One,All}() with const haystacks
2023-04-26 20:38:57 +02:00
DanRoscigno
fb39dc3f19 add some markdown 2023-04-26 14:36:34 -04:00
Robert Schulze
6c28966324
Merge branch 'master' into rs/show-indexes 2023-04-26 20:33:38 +02:00
DanRoscigno
3e1e86cff2 examples added 2023-04-26 14:26:49 -04:00
Robert Schulze
76e80497ed
Fix replace[Regexp]{One,All}() with const haystacks 2023-04-26 18:18:11 +00:00
alesapin
a34e465abf Fxi 2023-04-26 19:57:18 +02:00
Robert Schulze
6d6188eb0e
Merge pull request #48134 from HarryLeeIBM/hlee-s390x-part-hash
Fix partition ID issue for s390x
2023-04-26 19:50:08 +02:00
alesapin
f3d1d3b58b Merge branch 'master' into fix_zero_copy_not_atomic 2023-04-26 18:00:31 +02:00
kssenii
fd432a3ee4 Fix 2023-04-26 17:54:10 +02:00
DanRoscigno
57164820ef fixed column to string 2023-04-26 11:53:50 -04:00
DanRoscigno
ddd285cda2 compiles, but table has map and table is empty 2023-04-26 11:37:10 -04:00
kssenii
8ba9ab67c2 Fix 2023-04-26 17:13:15 +02:00
Anton Popov
871f9265cc allow using function 'concat' with Map type 2023-04-26 14:39:59 +00:00
Suzy Wang
6035f79bf6 fix reinterpretAs queries on s390x 2023-04-26 07:30:30 -07:00
Raúl Marín
7abb94fe33
Don't throw LOGICAL_ERROR when reading from remote if there is no local replica (#49136)
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-04-26 16:22:40 +02:00
DanRoscigno
c480f81f94 add: map header, return 2023-04-26 09:50:23 -04:00
kssenii
3939498ef7 Review fixes 2023-04-26 15:43:09 +02:00
Dmitry Novik
604e3f9112 Fix 02540_duplicate_primary_key2 2023-04-26 13:20:25 +00:00
Robert Schulze
ad15749b4e
Document makeDateTime() and its variants
Follow-up to #35628
2023-04-26 12:22:05 +00:00
Robert Schulze
f0710d7be1
Merge branch 'master' into iaadeflate_upgrade_qpl_v1.1.0 2023-04-26 13:27:50 +02:00